72755 2011-11-18 13:42:33 -0800 WebAudio: AudioContext::uninitialize() can cause AudioContext deletion before deleting marked nodes. 2011-11-28 10:50:32 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jer.noble jer.noble crogers eric.carlson sam webkit.review.bot oldest_to_newest 506022 0 jer.noble 2011-11-18 13:42:33 -0800 WebAudio: AudioContext::uninitialize() can caused AudioContext deletion before deleting marked nodes. 506029 1 jer.noble 2011-11-18 13:45:30 -0800 If the AudioContext's destination nodes hold the only references existing to the AudioContext, then calling m_destinationNode.clear() will cause the context's refCount to drop to 0, and the context will be deleted before exiting uninitialize(). This will potentially skip a lot of clean up and will cause an assertion in ~AudioContext(). 506031 2 115867 jer.noble 2011-11-18 13:47:54 -0800 Created attachment 115867 Patch 506032 3 115867 eric.carlson 2011-11-18 13:49:18 -0800 Comment on attachment 115867 Patch Is it possible to create a layout test for this? 506042 4 jer.noble 2011-11-18 14:02:28 -0800 (In reply to comment #3) > (From update of attachment 115867 [details]) > Is it possible to create a layout test for this? Probably not. 509948 5 115867 webkit.review.bot 2011-11-28 10:50:25 -0800 Comment on attachment 115867 Patch Clearing flags on attachment: 115867 Committed r101265: <http://trac.webkit.org/changeset/101265> 509949 6 webkit.review.bot 2011-11-28 10:50:32 -0800 All reviewed patches have been landed. Closing bug. 115867 2011-11-18 13:47:54 -0800 2011-11-28 10:50:25 -0800 Patch bug-72755-20111118134752.patch text/plain 1603 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIwYmFjMWM5M2MzNzY4 MmVmODZlMzc1NzdjZGE2Yjk1ODEyNmUwNy4uYmIxODNlNTFmMDUyNzcxMTA4ODA2ZjYyZjZlN2Y2 NzNkMDkwMDAzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTE4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFdlYkF1ZGlvOiBBdWRpb0Nv bnRleHQ6OnVuaW5pdGlhbGl6ZSgpIGNhbiBjYXVzZWQgQXVkaW9Db250ZXh0IGRlbGV0aW9uIGJl Zm9yZSBkZWxldGluZyBtYXJrZWQgbm9kZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03Mjc1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICBQcm90ZWN0IEF1ZGlv Q29udGV4dCBmcm9tIGJlaW5nIGRlbGV0ZWQgYmVmb3JlIHVuaW5pdGlhbGl6ZSgpIHJldHVybnMu IEZpeGVzIGFuIGFzc2VydGlvbiBpbiB+QXVkaW9Db250ZXh0KCkgYW5kIAorICAgICAgICBhIHBv dGVudGlhbCBzb3VyY2Ugb2YgbGVha3MuCisKKyAgICAgICAgKiB3ZWJhdWRpby9BdWRpb0NvbnRl eHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Db250ZXh0Ojp1bmluaXRpYWxpemUpOgor CiAyMDExLTExLTE0ICBBbm5hIENhdmVuZGVyICA8YW5uYWNjQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZW1vdmUgVGV4dFRyYWNrQ3VlSW5kZXggYW5kIFRleHRUcmFja0N1ZVNldC4gIE5vIGxv bmdlciBuZWVkZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0Nv bnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcAppbmRl eCBjY2UzMmJiOGQ1NjY5MWQwN2E3OGE0ZmEzODMzYWIxNDM0ZmEzYWYyLi5jMTAxZWUzNWExNjRk OGYzZTA2ZjgyNTZiYjYyYzAyZDg1YWU1MjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93 ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1 ZGlvQ29udGV4dC5jcHAKQEAgLTIxNSw3ICsyMTUsMTAgQEAgdm9pZCBBdWRpb0NvbnRleHQ6OnVu aW5pdGlhbGl6ZSgpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKIAotICAgIGlmICht X2lzSW5pdGlhbGl6ZWQpIHsgICAgCisgICAgaWYgKG1faXNJbml0aWFsaXplZCkgeworICAgICAg ICAvLyBQcm90ZWN0IHRoaXMgb2JqZWN0IGZyb20gYmVpbmcgZGVsZXRlZCBiZWZvcmUgd2UgZmlu aXNoIHVuaW5pdGlhbGl6aW5nLgorICAgICAgICBSZWZQdHI8QXVkaW9Db250ZXh0PiBwcm90ZWN0 KHRoaXMpOworCiAgICAgICAgIC8vIFRoaXMgc3RvcHMgdGhlIGF1ZGlvIHRocmVhZCBhbmQgYWxs IGF1ZGlvIHJlbmRlcmluZy4KICAgICAgICAgbV9kZXN0aW5hdGlvbk5vZGUtPnVuaW5pdGlhbGl6 ZSgpOwogCg==