72751 2011-11-18 13:13:11 -0800 WebKit2.MouseMoveAfterCrash API test is failing 2011-11-30 11:01:00 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser bdakin aroben bdakin simon.fraser oldest_to_newest 505993 0 simon.fraser 2011-11-18 13:13:11 -0800 WebKit2.MouseMoveAfterCrash is failing on the bots. This appears to have broken at r100483, which was the fix for https://bugs.webkit.org/show_bug.cgi?id=72400 506002 1 simon.fraser 2011-11-18 13:18:02 -0800 I confirmed that rolling out r100483 fixes this. 511102 2 bdakin 2011-11-29 14:10:48 -0800 I see what the problem is. The problem is in these changes: Index: Source/WebKit2/WebProcess/WebPage/WebPage.cpp =================================================================== --- Source/WebKit2/WebProcess/WebPage/WebPage.cpp (revision 100305) +++ Source/WebKit2/WebProcess/WebPage/WebPage.cpp (working copy) @@ -1105,7 +1105,7 @@ static bool handleContextMenuEvent(const return handled; } -static bool handleMouseEvent(const WebMouseEvent& mouseEvent, Page* page) +static bool handleMouseEvent(const WebMouseEvent& mouseEvent, Page* page, bool onlyUpdateScrollbars) { Frame* frame = page->mainFrame(); if (!frame->view()) @@ -1128,7 +1128,7 @@ static bool handleMouseEvent(const WebMo case WebCore::MouseEventReleased: return frame->eventHandler()->handleMouseReleaseEvent(platformMouseEvent); case WebCore::MouseEventMoved: - return frame->eventHandler()->mouseMoved(platformMouseEvent); + return frame->eventHandler()->mouseMoved(platformMouseEvent, onlyUpdateScrollbars); default: ASSERT_NOT_REACHED(); @@ -1154,7 +1154,7 @@ void WebPage::mouseEvent(const WebMouseE if (!handled) { CurrentEvent currentEvent(mouseEvent); - handled = handleMouseEvent(mouseEvent, m_page.get()); + handled = handleMouseEvent(mouseEvent, m_page.get(), !windowIsFocused()); } send(Messages::WebPageProxy::DidReceiveEvent(static_cast<uint32_t>(mouseEvent.type()), handled)); @@ -1172,7 +1172,7 @@ void WebPage::mouseEventSyncForTesting(c if (!handled) { CurrentEvent currentEvent(mouseEvent); - handled = handleMouseEvent(mouseEvent, m_page.get()); + handled = handleMouseEvent(mouseEvent, m_page.get(), !windowIsFocused()); } } In the test harness, windowIsFocused() is false because on Mac it evaluates to m_windowIsVisible, and the window is not visible. It's a simple problem, but I'll have to think about the best way to solve it. 511265 3 117087 bdakin 2011-11-29 18:03:50 -0800 Created attachment 117087 Patch 511898 4 bdakin 2011-11-30 11:01:00 -0800 Thanks Sam! Committed change with revision 101532. 117087 2011-11-29 18:03:50 -0800 2011-11-29 21:36:25 -0800 Patch for-review.txt text/plain 3854 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTQzOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTI5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzI3NTEKKyAgICAgICAgV2ViS2l0Mi5Nb3VzZU1vdmVBZnRlckNy YXNoIEFQSSB0ZXN0IGlzIGZhaWxpbmcgCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICB3aW5kb3dJc0ZvY3VzZWQoKSBpcyB0b28gcmVzdHJpY3RpdmUuIEFs bCB3ZSBuZWVkIHRvIGtub3cgaXMgdGhhdCB0aGUgcGFnZSBpcyAKKyAgICAgICBhY3RpdmUuCisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjptb3VzZUV2ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6bW91c2VF dmVudFN5bmNGb3JUZXN0aW5nKToKKwogMjAxMS0xMS0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5k ZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIERlY29yYXRlIGFkb3B0V0sgd2l0aCBXQVJOX1VO VVNFRF9SRVRVUk4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHAJKHJldmlzaW9uIDEwMTMwOCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE3OSw3ICsxMTc5LDcg QEAgdm9pZCBXZWJQYWdlOjptb3VzZUV2ZW50KGNvbnN0IFdlYk1vdXNlRQogICAgIGlmICghaGFu ZGxlZCkgewogICAgICAgICBDdXJyZW50RXZlbnQgY3VycmVudEV2ZW50KG1vdXNlRXZlbnQpOwog Ci0gICAgICAgIGhhbmRsZWQgPSBoYW5kbGVNb3VzZUV2ZW50KG1vdXNlRXZlbnQsIG1fcGFnZS5n ZXQoKSwgIXdpbmRvd0lzRm9jdXNlZCgpKTsKKyAgICAgICAgaGFuZGxlZCA9IGhhbmRsZU1vdXNl RXZlbnQobW91c2VFdmVudCwgbV9wYWdlLmdldCgpLCAhbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIo KS0+aXNBY3RpdmUoKSk7CiAgICAgfQogCiAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5 OjpEaWRSZWNlaXZlRXZlbnQoc3RhdGljX2Nhc3Q8dWludDMyX3Q+KG1vdXNlRXZlbnQudHlwZSgp KSwgaGFuZGxlZCkpOwpAQCAtMTE5Nyw3ICsxMTk3LDcgQEAgdm9pZCBXZWJQYWdlOjptb3VzZUV2 ZW50U3luY0ZvclRlc3RpbmcoYwogCiAgICAgaWYgKCFoYW5kbGVkKSB7CiAgICAgICAgIEN1cnJl bnRFdmVudCBjdXJyZW50RXZlbnQobW91c2VFdmVudCk7Ci0gICAgICAgIGhhbmRsZWQgPSBoYW5k bGVNb3VzZUV2ZW50KG1vdXNlRXZlbnQsIG1fcGFnZS5nZXQoKSwgIXdpbmRvd0lzRm9jdXNlZCgp KTsKKyAgICAgICAgaGFuZGxlZCA9IGhhbmRsZU1vdXNlRXZlbnQobW91c2VFdmVudCwgbV9wYWdl LmdldCgpLCAhbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+aXNBY3RpdmUoKSk7CiAgICAgfQog fQogCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMDE0MzkpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0xMS0yOSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+ CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNzUx CisgICAgICAgIFdlYktpdDIuTW91c2VNb3ZlQWZ0ZXJDcmFzaCBBUEkgdGVzdCBpcyBmYWlsaW5n IAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExpa2Ug RHVtcFJlbmRlclRyZWUsIHRoZSBOU1dpbmRvdyBzaG91bGQgYWN0IGFzIGFuIGFjdGl2ZSB3aW5k b3cuCisgICAgICAgICogVGVzdFdlYktpdEFQSS9tYWMvUGxhdGZvcm1XZWJWaWV3TWFjLm1tOgor ICAgICAgICAoLVtBY3RpdmVPZmZzY3JlZW5XaW5kb3cgaXNLZXlXaW5kb3ddKToKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OlBsYXRmb3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KToKKwogMjAx MS0xMS0yOSAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIExpc3Qg b2YgYnVpbGRlcnMgaW4gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQgaXMgb3V0IG9mIGRhdGUKSW5k ZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0JKHJl dmlzaW9uIDEwMTMwOCkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvbWFjL1BsYXRmb3JtV2ViVmll d01hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksMTYgQEAKICNpbXBvcnQgPFdlYktp dDIvV0tWaWV3UHJpdmF0ZS5oPgogI2ltcG9ydCA8Q2FyYm9uL0NhcmJvbi5oPgogCitAaW50ZXJm YWNlIEFjdGl2ZU9mZnNjcmVlbldpbmRvdyA6IE5TV2luZG93CitAZW5kCisKK0BpbXBsZW1lbnRh dGlvbiBBY3RpdmVPZmZzY3JlZW5XaW5kb3cKKy0gKEJPT0wpaXNLZXlXaW5kb3cKK3sKKyAgICBy ZXR1cm4gWUVTOworfQorQGVuZAorCiBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKIFBsYXRm b3JtV2ViVmlldzo6UGxhdGZvcm1XZWJWaWV3KFdLQ29udGV4dFJlZiBjb250ZXh0UmVmLCBXS1Bh Z2VHcm91cFJlZiBwYWdlR3JvdXBSZWYpCkBAIC0zNyw3ICs0Nyw3IEBAIFBsYXRmb3JtV2ViVmll dzo6UGxhdGZvcm1XZWJWaWV3KFdLQ29udGUKICAgICBtX3ZpZXcgPSBbW1dLVmlldyBhbGxvY10g aW5pdFdpdGhGcmFtZTpyZWN0IGNvbnRleHRSZWY6Y29udGV4dFJlZiBwYWdlR3JvdXBSZWY6cGFn ZUdyb3VwUmVmXTsKIAogICAgIE5TUmVjdCB3aW5kb3dSZWN0ID0gTlNPZmZzZXRSZWN0KHJlY3Qs IC0xMDAwMCwgWyhOU1NjcmVlbiAqKVtbTlNTY3JlZW4gc2NyZWVuc10gb2JqZWN0QXRJbmRleDow XSBmcmFtZV0uc2l6ZS5oZWlnaHQgLSByZWN0LnNpemUuaGVpZ2h0ICsgMTAwMDApOwotICAgIG1f d2luZG93ID0gW1tOU1dpbmRvdyBhbGxvY10gaW5pdFdpdGhDb250ZW50UmVjdDp3aW5kb3dSZWN0 IHN0eWxlTWFzazpOU0JvcmRlcmxlc3NXaW5kb3dNYXNrIGJhY2tpbmc6TlNCYWNraW5nU3RvcmVC dWZmZXJlZCBkZWZlcjpZRVNdOworICAgIG1fd2luZG93ID0gW1tBY3RpdmVPZmZzY3JlZW5XaW5k b3cgYWxsb2NdIGluaXRXaXRoQ29udGVudFJlY3Q6d2luZG93UmVjdCBzdHlsZU1hc2s6TlNCb3Jk ZXJsZXNzV2luZG93TWFzayBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6WUVT XTsKICAgICBbbV93aW5kb3cgc2V0Q29sb3JTcGFjZTpbW05TU2NyZWVuIG1haW5TY3JlZW5dIGNv bG9yU3BhY2VdXTsKICAgICBbW21fd2luZG93IGNvbnRlbnRWaWV3XSBhZGRTdWJ2aWV3Om1fdmll d107CiAgICAgW21fd2luZG93IG9yZGVyQmFjazpuaWxdOwo=