72750 2011-11-18 13:04:27 -0800 Found more void functions that are eager to return a value. 2011-11-18 16:23:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 knorton knorton abarth webkit.review.bot oldest_to_newest 505989 0 knorton 2011-11-18 13:04:27 -0800 Found more void functions that are eager to return a value. 505994 1 115854 knorton 2011-11-18 13:14:10 -0800 Created attachment 115854 Patch 505995 2 knorton 2011-11-18 13:15:20 -0800 I keep stumbling into these. 506182 3 115854 webkit.review.bot 2011-11-18 16:23:20 -0800 Comment on attachment 115854 Patch Clearing flags on attachment: 115854 Committed r100824: <http://trac.webkit.org/changeset/100824> 506183 4 webkit.review.bot 2011-11-18 16:23:24 -0800 All reviewed patches have been landed. Closing bug. 115854 2011-11-18 13:14:10 -0800 2011-11-18 16:23:20 -0800 Patch bug-72750-20111118161409.patch text/plain 6595 knorton SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDgwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTE4ICBLZWxseSBO b3J0b24gIDxrbm9ydG9uQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4ZXMgc2V2ZXJhbCBtb3Jl IHZvaWQgZnVuY3Rpb25zIGluIFJlbmRlck9iamVjdCB0aGF0IHJldHVybiB2YWx1ZXMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03Mjc1MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjp1cGRhdGVCZWZv cmVBZnRlckNvbnRlbnQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmFkZENoaWxk VG9Db250aW51YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmFkZENoaWxk VG9Bbm9ueW1vdXNDb2x1bW5CbG9ja3MpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6 OmFkZENoaWxkKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjphZGRDaGlsZElnbm9y aW5nQ29udGludWF0aW9uKToKKwogMjAxMS0xMS0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBBcHBlYXJhbmNlIG9mIGNvbXBvdW5kIHRyYW5zZm9y bSBhbmltYXRpb25zIHVuZGVyIGFwcHMgbGlua2VkIG9uIFNub3dMZW9wYXJkIGlzIGluY29ycmVj dApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lv biAxMDA3ODgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yOTYsNyArMjk2LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6dXBkYXRl QmVmb3JlQWZ0ZXJDb250ZQogICAgIC8vIElmIHRoaXMgaXMgYW4gYW5vbnltb3VzIHdyYXBwZXIs IHRoZW4gdGhlIHBhcmVudCBhcHBsaWVzIGl0cyBvd24gcHNldWRvLWVsZW1lbnQgc3R5bGUgdG8g aXQuCiAgICAgaWYgKHBhcmVudCgpICYmIHBhcmVudCgpLT5jcmVhdGVzQW5vbnltb3VzV3JhcHBl cigpKQogICAgICAgICByZXR1cm47Ci0gICAgcmV0dXJuIGNoaWxkcmVuKCktPnVwZGF0ZUJlZm9y ZUFmdGVyQ29udGVudCh0aGlzLCBwc2V1ZG9JZCk7CisgICAgY2hpbGRyZW4oKS0+dXBkYXRlQmVm b3JlQWZ0ZXJDb250ZW50KHRoaXMsIHBzZXVkb0lkKTsKIH0KIAogUmVuZGVyQmxvY2sqIFJlbmRl ckJsb2NrOjpjb250aW51YXRpb25CZWZvcmUoUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCkKQEAg LTMzOSw4ICszMzksMTAgQEAgdm9pZCBSZW5kZXJCbG9jazo6YWRkQ2hpbGRUb0NvbnRpbnVhdGlv bgogICAgICAgICAgICAgYmVmb3JlQ2hpbGRQYXJlbnQgPSBmbG93OwogICAgIH0KIAotICAgIGlm IChuZXdDaGlsZC0+aXNGbG9hdGluZ09yUG9zaXRpb25lZCgpKQotICAgICAgICByZXR1cm4gYmVm b3JlQ2hpbGRQYXJlbnQtPmFkZENoaWxkSWdub3JpbmdDb250aW51YXRpb24obmV3Q2hpbGQsIGJl Zm9yZUNoaWxkKTsKKyAgICBpZiAobmV3Q2hpbGQtPmlzRmxvYXRpbmdPclBvc2l0aW9uZWQoKSkg eworICAgICAgICBiZWZvcmVDaGlsZFBhcmVudC0+YWRkQ2hpbGRJZ25vcmluZ0NvbnRpbnVhdGlv bihuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAg Ly8gQSBjb250aW51YXRpb24gYWx3YXlzIGNvbnNpc3RzIG9mIHR3byBwb3RlbnRpYWwgY2FuZGlk YXRlczogYSBibG9jayBvciBhbiBhbm9ueW1vdXMKICAgICAvLyBjb2x1bW4gc3BhbiBib3ggaG9s ZGluZyBjb2x1bW4gc3BhbiBjaGlsZHJlbi4KQEAgLTM0OCwxNiArMzUwLDIyIEBAIHZvaWQgUmVu ZGVyQmxvY2s6OmFkZENoaWxkVG9Db250aW51YXRpb24KICAgICBib29sIGJjcElzTm9ybWFsID0g YmVmb3JlQ2hpbGRQYXJlbnQtPmlzSW5saW5lKCkgfHwgIWJlZm9yZUNoaWxkUGFyZW50LT5zdHls ZSgpLT5jb2x1bW5TcGFuKCk7CiAgICAgYm9vbCBmbG93SXNOb3JtYWwgPSBmbG93LT5pc0lubGlu ZSgpIHx8ICFmbG93LT5zdHlsZSgpLT5jb2x1bW5TcGFuKCk7CiAKLSAgICBpZiAoZmxvdyA9PSBi ZWZvcmVDaGlsZFBhcmVudCkKLSAgICAgICAgcmV0dXJuIGZsb3ctPmFkZENoaWxkSWdub3JpbmdD b250aW51YXRpb24obmV3Q2hpbGQsIGJlZm9yZUNoaWxkKTsKKyAgICBpZiAoZmxvdyA9PSBiZWZv cmVDaGlsZFBhcmVudCkgeworICAgICAgICBmbG93LT5hZGRDaGlsZElnbm9yaW5nQ29udGludWF0 aW9uKG5ld0NoaWxkLCBiZWZvcmVDaGlsZCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAgICAg CiAgICAgLy8gVGhlIGdvYWwgaGVyZSBpcyB0byBtYXRjaCB1cCBpZiB3ZSBjYW4sIHNvIHRoYXQg d2UgY2FuIGNvYWxlc2NlIGFuZCBjcmVhdGUgdGhlCiAgICAgLy8gbWluaW1hbCAjIG9mIGNvbnRp bnVhdGlvbnMgbmVlZGVkIGZvciB0aGUgaW5saW5lLgotICAgIGlmIChjaGlsZElzTm9ybWFsID09 IGJjcElzTm9ybWFsKQotICAgICAgICByZXR1cm4gYmVmb3JlQ2hpbGRQYXJlbnQtPmFkZENoaWxk SWdub3JpbmdDb250aW51YXRpb24obmV3Q2hpbGQsIGJlZm9yZUNoaWxkKTsKLSAgICBpZiAoZmxv d0lzTm9ybWFsID09IGNoaWxkSXNOb3JtYWwpCi0gICAgICAgIHJldHVybiBmbG93LT5hZGRDaGls ZElnbm9yaW5nQ29udGludWF0aW9uKG5ld0NoaWxkLCAwKTsgLy8gSnVzdCB0cmVhdCBsaWtlIGFu IGFwcGVuZC4KLSAgICByZXR1cm4gYmVmb3JlQ2hpbGRQYXJlbnQtPmFkZENoaWxkSWdub3JpbmdD b250aW51YXRpb24obmV3Q2hpbGQsIGJlZm9yZUNoaWxkKTsKKyAgICBpZiAoY2hpbGRJc05vcm1h bCA9PSBiY3BJc05vcm1hbCkgeworICAgICAgICBiZWZvcmVDaGlsZFBhcmVudC0+YWRkQ2hpbGRJ Z25vcmluZ0NvbnRpbnVhdGlvbihuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOworICAgICAgICByZXR1 cm47CisgICAgfQorICAgIGlmIChmbG93SXNOb3JtYWwgPT0gY2hpbGRJc05vcm1hbCkgeworICAg ICAgICBmbG93LT5hZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKG5ld0NoaWxkLCAwKTsgLy8g SnVzdCB0cmVhdCBsaWtlIGFuIGFwcGVuZC4KKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBi ZWZvcmVDaGlsZFBhcmVudC0+YWRkQ2hpbGRJZ25vcmluZ0NvbnRpbnVhdGlvbihuZXdDaGlsZCwg YmVmb3JlQ2hpbGQpOwogfQogCiAKQEAgLTM2OSwxNSArMzc3LDE5IEBAIHZvaWQgUmVuZGVyQmxv Y2s6OmFkZENoaWxkVG9Bbm9ueW1vdXNDb2wKICAgICBSZW5kZXJCbG9jayogYmVmb3JlQ2hpbGRQ YXJlbnQgPSB0b1JlbmRlckJsb2NrKGJlZm9yZUNoaWxkICYmIGJlZm9yZUNoaWxkLT5wYXJlbnQo KS0+aXNSZW5kZXJCbG9jaygpID8gYmVmb3JlQ2hpbGQtPnBhcmVudCgpIDogbGFzdENoaWxkKCkp OwogICAgIAogICAgIC8vIElmIHRoZSBuZXcgY2hpbGQgaXMgZmxvYXRpbmcgb3IgcG9zaXRpb25l ZCBpdCBjYW4ganVzdCBnbyBpbiB0aGF0IGJsb2NrLgotICAgIGlmIChuZXdDaGlsZC0+aXNGbG9h dGluZ09yUG9zaXRpb25lZCgpKQotICAgICAgICByZXR1cm4gYmVmb3JlQ2hpbGRQYXJlbnQtPmFk ZENoaWxkSWdub3JpbmdBbm9ueW1vdXNDb2x1bW5CbG9ja3MobmV3Q2hpbGQsIGJlZm9yZUNoaWxk KTsKKyAgICBpZiAobmV3Q2hpbGQtPmlzRmxvYXRpbmdPclBvc2l0aW9uZWQoKSkgeworICAgICAg ICBiZWZvcmVDaGlsZFBhcmVudC0+YWRkQ2hpbGRJZ25vcmluZ0Fub255bW91c0NvbHVtbkJsb2Nr cyhuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAg Ly8gU2VlIGlmIHRoZSBjaGlsZCBjYW4gYmUgcGxhY2VkIGluIHRoZSBib3guCiAgICAgYm9vbCBu ZXdDaGlsZEhhc0NvbHVtblNwYW4gPSBuZXdDaGlsZC0+c3R5bGUoKS0+Y29sdW1uU3BhbigpICYm ICFuZXdDaGlsZC0+aXNJbmxpbmUoKTsKICAgICBib29sIGJlZm9yZUNoaWxkUGFyZW50SG9sZHND b2x1bW5TcGFucyA9IGJlZm9yZUNoaWxkUGFyZW50LT5pc0Fub255bW91c0NvbHVtblNwYW5CbG9j aygpOwogCi0gICAgaWYgKG5ld0NoaWxkSGFzQ29sdW1uU3BhbiA9PSBiZWZvcmVDaGlsZFBhcmVu dEhvbGRzQ29sdW1uU3BhbnMpCi0gICAgICAgIHJldHVybiBiZWZvcmVDaGlsZFBhcmVudC0+YWRk Q2hpbGRJZ25vcmluZ0Fub255bW91c0NvbHVtbkJsb2NrcyhuZXdDaGlsZCwgYmVmb3JlQ2hpbGQp OworICAgIGlmIChuZXdDaGlsZEhhc0NvbHVtblNwYW4gPT0gYmVmb3JlQ2hpbGRQYXJlbnRIb2xk c0NvbHVtblNwYW5zKSB7CisgICAgICAgIGJlZm9yZUNoaWxkUGFyZW50LT5hZGRDaGlsZElnbm9y aW5nQW5vbnltb3VzQ29sdW1uQmxvY2tzKG5ld0NoaWxkLCBiZWZvcmVDaGlsZCk7CisgICAgICAg IHJldHVybjsKKyAgICB9CiAKICAgICBpZiAoIWJlZm9yZUNoaWxkKSB7CiAgICAgICAgIC8vIENy ZWF0ZSBhIG5ldyBibG9jayBvZiB0aGUgY29ycmVjdCB0eXBlLgpAQCAtMzk0LDggKzQwNiwxMCBA QCB2b2lkIFJlbmRlckJsb2NrOjphZGRDaGlsZFRvQW5vbnltb3VzQ29sCiAgICAgICAgICAgICBp c1ByZXZpb3VzQmxvY2tWaWFibGUgPSAhaW1tZWRpYXRlQ2hpbGQtPnByZXZpb3VzU2libGluZygp OwogICAgICAgICBpbW1lZGlhdGVDaGlsZCA9IGltbWVkaWF0ZUNoaWxkLT5wYXJlbnQoKTsKICAg ICB9Ci0gICAgaWYgKGlzUHJldmlvdXNCbG9ja1ZpYWJsZSAmJiBpbW1lZGlhdGVDaGlsZC0+cHJl dmlvdXNTaWJsaW5nKCkpCi0gICAgICAgIHJldHVybiB0b1JlbmRlckJsb2NrKGltbWVkaWF0ZUNo aWxkLT5wcmV2aW91c1NpYmxpbmcoKSktPmFkZENoaWxkSWdub3JpbmdBbm9ueW1vdXNDb2x1bW5C bG9ja3MobmV3Q2hpbGQsIDApOyAvLyBUcmVhdCBsaWtlIGFuIGFwcGVuZC4KKyAgICBpZiAoaXNQ cmV2aW91c0Jsb2NrVmlhYmxlICYmIGltbWVkaWF0ZUNoaWxkLT5wcmV2aW91c1NpYmxpbmcoKSkg eworICAgICAgICB0b1JlbmRlckJsb2NrKGltbWVkaWF0ZUNoaWxkLT5wcmV2aW91c1NpYmxpbmco KSktPmFkZENoaWxkSWdub3JpbmdBbm9ueW1vdXNDb2x1bW5CbG9ja3MobmV3Q2hpbGQsIDApOyAv LyBUcmVhdCBsaWtlIGFuIGFwcGVuZC4KKyAgICAgICAgcmV0dXJuOworICAgIH0KICAgICAgICAg CiAgICAgLy8gU3BsaXQgb3VyIGFub255bW91cyBibG9ja3MuCiAgICAgUmVuZGVyT2JqZWN0KiBu ZXdCZWZvcmVDaGlsZCA9IHNwbGl0QW5vbnltb3VzQmxvY2tzQXJvdW5kQ2hpbGQoYmVmb3JlQ2hp bGQpOwpAQCAtNzg1LDE1ICs3OTksMTcgQEAgdm9pZCBSZW5kZXJCbG9jazo6YWRkQ2hpbGRJZ25v cmluZ0Fub255bQogdm9pZCBSZW5kZXJCbG9jazo6YWRkQ2hpbGQoUmVuZGVyT2JqZWN0KiBuZXdD aGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCkKIHsKICAgICBpZiAoY29udGludWF0aW9u KCkgJiYgIWlzQW5vbnltb3VzQmxvY2soKSkKLSAgICAgICAgcmV0dXJuIGFkZENoaWxkVG9Db250 aW51YXRpb24obmV3Q2hpbGQsIGJlZm9yZUNoaWxkKTsKLSAgICByZXR1cm4gYWRkQ2hpbGRJZ25v cmluZ0NvbnRpbnVhdGlvbihuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOworICAgICAgICBhZGRDaGls ZFRvQ29udGludWF0aW9uKG5ld0NoaWxkLCBiZWZvcmVDaGlsZCk7CisgICAgZWxzZQorICAgICAg ICBhZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKG5ld0NoaWxkLCBiZWZvcmVDaGlsZCk7CiB9 CiAKIHZvaWQgUmVuZGVyQmxvY2s6OmFkZENoaWxkSWdub3JpbmdDb250aW51YXRpb24oUmVuZGVy T2JqZWN0KiBuZXdDaGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCkKIHsKICAgICBpZiAo IWlzQW5vbnltb3VzQmxvY2soKSAmJiBmaXJzdENoaWxkKCkgJiYgKGZpcnN0Q2hpbGQoKS0+aXNB bm9ueW1vdXNDb2x1bW5zQmxvY2soKSB8fCBmaXJzdENoaWxkKCktPmlzQW5vbnltb3VzQ29sdW1u U3BhbkJsb2NrKCkpKQotICAgICAgICByZXR1cm4gYWRkQ2hpbGRUb0Fub255bW91c0NvbHVtbkJs b2NrcyhuZXdDaGlsZCwgYmVmb3JlQ2hpbGQpOwotICAgIHJldHVybiBhZGRDaGlsZElnbm9yaW5n QW5vbnltb3VzQ29sdW1uQmxvY2tzKG5ld0NoaWxkLCBiZWZvcmVDaGlsZCk7CisgICAgICAgIGFk ZENoaWxkVG9Bbm9ueW1vdXNDb2x1bW5CbG9ja3MobmV3Q2hpbGQsIGJlZm9yZUNoaWxkKTsKKyAg ICBlbHNlCisgICAgICAgIGFkZENoaWxkSWdub3JpbmdBbm9ueW1vdXNDb2x1bW5CbG9ja3MobmV3 Q2hpbGQsIGJlZm9yZUNoaWxkKTsKIH0KIAogc3RhdGljIHZvaWQgZ2V0SW5saW5lUnVuKFJlbmRl ck9iamVjdCogc3RhcnQsIFJlbmRlck9iamVjdCogYm91bmRhcnksCg==