<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>72734</bug_id>
          
          <creation_ts>2011-11-18 08:59:28 -0800</creation_ts>
          <short_desc>Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp</short_desc>
          <delta_ts>2011-11-20 00:15:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>72824</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Peter Rybin">peter.rybin</reporter>
          <assigned_to name="Vsevolod Vlasov">vsevik</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>peter.rybin</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>vsevik</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>505832</commentid>
    <comment_count>0</comment_count>
    <who name="Peter Rybin">peter.rybin</who>
    <bug_when>2011-11-18 08:59:28 -0800</bug_when>
    <thetext>InspectorApplicationCacheAgent.cpp:188 (r100177)
size is declared &apos;string&apos;, but actual type is &apos;integer&apos;; why &apos;size&apos; is declared &apos;string&apos; in the first place?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>505842</commentid>
    <comment_count>1</comment_count>
    <who name="Peter Rybin">peter.rybin</who>
    <bug_when>2011-11-18 09:07:21 -0800</bug_when>
    <thetext>This should be fixed to conform to protocol declaration AND to prepare switching to type-safe JSON API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506408</commentid>
    <comment_count>2</comment_count>
      <attachid>115951</attachid>
    <who name="Vsevolod Vlasov">vsevik</who>
    <bug_when>2011-11-19 08:37:49 -0800</bug_when>
    <thetext>Created attachment 115951
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506410</commentid>
    <comment_count>3</comment_count>
      <attachid>115951</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-19 09:32:38 -0800</bug_when>
    <thetext>Comment on attachment 115951
Patch

Clearing flags on attachment: 115951

Committed r100857: &lt;http://trac.webkit.org/changeset/100857&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506411</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-19 09:32:43 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>115951</attachid>
            <date>2011-11-19 08:37:49 -0800</date>
            <delta_ts>2011-11-19 09:32:38 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-72734-20111119203747.patch</filename>
            <type>text/plain</type>
            <size>1553</size>
            <attacher name="Vsevolod Vlasov">vsevik</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjIwMTlmZWNiODc0NzE2
ODAwYjc0MmQwNTkwYmFmMWExYTY0ZGEyOS4uYWM1MGFmM2I5NDhhN2Q0OTdmMzMxZWZkYWNmMDFh
MGU1NTVlMjdlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTE5ICBWc2V2
b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0
b3I6W3Byb3RvY29sXSBhY3R1YWwgSlNPTiBtZXNzYWdlcyBkbyBub3QgY29uZm9ybSB0byBJbnNw
ZWN0b3IuanNvbiBpbiBJbnNwZWN0b3JBcHBsaWNhdGlvbkNhY2hlQWdlbnQuY3BwCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjczNAorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3Bl
Y3Rvci5qc29uOgorCiAyMDExLTExLTE4ICBBbGV4YW5kcnUgQ2hpY3VsaXRhICA8YWNoaWN1QGFk
b2JlLmNvbT4KIAogICAgICAgICBbQ1NTU2hhZGVyc10gSW1wbGVtZW50IHRoZSBjb21wdXRlZCBz
dHlsZSBmb3IgbWVzaCBwYXJhbWV0ZXJzIG9mIHRoZSBjdXN0b20oKSBmaWx0ZXIKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbiBiL1NvdXJjZS9XZWJD
b3JlL2luc3BlY3Rvci9JbnNwZWN0b3IuanNvbgppbmRleCA5MjU0NGUzMGIzZDZkODZmYzMyYjFi
YjM5YzY0NzU3NTYwZGZlNTA4Li42YzhmODZiZjU0ODdlMmYyMzNmMDBmOTcwNDg1ODIyZmM5MjNl
Y2E1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmpzb24K
KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvci5qc29uCkBAIC05MzEsNyAr
OTMxLDcgQEAKICAgICAgICAgICAgICAgICAiZGVzY3JpcHRpb24iOiAiRGV0YWlsZWQgYXBwbGlj
YXRpb24gY2FjaGUgcmVzb3VyY2UgaW5mb3JtYXRpb24uIiwKICAgICAgICAgICAgICAgICAicHJv
cGVydGllcyI6IFsKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJ1cmwiLCAidHlwZSI6
ICJzdHJpbmciLCAiZGVzY3JpcHRpb24iOiAiUmVzb3VyY2UgdXJsLiIgfSwKLSAgICAgICAgICAg
ICAgICAgICAgeyAibmFtZSI6ICJzaXplIiwgInR5cGUiOiAic3RyaW5nIiwgImRlc2NyaXB0aW9u
IjogIlJlc291cmNlIHNpemUuIiB9LAorICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInNp
emUiLCAidHlwZSI6ICJpbnRlZ2VyIiwgImRlc2NyaXB0aW9uIjogIlJlc291cmNlIHNpemUuIiB9
LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogInR5cGUiLCAidHlwZSI6ICJzdHJpbmci
LCAiZGVzY3JpcHRpb24iOiAiUmVzb3VyY2UgdHlwZS4iIH0KICAgICAgICAgICAgICAgICBdCiAg
ICAgICAgICAgICB9LAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>