72718 2011-11-18 05:33:17 -0800 [GTK] Downloads not started by WebView only fail for transport errors 2011-11-18 06:46:15 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned pnormand svillar oldest_to_newest 505700 0 cgarcia 2011-11-18 05:33:17 -0800 For example, downloading a file that doesn't exists finishes successfully. This doesn't affect downloads started by the web view, because the frame loader client fails and the download never starts. 505707 1 115790 cgarcia 2011-11-18 05:39:07 -0800 Created attachment 115790 Patch 505747 2 cgarcia 2011-11-18 06:46:15 -0800 Committed r100769: <http://trac.webkit.org/changeset/100769> 115790 2011-11-18 05:39:07 -0800 2011-11-18 06:31:18 -0800 Patch wk-downloads-errors.diff text/plain 7001 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCA3YTJiZTk4Li5jN2FlZDRhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTEtMTEtMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIERvd25sb2FkcyBub3Qgc3RhcnRlZCBieSBX ZWJWaWV3IG9ubHkgZmFpbCBmb3IgdHJhbnNwb3J0IGVycm9ycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI3MTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBYm9ydCB0aGUgZG93bmxvYWQgd2l0aCBhbiBl cnJvciBpZiB0aGUgcmVzcG9uc2UgY29udGFpbnMgYW4KKyAgICAgICAgZXJyb3IgY29kZS4gSXQg YWRkcyBhIG5ldyB0ZXN0IGNhc2UgdG8gdGhlIGRvd25sb2FkIHVuaXQgdGVzdHMuCisKKyAgICAg ICAgKiB0ZXN0cy90ZXN0ZG93bmxvYWQuYzoKKyAgICAgICAgKG5vdGlmeURvd25sb2FkU3RhdHVz Q2FsbGJhY2spOgorICAgICAgICAoc2VydmVyQ2FsbGJhY2spOgorICAgICAgICAodGVzdF93ZWJr aXRfZG93bmxvYWRfbm90X2ZvdW5kKToKKyAgICAgICAgKG1haW4pOgorICAgICAgICAqIHdlYmtp dC93ZWJraXRkb3dubG9hZC5jcHA6CisgICAgICAgIChEb3dubG9hZENsaWVudDo6ZGlkUmVjZWl2 ZVJlc3BvbnNlKTogQ2hlY2sgd2hldGhlciBodHRwIHN0YXR1cyBvZgorICAgICAgICB0aGUgcmVz cG9uc2UgaXMgYW4gZXJyb3IgY29kZSBhbmQgZW1pdCBlcnJvciBzaWduYWwgaW4gc3VjaCBjYXNl LgorCiAyMDExLTExLTE3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNv bT4KIAogICAgICAgICBbR1RLXSBDb25zaWRlciBwYXJlbnQgQXRrT2JqZWN0IGluIHdlYmtpdF9h Y2Nlc3NpYmxlX2dldF9wYXJlbnQoKSwgaWYgYWxyZWFkeSBzZXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBkODY1 NDA5Li5jYjY2MDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMTggIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtd IERvd25sb2FkcyBub3Qgc3RhcnRlZCBieSBXZWJWaWV3IG9ubHkgZmFpbCBmb3IgdHJhbnNwb3J0 IGVycm9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzI3MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFdlYlByb2Nlc3MvRG93bmxvYWRzL3NvdXAvRG93bmxvYWRTb3VwLmNwcDoKKyAgICAgICAgKFdl YktpdDo6RG93bmxvYWRDbGllbnQ6OmRpZFJlY2VpdmVSZXNwb25zZSk6IENoZWNrIGlmIHRoZSBo dHRwCisgICAgICAgIHN0YXR1cyBvZiB0aGUgcmVzcG9uc2UgaXMgYW4gZXJyb3IgY29kZSBhbmQg ZmluaXNoIHRoZSBkb3dubG9hZAorICAgICAgICB3aXRoIGFuIGVycm9yIGluIHN1Y2ggY2FzZS4K KwogMjAxMS0xMS0xNyAgQWxleGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9y Zz4KIAogICAgICAgICBbUXRdW1dLMl0gQ2xlYW51cCBkZWFkIGNvZGUgaW4gUXRXZWJQYWdlUHJv eHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0ZG93bmxvYWQuYyBi L1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb3dubG9hZC5jCmluZGV4IDAzYjM5ODU4Li5j MjZlNTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0ZG93bmxvYWQu YworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0ZG93bmxvYWQuYwpAQCAtMjQ4LDYg KzI0OCw2NyBAQCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9kYXRhKHZvaWQpCiAgICAgZ19vYmplY3Rf dW5yZWYod2ViVmlldyk7CiB9CiAKK3N0YXRpYyB2b2lkIG5vdGlmeURvd25sb2FkU3RhdHVzQ2Fs bGJhY2soR09iamVjdCAqb2JqZWN0LCBHUGFyYW1TcGVjICpwc3BlYywgZ3BvaW50ZXIgZGF0YSkK K3sKKyAgICBXZWJLaXREb3dubG9hZCAqZG93bmxvYWQgPSBXRUJLSVRfRE9XTkxPQUQob2JqZWN0 KTsKKyAgICBXZWJLaXROZXR3b3JrUmVzcG9uc2UgKnJlc3BvbnNlID0gd2Via2l0X2Rvd25sb2Fk X2dldF9uZXR3b3JrX3Jlc3BvbnNlKGRvd25sb2FkKTsKKyAgICBTb3VwTWVzc2FnZSAqbWVzc2Fn ZSA9IHdlYmtpdF9uZXR3b3JrX3Jlc3BvbnNlX2dldF9tZXNzYWdlKHJlc3BvbnNlKTsKKworICAg IHN3aXRjaCAod2Via2l0X2Rvd25sb2FkX2dldF9zdGF0dXMoZG93bmxvYWQpKSB7CisgICAgY2Fz ZSBXRUJLSVRfRE9XTkxPQURfU1RBVFVTX0VSUk9SOgorICAgICAgICBnX2Fzc2VydF9jbXBpbnQo bWVzc2FnZS0+c3RhdHVzX2NvZGUsID09LCA0MDQpOworICAgICAgICBnX21haW5fbG9vcF9xdWl0 KGxvb3ApOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFdFQktJVF9ET1dOTE9BRF9TVEFUVVNf RklOSVNIRUQ6CisgICAgY2FzZSBXRUJLSVRfRE9XTkxPQURfU1RBVFVTX0NBTkNFTExFRDoKKyAg ICAgICAgZ19hc3NlcnRfbm90X3JlYWNoZWQoKTsKKyAgICAgICAgYnJlYWs7CisgICAgZGVmYXVs dDoKKyAgICAgICAgYnJlYWs7CisgICAgfQorfQorCitzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFj ayhTb3VwU2VydmVyICpzZXJ2ZXIsIFNvdXBNZXNzYWdlICptZXNzYWdlLCBjb25zdCBjaGFyICpw YXRoLCBHSGFzaFRhYmxlICpxdWVyeSwgU291cENsaWVudENvbnRleHQgKmNvbnRleHQsIGdwb2lu dGVyIHVzZXJEYXRhKQoreworICAgIGlmIChtZXNzYWdlLT5tZXRob2QgIT0gU09VUF9NRVRIT0Rf R0VUKSB7CisgICAgICAgIHNvdXBfbWVzc2FnZV9zZXRfc3RhdHVzKG1lc3NhZ2UsIFNPVVBfU1RB VFVTX05PVF9JTVBMRU1FTlRFRCk7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBzb3Vw X21lc3NhZ2Vfc2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19OT1RfRk9VTkQpOworICAg IHNvdXBfbWVzc2FnZV9ib2R5X2NvbXBsZXRlKG1lc3NhZ2UtPnJlc3BvbnNlX2JvZHkpOworfQor CitzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9ub3RfZm91bmQodm9pZCkKK3sKKyAg ICBTb3VwU2VydmVyICpzZXJ2ZXIgPSBzb3VwX3NlcnZlcl9uZXcoU09VUF9TRVJWRVJfUE9SVCwg MCwgTlVMTCk7CisgICAgc291cF9zZXJ2ZXJfcnVuX2FzeW5jKHNlcnZlcik7CisgICAgc291cF9z ZXJ2ZXJfYWRkX2hhbmRsZXIoc2VydmVyLCBOVUxMLCBzZXJ2ZXJDYWxsYmFjaywgTlVMTCwgTlVM TCk7CisgICAgU291cFVSSSAqYmFzZVVSSSA9IHNvdXBfdXJpX25ldygiaHR0cDovLzEyNy4wLjAu MS8iKTsKKyAgICBzb3VwX3VyaV9zZXRfcG9ydChiYXNlVVJJLCBzb3VwX3NlcnZlcl9nZXRfcG9y dChzZXJ2ZXIpKTsKKworICAgIFNvdXBVUkkgKnVyaSA9IHNvdXBfdXJpX25ld193aXRoX2Jhc2Uo YmFzZVVSSSwgIi9mb28iKTsKKyAgICBjaGFyICp1cmlTdHJpbmcgPSBzb3VwX3VyaV90b19zdHJp bmcodXJpLCBGQUxTRSk7CisgICAgc291cF91cmlfZnJlZSh1cmkpOworCisgICAgbG9vcCA9IGdf bWFpbl9sb29wX25ldyhOVUxMLCBUUlVFKTsKKyAgICBXZWJLaXROZXR3b3JrUmVxdWVzdCAqcmVx dWVzdCA9IHdlYmtpdF9uZXR3b3JrX3JlcXVlc3RfbmV3KHVyaVN0cmluZyk7CisgICAgZ19mcmVl ICh1cmlTdHJpbmcpOworICAgIFdlYktpdERvd25sb2FkICpkb3dubG9hZCA9IHdlYmtpdF9kb3du bG9hZF9uZXcocmVxdWVzdCk7CisgICAgZ19vYmplY3RfdW5yZWYocmVxdWVzdCk7CisKKyAgICB3 ZWJraXRfZG93bmxvYWRfc2V0X2Rlc3RpbmF0aW9uX3VyaShkb3dubG9hZCwgImZpbGU6Ly8vdG1w L2ZvbyIpOworICAgIGdfc2lnbmFsX2Nvbm5lY3QoZG93bmxvYWQsICJub3RpZnk6OnN0YXR1cyIs IEdfQ0FMTEJBQ0sobm90aWZ5RG93bmxvYWRTdGF0dXNDYWxsYmFjayksIE5VTEwpOworCisgICAg d2Via2l0X2Rvd25sb2FkX3N0YXJ0KGRvd25sb2FkKTsKKyAgICBnX21haW5fbG9vcF9ydW4obG9v cCk7CisKKyAgICBnX29iamVjdF91bnJlZihkb3dubG9hZCk7CisgICAgZ19tYWluX2xvb3BfdW5y ZWYobG9vcCk7CisgICAgc291cF91cmlfZnJlZShiYXNlVVJJKTsKKyAgICBnX29iamVjdF91bnJl ZihzZXJ2ZXIpOworfQorCiBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CiAgICAg Z3RrX3Rlc3RfaW5pdCgmYXJnYywgJmFyZ3YsIE5VTEwpOwpAQCAtMjU3LDYgKzMxOCw3IEBAIGlu dCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKICAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJr aXQvZG93bmxvYWQvc3luY2giLCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9zeW5jaCk7CiAgICAgZ190 ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2Rvd25sb2FkL2FzeW5jaCIsIHRlc3Rfd2Via2l0X2Rvd25s b2FkX2FzeW5jaCk7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2Rvd25sb2FkL2RhdGEi LCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9kYXRhKTsKKyAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJr aXQvZG93bmxvYWQvbm90LWZvdW5kIiwgdGVzdF93ZWJraXRfZG93bmxvYWRfbm90X2ZvdW5kKTsK ICAgICByZXR1cm4gZ190ZXN0X3J1biAoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRkb3dubG9hZC5jcHAKaW5kZXggMGNkZTc2ZS4uY2Y0YzU5YyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGRvd25sb2FkLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0ZG93bmxvYWQuY3BwCkBAIC05NDAsNiArOTQwLDEwIEBA IERvd25sb2FkQ2xpZW50OjpEb3dubG9hZENsaWVudChXZWJLaXREb3dubG9hZCogZG93bmxvYWQp CiB2b2lkIERvd25sb2FkQ2xpZW50OjpkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUq LCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKIHsKICAgICB3ZWJraXRfZG93bmxv YWRfc2V0X3Jlc3BvbnNlKG1fZG93bmxvYWQsIHJlc3BvbnNlKTsKKyAgICBpZiAocmVzcG9uc2Uu aHR0cFN0YXR1c0NvZGUoKSA+PSA0MDApIHsKKyAgICAgICAgd2Via2l0X2Rvd25sb2FkX2Vycm9y KG1fZG93bmxvYWQsIFJlc291cmNlRXJyb3IoZXJyb3JEb21haW5Eb3dubG9hZCwgcmVzcG9uc2Uu aHR0cFN0YXR1c0NvZGUoKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcmVzcG9uc2UudXJsKCkuc3RyaW5nKCksIHJlc3BvbnNlLmh0dHBT dGF0dXNUZXh0KCkpKTsKKyAgICB9CiB9CiAKIHZvaWQgRG93bmxvYWRDbGllbnQ6OmRpZFJlY2Vp dmVEYXRhKFJlc291cmNlSGFuZGxlKiwgY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0aCwgaW50 IGVuY29kZWREYXRhTGVuZ3RoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAuY3BwCmluZGV4IGVhZjNiYTAuLjRjYTFk MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3NvdXAv RG93bmxvYWRTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rvd25sb2Fk cy9zb3VwL0Rvd25sb2FkU291cC5jcHAKQEAgLTU1LDYgKzU1LDE1IEBAIHB1YmxpYzoKIAogICAg IHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VS ZXNwb25zZSYgcmVzcG9uc2UpCiAgICAgeworICAgICAgICBtX3Jlc3BvbnNlID0gYWRvcHRHUmVm KHJlc3BvbnNlLnRvU291cE1lc3NhZ2UoKSk7CisgICAgICAgIG1fZG93bmxvYWQtPmRpZFJlY2Vp dmVSZXNwb25zZShyZXNwb25zZSk7CisKKyAgICAgICAgaWYgKHJlc3BvbnNlLmh0dHBTdGF0dXND b2RlKCkgPj0gNDAwKSB7CisgICAgICAgICAgICBkb3dubG9hZEZhaWxlZChkb3dubG9hZE5ldHdv cmtFcnJvcihSZXNvdXJjZUVycm9yKGVycm9yRG9tYWluRG93bmxvYWQsIHJlc3BvbnNlLmh0dHBT dGF0dXNDb2RlKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJlc3BvbnNlLnVybCgpLnN0cmluZygpLCByZXNwb25zZS5odHRw U3RhdHVzVGV4dCgpKSkpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKICAgICAg ICAgU3RyaW5nIHN1Z2dlc3RlZEZpbGVuYW1lID0gcmVzcG9uc2Uuc3VnZ2VzdGVkRmlsZW5hbWUo KTsKICAgICAgICAgaWYgKHN1Z2dlc3RlZEZpbGVuYW1lLmlzRW1wdHkoKSkgewogICAgICAgICAg ICAgS1VSTCB1cmwgPSByZXNwb25zZS51cmwoKTsKQEAgLTc5LDkgKzg4LDYgQEAgcHVibGljOgog ICAgICAgICAgICAgZG93bmxvYWRGYWlsZWQoZG93bmxvYWREZXN0aW5hdGlvbkVycm9yKHJlc3Bv bnNlLCBlcnJvci0+bWVzc2FnZSkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0K LSAgICAgICAgbV9yZXNwb25zZSA9IGFkb3B0R1JlZihyZXNwb25zZS50b1NvdXBNZXNzYWdlKCkp OwotICAgICAgICBtX2Rvd25sb2FkLT5kaWRSZWNlaXZlUmVzcG9uc2UocmVzcG9uc2UpOwogICAg IH0KIAogICAgIHZvaWQgZGlkUmVjZWl2ZURhdGEoUmVzb3VyY2VIYW5kbGUqLCBjb25zdCBjaGFy KiBkYXRhLCBpbnQgbGVuZ3RoLCBpbnQgLyplbmNvZGVkRGF0YUxlbmd0aCovKQo=