72717 2011-11-18 05:28:33 -0800 [Qt][WK2] setViewportInteractionEngine must also set the InteractionEngine for the tap recognizer 2011-11-18 05:49:19 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno kenneth webkit.review.bot zoltan oldest_to_newest 505696 0 zeno 2011-11-18 05:28:33 -0800 SSIA 505699 1 115787 zeno 2011-11-18 05:31:56 -0800 Created attachment 115787 patch for review. 505701 2 webkit.review.bot 2011-11-18 05:34:34 -0800 Attachment 115787 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:184: The parameter name "engine" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 505702 3 115787 zeno 2011-11-18 05:34:41 -0800 Comment on attachment 115787 patch for review. there is still something missing. 505710 4 115791 zeno 2011-11-18 05:43:09 -0800 Created attachment 115791 patch for review. 505714 5 115791 zeno 2011-11-18 05:49:10 -0800 Comment on attachment 115791 patch for review. Clearing flags on attachment: 115791 Committed r100760: <http://trac.webkit.org/changeset/100760> 505715 6 zeno 2011-11-18 05:49:19 -0800 All reviewed patches have been landed. Closing bug. 115787 2011-11-18 05:31:56 -0800 2011-11-18 05:34:40 -0800 patch for review. 72717_20111118-143028.patch text/plain 2333 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ZDIxNWU3Li45YzkxOWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTEtMTggIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIHNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUgbXVzdCBhbHNvIHNldCB0 aGUgSW50ZXJhY3Rpb25FbmdpbmUgZm9yIHRoZSB0YXAgcmVjb2duaXplci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNzE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQ YWdlUHJveHkuY3BwOgorICAgICAgICAoUXRXZWJQYWdlUHJveHk6OnNldFZpZXdwb3J0SW50ZXJh Y3Rpb25FbmdpbmUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oOgor CiAyMDExLTExLTE3ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNv bT4KIAogICAgICAgICBbUXRdIFJlbW92ZSBmb3J3YXJkaW5nIGhlYWRlciBmb3IgV2ViS2l0MiBD IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVBy b3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAK aW5kZXggNDg4ZjRjZS4uZTE3ZjEzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRXZWJQYWdlUHJveHkuY3BwCkBAIC03MTIsNiArNzEyLDE0IEBAIHZvaWQgUXRXZWJQYWdl UHJveHk6OnNldE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZChib29sIGVuYWJsZWQpCiAgICAgbV9j b250ZXh0LT5wb3N0TWVzc2FnZVRvSW5qZWN0ZWRCdW5kbGUobWVzc2FnZU5hbWUsIGJvZHkuZ2V0 KCkpOwogfQogCit2b2lkIFF0V2ViUGFnZVByb3h5OjpzZXRWaWV3cG9ydEludGVyYWN0aW9uRW5n aW5lKFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSogZW5naW5lKQoreworICAgIG1faW50ZXJh Y3Rpb25FbmdpbmUgPSBlbmdpbmU7CisgICAgbV9wYW5HZXN0dXJlUmVjb2duaXplci5zZXRWaWV3 cG9ydEludGVyYWN0aW9uRW5naW5lKGVuZ2luZSk7CisgICAgbV9waW5jaEdlc3R1cmVSZWNvZ25p emVyLnNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoZW5naW5lKTsKKyAgICBtX3RhcEdlc3R1 cmVSZWNvZ25pemVyLnNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoZW5naW5lKTsKK30KKwog dm9pZCBRdFdlYlBhZ2VQcm94eTo6cG9zdE1lc3NhZ2VUb05hdmlnYXRvclF0T2JqZWN0KGNvbnN0 IFFTdHJpbmcmIG1lc3NhZ2UpCiB7CiAgICAgc3RhdGljIFN0cmluZyBtZXNzYWdlTmFtZSgiTWVz c2FnZVRvTmF2aWdhdG9yUXRPYmplY3QiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0 L1F0V2ViUGFnZVByb3h5LmgKaW5kZXggNGM3NzUwZS4uMThlNDJkMzcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5oCkBAIC0xNzcsNyArMTc3LDcgQEAg cHVibGljOgogICAgIHZvaWQgc2V0TmF2aWdhdG9yUXRPYmplY3RFbmFibGVkKGJvb2wpOwogICAg IGJvb2wgbmF2aWdhdG9yUXRPYmplY3RFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9uYXZpZ2F0 b3JRdE9iamVjdEVuYWJsZWQ7IH0KIAotICAgIHZvaWQgc2V0Vmlld3BvcnRJbnRlcmFjdGlvbkVu Z2luZShRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUqIGVuZ2luZSkgeyBtX2ludGVyYWN0aW9u RW5naW5lID0gZW5naW5lOyBtX3Bhbkdlc3R1cmVSZWNvZ25pemVyLnNldFZpZXdwb3J0SW50ZXJh Y3Rpb25FbmdpbmUoZW5naW5lKTsgbV9waW5jaEdlc3R1cmVSZWNvZ25pemVyLnNldFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUoZW5naW5lKTt9CisgICAgdm9pZCBzZXRWaWV3cG9ydEludGVyYWN0 aW9uRW5naW5lKFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSogZW5naW5lKTsKIAogICAgIHZv aWQgcG9zdE1lc3NhZ2VUb05hdmlnYXRvclF0T2JqZWN0KGNvbnN0IFFTdHJpbmcmKTsKIAo= 115791 2011-11-18 05:43:09 -0800 2011-11-18 05:49:10 -0800 patch for review. 72717_20111118-144227.patch text/plain 3851 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ZDIxNWU3Li44ZDVhZDhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTEtMTggIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIHNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUgbXVzdCBhbHNvIHNldCB0 aGUgSW50ZXJhY3Rpb25FbmdpbmUgZm9yIHRoZSB0YXAgcmVjb2duaXplci4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNzE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRUYXBH ZXN0dXJlUmVjb2duaXplci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0VGFwR2VzdHVyZVJlY29n bml6ZXI6OnNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUpOgorICAgICAgICAqIFVJUHJvY2Vz cy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVyLmg6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0 V2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFF0V2ViUGFnZVByb3h5OjpzZXRWaWV3cG9ydElu dGVyYWN0aW9uRW5naW5lKToKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHku aDoKKwogMjAxMS0xMS0xNyAgVG9yIEFybmUgVmVzdGLDuCAgPHRvci5hcm5lLnZlc3Rib0Bub2tp YS5jb20+CiAKICAgICAgICAgW1F0XSBSZW1vdmUgZm9yd2FyZGluZyBoZWFkZXIgZm9yIFdlYktp dDIgQyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdl c3R1cmVSZWNvZ25pemVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFRhcEdl c3R1cmVSZWNvZ25pemVyLmNwcAppbmRleCAxNmI4ZDYwLi44NDliMzRkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuY3Bw CkBAIC00MCw2ICs0MCwxMiBAQCBRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpRdFRhcEdlc3R1cmVS ZWNvZ25pemVyKFF0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZSogaW50ZQogICAgIHJlc2V0KCk7 CiB9CiAKK3ZvaWQgUXRUYXBHZXN0dXJlUmVjb2duaXplcjo6c2V0Vmlld3BvcnRJbnRlcmFjdGlv bkVuZ2luZShRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUqIGVuZ2luZSkKK3sKKyAgICBRdEdl c3R1cmVSZWNvZ25pemVyOjpzZXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lKGVuZ2luZSk7Cisg ICAgcmVzZXQoKTsKK30KKwogYm9vbCBRdFRhcEdlc3R1cmVSZWNvZ25pemVyOjpyZWNvZ25pemUo Y29uc3QgUVRvdWNoRXZlbnQqIGV2ZW50LCBxaW50NjQgZXZlbnRUaW1lc3RhbXBNaWxsaXMpCiB7 CiAgICAgaWYgKGV2ZW50LT50b3VjaFBvaW50cygpLnNpemUoKSAhPSAxKSB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5oIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0VGFwR2VzdHVyZVJlY29nbml6ZXIuaAppbmRl eCA0N2RhNzVlLi5iNmFiZWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRUYXBHZXN0dXJlUmVjb2duaXplci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9xdC9RdFRhcEdlc3R1cmVSZWNvZ25pemVyLmgKQEAgLTUwLDYgKzUwLDcgQEAgbmFtZXNwYWNl IFdlYktpdCB7CiBjbGFzcyBRdFRhcEdlc3R1cmVSZWNvZ25pemVyIDogcHVibGljIFFPYmplY3Qs IHByaXZhdGUgUXRHZXN0dXJlUmVjb2duaXplciB7CiBwdWJsaWM6CiAgICAgUXRUYXBHZXN0dXJl UmVjb2duaXplcihRdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUqLCBRdFdlYlBhZ2VQcm94eSop OworICAgIHZvaWQgc2V0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZShRdFZpZXdwb3J0SW50ZXJh Y3Rpb25FbmdpbmUqKTsKICAgICBib29sIHJlY29nbml6ZShjb25zdCBRVG91Y2hFdmVudCosIHFp bnQ2NCBldmVudFRpbWVzdGFtcE1pbGxpcyk7CiAgICAgdm9pZCByZXNldCgpOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcAppbmRleCA0ODhmNGNl Li5lMTdmMTNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQ cm94eS5jcHAKQEAgLTcxMiw2ICs3MTIsMTQgQEAgdm9pZCBRdFdlYlBhZ2VQcm94eTo6c2V0TmF2 aWdhdG9yUXRPYmplY3RFbmFibGVkKGJvb2wgZW5hYmxlZCkKICAgICBtX2NvbnRleHQtPnBvc3RN ZXNzYWdlVG9JbmplY3RlZEJ1bmRsZShtZXNzYWdlTmFtZSwgYm9keS5nZXQoKSk7CiB9CiAKK3Zv aWQgUXRXZWJQYWdlUHJveHk6OnNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoUXRWaWV3cG9y dEludGVyYWN0aW9uRW5naW5lKiBlbmdpbmUpCit7CisgICAgbV9pbnRlcmFjdGlvbkVuZ2luZSA9 IGVuZ2luZTsKKyAgICBtX3Bhbkdlc3R1cmVSZWNvZ25pemVyLnNldFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmUoZW5naW5lKTsKKyAgICBtX3BpbmNoR2VzdHVyZVJlY29nbml6ZXIuc2V0Vmlld3Bv cnRJbnRlcmFjdGlvbkVuZ2luZShlbmdpbmUpOworICAgIG1fdGFwR2VzdHVyZVJlY29nbml6ZXIu c2V0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZShlbmdpbmUpOworfQorCiB2b2lkIFF0V2ViUGFn ZVByb3h5Ojpwb3N0TWVzc2FnZVRvTmF2aWdhdG9yUXRPYmplY3QoY29uc3QgUVN0cmluZyYgbWVz c2FnZSkKIHsKICAgICBzdGF0aWMgU3RyaW5nIG1lc3NhZ2VOYW1lKCJNZXNzYWdlVG9OYXZpZ2F0 b3JRdE9iamVjdCIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0 V2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJv eHkuaAppbmRleCA0Yzc3NTBlLi5lNWY0MjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvcXQvUXRXZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvUXRXZWJQYWdlUHJveHkuaApAQCAtMTc3LDcgKzE3Nyw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIHNldE5hdmlnYXRvclF0T2JqZWN0RW5hYmxlZChib29sKTsKICAgICBib29sIG5hdmlnYXRv clF0T2JqZWN0RW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuIG1fbmF2aWdhdG9yUXRPYmplY3RFbmFi bGVkOyB9CiAKLSAgICB2b2lkIHNldFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUoUXRWaWV3cG9y dEludGVyYWN0aW9uRW5naW5lKiBlbmdpbmUpIHsgbV9pbnRlcmFjdGlvbkVuZ2luZSA9IGVuZ2lu ZTsgbV9wYW5HZXN0dXJlUmVjb2duaXplci5zZXRWaWV3cG9ydEludGVyYWN0aW9uRW5naW5lKGVu Z2luZSk7IG1fcGluY2hHZXN0dXJlUmVjb2duaXplci5zZXRWaWV3cG9ydEludGVyYWN0aW9uRW5n aW5lKGVuZ2luZSk7fQorICAgIHZvaWQgc2V0Vmlld3BvcnRJbnRlcmFjdGlvbkVuZ2luZShRdFZp ZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUqKTsKIAogICAgIHZvaWQgcG9zdE1lc3NhZ2VUb05hdmln YXRvclF0T2JqZWN0KGNvbnN0IFFTdHJpbmcmKTsKIAo=