72710 2011-11-18 03:26:16 -0800 [CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files 2011-11-18 09:49:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga bfulgham webkit.review.bot oldest_to_newest 505652 0 paroga 2011-11-18 03:26:16 -0800 [CMake] Add possibility to overwrite WEBKIT_PORT_DIR in platform specific files 505653 1 115778 paroga 2011-11-18 03:27:12 -0800 Created attachment 115778 Patch 505845 2 115778 bfulgham 2011-11-18 09:09:19 -0800 Comment on attachment 115778 Patch I'm not sure I understand the change. Is the goal to move the declaration of the WEBKIT_PORT_DIR to a higher level so that more cmake files may make use of it? Because prior to this change, it looks like only the WebKit directory has access to this declaration: the others (WebKit2, JavaScriptCore, etc.) would have to add the declaration locally if they wanted to use it. But I'm not sure how this changes adds the possibility to overwrite the term for platform-specific files. 505846 3 paroga 2011-11-18 09:10:41 -0800 (In reply to comment #2) > (From update of attachment 115778 [details]) > I'm not sure I understand the change. Is the goal to move the declaration of the WEBKIT_PORT_DIR to a higher level so that more cmake files may make use of it? Because prior to this change, it looks like only the WebKit directory has access to this declaration: the others (WebKit2, JavaScriptCore, etc.) would have to add the declaration locally if they wanted to use it. > > But I'm not sure how this changes adds the possibility to overwrite the term for platform-specific files. Its moved before the include(Options$PORT}). In OptionsWinApple.cmake is then a SET(WEBKIT_PORT_DIR win), wich will overwrite the default of WinApple 505847 4 115778 bfulgham 2011-11-18 09:12:03 -0800 Comment on attachment 115778 Patch Looks great. 505869 5 115778 webkit.review.bot 2011-11-18 09:49:28 -0800 Comment on attachment 115778 Patch Clearing flags on attachment: 115778 Committed r100785: <http://trac.webkit.org/changeset/100785> 505870 6 webkit.review.bot 2011-11-18 09:49:32 -0800 All reviewed patches have been landed. Closing bug. 115778 2011-11-18 03:27:12 -0800 2011-11-18 09:49:28 -0800 Patch bug-72710-20111118122709.patch text/plain 2317 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVmMjY1YWVmZTU1YzE5NTZk ZWRiZDg2NzZiOGM2YzllOTRmNzk3NjUuLmY2ZTIyMjVjOTljNDNmNWRhZDk4NzZiYzVlZDQ5ODc2 MGVkYjg3ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMTggIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NNYWtlXSBBZGQgcG9z c2liaWxpdHkgdG8gb3ZlcndyaXRlIFdFQktJVF9QT1JUX0RJUiBpbiBwbGF0Zm9ybSBzcGVjaWZp YyBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzI3MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IENNYWtlTGlzdHMudHh0OgorCiAyMDExLTExLTE3ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhh dXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIExheWVyIHZpb2xhdGlvbjogcXRfcnVu dGltZS5jcHAgYWNjZXNzZXMgUVdlYkVsZW1lbnQgYW5kIFFURFJUTm9kZQpkaWZmIC0tZ2l0IGEv U291cmNlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0NNYWtlTGlzdHMudHh0CmluZGV4IDUxYTY2 YzM2NTdhZDM5MjNiMmRlZGEyYjQ5OWQxNzcwOGNiYzU5NmIuLmFkMWU5NmZmOWZjYjYzNzA0YWVj Mjg2Yzg2ZTQ4NDk1ZjdjOTc3MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9DTWFrZUxpc3RzLnR4dAor KysgYi9Tb3VyY2UvQ01ha2VMaXN0cy50eHQKQEAgLTQ1LDYgKzQ1LDggQEAgSUYgKCR7UkVUfSBF UVVBTCAtMSkKICAgICBNRVNTQUdFKEZBVEFMX0VSUk9SICJQbGVhc2UgY2hvb3NlIHdoaWNoIFdl YktpdCBwb3J0IHRvIGJ1aWxkIChvbmUgb2YgJHtBTExfUE9SVFN9KSIpCiBFTkRJRiAoKQogCitT VFJJTkcoVE9MT1dFUiAke1BPUlR9IFdFQktJVF9QT1JUX0RJUikKKwogIyAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQogIyBGaW5kIGNvbW1vbiBwYWNrYWdlcyAodXNlZCBieSBhbGwgcG9ydHMpCiAjIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMu dHh0IGIvU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dAppbmRleCBkZmNiZWQwNjhjMDI2ODU4 MTlmOTc4ZThlNDg5NDQ3ZDA5OGU4NjNlLi5iYmY0Mjc5NTA3NWViMzNiNDRiYTU0MGUwYWFjOGFi NzhlNzYzYTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9XZWJLaXQvQ01ha2VMaXN0cy50eHQKQEAgLTY0LDcgKzY0LDYgQEAgU0VUKFdlYktp dF9MSUJSQVJJRVMKICAgICAke1dlYkNvcmVfTElCUkFSWV9OQU1FfQogKQogCi1TVFJJTkcoVE9M T1dFUiAke1BPUlR9IFdFQktJVF9QT1JUX0RJUikKIElOQ0xVREVfSUZfRVhJU1RTKCR7V0VCS0lU X0RJUn0vJHtXRUJLSVRfUE9SVF9ESVJ9L0NNYWtlTGlzdHMke1BPUlR9LnR4dCkKIAogQUREX0RF RklOSVRJT05TKC1EQlVJTERJTkdfV2ViS2l0KQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDNlMGVhMzM0ZDViYWE5ODQxNjViNDIyNTE1ZWNkODcwZWMzNWY2MjguLmM4 YWM1ZDBmZmFiM2FhZTJjNDk1YTY4YmVkNjRkMWJjMjk0ZjFiMGMgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0xMS0xOCAgUGF0cmlj ayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbQ01ha2VdIEFkZCBw b3NzaWJpbGl0eSB0byBvdmVyd3JpdGUgV0VCS0lUX1BPUlRfRElSIGluIHBsYXRmb3JtIHNwZWNp ZmljIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MjcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU291cmNlL0NNYWtlTGlzdHMudHh0OgorCiAyMDExLTExLTE3ICBSYXBoYWVsIEt1Ym8gZGEg Q29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIENsZWFuIHVwIHRo ZSB1c2Ugb2YgREFUQV9ESVIgaW4gdGhlIGJ1aWxkc3lzdGVtCg==