72708 2011-11-18 02:54:21 -0800 [GTK] Accessibility API tests failing because of using non-WebKit GtkWidgets 2011-11-18 08:47:32 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned pnormand oldest_to_newest 505638 0 mario 2011-11-18 02:54:21 -0800 The ATK unit tests testWebkitAtkParentForRootObject() and testWebkitAtkSetParentForObject() has been failing in the bots lately and it seems it's because they are the only one using GtkWidget's not provided by WebKit (GtkWindow and GtkBox), so when the test asks for the AtkObject's associated to them (through gtk_widget_get_accessible()) the returned object is not the expected one, but a dummy AtkNoOpObject, since the accessibility implementation of Gtk is not being loaded along with the tests. And this results on errors like this: TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatk... (pid=25379) ** ERROR:../../Source/WebKit/gtk/tests/testatk.c:1629:testWebkitAtkParentForRootObject: assertion failed: (axBoxChild) One possible solution is to only use GtkWidget's provided by WebKitGTK+ instead of GtkWindow and GtkBox, to use them as parent containers. And this is a very good option since WebKitWebView widget inherits from GtkContainer, so that makes it suitable for that task. Will attach a patch soon. 505639 1 115774 mario 2011-11-18 02:58:04 -0800 Created attachment 115774 Patch proposal 505656 2 115774 xan.lopez 2011-11-18 03:38:44 -0800 Comment on attachment 115774 Patch proposal So, this is a pretty big hack. I think it's much more interesting to try to figure out why the a11y stuff is not being loaded, since that will likely cause us more problems in the future. That being said, since Mario says he cannot figure out atm and in the interest of keeping the bots green I'll r+ this patch in case he wants to land it to investigate things properly. 505660 3 mario 2011-11-18 03:41:38 -0800 (In reply to comment #2) > (From update of attachment 115774 [details]) > So, this is a pretty big hack. A webView inside another webView? Oh, yeah it is sure a hack... but the best thing I could find at the moment, since my investigations in the bots about why loading the module would not work have no shed any light yet... > I think it's much more interesting to try to figure out why the a11y stuff is not being loaded, since that will > likely cause us more problems in the future. Agreed. > That being said, since Mario says he cannot figure out atm and in the interest of keeping the bots green I'll r+ > this patch in case he wants to land it to investigate things properly. Thanks, I will push this now then and will try to figure out what's the true reason and a better solution asap. 505663 4 mario 2011-11-18 03:46:32 -0800 Committed r100747: <http://trac.webkit.org/changeset/100747> 505825 5 mario 2011-11-18 08:47:32 -0800 (In reply to comment #3) > (In reply to comment #2) > [...] > > I think it's much more interesting to try to figure out why the a11y stuff is not being loaded, since that will > > likely cause us more problems in the future. > > Agreed. I found the root issue here. See bug 72732 for the details :-) > > That being said, since Mario says he cannot figure out atm and in the interest of keeping the bots green I'll r+ > > this patch in case he wants to land it to investigate things properly. > > Thanks, I will push this now then and will try to figure out what's the true reason and a better solution asap. I have already attached a patch for bug 72732 that should get testatk.c file back to sanity Thanks for your understanding! 115774 2011-11-18 02:58:04 -0800 2011-11-18 03:38:44 -0800 Patch proposal 0001-2011-11-18-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 6692 mario RnJvbSAxODc5NDk5MDE2MDY5ZGMwZDExZjA5MzVkZmI5ZTExNDAwYWM3NmRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBGcmksIDE4IE5vdiAyMDExIDExOjU2OjE3ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0xMS0xOCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIEFjY2Vzc2liaWxpdHkgQVBJIHRlc3RzIGZhaWxpbmcgYmVjYXVzZSBv ZiB1c2luZyBub24tV2ViS2l0IEd0a1dpZGdldHMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI3MDgKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgogICAgICAgIERvIG5vdCB1c2Ugbm9uLVdlYktpdCBHdGtXaWRnZXQncyBpbiB1bml0 IHRlc3RzLCB0byBhdm9pZCBwcm9ibGVtcwogICAgICAgIHdoZW4gR1RLJ3MgYWNjZXNzaWJpbGl0 eSBpbXBsZW1lbnRhdGlvbiBpcyBub3QgYmVpbmcgbG9hZGVkLgoKICAgICAgICAqIHRlc3RzL3Rl c3RhdGsuYzoKICAgICAgICAodGVzdFdlYmtpdEF0a1BhcmVudEZvclJvb3RPYmplY3QpOiBVc2Ug YSBkdW1teSBXZWJLaXRXZWJWaWV3CiAgICAgICAgd2lkZ2V0IGFzIHRoZSBwYXJlbnQgY29udGFp bmVyIG5lZWRlZCBmb3IgdGhpcyB1bml0IHRlc3QuCiAgICAgICAgKHRlc3RXZWJraXRBdGtTZXRQ YXJlbnRGb3JPYmplY3QpOiBEaXR0by4KLS0tCiBTb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cg ICAgICAgfCAgIDE1ICsrKysrKysKIFNvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGsuYyB8 ICAgNzQgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5n ZWQsIDQ4IGluc2VydGlvbnMoKyksIDQxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRl eCAzZGJlZGRlLi4wMDFiMDEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIw MTEtMTEtMTggIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIEFjY2Vzc2liaWxpdHkgQVBJIHRlc3RzIGZhaWxpbmcgYmVjYXVzZSBvZiB1 c2luZyBub24tV2ViS2l0IEd0a1dpZGdldHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcyNzA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRG8gbm90IHVzZSBub24tV2ViS2l0IEd0a1dpZGdldCdzIGluIHVu aXQgdGVzdHMsIHRvIGF2b2lkIHByb2JsZW1zCisgICAgICAgIHdoZW4gR1RLJ3MgYWNjZXNzaWJp bGl0eSBpbXBsZW1lbnRhdGlvbiBpcyBub3QgYmVpbmcgbG9hZGVkLgorCisgICAgICAgICogdGVz dHMvdGVzdGF0ay5jOgorICAgICAgICAodGVzdFdlYmtpdEF0a1BhcmVudEZvclJvb3RPYmplY3Qp OiBVc2UgYSBkdW1teSBXZWJLaXRXZWJWaWV3CisgICAgICAgIHdpZGdldCBhcyB0aGUgcGFyZW50 IGNvbnRhaW5lciBuZWVkZWQgZm9yIHRoaXMgdW5pdCB0ZXN0LgorICAgICAgICAodGVzdFdlYmtp dEF0a1NldFBhcmVudEZvck9iamVjdCk6IERpdHRvLgorCiAyMDExLTExLTE3ICBNYXJpbyBTYW5j aGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR3RrXSBFbnN1cmUg dGhlIHBhcmVudCBmb3IgdGhlIHdlYlZpZXcncyBhMTF5IG9iamVjdCBpcyBzZXQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrLmMgYi9Tb3VyY2UvV2ViS2l0L2d0 ay90ZXN0cy90ZXN0YXRrLmMKaW5kZXggNTA1YTQyMS4uYmZmMzFjNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rl c3RzL3Rlc3RhdGsuYwpAQCAtMTYxMiwzMyArMTYxMiwyMyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2Vi a2l0QXRrUGFyZW50Rm9yUm9vdE9iamVjdCgpCiAgICAgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRl KEdUS19XSURHRVQod2ViVmlldyksICZhbGxvY2F0aW9uKTsKICAgICB3ZWJraXRfd2ViX3ZpZXdf bG9hZF9zdHJpbmcod2ViVmlldywgY29udGVudHMsIDAsIDAsIDApOwogCi0gICAgLyogV2UgbmVl ZCBhIHBhcmVudCBmb3IgdGhlIHdlYnZpZXcgdG8gY2hlY2sgdG9wLWRvd24gYW5kCi0gICAgICAg Ym90dG9tLXVwIG5hdmlnYXRpb24gYW1vbmcgdGhlbSwgc28gY3JlYXRlIGEgYm94IGZvciBpdC4g Ki8KLSNpZmRlZiBHVEtfQVBJX1ZFUlNJT05fMgotICAgIEd0a1dpZGdldCogYm94ID0gZ3RrX3Zi b3hfbmV3KEZBTFNFLCAwKTsKLSNlbHNlCi0gICAgR3RrV2lkZ2V0KiBib3ggPSBndGtfYm94X25l dyhHVEtfT1JJRU5UQVRJT05fVkVSVElDQUwsIDApOwotI2VuZGlmCi0gICAgZ19vYmplY3RfcmVm X3NpbmsoYm94KTsKLSAgICBndGtfYm94X3BhY2tfc3RhcnQoR1RLX0JPWChib3gpLCBHVEtfV0lE R0VUKHdlYlZpZXcpLCBGQUxTRSwgRkFMU0UsIDApOworICAgIC8qIFdlIG5lZWQgYSBwYXJlbnQg Y29udGFpbmVyIHdpZGdldCBmb3IgdGhlIHdlYnZpZXcgc28gdXNlCisgICAgICAgYW5vdGhlciAo ZHVtbXkpIHdlYlZpZXcgYXMgdGhhdCBjb250YWluZXIuICovCisgICAgR3RrV2lkZ2V0KiBwYXJl bnRDb250YWluZXIgPSB3ZWJraXRfd2ViX3ZpZXdfbmV3KCk7CisgICAgZ19vYmplY3RfcmVmX3Np bmsocGFyZW50Q29udGFpbmVyKTsKKyAgICBndGtfY29udGFpbmVyX2FkZChHVEtfQ09OVEFJTkVS KHBhcmVudENvbnRhaW5lciksIEdUS19XSURHRVQod2ViVmlldykpOwogCi0gICAgQXRrT2JqZWN0 KiBheEJveCA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2libGUgKGJveCk7Ci0gICAgZ19hc3NlcnQo QVRLX0lTX09CSkVDVChheEJveCkpOwotCi0gICAgQXRrT2JqZWN0KiBheEJveENoaWxkID0gYXRr X29iamVjdF9yZWZfYWNjZXNzaWJsZV9jaGlsZChheEJveCwgMCk7Ci0gICAgZ19hc3NlcnQoYXhC b3hDaGlsZCk7CisgICAgQXRrT2JqZWN0KiBheFBhcmVudCA9IGd0a193aWRnZXRfZ2V0X2FjY2Vz c2libGUgKHBhcmVudENvbnRhaW5lcik7CisgICAgZ19hc3NlcnQoQVRLX0lTX09CSkVDVChheFBh cmVudCkpOwogCiAgICAgQXRrT2JqZWN0KiBheFJvb3QgPSBndGtfd2lkZ2V0X2dldF9hY2Nlc3Np YmxlKEdUS19XSURHRVQod2ViVmlldykpOwogICAgIGdfYXNzZXJ0KEFUS19JU19PQkpFQ1QoYXhS b290KSk7CiAKLSAgICAvKiBUaGUgYm94J3MgY2hpbGQgc2hvdWxkIGJlIHRoZSBBdGtPYmplY3Qg Zm9yIHRoZSBXZWJWaWV3J3Mgcm9vdC4gKi8KLSAgICBnX2Fzc2VydChheEJveENoaWxkID09IGF4 Um9vdCk7Ci0KLSAgICAvKiBCb3R0b20tdXAgbmF2aWdhdGlvbiBzaG91bGQgbWF0Y2ggdG9wLWRv d24gb25lLiAqLwotICAgIGdfYXNzZXJ0KGF0a19vYmplY3RfZ2V0X3BhcmVudChheEJveENoaWxk KSA9PSBheEJveCk7CisgICAgLyogQ2hlY2sgdGhhdCB0aGUgcGFyZW50IGZvciB0aGUgd2ViVmll dydzIGFjY2Vzc2liaWxpdHkgb2JqZWN0IGlzCisgICAgICAgdGhlIHRoZSBhY2Nlc3NpYmlsaXR5 IG9iamVjdCBmb3IgdGhlIHdlYnZpZXcncyBwYXJlbnQgd2lkZ2V0LiAqLworICAgIGdfYXNzZXJ0 KGF0a19vYmplY3RfZ2V0X3BhcmVudChheFJvb3QpID09IGF4UGFyZW50KTsKIAotICAgIGdfb2Jq ZWN0X3VucmVmKGF4Qm94Q2hpbGQpOwotICAgIGdfb2JqZWN0X3VucmVmKGJveCk7CisgICAgZ19v YmplY3RfdW5yZWYocGFyZW50Q29udGFpbmVyKTsKIH0KIAogc3RhdGljIHZvaWQgdGVzdFdlYmtp dEF0a1NldFBhcmVudEZvck9iamVjdCgpCkBAIC0xNjQ4LDM1ICsxNjM4LDM3IEBAIHN0YXRpYyB2 b2lkIHRlc3RXZWJraXRBdGtTZXRQYXJlbnRGb3JPYmplY3QoKQogICAgIGd0a193aWRnZXRfc2l6 ZV9hbGxvY2F0ZShHVEtfV0lER0VUKHdlYlZpZXcpLCAmYWxsb2NhdGlvbik7CiAgICAgd2Via2l0 X3dlYl92aWV3X2xvYWRfc3RyaW5nKHdlYlZpZXcsIGNvbnRlbnRzLCAwLCAwLCAwKTsKIAotICAg IC8qIFB1dCB0aGUgd2VidmlldyBpbiBhIHdpbmRvdyB0byBjaGVjayB0aGUgbm9ybWFsIGJlaGF2 aW91ciBrZWVwcwotICAgICAgIHdvcmtpbmcgYXMgZXhwZWN0ZWQgd2hlbiB0aGUgd2VidmlldyBp cyBpbnNpZGUgYSBjb250YWluZXIuICovCi0gICAgR3RrV2lkZ2V0KiB3aW5kb3cgPSBndGtfd2lu ZG93X25ldyhHVEtfV0lORE9XX1RPUExFVkVMKTsKLSAgICBnX29iamVjdF9yZWZfc2luayh3aW5k b3cpOwotICAgIGd0a19jb250YWluZXJfYWRkKEdUS19DT05UQUlORVIod2luZG93KSwgd2ViVmll dyk7CisgICAgLyogUHV0IHRoZSB3ZWJ2aWV3IGluIGEgcGFyZW50IGNvbnRhaW5lciB3aWRnZXQg Y2hlY2sgdGhlIG5vcm1hbAorICAgICAgIGJlaGF2aW91ciBrZWVwcyB3b3JraW5nIGFzIGV4cGVj dGVkIHdoZW4gdGhlIHdlYnZpZXcgaXMgaW5zaWRlCisgICAgICAgYSBjb250YWluZXIuIFdlIHVz ZSBhIGR1bW15IHdlYlZpZXcgZm9yIHRoYXQgaW4gb3JkZXIgbm90IHRvCisgICAgICAgbmVlZCBh bnkgQVRLIGltcGxlbWVudGF0aW9uIG90aGVyIHRoYW4gV2ViS2l0J3Mgb25lLiAqLworICAgIEd0 a1dpZGdldCogcGFyZW50Q29udGFpbmVyID0gd2Via2l0X3dlYl92aWV3X25ldygpOworICAgIGdf b2JqZWN0X3JlZl9zaW5rKHBhcmVudENvbnRhaW5lcik7CisgICAgZ3RrX2NvbnRhaW5lcl9hZGQo R1RLX0NPTlRBSU5FUihwYXJlbnRDb250YWluZXIpLCBHVEtfV0lER0VUKHdlYlZpZXcpKTsKIAog ICAgIEF0a09iamVjdCogYXhSb290ID0gZ3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZShHVEtfV0lE R0VUKHdlYlZpZXcpKTsKICAgICBnX2Fzc2VydChBVEtfSVNfT0JKRUNUKGF4Um9vdCkpOwogCi0g ICAgQXRrT2JqZWN0KiBheFdpbmRvdyA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2libGUod2luZG93 KTsKLSAgICBnX2Fzc2VydChBVEtfSVNfT0JKRUNUKGF4V2luZG93KSk7CisgICAgQXRrT2JqZWN0 KiBheFBhcmVudCA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2libGUocGFyZW50Q29udGFpbmVyKTsK KyAgICBnX2Fzc2VydChBVEtfSVNfT0JKRUNUKGF4UGFyZW50KSk7CiAKLSAgICAvKiBUaGUgcGFy ZW50IG9mIHRoZSByb290IG9iamVjdCBpcyB0aGUgd2luZG93J3MgYTExeSBvYmplY3QuICovCi0g ICAgZ19hc3NlcnQoYXRrX29iamVjdF9nZXRfcGFyZW50KGF4Um9vdCkgPT0gYXhXaW5kb3cpOwor ICAgIC8qIFRoZSBwYXJlbnQgb2YgdGhlIHJvb3Qgb2JqZWN0IGlzIHRoZSBwYXJlbnQgY29udGFp bmVyJ3MgYTExeSBvYmplY3QuICovCisgICAgZ19hc3NlcnQoYXRrX29iamVjdF9nZXRfcGFyZW50 KGF4Um9vdCkgPT0gYXhQYXJlbnQpOwogCi0gICAgLyogV2Ugbm93IG5lZWQgdG8gdXNlIHNvbWV0 aGluZyBhcyBhIGFuIGFsdGVybmF0aXZlIHBhcmVudCBmb3IKLSAgICAgICB0aGUgYTExeSBvYmpl Y3QgYXNzb2NpYXRlZCB3aXRoIHRoZSByb290IG9mIHRoZSBET00gdHJlZS4gKi8KLSAgICBHdGtX aWRnZXQqIGJ1dHRvbiA9IGd0a19idXR0b25fbmV3KCk7Ci0gICAgZ19vYmplY3RfcmVmX3Npbmso YnV0dG9uKTsKKyAgICAvKiBXZSBub3cgbmVlZCB0byB1c2UgYW5vdGhlciBBdGtPYmplY3QgYXMg YSBhbiBhbHRlcm5hdGl2ZSBwYXJlbnQKKyAgICAgICBmb3IgdGhlIGExMXkgb2JqZWN0IGFzc29j aWF0ZWQgd2l0aCB0aGUgcm9vdCBvZiB0aGUgRE9NIHRyZWUuICovCisgICAgR3RrV2lkZ2V0KiBh bHRlcm5hdGl2ZVBhcmVudCA9IHdlYmtpdF93ZWJfdmlld19uZXcoKTsKKyAgICBnX29iamVjdF9y ZWZfc2luayhhbHRlcm5hdGl2ZVBhcmVudCk7CiAKLSAgICBBdGtPYmplY3QqIGF4QnV0dG9uID0g Z3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZSAoYnV0dG9uKTsKLSAgICBnX2Fzc2VydChBVEtfSVNf T0JKRUNUKGF4QnV0dG9uKSk7CisgICAgQXRrT2JqZWN0KiBheEFsdGVybmF0aXZlUGFyZW50ID0g Z3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZSAoYWx0ZXJuYXRpdmVQYXJlbnQpOworICAgIGdfYXNz ZXJ0KEFUS19JU19PQkpFQ1QoYXhBbHRlcm5hdGl2ZVBhcmVudCkpOwogCiAgICAgLyogTWFudWFs bHkgc2V0IHRoZSBidXR0b24ncyBhMTF5IG9iamVjdCBhcyB0aGUgcGFyZW50IGFuZCBjaGVjay4g Ki8KLSAgICBhdGtfb2JqZWN0X3NldF9wYXJlbnQoYXhSb290LCBheEJ1dHRvbik7Ci0gICAgZ19h c3NlcnQoYXRrX29iamVjdF9nZXRfcGFyZW50KGF4Um9vdCkgPT0gYXhCdXR0b24pOworICAgIGF0 a19vYmplY3Rfc2V0X3BhcmVudChheFJvb3QsIGF4QWx0ZXJuYXRpdmVQYXJlbnQpOworICAgIGdf YXNzZXJ0KGF0a19vYmplY3RfZ2V0X3BhcmVudChheFJvb3QpID09IGF4QWx0ZXJuYXRpdmVQYXJl bnQpOwogCi0gICAgZ19vYmplY3RfdW5yZWYoYnV0dG9uKTsKLSAgICBnX29iamVjdF91bnJlZih3 aW5kb3cpOworICAgIGdfb2JqZWN0X3VucmVmKGFsdGVybmF0aXZlUGFyZW50KTsKKyAgICBnX29i amVjdF91bnJlZihwYXJlbnRDb250YWluZXIpOwogfQogCiBpbnQgbWFpbihpbnQgYXJnYywgY2hh cioqIGFyZ3YpCi0tIAoxLjcuNy4xCgo=