72678 2011-11-17 16:34:18 -0800 Remove support for running check-webkit-style w/o a webkit checkout 2011-11-17 16:39:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric eric abarth levin ojan webkit.review.bot oldest_to_newest 505345 0 eric 2011-11-17 16:34:18 -0800 Remove support for running check-webkit-style w/o a webkit checkout 505346 1 115707 eric 2011-11-17 16:35:32 -0800 Created attachment 115707 Patch 505348 2 eric 2011-11-17 16:39:49 -0800 Committed r100699: <http://trac.webkit.org/changeset/100699> 115707 2011-11-17 16:35:32 -0800 2011-11-17 16:38:56 -0800 Patch bug-72678-20111117163530.patch text/plain 6143 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNjk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWQ4ZTUzMWEwNzQ0NDYzYWZhNmRjOWQwNzI1M2E5MTMy Y2RkMjRhMy4uZGQyMzQ3MjdjYTZmOWMxYTliNjMwMjBkNzBiYmU2NTFiYzFkYzRlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDExLTExLTE3ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAorICAgICAg ICBSZW1vdmUgc3VwcG9ydCBmb3IgcnVubmluZyBjaGVjay13ZWJraXQtc3R5bGUgdy9vIGEgd2Vi a2l0IGNoZWNrb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MjY3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFmdGVyIHRhbGtpbmcgdG8gRGF2ZSBMZXZpbiB3ZSd2ZSBkZWNpZGVkIHRvIHJlbW92ZSB0 aGlzCisgICAgICAgIGNvZGUuICBJIGtub3cgb2Ygbm8gdXNlcnMgb2YgY2hlY2std2Via2l0LXN0 eWxlIHcvbyBhIHdlYmtpdCBjaGVja291dAorICAgICAgICBhbmQgdGhpcyBuZWVkbGVzc2x5IGFk ZHMgY29tcGxleGl0eS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvbWFpbi5w eToKKworMjAxMS0xMS0xNyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKICAgICAg ICAgUmVtb3ZlIG1vcmUgZGlyZWN0IHVzZXMgb2Ygb3MucGF0aAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI2NzcKIApkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9tYWluLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9z dHlsZS9tYWluLnB5CmluZGV4IDFlYjc4NWU1ZTc5MDNkZmI4NjdiNGY5NmQ3Yjk5Mjk5MDRmZmU3 ODIuLmQ1ZTZhMzQ3OTMyMDAyNDJmZjM2OTU1OTY0N2UyZjZlZGRmOWRiYzkgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvbWFpbi5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL21haW4ucHkKQEAgLTQ2LDU0ICs0NiwyMyBAQCBkZWYgY2hhbmdlX2Rp cmVjdG9yeShmaWxlc3lzdGVtLCBjaGVja291dF9yb290LCBwYXRocyk6CiAgICAgY2hlY2tvdXQg cm9vdCwgYW5kIGZvciBwYXRoLXNwZWNpZmljIHN0eWxlIGNoZWNrcyB0byB3b3JrIGFzIGV4cGVj dGVkLgogICAgIFBhdGgtc3BlY2lmaWMgY2hlY2tzIGluY2x1ZGUgd2hldGhlciBmaWxlcyBzaG91 bGQgYmUgc2tpcHBlZCwgd2hldGhlcgogICAgIGN1c3RvbSBzdHlsZSBydWxlcyBzaG91bGQgYXBw bHkgdG8gY2VydGFpbiBmaWxlcywgZXRjLgotICAgICAgICBJZiB0aGUgY2hlY2tvdXQgcm9vdCBp cyBOb25lIG9yIHRoZSBlbXB0eSBzdHJpbmcsIHRoaXMgbWV0aG9kIHJldHVybnMKLSAgICB0aGUg cGF0aHMgcGFyYW1ldGVyIHVuY2hhbmdlZC4KIAogICAgIFJldHVybnM6CiAgICAgICBwYXRoczog QSBjb3B5IG9mIHRoZSBwYXRocyBwYXJhbWV0ZXIgLS0gcG9zc2libHkgY29udmVydGVkLCBhcyBm b2xsb3dzLgogICAgICAgICAgICAgIElmIHRoaXMgbWV0aG9kIGNoYW5nZWQgdGhlIGN1cnJlbnQg d29ya2luZyBkaXJlY3RvcnkgdG8gdGhlCiAgICAgICAgICAgICAgY2hlY2tvdXQgcm9vdCwgdGhl biB0aGUgbGlzdCBpcyB0aGUgcGF0aHMgcGFyYW1ldGVyIGNvbnZlcnRlZCB0bwotICAgICAgICAg ICAgIG5vcm1hbGl6ZWQgcGF0aHMgcmVsYXRpdmUgdG8gdGhlIGNoZWNrb3V0IHJvb3QuICBPdGhl cndpc2UsIHRoZQotICAgICAgICAgICAgIHBhdGhzIGFyZSBub3QgY29udmVydGVkLgorICAgICAg ICAgICAgIG5vcm1hbGl6ZWQgcGF0aHMgcmVsYXRpdmUgdG8gdGhlIGNoZWNrb3V0IHJvb3QuCiAK ICAgICBBcmdzOgogICAgICAgcGF0aHM6IEEgbGlzdCBvZiBwYXRocyB0byB0aGUgZmlsZXMgdGhh dCBzaG91bGQgYmUgY2hlY2tlZCBmb3Igc3R5bGUuCiAgICAgICAgICAgICAgVGhpcyBhcmd1bWVu dCBjYW4gYmUgTm9uZSBvciB0aGUgZW1wdHkgbGlzdCBpZiBhIGdpdCBjb21taXQKICAgICAgICAg ICAgICBvciBhbGwgY2hhbmdlcyB1bmRlciB0aGUgY2hlY2tvdXQgcm9vdCBzaG91bGQgYmUgY2hl Y2tlZC4KLSAgICAgIGNoZWNrb3V0X3Jvb3Q6IFRoZSBwYXRoIHRvIHRoZSByb290IG9mIHRoZSBX ZWJLaXQgY2hlY2tvdXQsIG9yIE5vbmUgb3IKLSAgICAgICAgICAgICAgICAgICAgIHRoZSBlbXB0 eSBzdHJpbmcgaWYgbm8gY2hlY2tvdXQgY291bGQgYmUgZGV0ZWN0ZWQuCisgICAgICBjaGVja291 dF9yb290OiBUaGUgcGF0aCB0byB0aGUgcm9vdCBvZiB0aGUgV2ViS2l0IGNoZWNrb3V0LgogCiAg ICAgIiIiCiAgICAgaWYgcGF0aHMgaXMgbm90IE5vbmU6CiAgICAgICAgIHBhdGhzID0gbGlzdChw YXRocykKIAotICAgIGlmIG5vdCBjaGVja291dF9yb290OgotICAgICAgICBpZiBub3QgcGF0aHM6 Ci0gICAgICAgICAgICByYWlzZSBFeGNlcHRpb24oIlRoZSBwYXRocyBwYXJhbWV0ZXIgbXVzdCBi ZSBub24tZW1wdHkgaWYgIgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICJ0aGVyZSBpcyBu byBjaGVja291dCByb290LiIpCi0KLSAgICAgICAgIyBGSVhNRTogQ29uc2lkZXIgdHJ5aW5nIHRv IGRldGVjdCB0aGUgY2hlY2tvdXQgcm9vdCBmb3IgZWFjaCBmaWxlCi0gICAgICAgICMgICAgICAg IGJlaW5nIGNoZWNrZWQgcmF0aGVyIHRoYW4gb25seSB0cnlpbmcgdG8gZGV0ZWN0IHRoZSBjaGVj a291dAotICAgICAgICAjICAgICAgICByb290IGZvciB0aGUgY3VycmVudCB3b3JraW5nIGRpcmVj dG9yeS4gIFRoaXMgd291bGQgYWxsb3cKLSAgICAgICAgIyAgICAgICAgZmlsZXMgdG8gYmUgY2hl Y2tlZCBjb3JyZWN0bHkgZXZlbiBpZiB0aGUgc2NyaXB0IGlzIGJlaW5nCi0gICAgICAgICMgICAg ICAgIHJ1biBmcm9tIG91dHNpZGUgYW55IFdlYktpdCBjaGVja291dC4KLSAgICAgICAgIwotICAg ICAgICAjICAgICAgICBNb3Jlb3ZlciwgdHJ5IHRvIGZpbmQgdGhlICJzb3VyY2Ugcm9vdCIgZm9y IGVhY2ggZmlsZQotICAgICAgICAjICAgICAgICB1c2luZyBwYXRoLWJhc2VkIGhldXJpc3RpY3Mg cmF0aGVyIHRoYW4gdXNpbmcgb25seSB0aGUKLSAgICAgICAgIyAgICAgICAgcHJlc2VuY2Ugb2Yg YSBXZWJLaXQgY2hlY2tvdXQuICBGb3IgZXhhbXBsZSwgd2UgY291bGQKLSAgICAgICAgIyAgICAg ICAgZXhhbWluZSBwYXJlbnQgZGlyZWN0b3JpZXMgdW50aWwgYSBkaXJlY3RvcnkgaXMgZm91bmQK LSAgICAgICAgIyAgICAgICAgY29udGFpbmluZyBKYXZhU2NyaXB0Q29yZSwgV2ViQ29yZSwgV2Vi S2l0LCBXZWJzaXRlcywKLSAgICAgICAgIyAgICAgICAgYW5kIFRvb2xzLgotICAgICAgICAjICAg ICAgICAgICAgIFRoZW4gbG9nIGFuIElORk8gbWVzc2FnZSBzYXlpbmcgdGhhdCBhIHNvdXJjZSBy b290IG5vdAotICAgICAgICAjICAgICAgICBpbiBhIFdlYktpdCBjaGVja291dCB3YXMgZm91bmQu ICBUaGlzIHdpbGwgYWxsb3cgdXMgdG8gY2hlY2sKLSAgICAgICAgIyAgICAgICAgdGhlIHN0eWxl IG9mIG5vbi1zY20gY29waWVzIG9mIHRoZSBzb3VyY2UgdHJlZSAoZS5nLgotICAgICAgICAjICAg ICAgICBuaWdodGxpZXMpLgotICAgICAgICBfbG9nLndhcm4oIldlYktpdCBjaGVja291dCByb290 IG5vdCBmb3VuZDpcbiIKLSAgICAgICAgICAgICAgICAgICIgIFBhdGgtZGVwZW5kZW50IHN0eWxl IGNoZWNrcyBtYXkgbm90IHdvcmsgY29ycmVjdGx5LlxuIgotICAgICAgICAgICAgICAgICAgIiAg U2VlIHRoZSBoZWxwIGRvY3VtZW50YXRpb24gZm9yIG1vcmUgaW5mby4iKQotCi0gICAgICAgIHJl dHVybiBwYXRocwotCiAgICAgaWYgcGF0aHM6CiAgICAgICAgICMgVGhlbiB0cnkgY29udmVydGlu ZyBhbGwgb2YgdGhlIHBhdGhzIHRvIHBhdGhzIHJlbGF0aXZlIHRvCiAgICAgICAgICMgdGhlIGNo ZWNrb3V0IHJvb3QuCkBAIC0xNTYsMTAgKzEyNSw3IEBAIGNsYXNzIENoZWNrV2ViS2l0U3R5bGUo b2JqZWN0KToKICAgICAgICAgYXJncyA9IHN5cy5hcmd2WzE6XQogCiAgICAgICAgIGhvc3QgPSBI b3N0KCkKLSAgICAgICAgIyBGSVhNRTogSW50ZW50aW9uYWxseSBub3QgY2FsbGluZyBob3N0Ll9p bml0aWFsaXplX3NjbSgpIGZvciBub3cuCi0gICAgICAgICMgX2luaXRpYWxpemVfc2NtKCkgd291 bGQgdGhyb3cgYW4gZXhjZXB0aW9uIGlmIGl0IGZhaWxlZCB0byBmaW5kIHRoZSBjaGVja291dF9y b290LgotICAgICAgICAjIGNoZWNrLXdlYmtpdC1zdHlsZSBzZWVtcyBkZXNpZ25lZCB0byBiZSBy dW4gZnJvbSBvdXRzaWRlIGEgd2Via2l0IGNoZWNrb3V0LgotICAgICAgICAjIFVuY2xlYXIgaWYg dGhhdCdzIHN0aWxsIGEgbmVlZGVkIGZlYXR1cmUuCisgICAgICAgIGhvc3QuX2luaXRpYWxpemVf c2NtKCkKIAogICAgICAgICBzdGRlcnIgPSBzZWxmLl9lbmdhZ2VfYXdlc29tZV9zdGRlcnJfaGFj a3MoKQogCkBAIC0xNzMsMjMgKzEzOSw5IEBAIGNsYXNzIENoZWNrV2ViS2l0U3R5bGUob2JqZWN0 KToKICAgICAgICAgcGFyc2VyID0gY2hlY2tlci5jaGVja193ZWJraXRfc3R5bGVfcGFyc2VyKCkK ICAgICAgICAgKHBhdGhzLCBvcHRpb25zKSA9IHBhcnNlci5wYXJzZShhcmdzKQogCi0gICAgICAg IHNjbSA9IGRldGVjdF9zY21fc3lzdGVtKGhvc3QuZmlsZXN5c3RlbS5nZXRjd2QoKSkKLSAgICAg ICAgaWYgc2NtIGlzIE5vbmU6Ci0gICAgICAgICAgICBpZiBub3QgcGF0aHM6Ci0gICAgICAgICAg ICAgICAgX2xvZy5lcnJvcigiV2ViS2l0IGNoZWNrb3V0IG5vdCBmb3VuZDogWW91IG11c3QgcnVu IHRoaXMgc2NyaXB0ICIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICJmcm9tIHdpdGhpbiBh IFdlYktpdCBjaGVja291dCBpZiB5b3UgYXJlIG5vdCBwYXNzaW5nICIKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICJzcGVjaWZpYyBwYXRocyB0byBjaGVjay4iKQotICAgICAgICAgICAgICAg IHJldHVybiAxCi0KLSAgICAgICAgICAgIGNoZWNrb3V0X3Jvb3QgPSBOb25lCi0gICAgICAgICAg ICBfbG9nLmRlYnVnKCJXZWJLaXQgY2hlY2tvdXQgbm90IGZvdW5kIGZvciBjdXJyZW50IGRpcmVj dG9yeS4iKQotICAgICAgICBlbHNlOgotICAgICAgICAgICAgY2hlY2tvdXRfcm9vdCA9IHNjbS5j aGVja291dF9yb290Ci0gICAgICAgICAgICBfbG9nLmRlYnVnKCJXZWJLaXQgY2hlY2tvdXQgZm91 bmQgd2l0aCByb290OiAlcyIgJSBjaGVja291dF9yb290KQotCiAgICAgICAgIGNvbmZpZ3VyYXRp b24gPSBjaGVja2VyLmNoZWNrX3dlYmtpdF9zdHlsZV9jb25maWd1cmF0aW9uKG9wdGlvbnMpCiAK LSAgICAgICAgcGF0aHMgPSBjaGFuZ2VfZGlyZWN0b3J5KGhvc3QuZmlsZXN5c3RlbSwgY2hlY2tv dXRfcm9vdD1jaGVja291dF9yb290LCBwYXRocz1wYXRocykKKyAgICAgICAgcGF0aHMgPSBjaGFu Z2VfZGlyZWN0b3J5KGhvc3QuZmlsZXN5c3RlbSwgY2hlY2tvdXRfcm9vdD1ob3N0LnNjbSgpLmNo ZWNrb3V0X3Jvb3QsIHBhdGhzPXBhdGhzKQogCiAgICAgICAgIHN0eWxlX3Byb2Nlc3NvciA9IFN0 eWxlUHJvY2Vzc29yKGNvbmZpZ3VyYXRpb24pCiAgICAgICAgIGZpbGVfcmVhZGVyID0gVGV4dEZp bGVSZWFkZXIoaG9zdC5maWxlc3lzdGVtLCBzdHlsZV9wcm9jZXNzb3IpCkBAIC0xOTgsNyArMTUw LDcgQEAgY2xhc3MgQ2hlY2tXZWJLaXRTdHlsZShvYmplY3QpOgogICAgICAgICAgICAgZmlsZV9y ZWFkZXIucHJvY2Vzc19wYXRocyhwYXRocykKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIGNo YW5nZWRfZmlsZXMgPSBwYXRocyBpZiBvcHRpb25zLmRpZmZfZmlsZXMgZWxzZSBOb25lCi0gICAg ICAgICAgICBwYXRjaCA9IHNjbS5jcmVhdGVfcGF0Y2gob3B0aW9ucy5naXRfY29tbWl0LCBjaGFu Z2VkX2ZpbGVzPWNoYW5nZWRfZmlsZXMpCisgICAgICAgICAgICBwYXRjaCA9IGhvc3Quc2NtKCku Y3JlYXRlX3BhdGNoKG9wdGlvbnMuZ2l0X2NvbW1pdCwgY2hhbmdlZF9maWxlcz1jaGFuZ2VkX2Zp bGVzKQogICAgICAgICAgICAgcGF0Y2hfY2hlY2tlciA9IFBhdGNoUmVhZGVyKGZpbGVfcmVhZGVy KQogICAgICAgICAgICAgcGF0Y2hfY2hlY2tlci5jaGVjayhwYXRjaCkKIAo=