72676 2011-11-17 16:06:58 -0800 Remove cargo-cult copy/pasting of ScriptExecutionContext namespace 2011-11-17 16:20:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71745 1 abarth abarth eric oldest_to_newest 505321 0 abarth 2011-11-17 16:06:58 -0800 Remove cargo-cult copy/pasting of ScriptExecutionContext namespace 505328 1 115706 abarth 2011-11-17 16:11:54 -0800 Created attachment 115706 Patch 505331 2 115706 eric 2011-11-17 16:14:09 -0800 Comment on attachment 115706 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115706&action=review > Source/WebCore/dom/Document.cpp:-4530 > - initDNSPrefetch(); You're sure removing this is OK? 505334 3 abarth 2011-11-17 16:18:18 -0800 (In reply to comment #2) > (From update of attachment 115706 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115706&action=review > > > Source/WebCore/dom/Document.cpp:-4530 > > - initDNSPrefetch(); > > You're sure removing this is OK? Yes. It's called in the constructor already. Having it in this function is a menace, actually, because it's not safe to call multiple times. 505335 4 abarth 2011-11-17 16:20:48 -0800 Committed r100696: <http://trac.webkit.org/changeset/100696> 115706 2011-11-17 16:11:54 -0800 2011-11-17 16:14:08 -0800 Patch bug-72676-20111117161152.patch text/plain 5906 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDY5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDExLTExLTE3ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGNhcmdvLWN1bHQgY29w eS9wYXN0aW5nIG9mIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgbmFtZXNwYWNlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjY3NgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGxvb2tzIGxpa2UgdGhpcyBj YXJnby1jdWx0IHN0YXJ0ZWQgd2l0aCBpbml0RE5TUHJlZmV0Y2ggYmVpbmcgaGFja2VkCisgICAg ICAgIGludG8gc2V0U2VjdXJpdHlPcmlnaW4uICBJJ3ZlIHJlbW92ZWQgdGhpcyBoYWNrIGFsb25n IHdpdGggdGhlCisgICAgICAgIGNvcHkvcGFzdGUgY29kZS4KKworICAgICAgICAqIGRvbS9ET01J bXBsZW1lbnRhdGlvbi5jcHA6CisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50OjpzZXRJc1ZpZXdTb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6 RG9jdW1lbnQ6Om9wZW4pOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmluaXRTZWN1cml0 eUNvbnRleHQpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldFNlY3VyaXR5T3JpZ2lu KToKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKiB4bWwvWFNMVFByb2Nlc3Nv ci5jcHA6CisKIDIwMTEtMTEtMTcgIEtvbnN0YW50aW4gU2NoZWdsb3YgIDxzY2hlZ2xvdkBnb29n bGUuY29tPgogCiAgICAgICAgIEFic29sdXRlIGNoaWxkIGlzIG5vdCByZXBhaW50ZWQgd2hlbiBw YXJlbnQgb3BhY2l0eSBjaGFuZ2VzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRE9NSW1wbGVt ZW50YXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9ET01JbXBsZW1l bnRhdGlvbi5jcHAJKHJldmlzaW9uIDEwMDY5MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9ET01J bXBsZW1lbnRhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAKICNpbmNs dWRlICJQbHVnaW5EYXRhLmgiCiAjaW5jbHVkZSAiUGx1Z2luRG9jdW1lbnQuaCIKICNpbmNsdWRl ICJSZWd1bGFyRXhwcmVzc2lvbi5oIgorI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5j bHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJUZXh0RG9jdW1lbnQuaCIKICNpbmNsdWRlICJU aHJlYWRHbG9iYWxEYXRhLmgiCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9u IDEwMDY5MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE3NjIsNyArMTc2Miw3IEBAIHZvaWQgRG9jdW1lbnQ6OnNldElzVmlld1NvdXJjZShi b29sIGlzVmkKICAgICBpZiAoIW1faXNWaWV3U291cmNlKQogICAgICAgICByZXR1cm47CiAKLSAg ICBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpzZXRTZWN1cml0eU9yaWdpbihTZWN1cml0eU9yaWdp bjo6Y3JlYXRlKHVybCgpLCB0cnVlKSk7CisgICAgc2V0U2VjdXJpdHlPcmlnaW4oU2VjdXJpdHlP cmlnaW46OmNyZWF0ZSh1cmwoKSwgdHJ1ZSkpOwogfQogCiB2b2lkIERvY3VtZW50OjpjcmVhdGVT dHlsZVNlbGVjdG9yKCkKQEAgLTIwMDcsNyArMjAwNyw3IEBAIHZvaWQgRG9jdW1lbnQ6Om9wZW4o RG9jdW1lbnQqIG93bmVyRG9jdW0KICAgICBpZiAob3duZXJEb2N1bWVudCkgewogICAgICAgICBz ZXRVUkwob3duZXJEb2N1bWVudC0+dXJsKCkpOwogICAgICAgICBtX2Nvb2tpZVVSTCA9IG93bmVy RG9jdW1lbnQtPmNvb2tpZVVSTCgpOwotICAgICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0Ojpz ZXRTZWN1cml0eU9yaWdpbihvd25lckRvY3VtZW50LT5zZWN1cml0eU9yaWdpbigpKTsKKyAgICAg ICAgc2V0U2VjdXJpdHlPcmlnaW4ob3duZXJEb2N1bWVudC0+c2VjdXJpdHlPcmlnaW4oKSk7CiAg ICAgfQogCiAgICAgaWYgKG1fZnJhbWUpIHsKQEAgLTQ0NTgsMTcgKzQ0NTgsMTcgQEAgdm9pZCBE b2N1bWVudDo6aW5pdFNlY3VyaXR5Q29udGV4dCgpCiAgICAgICAgIC8vIE5vIHNvdXJjZSBmb3Ig YSBzZWN1cml0eSBjb250ZXh0LgogICAgICAgICAvLyBUaGlzIGNhbiBvY2N1ciB2aWEgZG9jdW1l bnQuaW1wbGVtZW50YXRpb24uY3JlYXRlRG9jdW1lbnQoKS4KICAgICAgICAgbV9jb29raWVVUkwg PSBLVVJMKFBhcnNlZFVSTFN0cmluZywgIiIpOwotICAgICAgICBTY3JpcHRFeGVjdXRpb25Db250 ZXh0OjpzZXRTZWN1cml0eU9yaWdpbihTZWN1cml0eU9yaWdpbjo6Y3JlYXRlVW5pcXVlKCkpOwot ICAgICAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpzZXRDb250ZW50U2VjdXJpdHlQb2xpY3ko Q29udGVudFNlY3VyaXR5UG9saWN5OjpjcmVhdGUodGhpcykpOworICAgICAgICBzZXRTZWN1cml0 eU9yaWdpbihTZWN1cml0eU9yaWdpbjo6Y3JlYXRlVW5pcXVlKCkpOworICAgICAgICBzZXRDb250 ZW50U2VjdXJpdHlQb2xpY3koQ29udGVudFNlY3VyaXR5UG9saWN5OjpjcmVhdGUodGhpcykpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgLy8gSW4gdGhlIGNvbW1vbiBjYXNlLCBjcmVh dGUgdGhlIHNlY3VyaXR5IGNvbnRleHQgZnJvbSB0aGUgY3VycmVudGx5CiAgICAgLy8gbG9hZGlu ZyBVUkwgd2l0aCBhIGZyZXNoIGNvbnRlbnQgc2VjdXJpdHkgcG9saWN5LgogICAgIG1fY29va2ll VVJMID0gbV91cmw7Ci0gICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6ZW5mb3JjZVNhbmRib3hG bGFncyhtX2ZyYW1lLT5sb2FkZXIoKS0+ZWZmZWN0aXZlU2FuZGJveEZsYWdzKCkpOwotICAgIFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnNldFNlY3VyaXR5T3JpZ2luKFNlY3VyaXR5T3JpZ2luOjpj cmVhdGUobV91cmwsIGlzU2FuZGJveGVkKFNhbmRib3hPcmlnaW4pKSk7Ci0gICAgU2NyaXB0RXhl Y3V0aW9uQ29udGV4dDo6c2V0Q29udGVudFNlY3VyaXR5UG9saWN5KENvbnRlbnRTZWN1cml0eVBv bGljeTo6Y3JlYXRlKHRoaXMpKTsKKyAgICBlbmZvcmNlU2FuZGJveEZsYWdzKG1fZnJhbWUtPmxv YWRlcigpLT5lZmZlY3RpdmVTYW5kYm94RmxhZ3MoKSk7CisgICAgc2V0U2VjdXJpdHlPcmlnaW4o U2VjdXJpdHlPcmlnaW46OmNyZWF0ZShtX3VybCwgaXNTYW5kYm94ZWQoU2FuZGJveE9yaWdpbikp KTsKKyAgICBzZXRDb250ZW50U2VjdXJpdHlQb2xpY3koQ29udGVudFNlY3VyaXR5UG9saWN5Ojpj cmVhdGUodGhpcykpOwogCiAgICAgaWYgKFNlY3VyaXR5UG9saWN5OjphbGxvd1N1YnN0aXR1dGVE YXRhQWNjZXNzVG9Mb2NhbCgpKSB7CiAgICAgICAgIC8vIElmIHRoaXMgZG9jdW1lbnQgd2FzIGxv YWRlZCB3aXRoIHN1YnN0aXR1dGVEYXRhLCB0aGVuIHRoZSBkb2N1bWVudCBjYW4KQEAgLTQ1MTcs MTcgKzQ1MTcsMTMgQEAgdm9pZCBEb2N1bWVudDo6aW5pdFNlY3VyaXR5Q29udGV4dCgpCiAgICAg bV9jb29raWVVUkwgPSBvd25lckZyYW1lLT5kb2N1bWVudCgpLT5jb29raWVVUkwoKTsKICAgICAv LyBXZSBhbGlhcyB0aGUgU2VjdXJpdHlPcmlnaW5zIHRvIG1hdGNoIEZpcmVmb3gsIHNlZSBCdWcg MTUzMTMKICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUz MTMKLSAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0OjpzZXRTZWN1cml0eU9yaWdpbihvd25lckZy YW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpKTsKLSAgICAvLyBGSVhNRTogQ29uc2lk ZXIgbW92aW5nIG1fY29udGVudFNlY3VyaXR5UG9saWN5IGludG8gU2VjdXJpdHlPcmlnaW4uCi0g ICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6c2V0Q29udGVudFNlY3VyaXR5UG9saWN5KG93bmVy RnJhbWUtPmRvY3VtZW50KCktPmNvbnRlbnRTZWN1cml0eVBvbGljeSgpKTsKKyAgICBzZXRTZWN1 cml0eU9yaWdpbihvd25lckZyYW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpKTsKKyAg ICBzZXRDb250ZW50U2VjdXJpdHlQb2xpY3kob3duZXJGcmFtZS0+ZG9jdW1lbnQoKS0+Y29udGVu dFNlY3VyaXR5UG9saWN5KCkpOwogfQogCi12b2lkIERvY3VtZW50OjpzZXRTZWN1cml0eU9yaWdp bihTZWN1cml0eU9yaWdpbiogc2VjdXJpdHlPcmlnaW4pCit2b2lkIERvY3VtZW50OjpzZXRTZWN1 cml0eU9yaWdpbihQYXNzUmVmUHRyPFNlY3VyaXR5T3JpZ2luPiBvcmlnaW4pCiB7Ci0gICAgU2Ny aXB0RXhlY3V0aW9uQ29udGV4dDo6c2V0U2VjdXJpdHlPcmlnaW4oc2VjdXJpdHlPcmlnaW4pOwot ICAgIC8vIEZJWE1FOiBGaW5kIGEgYmV0dGVyIHBsYWNlIHRvIGVuYWJsZSBETlMgcHJlZmV0Y2gs IHdoaWNoIGlzIGEgbG9hZGVyIGNvbmNlcHQsCi0gICAgLy8gbm90IGFwcGxpY2FibGUgdG8gYXJi aXRyYXJ5IGRvY3VtZW50cy4KLSAgICBpbml0RE5TUHJlZmV0Y2goKTsKKyAgICBTZWN1cml0eUNv bnRleHQ6OnNldFNlY3VyaXR5T3JpZ2luKG9yaWdpbik7CiB9CiAKICNpZiBFTkFCTEUoU1FMX0RB VEFCQVNFKQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgJKHJldmlzaW9uIDEwMDY5MCkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDE2LDcgKzEw MTYsNyBAQCBwdWJsaWM6CiAgICAgLy8gRXhwbGljaXRseSBvdmVycmlkZSB0aGUgc2VjdXJpdHkg b3JpZ2luIGZvciB0aGlzIGRvY3VtZW50LgogICAgIC8vIE5vdGU6IEl0IGlzIGRhbmdlcm91cyB0 byBjaGFuZ2UgdGhlIHNlY3VyaXR5IG9yaWdpbiBvZiBhIGRvY3VtZW50CiAgICAgLy8gICAgICAg dGhhdCBhbHJlYWR5IGNvbnRhaW5zIGNvbnRlbnQuCi0gICAgdm9pZCBzZXRTZWN1cml0eU9yaWdp bihTZWN1cml0eU9yaWdpbiopOworICAgIHZvaWQgc2V0U2VjdXJpdHlPcmlnaW4oUGFzc1JlZlB0 cjxTZWN1cml0eU9yaWdpbj4pOwogCiAgICAgdm9pZCB1cGRhdGVVUkxGb3JQdXNoT3JSZXBsYWNl U3RhdGUoY29uc3QgS1VSTCYpOwogICAgIHZvaWQgc3RhdGVQb3BwZWQoU2VyaWFsaXplZFNjcmlw dFZhbHVlKik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS94bWwvWFNMVFByb2Nlc3Nvci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUveG1sL1hTTFRQcm9jZXNzb3IuY3BwCShyZXZpc2lv biAxMDA2OTApCisrKyBTb3VyY2UvV2ViQ29yZS94bWwvWFNMVFByb2Nlc3Nvci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKICNpbmNsdWRlICJIVE1MQm9keUVsZW1lbnQuaCIK ICNpbmNsdWRlICJIVE1MRG9jdW1lbnQuaCIKICNpbmNsdWRlICJQYWdlLmgiCisjaW5jbHVkZSAi U2VjdXJpdHlPcmlnaW4uaCIKICNpbmNsdWRlICJUZXh0LmgiCiAjaW5jbHVkZSAiVGV4dFJlc291 cmNlRGVjb2Rlci5oIgogI2luY2x1ZGUgIm1hcmt1cC5oIgo=