72647 2011-11-17 13:28:03 -0800 Chromium crashing on http/tests/misc/xslt-bad-import.html after r100311 2011-11-17 15:35:42 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth webkit.review.bot oldest_to_newest 505146 0 japhet 2011-11-17 13:28:03 -0800 I appear to have dropped a needed protecting RefPtr<Document> in obscure cases in http://trac.webkit.org/changeset/100311. If SubresourceLoader::releaseResources() gets re-entered, a CachedResourceLoader can die while still in loadDone(). The variant of http/tests/misc/xslt-bad-import.html that runs in a full chromium build crashes pretty consistently as a result. Patch imminent. 505157 1 115668 japhet 2011-11-17 13:37:02 -0800 Created attachment 115668 patch 505291 2 115668 webkit.review.bot 2011-11-17 15:35:38 -0800 Comment on attachment 115668 patch Clearing flags on attachment: 115668 Committed r100692: <http://trac.webkit.org/changeset/100692> 505292 3 webkit.review.bot 2011-11-17 15:35:42 -0800 All reviewed patches have been landed. Closing bug. 115668 2011-11-17 13:37:02 -0800 2011-11-17 15:35:38 -0800 patch ref.txt text/plain 1274 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDY2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTE3ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgcjEwMDMxMSBkcm9wcGVkIGEg UmVmUHRyIHRoYXQgaXMgdmVyeQorICAgICAgICBoZWxwZnVsLiBBZGQgaXQgYmFjay4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cC90ZXN0cy9taXNj L3hzbHQtYmFkLWltcG9ydC5odG1sIHNob3VsZAorICAgICAgICBzdG9wIGNyYXNoaW5nIGluIGZ1 bGwgY2hyb21pdW0gYnVpbGRzLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291 cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlTG9hZGVyOjps b2FkRG9uZSk6CisKIDIwMTEtMTEtMTcgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxl LmNvbT4KIAogICAgICAgICBBWDogY2xlYW51cCBzdHlsZSBhbmQgbmFtaW5nIGFuZCBjb2RlIGlu IGFjY2Vzc2liaWxpdHkgc2VhcmNoIG1lY2hhbmlzbQpJbmRleDogU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAx MDA2NTMpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2Fk ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NTMsNiArNjUzLDggQEAKIHZvaWQgQ2FjaGVkUmVz b3VyY2VMb2FkZXI6OmxvYWREb25lKCkKIHsKICAgICBtX2xvYWRGaW5pc2hpbmcgPSBmYWxzZTsK KworICAgIFJlZlB0cjxEb2N1bWVudD4gcHJvdGVjdChtX2RvY3VtZW50KTsKICAgICBpZiAoZnJh bWUoKSkKICAgICAgICAgZnJhbWUoKS0+bG9hZGVyKCktPmxvYWREb25lKCk7CiAgICAgcGVyZm9y bVBvc3RMb2FkQWN0aW9ucygpOwo=