72643 2011-11-17 12:25:30 -0800 [CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h 2011-11-18 08:07:24 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga bfulgham rakuco webkit.review.bot oldest_to_newest 505096 0 paroga 2011-11-17 12:25:30 -0800 [CMake] Add ENABLE_CLIENT_BASED_GEOLOCATION to cmakeconfig.h 505099 1 115658 paroga 2011-11-17 12:26:22 -0800 Created attachment 115658 Patch 505184 2 115658 bfulgham 2011-11-17 14:04:06 -0800 Comment on attachment 115658 Patch Looks good to me. The supposedly-failing chromium tests can't possibly be affected by this change. 505192 3 115658 paroga 2011-11-17 14:05:49 -0800 Comment on attachment 115658 Patch (In reply to comment #2) > (From update of attachment 115658 [details]) > Looks good to me. The supposedly-failing chromium tests can't possibly be affected by this change. Since chromium does not use CMake: NO! ;-) 505269 4 115658 webkit.review.bot 2011-11-17 15:15:14 -0800 Comment on attachment 115658 Patch Clearing flags on attachment: 115658 Committed r100686: <http://trac.webkit.org/changeset/100686> 505271 5 webkit.review.bot 2011-11-17 15:15:18 -0800 All reviewed patches have been landed. Closing bug. 505794 6 rakuco 2011-11-18 08:07:24 -0800 This patch broke the EFL build with ENABLE_GEOLOCATION (and most likely platform/mock/GeolocationServiceMock.cpp too), as they do not check for ENABLE_CLIENT_BASED_GEOLOCATION and define s_factoryFunction regardless of whether GeolocationService.cpp also does so. 115658 2011-11-17 12:26:22 -0800 2011-11-17 15:15:14 -0800 Patch bug-72643-20111117212620.patch text/plain 4382 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDQ5Yzhl ZWZlMDc1NjlkNzNjMmY1NTM5NzFmNzJjOWI4ZjJmMjdkOGEuLjE3NTZmMzUwYTQzNGNkZmExNjc2 NDk4ZTAyN2FmZjc1MWI2MWRhYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC02MSw3ICs2MSw3 IEBAIFNFVChWRVJTSU9OX1NDUklQVCAiLVdsLC0tdmVyc2lvbi1zY3JpcHQsJHtDTUFLRV9NT0RV TEVfUEFUSH0vZWZsc3ltYm9scy5maWx0ZXIiCiAKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9CTE9C ICJFbmFibGUgYmxvYiBzbGljZSIgREVGQVVMVCBPRkYpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVf Q0hBTk5FTF9NRVNTQUdJTkcgIkVuYWJsZSBjaGFubmVsIG1lc3NhZ2luZyIgREVGQVVMVCBPTikK LVdFQktJVF9GRUFUVVJFKEVOQUJMRV9TUUxfREFUQUJBU0UgIkVuYWJsZSBTUUwgZGF0YWJhc2Ui IERFRkFVTFQgT04pCitXRUJLSVRfRkVBVFVSRShFTkFCTEVfQ0xJRU5UX0JBU0VEX0dFT0xPQ0FU SU9OICJFbmFibGUgY2xpZW50IGJhc2VkIGdlb2xvY2F0aW9uIiBERUZBVUxUIE9GRikKIFdFQktJ VF9GRUFUVVJFKEVOQUJMRV9EQVRBR1JJRCAiRW5hYmxlIGRhdGFncmlkIiBERUZBVUxUIE9GRikK IFdFQktJVF9GRUFUVVJFKEVOQUJMRV9EQVRBTElTVCAiRW5hYmxlIGRhdGFsaXN0IiBERUZBVUxU IE9OIEhUTUwpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfREFUQV9UUkFOU0ZFUl9JVEVNUyAiRW5h YmxlIGRhdGEgdHJhbnNmZXIgaXRlbXMiIERFRkFVTFQgT0ZGKQpAQCAtODcsNiArODcsNyBAQCBX RUJLSVRfRkVBVFVSRShFTkFCTEVfUEFHRV9WSVNJQklMSVRZX0FQSSAiRW5hYmxlIFBhZ2UgVmlz aWJpbGl0eSBBUEkiIERFRkFVTFQgTwogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1BST0dSRVNTX1RB RyAiRW5hYmxlIHByb2dyZXNzIHRhZyIgREVGQVVMVCBPTikKIFdFQktJVF9GRUFUVVJFKEVOQUJM RV9SRVFVRVNUX0FOSU1BVElPTl9GUkFNRSAiRW5hYmxlIHJlcXVlc3RBbmltYXRpb25GcmFtZSBB UEkiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfU0hBUkVEX1dPUktFUlMgIkVu YWJsZSBzaGFyZWQgd29ya2VycyIgREVGQVVMVCBPTikKK1dFQktJVF9GRUFUVVJFKEVOQUJMRV9T UUxfREFUQUJBU0UgIkVuYWJsZSBTUUwgZGF0YWJhc2UiIERFRkFVTFQgT04pCiBXRUJLSVRfRkVB VFVSRShFTkFCTEVfU1ZHICJFbmFibGUgU1ZHIiBERUZBVUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUo RU5BQkxFX1NWR19GT05UUyAiRW5hYmxlIFNWRyBmb250cyIgREVGQVVMVCBPTiBTVkcpCiBXRUJL SVRfRkVBVFVSRShFTkFCTEVfVE9VQ0hfRVZFTlRTICJFbmFibGUgVG91Y2ggRXZlbnRzIiBERUZB VUxUIE9GRikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2UgYi9T b3VyY2UvY21ha2UvT3B0aW9uc1dpbkNFLmNtYWtlCmluZGV4IDBhNTEyYmJkYzRlYzg5NGM5ZWUx Y2NiNjIxMzgxYTNkZDY1OTI4MmYuLjNlMzNmZDk4YTc3MDc5NjVhZDE5M2FlZDk3MmQ0YTBiYjg2 ZjBlNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2UKKysrIGIv U291cmNlL2NtYWtlL09wdGlvbnNXaW5DRS5jbWFrZQpAQCAtMjEsNyArMjEsNyBAQCBBRERfU1VC RElSRUNUT1JZKCR7M1JEUEFSVFlfRElSfSAiJHtDTUFLRV9DVVJSRU5UX0JJTkFSWV9ESVJ9LzNy ZHBhcnR5IikKIAogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX0JMT0IgIkVuYWJsZSBibG9iIHNsaWNl IiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9DSEFOTkVMX01FU1NBR0lORyAi RW5hYmxlIGNoYW5uZWwgbWVzc2FnaW5nIiBERUZBVUxUIE9GRikKLVdFQktJVF9GRUFUVVJFKEVO QUJMRV9TUUxfREFUQUJBU0UgIkVuYWJsZSBTUUwgZGF0YWJhc2UiIERFRkFVTFQgT0ZGKQorV0VC S0lUX0ZFQVRVUkUoRU5BQkxFX0NMSUVOVF9CQVNFRF9HRU9MT0NBVElPTiAiRW5hYmxlIGNsaWVu dCBiYXNlZCBnZW9sb2NhdGlvbiIgREVGQVVMVCBPRkYpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVf REFUQUdSSUQgIkVuYWJsZSBkYXRhZ3JpZCIgREVGQVVMVCBPRkYpCiBXRUJLSVRfRkVBVFVSRShF TkFCTEVfREFUQUxJU1QgIkVuYWJsZSBkYXRhbGlzdCIgREVGQVVMVCBPRkYgSFRNTCkKIFdFQktJ VF9GRUFUVVJFKEVOQUJMRV9EQVRBX1RSQU5TRkVSX0lURU1TICJFbmFibGUgZGF0YSB0cmFuc2Zl ciBpdGVtcyIgREVGQVVMVCBPRkYpCkBAIC00MSw2ICs0MSw3IEBAIFdFQktJVF9GRUFUVVJFKEVO QUJMRV9OT1RJRklDQVRJT05TICJFbmFibGUgbm90aWZpY2F0aW9ucyIgREVGQVVMVCBPRkYpCiBX RUJLSVRfRkVBVFVSRShFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTICJFbmFibGUgb3JpZW50YXRp b24gZXZlbnRzIiBERUZBVUxUIE9GRikKIFdFQktJVF9GRUFUVVJFKEVOQUJMRV9QUk9HUkVTU19U QUcgIkVuYWJsZSBwcm9ncmVzcyB0YWciIERFRkFVTFQgT0ZGKQogV0VCS0lUX0ZFQVRVUkUoRU5B QkxFX1NIQVJFRF9XT1JLRVJTICJFbmFibGUgc2hhcmVkIHdvcmtlcnMiIERFRkFVTFQgT0ZGKQor V0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1NRTF9EQVRBQkFTRSAiRW5hYmxlIFNRTCBkYXRhYmFzZSIg REVGQVVMVCBPRkYpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfU1ZHICJFbmFibGUgU1ZHIiBERUZB VUxUIE9OKQogV0VCS0lUX0ZFQVRVUkUoRU5BQkxFX1NWR19GT05UUyAiRW5hYmxlIFNWRyBmb250 cyIgREVGQVVMVCBPTiBTVkcpCiBXRUJLSVRfRkVBVFVSRShFTkFCTEVfVE9VQ0hfRVZFTlRTICJF bmFibGUgVG91Y2ggRXZlbnRzIiBERUZBVUxUIE9GRikKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFr ZWNvbmZpZy5oLmNtYWtlIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKaW5kZXggNjFkNDZh MGJiZGVhODQzYTI5OTBjNjc4NjYwNTQ2NGVjNzU2ZGU1Yy4uYmZiNTM2NmI4YTc4ODQ1ZThlNjli NTkwMGE3NzViMGUxYmYzYzJhZSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlY29uZmlnLmguY21h a2UKKysrIGIvU291cmNlL2NtYWtlY29uZmlnLmguY21ha2UKQEAgLTgsNyArOCw3IEBACiAjY21h a2VkZWZpbmUwMSBFTkFCTEVfQVNfSU1BR0UKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9CTE9CCiAj Y21ha2VkZWZpbmUwMSBFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkcKLSNjbWFrZWRlZmluZTAxIEVO QUJMRV9TUUxfREFUQUJBU0UKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9DTElFTlRfQkFTRURfR0VP TE9DQVRJT04KICNjbWFrZWRlZmluZTAxIEVOQUJMRV9EQVRBR1JJRAogI2NtYWtlZGVmaW5lMDEg RU5BQkxFX0RBVEFMSVNUCiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfREFUQV9UUkFOU0ZFUl9JVEVN UwpAQCAtMzQsNiArMzQsNyBAQAogI2NtYWtlZGVmaW5lMDEgRU5BQkxFX1BST0dSRVNTX1RBRwog I2NtYWtlZGVmaW5lMDEgRU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FCiAjY21ha2VkZWZp bmUwMSBFTkFCTEVfU0hBUkVEX1dPUktFUlMKKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9TUUxfREFU QUJBU0UKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9TVkcKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9T VkdfRk9OVFMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9UT1VDSF9FVkVOVFMKZGlmZiAtLWdpdCBh L0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkZDU2NmM1YmRhOWVjYzRhMzRmMDEzOGYwMTNj N2JkZDdhZWM5MzgzLi5hMWNjNWE1MzU4YTRiNWM5Zjk5OGIyYjdiMDYzOWEyYWU5NmEzNjM0IDEw MDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTEtMTEtMTcgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0NNYWtlXSBBZGQgRU5BQkxFX0NMSUVOVF9CQVNFRF9HRU9MT0NBVElPTiB0byBjbWFrZWNv bmZpZy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MjY0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNXaW5DRS5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZToK KwogMjAxMS0xMS0xNyAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbY2hyb21pdW1dIGFkZCBneXAtbWFjLXRvb2wgdG8gLmdpdGlnbm9yZQo=