72640 2011-11-17 12:05:38 -0800 return values in void functions. 2011-11-17 15:05:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 knorton knorton abarth webkit.review.bot oldest_to_newest 505070 0 knorton 2011-11-17 12:05:38 -0800 Several void functions in FrameView and RenderObject return values. 505080 1 115651 knorton 2011-11-17 12:15:14 -0800 Created attachment 115651 Patch 505263 2 115651 webkit.review.bot 2011-11-17 15:05:32 -0800 Comment on attachment 115651 Patch Clearing flags on attachment: 115651 Committed r100685: <http://trac.webkit.org/changeset/100685> 505264 3 webkit.review.bot 2011-11-17 15:05:37 -0800 All reviewed patches have been landed. Closing bug. 115651 2011-11-17 12:15:14 -0800 2011-11-17 15:05:32 -0800 Patch bug-72640-20111117151513.patch text/plain 4507 knorton SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDY1 NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTEx LTE3ICBLZWxseSBOb3J0b24gIDxrbm9ydG9uQGdvb2dsZS5jb20+CisKKyAgICAgICBTZXZlcmFs IHZvaWQgZnVuY3Rpb25zIGluIEZyYW1lVmlldyBhbmQgUmVuZGVyT2JqZWN0IGFjdHVhbGx5IHJl dHVybiB2YWx1ZXMuCisgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcyNjQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiAuLi8uLi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgICog Li4vLi4vU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisKIDIwMTEt MTEtMTcgIEpvY2hlbiBFaXNpbmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg W2Nocm9taXVtXSBhZGQgZ3lwLW1hYy10b29sIHRvIC5naXRpZ25vcmUKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDEwMDY0MykKKysrIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgwNyw4ICsxODA3LDEwIEBAIHZv aWQgRnJhbWVWaWV3Ojp2aXNpYmxlQ29udGVudHNSZXNpemVkKCkKIHZvaWQgRnJhbWVWaWV3Ojpi ZWdpbkRlZmVycmVkUmVwYWludHMoKQogewogICAgIFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLT5wYWdl KCk7Ci0gICAgaWYgKHBhZ2UtPm1haW5GcmFtZSgpICE9IG1fZnJhbWUpCi0gICAgICAgIHJldHVy biBwYWdlLT5tYWluRnJhbWUoKS0+dmlldygpLT5iZWdpbkRlZmVycmVkUmVwYWludHMoKTsKKyAg ICBpZiAocGFnZS0+bWFpbkZyYW1lKCkgIT0gbV9mcmFtZSkgeworICAgICAgICBwYWdlLT5tYWlu RnJhbWUoKS0+dmlldygpLT5iZWdpbkRlZmVycmVkUmVwYWludHMoKTsKKyAgICAgICAgcmV0dXJu OworICAgIH0KIAogICAgIG1fZGVmZXJyaW5nUmVwYWludHMrKzsKIH0KQEAgLTE4MTcsOCArMTgx OSwxMCBAQCB2b2lkIEZyYW1lVmlldzo6YmVnaW5EZWZlcnJlZFJlcGFpbnRzKCkKIHZvaWQgRnJh bWVWaWV3OjplbmREZWZlcnJlZFJlcGFpbnRzKCkKIHsKICAgICBQYWdlKiBwYWdlID0gbV9mcmFt ZS0+cGFnZSgpOwotICAgIGlmIChwYWdlLT5tYWluRnJhbWUoKSAhPSBtX2ZyYW1lKQotICAgICAg ICByZXR1cm4gcGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKS0+ZW5kRGVmZXJyZWRSZXBhaW50cygp OworICAgIGlmIChwYWdlLT5tYWluRnJhbWUoKSAhPSBtX2ZyYW1lKSB7CisgICAgICAgIHBhZ2Ut Pm1haW5GcmFtZSgpLT52aWV3KCktPmVuZERlZmVycmVkUmVwYWludHMoKTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KIAogICAgIEFTU0VSVChtX2RlZmVycmluZ1JlcGFpbnRzID4gMCk7CiAKQEAg LTIzODUsNyArMjM4OSw3IEBAIHZvaWQgRnJhbWVWaWV3OjpkaWRTdGFydFJ1YmJlckJhbmQoY29u c3QKICAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOwogICAgIGlmICghcGFnZSkKICAg ICAgICAgcmV0dXJuOwotICAgIHJldHVybiBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPmRpZENv bXBsZXRlUnViYmVyQmFuZEZvckZyYW1lKG1fZnJhbWUuZ2V0KCksIGluaXRpYWxPdmVyaGFuZyk7 CisgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5kaWRDb21wbGV0ZVJ1YmJlckJhbmRGb3JG cmFtZShtX2ZyYW1lLmdldCgpLCBpbml0aWFsT3ZlcmhhbmcpOwogfQogCiB2b2lkIEZyYW1lVmll dzo6ZGlkQ29tcGxldGVSdWJiZXJCYW5kKGNvbnN0IEludFNpemUmIGluaXRpYWxPdmVyaGFuZykg Y29uc3QKQEAgLTIzOTMsNyArMjM5Nyw3IEBAIHZvaWQgRnJhbWVWaWV3OjpkaWRDb21wbGV0ZVJ1 YmJlckJhbmQoY28KICAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOwogICAgIGlmICgh cGFnZSkKICAgICAgICAgcmV0dXJuOwotICAgIHJldHVybiBwYWdlLT5jaHJvbWUoKS0+Y2xpZW50 KCktPmRpZENvbXBsZXRlUnViYmVyQmFuZEZvckZyYW1lKG1fZnJhbWUuZ2V0KCksIGluaXRpYWxP dmVyaGFuZyk7CisgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5kaWRDb21wbGV0ZVJ1YmJl ckJhbmRGb3JGcmFtZShtX2ZyYW1lLmdldCgpLCBpbml0aWFsT3ZlcmhhbmcpOwogfQogCiB2b2lk IEZyYW1lVmlldzo6ZGlkU3RhcnRBbmltYXRlZFNjcm9sbCgpIGNvbnN0CkBAIC0yNDAxLDcgKzI0 MDUsNyBAQCB2b2lkIEZyYW1lVmlldzo6ZGlkU3RhcnRBbmltYXRlZFNjcm9sbCgpCiAgICAgUGFn ZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsKICAgICBpZiAoIXBhZ2UpCiAgICAgICAgIHJldHVy bjsKLSAgICByZXR1cm4gcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5kaWRTdGFydEFuaW1hdGVk U2Nyb2xsKCk7CisgICAgcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5kaWRTdGFydEFuaW1hdGVk U2Nyb2xsKCk7CiB9CiAKIHZvaWQgRnJhbWVWaWV3OjpkaWRDb21wbGV0ZUFuaW1hdGVkU2Nyb2xs KCkgY29uc3QKQEAgLTI0MDksNyArMjQxMyw3IEBAIHZvaWQgRnJhbWVWaWV3OjpkaWRDb21wbGV0 ZUFuaW1hdGVkU2Nyb2wKICAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOwogICAgIGlm ICghcGFnZSkKICAgICAgICAgcmV0dXJuOwotICAgIHJldHVybiBwYWdlLT5jaHJvbWUoKS0+Y2xp ZW50KCktPmRpZENvbXBsZXRlQW5pbWF0ZWRTY3JvbGwoKTsKKyAgICBwYWdlLT5jaHJvbWUoKS0+ Y2xpZW50KCktPmRpZENvbXBsZXRlQW5pbWF0ZWRTY3JvbGwoKTsKIH0KIAogdm9pZCBGcmFtZVZp ZXc6OnNldFZpc2libGVTY3JvbGxlclRodW1iUmVjdChjb25zdCBJbnRSZWN0JiBzY3JvbGxlclRo dW1iKQpAQCAtMjQxOSw3ICsyNDIzLDcgQEAgdm9pZCBGcmFtZVZpZXc6OnNldFZpc2libGVTY3Jv bGxlclRodW1iUgogICAgICAgICByZXR1cm47CiAgICAgaWYgKHBhZ2UtPm1haW5GcmFtZSgpICE9 IG1fZnJhbWUpCiAgICAgICAgIHJldHVybjsKLSAgICByZXR1cm4gcGFnZS0+Y2hyb21lKCktPmNs aWVudCgpLT5ub3RpZnlTY3JvbGxlclRodW1iSXNWaXNpYmxlSW5SZWN0KHNjcm9sbGVyVGh1bWIp OworICAgIHBhZ2UtPmNocm9tZSgpLT5jbGllbnQoKS0+bm90aWZ5U2Nyb2xsZXJUaHVtYklzVmlz aWJsZUluUmVjdChzY3JvbGxlclRodW1iKTsKIH0KIAogYm9vbCBGcmFtZVZpZXc6OmlzT25BY3Rp dmVQYWdlKCkgY29uc3QKQEAgLTI4MjMsNyArMjgyNyw3IEBAIHZvaWQgRnJhbWVWaWV3OjpwYWlu dE92ZXJoYW5nQXJlYXMoR3JhcGgKICAgICAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBy ZXR1cm4gU2Nyb2xsVmlldzo6cGFpbnRPdmVyaGFuZ0FyZWFzKGNvbnRleHQsIGhvcml6b250YWxP dmVyaGFuZ0FyZWEsIHZlcnRpY2FsT3ZlcmhhbmdBcmVhLCBkaXJ0eVJlY3QpOworICAgIFNjcm9s bFZpZXc6OnBhaW50T3ZlcmhhbmdBcmVhcyhjb250ZXh0LCBob3Jpem9udGFsT3ZlcmhhbmdBcmVh LCB2ZXJ0aWNhbE92ZXJoYW5nQXJlYSwgZGlydHlSZWN0KTsKIH0KIAogdm9pZCBGcmFtZVZpZXc6 OnVwZGF0ZUxheW91dEFuZFN0eWxlSWZOZWVkZWRSZWN1cnNpdmUoKQpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDEwMDY0MykKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMjg5LDggKzEyODksMTAgQEAgdm9pZCBSZW5kZXJPYmplY3Q6OnJlcGFpbnRVc2luZ0NvbnRh aW5lcgogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgaWYgKHJlcGFpbnRDb250YWluZXIt PmlzUmVuZGVyRmxvd1RocmVhZCgpKQotICAgICAgICByZXR1cm4gdG9SZW5kZXJGbG93VGhyZWFk KHJlcGFpbnRDb250YWluZXIpLT5yZXBhaW50UmVjdGFuZ2xlSW5SZWdpb25zKHIsIGltbWVkaWF0 ZSk7CisgICAgaWYgKHJlcGFpbnRDb250YWluZXItPmlzUmVuZGVyRmxvd1RocmVhZCgpKSB7Cisg ICAgICAgIHRvUmVuZGVyRmxvd1RocmVhZChyZXBhaW50Q29udGFpbmVyKS0+cmVwYWludFJlY3Rh bmdsZUluUmVnaW9ucyhyLCBpbW1lZGlhdGUpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAj aWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogICAgIFJlbmRlclZpZXcqIHYgPSB2aWV3 KCk7Cg==