72620 2011-11-17 08:27:36 -0800 Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake 2011-11-17 14:35:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cmarcelo cmarcelo abarth levin ojan webkit.review.bot oldest_to_newest 504882 0 cmarcelo 2011-11-17 08:27:36 -0800 Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake 504885 1 115598 cmarcelo 2011-11-17 08:32:07 -0800 Created attachment 115598 Patch 504916 2 115598 cmarcelo 2011-11-17 09:27:37 -0800 Comment on attachment 115598 Patch Forgot the unittests. 504919 3 115606 cmarcelo 2011-11-17 09:37:52 -0800 Created attachment 115606 Patch 505020 4 115606 levin 2011-11-17 11:39:20 -0800 Comment on attachment 115606 Patch thanks for adding a test. 505226 5 115606 webkit.review.bot 2011-11-17 14:35:16 -0800 Comment on attachment 115606 Patch Clearing flags on attachment: 115606 Committed r100678: <http://trac.webkit.org/changeset/100678> 505228 6 webkit.review.bot 2011-11-17 14:35:20 -0800 All reviewed patches have been landed. Closing bug. 115598 2011-11-17 08:32:07 -0800 2011-11-17 09:37:46 -0800 Patch bug-72620-20111117133243.patch text/plain 1929 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNjIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmU2MWRiMjcxZjdkOGZiMTI4Y2YyNzNjZjA4YTFkOGY0 MWQwZDRmOC4uYjhlODhjMWQ1NzgwZTkyOWUxZDY4NTVkZTg3MGI2OTVkNDA2MTJkYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDExLTExLTE3ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9s aXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgTWFrZSBjaGVjay13ZWJraXQtc3R5bGUg YWNjZXB0IHh4eF9wLmggYXMgYSBwcmltYXJ5IGhlYWRlciBmb3IgeHh4LmNwcCBmb3IgUXQncyBz YWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjYy MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFF0J3Mg Y29udmVudGlvbiBvZiBrZWVwaW5nIHByaXZhdGUgKGJ1dCBleHBvc2VkKSBBUEkgc3VmZml4ZWQg YnkgIl9wLmgiIGJ1dCBub3QKKyAgICAgICAgYWRkaW5nIHRoZSBzdWZmaXggdGhlIGNwcCBmaWxl LiBPbmUgZXhhbXBsZSBvZiBmYWxzZSBwb3NpdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIzMTkjYzEyLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IGFsc28gYWNjZXB0IGEgaGVhZGVyIGFzIHBy aW1hcnkgaWYgaXRzIGJhc2VuYW1lCisgICAgICAgIGNvbnRhaW5zIHRoZSBjcHAncyBiYXNlbmFt ZS4KKwogMjAxMS0xMS0xNyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAg ICAgSWdub3JlIHNvbWUgbGVha3MgaW4gZnJhbWV3b3JrcyB3ZSBsaW5rIGFnYWluc3Qgb24gTGlv bgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA3 MTM5MzI3ZTk4Yzk1YjQ2NTIzYmQzMDI5ZGE1ZDYxMGU3YjY4YzE0Li40YTQyM2RjN2UwNjQ4MTY2 YWQxMWMyYWQxM2JlNjE0ZTk5ZWZjYTM3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjYwNSw3ICsyNjA1LDggQEAgZGVmIF9jbGFzc2lmeV9p bmNsdWRlKGZpbGVuYW1lLCBpbmNsdWRlLCBpc19zeXN0ZW0sIGluY2x1ZGVfc3RhdGUpOgogICAg IGluY2x1ZGVfYmFzZSA9IEZpbGVJbmZvKGluY2x1ZGUpLmJhc2VfbmFtZSgpCiAKICAgICAjIElm IHdlIGhhdmVuJ3QgZW5jb3VudGVyZWQgYSBwcmltYXJ5IGhlYWRlciwgdGhlbiBiZSBsZW5pZW50 IGluIGNoZWNraW5nLgotICAgIGlmIG5vdCBpbmNsdWRlX3N0YXRlLnZpc2l0ZWRfcHJpbWFyeV9z ZWN0aW9uKCkgYW5kIHRhcmdldF9iYXNlLmZpbmQoaW5jbHVkZV9iYXNlKSAhPSAtMToKKyAgICBp ZiAobm90IGluY2x1ZGVfc3RhdGUudmlzaXRlZF9wcmltYXJ5X3NlY3Rpb24oKQorICAgICAgICBh bmQgKHRhcmdldF9iYXNlLmZpbmQoaW5jbHVkZV9iYXNlKSAhPSAtMSBvciBpbmNsdWRlX2Jhc2Uu ZmluZCh0YXJnZXRfYmFzZSkgIT0gLTEpKToKICAgICAgICAgcmV0dXJuIF9QUklNQVJZX0hFQURF UgogICAgICMgSWYgd2UgYWxyZWFkeSBlbmNvdW50ZXJlZCBhIHByaW1hcnkgaGVhZGVyLCBwZXJm b3JtIGEgc3RyaWN0IGNvbXBhcmlzb24uCiAgICAgIyBJbiBjYXNlIHRoZSB0d28gZmlsZW5hbWUg YmFzZXMgYXJlIHRoZSBzYW1lIHRoZW4gdGhlIGFib3ZlIGxlbmllbnQgY2hlY2sK 115606 2011-11-17 09:37:52 -0800 2011-11-17 14:35:15 -0800 Patch bug-72620-20111117143829.patch text/plain 3264 cmarcelo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNjM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWZjMDJmZDQ2MWFlMDc5MTA5N2FjNjg4NDFiN2U2NmRj ODRhYjRmNS4uZjJhMTQ0MGE2NmYxMWEyYjdkNjI1OWM4OTk0NzJhM2E0NDlhNWM2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDExLTExLTE3ICBDYWlvIE1hcmNlbG8gZGUgT2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9s aXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgTWFrZSBjaGVjay13ZWJraXQtc3R5bGUg YWNjZXB0IHh4eF9wLmggYXMgYSBwcmltYXJ5IGhlYWRlciBmb3IgeHh4LmNwcCBmb3IgUXQncyBz YWtlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjYy MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFF0J3Mg Y29udmVudGlvbiBvZiBrZWVwaW5nIHByaXZhdGUgKGJ1dCBleHBvc2VkKSBBUEkgc3VmZml4ZWQg YnkgIl9wLmgiIGJ1dCBub3QKKyAgICAgICAgYWRkaW5nIHRoZSBzdWZmaXggdGhlIGNwcCBmaWxl LiBPbmUgZXhhbXBsZSBvZiBmYWxzZSBwb3NpdGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIzMTkjYzEyLgorCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6IGFjY2VwdCBoZWFkZXJzIGVuZGluZyB3aXRo IF9wIGFzIHByaW1hcnkgaWYgaXRzCisgICAgICAgIGJhc2VuYW1lIGNvbnRhaW5zIHRoZSBjcHAn cyBiYXNlbmFtZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cF91bml0dGVzdC5weToKKwogMjAxMS0xMS0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5k QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcnVuLWJpbmRpbmdzLXRlc3RzIGZp eCBhZnRlciByOTEwMjguCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5CmluZGV4IDcxMzkzMjdlOThjOTViNDY1MjNiZDMwMjlkYTVkNjEwZTdiNjhjMTQuLmY3 OWE5MjY2YTcwMmY0NmYxMTdkNTExMTBiMzJkZTE2ZDQxOTdhYTggMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yNjA1LDggKzI2MDUsMTMgQEAg ZGVmIF9jbGFzc2lmeV9pbmNsdWRlKGZpbGVuYW1lLCBpbmNsdWRlLCBpc19zeXN0ZW0sIGluY2x1 ZGVfc3RhdGUpOgogICAgIGluY2x1ZGVfYmFzZSA9IEZpbGVJbmZvKGluY2x1ZGUpLmJhc2VfbmFt ZSgpCiAKICAgICAjIElmIHdlIGhhdmVuJ3QgZW5jb3VudGVyZWQgYSBwcmltYXJ5IGhlYWRlciwg dGhlbiBiZSBsZW5pZW50IGluIGNoZWNraW5nLgotICAgIGlmIG5vdCBpbmNsdWRlX3N0YXRlLnZp c2l0ZWRfcHJpbWFyeV9zZWN0aW9uKCkgYW5kIHRhcmdldF9iYXNlLmZpbmQoaW5jbHVkZV9iYXNl KSAhPSAtMToKLSAgICAgICAgcmV0dXJuIF9QUklNQVJZX0hFQURFUgorICAgIGlmIG5vdCBpbmNs dWRlX3N0YXRlLnZpc2l0ZWRfcHJpbWFyeV9zZWN0aW9uKCk6CisgICAgICAgIGlmIHRhcmdldF9i YXNlLmZpbmQoaW5jbHVkZV9iYXNlKSAhPSAtMToKKyAgICAgICAgICAgIHJldHVybiBfUFJJTUFS WV9IRUFERVIKKyAgICAgICAgIyBRdCBwcml2YXRlIEFQSXMgdXNlIF9wLmggc3VmZml4LgorICAg ICAgICBpZiBpbmNsdWRlX2Jhc2UuZmluZCh0YXJnZXRfYmFzZSkgIT0gLTEgYW5kIGluY2x1ZGVf YmFzZS5lbmRzd2l0aCgnX3AnKToKKyAgICAgICAgICAgIHJldHVybiBfUFJJTUFSWV9IRUFERVIK KwogICAgICMgSWYgd2UgYWxyZWFkeSBlbmNvdW50ZXJlZCBhIHByaW1hcnkgaGVhZGVyLCBwZXJm b3JtIGEgc3RyaWN0IGNvbXBhcmlzb24uCiAgICAgIyBJbiBjYXNlIHRoZSB0d28gZmlsZW5hbWUg YmFzZXMgYXJlIHRoZSBzYW1lIHRoZW4gdGhlIGFib3ZlIGxlbmllbnQgY2hlY2sKICAgICAjIHBy b2JhYmx5IHdhcyBhIGZhbHNlIHBvc2l0aXZlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQppbmRleCBhZTkwOWNiMTRiZDNm ZjdlNGU1MmQxNjJhOGRmMDUxNjEwZTdiOWM0Li4zMWE4NmM1ZDg4MmNjNjNmMGUyNmFjNTM5MGJm NjFhOTQxYmZmNzI5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMjcwNiw2ICsyNzA2LDExIEBAIGNsYXNzIE9y ZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAgICAg ICAgICAgY2xhc3NpZnlfaW5jbHVkZSgnZm9vLmNwcCcsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnbW9jX2Zvby5jcHAnLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgRmFsc2UsIGluY2x1ZGVfc3RhdGUpKQorICAgICAgICAjIFF0 IHByaXZhdGUgQVBJcyB1c2UgX3AuaCBzdWZmaXguCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwo Y3BwX3N0eWxlLl9QUklNQVJZX0hFQURFUiwKKyAgICAgICAgICAgICAgICAgICAgICAgICBjbGFz c2lmeV9pbmNsdWRlKCdmb28uY3BwJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICdmb29fcC5oJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEZhbHNlLCBpbmNsdWRlX3N0YXRlKSkKICAgICAgICAgIyBUcmlja3kgZXhhbXBsZSB3 aGVyZSBib3RoIGluY2x1ZGVzIG1pZ2h0IGJlIGNsYXNzaWZpZWQgYXMgcHJpbWFyeS4KICAgICAg ICAgc2VsZi5hc3NlcnRfbGFuZ3VhZ2VfcnVsZXNfY2hlY2soJ1Njcm9sbGJhclRoZW1lV2luY2Uu Y3BwJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRl ICJjb25maWcuaCJcbicK