72615 2011-11-17 08:02:56 -0800 Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests 2011-11-17 14:08:22 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 steveblock dpranke abarth dpranke jamesr ojan webkit.review.bot oldest_to_newest 504860 0 steveblock 2011-11-17 08:02:56 -0800 See http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29%28dbg%29%281%29/builds/895 It looks like the test manager script isn't designed to handle only 1 test being run ... 2011-11-17 07:24:10,271 37811 printing.py:462 INFO Preparing tests ... 2011-11-17 07:24:10,271 37811 printing.py:462 INFO Found: 1 tests Traceback (most recent call last): File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 420, in <module> sys.exit(main()) File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 415, in main return run(port, options, args) File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 86, in run result_summary = manager.set_up_run() File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 877, in set_up_run result_summary = self.prepare_lists_and_print_output() File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 514, in prepare_lists_and_print_output skipped = self._split_into_chunks_if_necessary(skipped) File "/b/build/slave/Webkit_Mac10_5__CG__dbg__1_/build/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 426, in _split_into_chunks_if_necessary assert(test_size <= num_tests) AssertionError On Webkit Mac10.5 (CG)(dbg)(1), the problem started some time between build 878 and 891 (WebKit r100341 to r559). It's not clear exactly when because the test_expectations file was broken in this range, causing the test run to fail for other reasons. I suspect this is something to do with the recent changes made by jamesr, regarding not running CG tests on Mac 10.5, but I can't find the change he made. 504945 1 jamesr 2011-11-17 09:59:43 -0800 Note that zero tests should run on the 10.5 bots in webkit_gpu_tests, so we aren't losing any actual coverage here. 504953 2 dpranke 2011-11-17 10:15:53 -0800 Ah, interesting. I can believe we don't have tests for this. Will fix later this morning. 505087 3 115654 dpranke 2011-11-17 12:17:35 -0800 Created attachment 115654 Patch 505088 4 dpranke 2011-11-17 12:19:03 -0800 Okay, for now I'll just run a few more dummy tests, since it's not obvious what the right way to fix things is - should each shard run the same test? etc. Also, it looks like eric refactored that part of the code in a way that's a little weird, so I want to clean it up separately. 505195 5 115654 dpranke 2011-11-17 14:08:18 -0800 Comment on attachment 115654 Patch Clearing flags on attachment: 115654 Committed r100673: <http://trac.webkit.org/changeset/100673> 505196 6 dpranke 2011-11-17 14:08:22 -0800 All reviewed patches have been landed. Closing bug. 115654 2011-11-17 12:17:35 -0800 2011-11-17 14:08:18 -0800 Patch bug-72615-20111117121734.patch text/plain 1597 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNTE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWUyN2I4OWY3OTc4ZDNiNmEyYmNiNmM3MzU2ZmM5MGM1 MDJhOGU5OC4uYjIyMjgyMDNmYzFmNmJjOWVlMDBlMTZlMjYzZGQwYWQ3YzMyZGI5MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTExLTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIENocm9taXVtIE1hYyAxMC41IENHIGRiZyBib3RzIGFyZSBmYWlsaW5nIHRvIHJ1biB3 ZWJraXRfZ3B1X3Rlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03MjYxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9ncHUu cHk6CisKIDIwMTEtMTEtMTYgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbTlJXVF0gc3BlY3VsYXRpdmUgZml4IGZvciBtdWx0aXBsZSBzdWJwcm9jZXNzIHRlc3Qg b24gY3lnd2luCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2dwdS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CmluZGV4IDgzNGMyMDNiMzgzZTdhOGM5Y2I3Yjk4OGU0 MmZhNDY4NTg0ZjhlMmYuLmU4NmI4Yjc1M2VkN2ExYjBjMTg5ZjliNTQ0NjE3YjdkOWRhNjc1OWMg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW1fZ3B1LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvY2hyb21pdW1fZ3B1LnB5CkBAIC05Nyw4ICs5Nyw4IEBAIGRlZiBfdGVzdHMocG9ydCwgcGF0 aHMpOgogICAgICAgICAgICAgIyB0ZXN0cyBvbiB0aGUgYm90cy4gSWYgcGF0aHMgaXMgZW1wdHks IHRlc3RfZmlsZXMuZmluZCgpCiAgICAgICAgICAgICAjIGZpbmRzICpldmVyeXRoaW5nKi4gSG93 ZXZlciwgd2UgaGF2ZSB0byByZXR1cm4gc29tZXRoaW5nLAogICAgICAgICAgICAgIyBvciBOUldU IHRoaW5rcyB0aGVyZSdzIHNvbWV0aGluZyB3cm9uZy4gU28sIHdlIHJldHVybiBhIHNpbmdsZQot ICAgICAgICAgICAgIyBkdW1teSB0ZXN0LiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcyNDk4LgotICAgICAgICAgICAgcGF0aHMgPSBbJ2Zhc3QvaHRtbC9hcnRp Y2xlLWVsZW1lbnQuaHRtbCddCisgICAgICAgICAgICAjIHNob3J0IGRpcmVjdG9yeS4gU2VlIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjQ5OC4KKyAgICAgICAgICAg IHBhdGhzID0gWydmYXN0L2h0bWwnXQogCiAgICAgcmV0dXJuIHNldChbcG9ydC5yZWxhdGl2ZV90 ZXN0X2ZpbGVuYW1lKGYpIGZvciBmIGluIHRlc3RfZmlsZXMuZmluZChwb3J0LCBwYXRocyldKQog Cg==