72613 2011-11-17 07:58:49 -0800 [GTK] plugins/get-url-notify-with-url-that-fails-to-load.html on bots after r100466 2011-11-17 09:49:44 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar danw mrobinson pnormand svillar oldest_to_newest 504853 0 svillar 2011-11-17 07:58:49 -0800 This is the stacktrace: Program terminated with signal 11, Segmentation fault. #0 0x00002b6fa6e01e45 in WebCore::ResourceHandle::platformSetDefersLoading (this=0x3762b20, defersLoading=false) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:751 751 ASSERT(d->m_soupRequest); Thread 1 (Thread 0x2b6fb457d8e0 (LWP 5596)): #0 0x00002b6fa6e01e45 in WebCore::ResourceHandle::platformSetDefersLoading (this=0x3762b20, defersLoading=false) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:751 #1 0x00002b6fa6df78ed in WebCore::ResourceHandle::setDefersLoading (this=0x3762b20, defers=false) at ../../Source/WebCore/platform/network/ResourceHandle.cpp:174 #2 0x00002b6fa6c66977 in WebCore::ResourceLoader::setDefersLoading (this=0x64769c10, defers=false) at ../../Source/WebCore/loader/ResourceLoader.cpp:169 #3 0x00002b6fa6e4f99a in WebCore::PluginStream::destroyStream (this=0x65c5f690) at ../../Source/WebCore/plugins/PluginStream.cpp:301 #4 0x00002b6fa6e4f372 in WebCore::PluginStream::destroyStream (this=0x65c5f690, reason=1) at ../../Source/WebCore/plugins/PluginStream.cpp:234 #5 0x00002b6fa6e504bf in WebCore::PluginStream::didFail (this=0x65c5f690, loader=0x64769c10) at ../../Source/WebCore/plugins/PluginStream.cpp:443 #6 0x00002b6fa6c5cf05 in WebCore::NetscapePlugInStreamLoader::didFail (this=0x64769c10, error=...) at ../../Source/WebCore/loader/NetscapePlugInStreamLoader.cpp:119 #7 0x00002b6fa6c67d3a in WebCore::ResourceLoader::cannotShowURL (this=0x64769c10) at ../../Source/WebCore/loader/ResourceLoader.cpp:480 #8 0x00002b6fa6df7535 in WebCore::ResourceHandle::fireFailure (this=0x3762b20) at ../../Source/WebCore/platform/network/ResourceHandle.cpp:98 #9 0x00002b6fa6df7fa6 in WebCore::Timer<WebCore::ResourceHandle>::fired (this=0x63fa4828) at ../../Source/WebCore/platform/Timer.h:100 504857 1 svillar 2011-11-17 08:00:46 -0800 Will provide a patch soon. Basically recent changes didn't take into account that not handled URL schemes (like foo://) do not generate valid SoupRequest objects. 504918 2 115605 svillar 2011-11-17 09:33:38 -0800 Created attachment 115605 Patch 504921 3 115605 mrobinson 2011-11-17 09:40:38 -0800 Comment on attachment 115605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115605&action=review > Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:751 > + // have risen a failure (for example invalid URLs). We cannot Nit: risen -> raised 504930 4 svillar 2011-11-17 09:49:44 -0800 Committed r100640: <http://trac.webkit.org/changeset/100640> 115605 2011-11-17 09:33:38 -0800 2011-11-17 09:40:38 -0800 Patch bug-72613-20111117183336.patch text/plain 3382 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM3MWYwODFmMjZiM2Rl NmJiMTY2NTg4MmM1ODI4ZTE4NTFlMzIwMi4uOWZlMjZjY2I1OTY1MDc2MTQwZDBhZDcwODE3MWM2 ZWZmYWQxMjM5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTE3ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIHBs dWdpbnMvZ2V0LXVybC1ub3RpZnktd2l0aC11cmwtdGhhdC1mYWlscy10by1sb2FkLmh0bWwgb24g Ym90cyBhZnRlciByMTAwNDY2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MjYxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIERvIG5vdCBhc3N1bWUgdGhhdCBhIFNvdXBSZXF1ZXN0IGFsd2F5cyBleGlzdHMs IGl0IGlzIG5vdAorICAgICAgICBnZW5lcmF0ZWQgZm9yIGV4YW1wbGUgd2hlbiB0aGUgcHJvdmlk ZWQgVVJMIGlzCisgICAgICAgIGludmFsaWQuIFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERl ZmVyc0xvYWRpbmcgd2FzIGNyYXNoaW5nCisgICAgICAgIGJlY2F1c2Ugb2YgdGhhdC4KKworICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9hZGluZyk6 CisKIDIwMTEtMTEtMTYgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbnNwZWN0b3IgZm9sbG93cyBqYXZhc2NyaXB0OiBo cmVmcyBhcyByZWxhdGl2ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBjOGYxMThlMDU2NzE5 YmZkMTFmMTgzMWIzNDlhNjY4ZDA3ZTUwMGVlLi5iYTA4NDQzYmU4ZTVmZjk3ZTI1MDI3NDEzZTg3 YzA5NzhkNDA3Mzc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNzQ3LDggKzc0NywxMSBA QCB2b2lkIFJlc291cmNlSGFuZGxlOjpwbGF0Zm9ybVNldERlZmVyc0xvYWRpbmcoYm9vbCBkZWZl cnNMb2FkaW5nKQogICAgIGlmIChkZWZlcnNMb2FkaW5nKQogICAgICAgICByZXR1cm47CiAKLSAg ICBpZiAoIWhhc0JlZW5TZW50KHRoaXMpKSB7Ci0gICAgICAgIEFTU0VSVChkLT5tX3NvdXBSZXF1 ZXN0KTsKKyAgICAvLyBXZSBuZWVkIHRvIGNoZWNrIGZvciBkLT5tX3NvdXBSZXF1ZXN0IGJlY2F1 c2UgdGhlIHJlcXVlc3QgbWF5CisgICAgLy8gaGF2ZSByaXNlbiBhIGZhaWx1cmUgKGZvciBleGFt cGxlIGludmFsaWQgVVJMcykuIFdlIGNhbm5vdAorICAgIC8vIHNpbXBseSBjaGVjayBmb3IgZC0+ bV9zY2hlZHVsZWRGYWlsdXJlIGJlY2F1c2UgaXQncyBjbGVhcmVkIGFzCisgICAgLy8gc29vbiBh cyB0aGUgZmFpbHVyZSBldmVudCBpcyBmaXJlZC4KKyAgICBpZiAoIWhhc0JlZW5TZW50KHRoaXMp ICYmIGQtPm1fc291cFJlcXVlc3QpIHsKICAgICAgICAgZC0+bV9jYW5jZWxsYWJsZSA9IGFkb3B0 R1JlZihnX2NhbmNlbGxhYmxlX25ldygpKTsKICAgICAgICAgc291cF9yZXF1ZXN0X3NlbmRfYXN5 bmMoZC0+bV9zb3VwUmVxdWVzdC5nZXQoKSwgZC0+bV9jYW5jZWxsYWJsZS5nZXQoKSwgc2VuZFJl cXVlc3RDYWxsYmFjaywgdGhpcyk7CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhOWQ4MzdhMmY5 MzljODI5YzQ5NTI5NWJjNzU5MGI1Y2FhZGY3YTE3Li4xYTAxZjgyOWU3NjZhMTNkZDcwMzRlMDgw NWZhZmNhNTNhMmQwOGIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMTEtMTcgIFNlcmdp byBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gcGx1 Z2lucy9nZXQtdXJsLW5vdGlmeS13aXRoLXVybC10aGF0LWZhaWxzLXRvLWxvYWQuaHRtbCBvbiBi b3RzIGFmdGVyIHIxMDA0NjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTcyNjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgYSB0ZXN0IHRoYXQgdGltZXMgb3V0IGluIFdLMi4KKworICAgICAgICAq IHBsYXRmb3JtL2d0ay13azIvU2tpcHBlZDogYWRkZWQgcGx1Z2lucy9nZXQtdXJsLW5vdGlmeS13 aXRoLXVybC10aGF0LWZhaWxzLXRvLWxvYWQuaHRtbAorCiAyMDExLTExLTE2ICBBbGV4YW5kZXIg UGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog aW5zcGVjdG9yIGZvbGxvd3MgamF2YXNjcmlwdDogaHJlZnMgYXMgcmVsYXRpdmUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvU2tpcHBlZCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay13azIvU2tpcHBlZAppbmRleCA5ZmVjMjRiMDA3YTdmOTg0ZWI2YTExZjU4ZmQy ZTIxNjc1ZDI2ZjNhLi5hYTM5NDY1MTUzMmNlOTcxNTg3ZjMzNDFmNjFhMGYwZjUwZjZlYzA1IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGstd2syL1NraXBwZWQKKysrIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMi9Ta2lwcGVkCkBAIC03NCw2ICs3NCw3IEBAIGVkaXRp bmcvZGVsZXRpbmcvZGVsZXRlLWJ5LXdvcmQtMDAxLmh0bWwKIGVkaXRpbmcvdW5kby91bmRvLWRl bGV0ZVdvcmQuaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkL2VtYWNzLWN0cmwtYS1rLXkuaHRtbAog ZWRpdGluZy9pbnB1dC9lbWFjcy1jdHJsLW8uaHRtbAorcGx1Z2lucy9nZXQtdXJsLW5vdGlmeS13 aXRoLXVybC10aGF0LWZhaWxzLXRvLWxvYWQuaHRtbAogCiAjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj CiAjIFRFU1RTIENSQVNISU5HCg==