72612 2011-11-17 07:58:15 -0800 [Qt][WK2] REGRESSION(100483): It made 2 API tests fail 2011-11-21 13:45:47 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 70236 1 ossy menard hausmann menard ossy vestbo webkit.review.bot zoltan oldest_to_newest 504852 0 ossy 2011-11-17 07:58:15 -0800 FAIL! : qmltests::DesktopWebViewLinkHovered::test_linkHovered() 'wait for signal linkHovered' returned FALSE. () Loc: [/usr/local/Trolltech/Qt5/Qt-5.0.0-r11/imports/QtTest/TestCase.qml(473)] FAIL! : qmltests::DesktopWebViewLinkHovered::test_linkHoveredDoesntEmitRepeated() 'wait for signal linkHovered' returned FALSE. () Loc: [/usr/local/Trolltech/Qt5/Qt-5.0.0-r11/imports/QtTest/TestCase.qml(473)] 507046 1 menard 2011-11-21 09:59:58 -0800 Grab it, I'm on it. 507095 2 116108 menard 2011-11-21 11:19:36 -0800 Created attachment 116108 Patch 507126 3 116108 vestbo 2011-11-21 12:29:05 -0800 Comment on attachment 116108 Patch It should not be necessary for the user of the API to do this themselves. We should fix it in WebKit, not in a test. 507148 4 menard 2011-11-21 12:57:20 -0800 (In reply to comment #3) > (From update of attachment 116108 [details]) > It should not be necessary for the user of the API to do this themselves. We should fix it in WebKit, not in a test. Well QML doesn't have a concept of default focus item... Ok let's say the view as the focus then we need to fix bool QtWebPageProxy::isViewFocused() { return m_qmlWebPage->hasFocus(); } to bool QtWebPageProxy::isViewFocused() { return m_qmlWebView->hasFocus(); } which I did first. 507174 5 116125 menard 2011-11-21 13:29:28 -0800 Created attachment 116125 Patch 507177 6 116125 kenneth 2011-11-21 13:33:56 -0800 Comment on attachment 116125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116125&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:119 > + virtual void focusInEvent(QFocusEvent *); > + virtual void focusOutEvent(QFocusEvent *); wrong coding style 507185 7 menard 2011-11-21 13:45:47 -0800 Committed r100955: <http://trac.webkit.org/changeset/100955> 116108 2011-11-21 11:19:36 -0800 2011-11-21 13:29:21 -0800 Patch bug-72612-20111121131753.patch text/plain 1449 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwOTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmQ0MTI1M2ZkNjJjYzI5 OTE0MzE1ZGMyMGRkOGIzNmRhYTlkMzdhMC4uYzA2YWFhNmNhYThlZTE2NWU3ZDY4YmE1NjYzYWQz ZWI0ZjQ2ODhmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTIxICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF1b V0syXSBSRUdSRVNTSU9OKDEwMDQ4Myk6IEl0IG1hZGUgMiBBUEkgdGVzdHMgZmFpbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI2MTIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdGhlIHBh Z2UgaGFzIHRoZSBmb2N1cyBpbiBvcmRlciBmb3IgV2ViS2l0IHRvIGhhbmRsZSBtb3VzZQorICAg ICAgICBtb3ZlIHByb3Blcmx5LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9x bWx0ZXN0cy9EZXNrdG9wQmVoYXZpb3IvdHN0X2xpbmtIb3ZlcmVkLnFtbDoKKwogMjAxMS0xMS0y MSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9z c2Eub3JnPgogCiAgICAgICAgIFtRdF0gQWRkIFdlYlZpZXcudmlldyBhdHRhY2hlZCBwcm9wZXJ0 eSBzdXBwb3J0IGZvciBkaWFsb2dzIGluIFFNTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wQmVoYXZpb3IvdHN0X2xpbmtI b3ZlcmVkLnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvRGVza3RvcEJlaGF2aW9yL3RzdF9saW5rSG92ZXJlZC5xbWwKaW5kZXggOTk2NzJiZjc5MWUw NDZiMTJhYjFmYmMxNjA1ZGU1NzVkZmQ3YzliZS4uZTRhNzQwNmU5ZTJiNDE3YzRmNGQ0MzU0NmRm N2VkYzQ2NjExNDkwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC90ZXN0cy9xbWx0ZXN0cy9EZXNrdG9wQmVoYXZpb3IvdHN0X2xpbmtIb3ZlcmVkLnFtbAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BC ZWhhdmlvci90c3RfbGlua0hvdmVyZWQucW1sCkBAIC03LDYgKzcsNyBAQCBEZXNrdG9wV2ViVmll dyB7CiAgICAgaWQ6IHdlYlZpZXcKICAgICB3aWR0aDogMjAwCiAgICAgaGVpZ2h0OiA0MDAKKyAg ICBwYWdlLmZvY3VzOiB0cnVlCiAKICAgICBwcm9wZXJ0eSBzdHJpbmcgbGFzdFVybAogICAgIHBy b3BlcnR5IHN0cmluZyBsYXN0VGl0bGUK 116125 2011-11-21 13:29:28 -0800 2011-11-21 13:33:56 -0800 Patch bug-72612-20111121182926.patch text/plain 4267 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwOTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTIzZGQ5Mzg4YmFkMTJi ZmZjMTQxYWU2NDE1ZGM2YjkwZGI5YmZhMC4uZjcwNjFhNDYwNTQ0YmVlOTgyYjdjMzY4YjE3MmU4 YTViY2UxNjhiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDExLTExLTIxICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzLm1lbmFyZEBvcGVuYm9zc2Eub3JnPgogCisgICAgICAgIFtRdF1b V0syXSBSRUdSRVNTSU9OKDEwMDQ4Myk6IEl0IG1hZGUgMiBBUEkgdGVzdHMgZmFpbAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI2MTIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHN1cmUgdGhhdCB3 aGVuIHRoZSB2aWV3IGlzIGZvY3VzZWQsIHRoZSBwYWdlIGtub3dzIGFib3V0IGl0LgorICAgICAg ICBBbHNvIHNldCBhIHRoZSB2aWV3IHRvIGJlIHRoZSBmb2N1c2VkIGl0ZW0gaW4gdGhlIGZhaWxp bmcgdGVzdHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2VfcC5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAg IChRUXVpY2tXZWJWaWV3Ojpmb2N1c0luRXZlbnQpOgorICAgICAgICAoUVF1aWNrV2ViVmlldzo6 Zm9jdXNPdXRFdmVudCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3 X3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BC ZWhhdmlvci90c3RfbGlua0hvdmVyZWQucW1sOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFdl YlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChRdFdlYlBhZ2VQcm94eTo6aXNWaWV3Rm9jdXNlZCk6 CisKKzIwMTEtMTEtMjEgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKICAgICAgICAgW1F0XSBSZW1vdmUgdW5uZWNlc3NhcnkgaW5pdGlhbGl6ZSBtZXRob2Qg ZnJvbSBRUXVpY2tXZWJWaWV3LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzI5MDUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xcXVpY2t3ZWJwYWdlX3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2VicGFnZV9wLmgKaW5kZXggNTdhMDVhODRhYWQxNDQ1OWFjYjBjNDI0NWIxMDgy ODA4NzEzNGQxZi4uNDBkZWExNzVhYWY3MjMxYWZiNzI4MTIwMjgwODNjODE4MDMwM2ZkYiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJwYWdlX3Au aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnBhZ2VfcC5o CkBAIC03Miw2ICs3Miw3IEBAIHByaXZhdGU6CiAgICAgUV9QUklWQVRFX1NMT1QoZCwgdm9pZCBf cV9vblNjZW5lR3JhcGhJbml0aWFsaXplZCgpKTsKIAogICAgIFFRdWlja1dlYlBhZ2VQcml2YXRl KiBkOworICAgIGZyaWVuZCBjbGFzcyBRUXVpY2tXZWJWaWV3OwogICAgIGZyaWVuZCBjbGFzcyBR UXVpY2tXZWJWaWV3UHJpdmF0ZTsKICAgICBmcmllbmQgY2xhc3MgUXRXZWJQYWdlUHJveHk7CiB9 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2 aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5j cHAKaW5kZXggMWE0ODZhYzZkNDU3MGFmNzg1ODI3YzYyMzI3YTlmNmNlN2M4Mzg5Ni4uZjE0NmMy YjU5NTY3NWE4OGNlOTQ2NjU3NGZlMTc4NDY0YmVhMjhiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBAIC02MDMsNiArNjAzLDE4 IEBAIHZvaWQgUVF1aWNrV2ViVmlldzo6Z2VvbWV0cnlDaGFuZ2VkKGNvbnN0IFFSZWN0RiYgbmV3 R2VvbWV0cnksIGNvbnN0IFFSZWN0RiYgb2xkCiAgICAgfQogfQogCit2b2lkIFFRdWlja1dlYlZp ZXc6OmZvY3VzSW5FdmVudChRRm9jdXNFdmVudCogZXZlbnQpCit7CisgICAgUV9EKFFRdWlja1dl YlZpZXcpOworICAgIGQtPnBhZ2VWaWV3LT5ldmVudChldmVudCk7Cit9CisKK3ZvaWQgUVF1aWNr V2ViVmlldzo6Zm9jdXNPdXRFdmVudChRRm9jdXNFdmVudCogZXZlbnQpCit7CisgICAgUV9EKFFR dWlja1dlYlZpZXcpOworICAgIGQtPnBhZ2VWaWV3LT5ldmVudChldmVudCk7Cit9CisKIHZvaWQg UVF1aWNrV2ViVmlldzo6dG91Y2hFdmVudChRVG91Y2hFdmVudCogZXZlbnQpCiB7CiAgICAgZm9y Y2VBY3RpdmVGb2N1cygpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlld19wLmgKaW5kZXggNWVhYjc1YWU5ZTAwN2NjZWJlZGNiYTFhNDAwMjZkNDM2 OGQzYmQ5MS4uMjU0MTA0YzQ3ZWMxYmNiMDhlOWZlYzcyNGM0ZGJkOTIyNjdkNWFjYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oCkBA IC0xMTUsNiArMTE1LDggQEAgUV9TSUdOQUxTOgogCiBwcm90ZWN0ZWQ6CiAgICAgdmlydHVhbCB2 b2lkIGdlb21ldHJ5Q2hhbmdlZChjb25zdCBRUmVjdEYmLCBjb25zdCBRUmVjdEYmKTsKKyAgICB2 aXJ0dWFsIHZvaWQgZm9jdXNJbkV2ZW50KFFGb2N1c0V2ZW50ICopOworICAgIHZpcnR1YWwgdm9p ZCBmb2N1c091dEV2ZW50KFFGb2N1c0V2ZW50ICopOwogICAgIHZpcnR1YWwgdm9pZCB0b3VjaEV2 ZW50KFFUb3VjaEV2ZW50KiBldmVudCk7CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BCZWhhdmlvci90 c3RfbGlua0hvdmVyZWQucW1sIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0 cy9xbWx0ZXN0cy9EZXNrdG9wQmVoYXZpb3IvdHN0X2xpbmtIb3ZlcmVkLnFtbAppbmRleCA5OTY3 MmJmNzkxZTA0NmIxMmFiMWZiYzE2MDVkZTU3NWRmZDdjOWJlLi5lYTM4YWM4ZmZhZjAxMDdmYmI1 MDQ2MTEwMDkwYTk1ODg2MzM3YzVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL0Rlc2t0b3BCZWhhdmlvci90c3RfbGlua0hvdmVyZWQu cW1sCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMv RGVza3RvcEJlaGF2aW9yL3RzdF9saW5rSG92ZXJlZC5xbWwKQEAgLTcsNiArNyw3IEBAIERlc2t0 b3BXZWJWaWV3IHsKICAgICBpZDogd2ViVmlldwogICAgIHdpZHRoOiAyMDAKICAgICBoZWlnaHQ6 IDQwMAorICAgIGZvY3VzOiB0cnVlCiAKICAgICBwcm9wZXJ0eSBzdHJpbmcgbGFzdFVybAogICAg IHByb3BlcnR5IHN0cmluZyBsYXN0VGl0bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv cXQvUXRXZWJQYWdlUHJveHkuY3BwCmluZGV4IDUzN2I1YTY5NDNkYjI4MDExMTM4ZWQ2MWY5Zjll YTRkOGJhMjc0NWUuLjYzZGU0ZTJlNmNkMGQ0MmI0NzVhZDcwZmZhZTZiMzFjZGQxMTdiNzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVByb3h5LmNwcApAQCAt NDkzLDcgKzQ5Myw3IEBAIGJvb2wgUXRXZWJQYWdlUHJveHk6OmlzVmlld1dpbmRvd0FjdGl2ZSgp CiAKIGJvb2wgUXRXZWJQYWdlUHJveHk6OmlzVmlld0ZvY3VzZWQoKQogewotICAgIHJldHVybiBt X3FtbFdlYlBhZ2UtPmhhc0ZvY3VzKCk7CisgICAgcmV0dXJuIG1fcW1sV2ViVmlldy0+aGFzRm9j dXMoKTsKIH0KIAogYm9vbCBRdFdlYlBhZ2VQcm94eTo6aXNWaWV3VmlzaWJsZSgpCg==