72602 2011-11-17 04:54:12 -0800 [Qt] REGRESSION(r100510): Enable 8 Bit Strings in JavaScriptCore 2011-11-17 23:44:22 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 loki msaboff ggaren msaboff ossy zherczeg oldest_to_newest 504759 0 loki 2011-11-17 04:54:12 -0800 Four tests were broken after http://trac.webkit.org/changeset/100510 The pretty diff can be see at bug 71337 or http://build.webkit.org/results/Qt%20Linux%20Release/r100512%20(39877)/results.html Those tests are using several Unicode characters and the FindString function. The tests will be skipped until a fix. 504766 1 loki 2011-11-17 05:05:43 -0800 The tests were skipped in http://trac.webkit.org/changeset/100608 504923 2 msaboff 2011-11-17 09:41:13 -0800 These tests work fine on Mac. The problem appears to be in WebCore/editing/TextIterator.cpp when WTF_USE_ICU_UNICODE is 0. Continuing to investigate. 505049 3 115643 msaboff 2011-11-17 11:51:42 -0800 Created attachment 115643 Proposed Patch I debugged and fixed this issue on a Mac by locally disabling WTF_USE_ICU_UNICODE in WebCore/editing/TextIterator.cpp. The proposed patch fixed the issues, but the expected results for the impacted tests as well as a few others are different on Mac than on qt. Therefore I'd like someone working on qt to verify that this does fix the test failures in a qt build. 505125 4 loki 2011-11-17 13:01:03 -0800 > Created an attachment (id=115643) [details] You are great! I can confirm that the patch fixes those tests. Thank you very much! 505128 5 msaboff 2011-11-17 13:05:29 -0800 (In reply to comment #4) > > Created an attachment (id=115643) [details] [details] > > You are great! I can confirm that the patch fixes those tests. > Thank you very much! Do you want me to add the changes to relabel the skipped tests? 505199 6 loki 2011-11-17 14:10:21 -0800 If you have time to create another patch which relabels those tests as well, please do it. Otherwise I will take care of them tomorrow. Thanks again! 505535 7 115643 zherczeg 2011-11-17 23:23:36 -0800 Comment on attachment 115643 Proposed Patch rs=me 505541 8 115643 loki 2011-11-17 23:43:20 -0800 Comment on attachment 115643 Proposed Patch Landed in http://trac.webkit.org/changeset/100729 505542 9 loki 2011-11-17 23:44:22 -0800 The tests are enabled in http://trac.webkit.org/changeset/100730 115643 2011-11-17 11:51:42 -0800 2011-11-17 23:43:20 -0800 Proposed Patch 72602.patch text/plain 3844 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwNjUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDExLTExLTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFtRdF0gUkVHUkVTU0lPTihyMTAwNTEwKTogRW5hYmxlIDggQml0IFN0cmluZ3MgaW4gSmF2 YVNjcmlwdENvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcyNjAyCisKKyAgICAgICAgRml4ZWQgU3RyaW5nSW1wbDo6Zm9sZENhc2UgYnkgYWRkaW5n IHJldHVybiBpbiB0aGUgY2FzZSB3ZSBuZWVkIHRvIGhhbmRsZQorICAgICAgICBmb2xkaW5nIG9m IDggYml0IHN0cmluZ3Mgd2l0aCBMYXRpbi0xIGNoYXJhY3RlcnMuCisKKyAgICAgICAgRml4ZWQg Y2FzZSB3aGVyZSBTdHJpbmdJbXBsOjpyZXBsYWNlIHdhcyB1c2luZyBhIGNoYXIgdGVtcCBpbnN0 ZWFkIG9mIGFuCisgICAgICAgIExDaGFyIHRlbXAuCisKKyAgICAgICAgQmVjYXVzZSBvZiB0aGUg c2Vjb25kIGNoYW5nZSwgSSBjaGFuZ2VkIG90aGVyIHVzZXMgb2YgY2hhciBvcgorICAgICAgICB1 bnNpZ25lZCBjaGFyIHRvIExDaGFyLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXVEY6 OlN0cmluZ0ltcGw6OnVwcGVyKToKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6Zm9sZENhc2Up OgorICAgICAgICAoV1RGOjplcXVhbCk6CisgICAgICAgIChXVEY6OmVxdWFsSWdub3JpbmdDYXNl KToKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6cmVwbGFjZSk6CisKIDIwMTEtMTEtMTUgIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBDb2RlIGJsb2NrIGpldHRp c29uaW5nIHNob3VsZCBiZSBwYXJ0IG9mIHRoZSBHQydzIHRyYW5zaXRpdmUgY2xvc3VyZQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAkocmV2 aXNpb24gMTAwNjMyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0lt cGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjQsOSArMzY0LDkgQEAgUGFzc1JlZlB0cjxTdHJp bmdJbXBsPiBTdHJpbmdJbXBsOjp1cHBlcgogICAgICAgICBSZWZQdHI8U3RyaW5nSW1wbD4gbmV3 SW1wbCA9IGNyZWF0ZVVuaW5pdGlhbGl6ZWQobV9sZW5ndGgsIGRhdGE4KTsKICAgICAgICAgCiAg ICAgICAgIC8vIERvIGEgZmFzdGVyIGxvb3AgZm9yIHRoZSBjYXNlIHdoZXJlIGFsbCB0aGUgY2hh cmFjdGVycyBhcmUgQVNDSUkuCi0gICAgICAgIGNoYXIgb3JlZCA9IDA7CisgICAgICAgIExDaGFy IG9yZWQgPSAwOwogICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7Ci0g ICAgICAgICAgICBjaGFyIGMgPSBtX2RhdGE4W2ldOworICAgICAgICAgICAgTENoYXIgYyA9IG1f ZGF0YThbaV07CiAgICAgICAgICAgICBvcmVkIHw9IGM7CiAgICAgICAgICAgICBkYXRhOFtpXSA9 IHRvQVNDSUlVcHBlcihjKTsKICAgICAgICAgfQpAQCAtNDQ5LDYgKzQ0OSw4IEBAIFBhc3NSZWZQ dHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Zm9sZEMKICAgICAgICAgLy8gRG8gYSBzbG93ZXIg aW1wbGVtZW50YXRpb24gZm9yIGNhc2VzIHRoYXQgaW5jbHVkZSBub24tQVNDSUkgTGF0aW4tMSBj aGFyYWN0ZXJzLgogICAgICAgICBmb3IgKGludDMyX3QgaSA9IDA7IGkgPCBsZW5ndGg7IGkrKykK ICAgICAgICAgICAgIGRhdGFbaV0gPSBzdGF0aWNfY2FzdDxMQ2hhcj4oVW5pY29kZTo6dG9Mb3dl cihtX2RhdGE4W2ldKSk7CisKKyAgICAgICAgcmV0dXJuIG5ld0ltcGwucmVsZWFzZSgpOwogICAg IH0KIAogICAgIC8vIERvIGEgZmFzdGVyIGxvb3AgZm9yIHRoZSBjYXNlIHdoZXJlIGFsbCB0aGUg Y2hhcmFjdGVycyBhcmUgQVNDSUkuCkBAIC03MTMsNyArNzE1LDcgQEAgc3RhdGljIGJvb2wgZXF1 YWwoY29uc3QgVUNoYXIqIGEsIGNvbnN0IAogewogICAgIEFTU0VSVChsZW5ndGggPj0gMCk7CiAg ICAgd2hpbGUgKGxlbmd0aC0tKSB7Ci0gICAgICAgIHVuc2lnbmVkIGNoYXIgYmMgPSAqYisrOwor ICAgICAgICBMQ2hhciBiYyA9ICpiKys7CiAgICAgICAgIGlmICgqYSsrICE9IGJjKQogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KQEAgLTcyMyw3ICs3MjUsNyBAQCBzdGF0aWMgYm9v bCBlcXVhbChjb25zdCBVQ2hhciogYSwgY29uc3QgCiBib29sIGVxdWFsSWdub3JpbmdDYXNlKGNv bnN0IFVDaGFyKiBhLCBjb25zdCBMQ2hhciogYiwgdW5zaWduZWQgbGVuZ3RoKQogewogICAgIHdo aWxlIChsZW5ndGgtLSkgewotICAgICAgICB1bnNpZ25lZCBjaGFyIGJjID0gKmIrKzsKKyAgICAg ICAgTENoYXIgYmMgPSAqYisrOwogICAgICAgICBpZiAoZm9sZENhc2UoKmErKykgIT0gZm9sZENh c2UoYmMpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KQEAgLTEwNDksNyArMTA1 MSw3IEBAIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6cmVwbGEKICAgICAgICAg ICAgIFJlZlB0cjxTdHJpbmdJbXBsPiBuZXdJbXBsID0gY3JlYXRlVW5pbml0aWFsaXplZChtX2xl bmd0aCwgZGF0YSk7CiAKICAgICAgICAgICAgIGZvciAoaSA9IDA7IGkgIT0gbV9sZW5ndGg7ICsr aSkgewotICAgICAgICAgICAgICAgIGNoYXIgY2ggPSBtX2RhdGE4W2ldOworICAgICAgICAgICAg ICAgIExDaGFyIGNoID0gbV9kYXRhOFtpXTsKICAgICAgICAgICAgICAgICBpZiAoY2ggPT0gb2xk Q2hhcikKICAgICAgICAgICAgICAgICAgICAgY2ggPSBuZXdDaGFyOwogICAgICAgICAgICAgICAg IGRhdGFbaV0gPSBjaDsKQEAgLTEzODYsOCArMTM4OCw4IEBAIGJvb2wgZXF1YWwoY29uc3QgU3Ry aW5nSW1wbCogYSwgY29uc3QgTEMKICAgICBpZiAoYS0+aXM4Qml0KCkpIHsKICAgICAgICAgY29u c3QgTENoYXIqIGFQdHIgPSBhLT5jaGFyYWN0ZXJzOCgpOwogICAgICAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpICE9IGxlbmd0aDsgKytpKSB7Ci0gICAgICAgICAgICB1bnNpZ25lZCBjaGFyIGJj ID0gYltpXTsKLSAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIgYWMgPSBhUHRyW2ldOworICAgICAg ICAgICAgTENoYXIgYmMgPSBiW2ldOworICAgICAgICAgICAgTENoYXIgYWMgPSBhUHRyW2ldOwog ICAgICAgICAgICAgaWYgKCFiYykKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg ICAgICAgICBpZiAoYWMgIT0gYmMpCkBAIC0xMzk5LDcgKzE0MDEsNyBAQCBib29sIGVxdWFsKGNv bnN0IFN0cmluZ0ltcGwqIGEsIGNvbnN0IExDCiAKICAgICBjb25zdCBVQ2hhciogYVB0ciA9IGEt PmNoYXJhY3RlcnMxNigpOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgIT0gbGVuZ3RoOyAr K2kpIHsKLSAgICAgICAgdW5zaWduZWQgY2hhciBiYyA9IGJbaV07CisgICAgICAgIExDaGFyIGJj ID0gYltpXTsKICAgICAgICAgaWYgKCFiYykKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAg ICAgICAgaWYgKGFQdHJbaV0gIT0gYmMpCg==