72601 2011-11-17 04:51:56 -0800 [GTK] enable ref tests 2011-11-17 15:01:40 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned abarth ojan webkit.review.bot oldest_to_newest 504757 0 pnormand 2011-11-17 04:51:56 -0800 They were disabled in bug 72599 505023 1 115635 zan 2011-11-17 11:40:25 -0800 Created attachment 115635 Patch This is a small hack, adding 20 to the display number when the driver is also doing the pixel tests. It theoretically works as long as the number of workers is below 20, so feel free to advise on what to actually do to make this bullet-proof. The basic idea is for each driver to have its own Xvfb process up and running. This is the reason of the flakiness that caused bug #72599 to disable the ref tests. 505050 2 115635 tony 2011-11-17 11:51:48 -0800 Comment on attachment 115635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115635&action=review Thanks for tracking this down! > Tools/Scripts/webkitpy/layout_tests/port/gtk.py:53 > + if self._pixel_tests: > + display_id += 20 We have machines with 24 cores. Instead of adding a constant, we could have: display_id = (self._worker_number + 1) * 2 if self._pixel_tests: display_id += 1 505071 3 115649 zan 2011-11-17 12:08:05 -0800 Created attachment 115649 Patch Thanks for the review! Rather used 'self._worker_number * 2 + 1', just to number the displays from 1 onwards. 505083 4 115649 tony 2011-11-17 12:15:44 -0800 Comment on attachment 115649 Patch Thanks! 505259 5 115649 webkit.review.bot 2011-11-17 15:01:35 -0800 Comment on attachment 115649 Patch Clearing flags on attachment: 115649 Committed r100683: <http://trac.webkit.org/changeset/100683> 505261 6 webkit.review.bot 2011-11-17 15:01:40 -0800 All reviewed patches have been landed. Closing bug. 115635 2011-11-17 11:40:25 -0800 2011-11-17 12:07:50 -0800 Patch bug-72601-20111117204023.patch text/plain 2847 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNjA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTJjYWU5NTM5NTAyMzk0OTZkNmRiODZjM2FlOWFhOTY0 MDc3NTM2ZC4uNWQ3OTdhZjAwMTYyNDJhMDY5ODM1YmRhMWY0YTY1YThhZDVhMzA1MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDExLTExLTE3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0dUS10gZW5hYmxlIHJlZiB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI2MDEKKworICAgICAgICBSZS1lbmFibGUgcmVmIHRl c3RzLiBBZGQgYWRkaXRpb25hbCBvZmZzZXQgdG8gdGhlIGRpc3BsYXkgbnVtYmVyIGZvciBYdmZi CisgICAgICAgIHdoZW4gcGl4ZWwgdGVzdHMgYXJlIG5lZWRlZCwgYnV0IG5vdCBlbmFibGVkIChl LmcuIHdoZW4gdGVzdGluZyByZWYgdGVzdHMpLgorICAgICAgICBJZiB0aGF0J3MgdGhlIGNhc2Us IERyaXZlclByb3h5IGNyZWF0ZXMgdHdvIGRyaXZlcnMsIG9uZSBmb3Igbm9ybWFsIGFuZCBvbmUK KyAgICAgICAgZm9yIHJlZiB0ZXN0cy4gVGhleSBib3RoIGhhdmUgc2FtZSB3b3JrZXIgbnVtYmVy LCBidXQgc2hvdWxkIHJlYWxseSBiZSB1c2luZworICAgICAgICBkaWZmZXJlbnQgWHZmYiBpbnN0 YW5jZXMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weTogQWxzbyBzZXQgWHZm YiB2YXJpYWJsZSB0byBOb25lCisgICAgICAgIGFmdGVyIHRoZSBwcm9jZXNzIGlzIGtpbGxlZAor CiAyMDExLTExLTE3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBEaXNhYmxlIHJlZiB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weQppbmRleCAzYWQwYWJiZTc3ODEyYjQwYTVmZWZj MWM4NDM4ODFhMTY1MzU1Yjk4Li5iNDIwZTgwOTdkOWYyYWRlMTQyZTNlZTIwYzk1YzJjOGQ4NmFl YTM1IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2d0ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0 ay5weQpAQCAtNDYsNiArNDYsMTEgQEAgX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9f KQogY2xhc3MgR3RrRHJpdmVyKFdlYktpdERyaXZlcik6CiAgICAgZGVmIF9zdGFydChzZWxmKToK ICAgICAgICAgZGlzcGxheV9pZCA9IHNlbGYuX3dvcmtlcl9udW1iZXIgKyAxCisgICAgICAgICMg QWRkIGFkZGl0aW9uYWwgb2Zmc2V0IHdoZW4gcGl4ZWwgdGVzdHMgYXJlIG5lZWRlZC4gVGhpcyBp cyBuZWVkZWQgd2hlbiByZWYgdGVzdHMgYXJlIGVuYWJsZWQgYnV0IHBpeGVsIHRlc3RzCisgICAg ICAgICMgYXJlIG5vdCwgYXMgdGhlIERyaXZlclByb3h5IGNyZWF0ZXMgdHdvIGRyaXZlcnMsIG9u ZSBmb3Igbm9ybWFsIGFuZCBvbmUgZm9yIHJlZiB0ZXN0cy4gVGhleSBoYXZlIHRoZSBzYW1lIHdv cmtlciBudW1iZXIsCisgICAgICAgICMgYnV0IHNob3VsZG4ndCByZWFsbHkgYmUgdXNpbmcgdGhl IHNhbWUgWHZmYiBpbnN0YW5jZS4gTm90ZSB0aGF0IGhpcyBtYXkgYmVjb21lIGFuIGlzc3VlIHdo ZW4gbW9yZSB0aGFuIDIwIGRyaXZlcnMgYXJlIHVzZWQuCisgICAgICAgIGlmIHNlbGYuX3BpeGVs X3Rlc3RzOgorICAgICAgICAgICAgZGlzcGxheV9pZCArPSAyMAogICAgICAgICBydW5feHZmYiA9 IFsiWHZmYiIsICI6JWQiICUgKGRpc3BsYXlfaWQpLCAiLXNjcmVlbiIsICAiMCIsICI4MDB4NjAw eDI0IiwgIi1ub2xpc3RlbiIsICJ0Y3AiXQogICAgICAgICB3aXRoIG9wZW4ob3MuZGV2bnVsbCwg J3cnKSBhcyBkZXZudWxsOgogICAgICAgICAgICAgc2VsZi5feHZmYl9wcm9jZXNzID0gc3VicHJv Y2Vzcy5Qb3BlbihydW5feHZmYiwgc3RkZXJyPWRldm51bGwpCkBAIC02MSw2ICs2Niw3IEBAIGNs YXNzIEd0a0RyaXZlcihXZWJLaXREcml2ZXIpOgogICAgICAgICAgICAgIyBGSVhNRTogVGhpcyBz aG91bGQgdXNlIEV4ZWN1dGl2ZS5raWxsX3Byb2Nlc3MKICAgICAgICAgICAgIG9zLmtpbGwoc2Vs Zi5feHZmYl9wcm9jZXNzLnBpZCwgc2lnbmFsLlNJR1RFUk0pCiAgICAgICAgICAgICBzZWxmLl94 dmZiX3Byb2Nlc3Mud2FpdCgpCisgICAgICAgICAgICBzZWxmLl94dmZiX3Byb2Nlc3MgPSBOb25l CiAKIAogY2xhc3MgR3RrUG9ydChXZWJLaXRQb3J0KToKQEAgLTY4LDExICs3NCw2IEBAIGNsYXNz IEd0a1BvcnQoV2ViS2l0UG9ydCk6CiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgaG9zdCwgKipr d2FyZ3MpOgogICAgICAgICBXZWJLaXRQb3J0Ll9faW5pdF9fKHNlbGYsIGhvc3QsICoqa3dhcmdz KQotCi0gICAgICAgICMgRklYTUU6IERpc2FibGUgcmVmIHRlc3RzIGZvciBub3csIHRoZXkgbWFr ZSB0aGUgYnVpbGRib3RzIHZlcnkgZmxha3kgOigKLSAgICAgICAgIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI2MDEKLSAgICAgICAgc2VsZi5zZXRfb3B0aW9uX2Rl ZmF1bHQoIm5vX3JlZl90ZXN0cyIsIFRydWUpCi0KICAgICAgICAgc2VsZi5fdmVyc2lvbiA9IHNl bGYucG9ydF9uYW1lCiAKICAgICBkZWYgX3BvcnRfZmxhZ19mb3Jfc2NyaXB0cyhzZWxmKToK 115649 2011-11-17 12:08:05 -0800 2011-11-17 15:01:35 -0800 Patch bug-72601-20111117210803.patch text/plain 2689 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNjA3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTJjYWU5NTM5NTAyMzk0OTZkNmRiODZjM2FlOWFhOTY0 MDc3NTM2ZC4uY2RkY2VlYmQ2MWYzNThhMGQzMWNkNWZjOTkxZmIzMWU0ODQ2YjhlYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDExLTExLTE3ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW0dUS10gZW5hYmxlIHJlZiB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI2MDEKKworICAgICAgICBSZS1lbmFibGUgcmVmIHRl c3RzLiBSdW4gdGhlIGRyaXZlciB1bmRlciBldmVubHkgbnVtYmVyZWQgZGlzcGxheSBpZiBwZXJm b3JtaW5nCisgICAgICAgIHBpeGVsIHRlc3RzIG9yIHVuZGVyIG9kZGx5IG51bWJlcmVkIGRpc3Bs YXkgb3RoZXJ3aXNlLiBUaGlzIHByZXZlbnRzIHRoZSByZWYgdGVzdHMKKyAgICAgICAgYmVpbmcg cnVuIGluIGFuIGFscmVhZHkgdXNlZCBYdmZiIGluc3RhbmNlIGlmIHBpeGVsIHRlc3RzIGFyZSBk aXNhYmxlZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5OiBBbHNvIHNldCBY dmZiIHZhcmlhYmxlIHRvIE5vbmUKKyAgICAgICAgYWZ0ZXIgdGhlIHByb2Nlc3MgaXMga2lsbGVk CisKIDIwMTEtMTEtMTcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtHVEtdIERpc2FibGUgcmVmIHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5CmluZGV4IDNhZDBhYmJlNzc4MTJiNDBhNWZl ZmMxYzg0Mzg4MWExNjUzNTViOTguLjdmODBjYTEzNTQzZGUwZjA2OTdmMzlhNDAyNWNhM2U2MTY0 ZjJhNjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvZ3RrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Z3RrLnB5CkBAIC00NSw3ICs0NSwxMiBAQCBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1l X18pCiAKIGNsYXNzIEd0a0RyaXZlcihXZWJLaXREcml2ZXIpOgogICAgIGRlZiBfc3RhcnQoc2Vs Zik6Ci0gICAgICAgIGRpc3BsYXlfaWQgPSBzZWxmLl93b3JrZXJfbnVtYmVyICsgMQorICAgICAg ICAjIFVzZSBldmVuIGRpc3BsYXlzIGZvciBwaXhlbCB0ZXN0cyBhbmQgb2RkIG9uZXMgb3RoZXJ3 aXNlLiBXaGVuIHBpeGVsIHRlc3RzIGFyZSBkaXNhYmxlZCwKKyAgICAgICAgIyBEcml2ZXJQcm94 eSBjcmVhdGVzIHR3byBkcml2ZXJzLCBvbmUgZm9yIG5vcm1hbCBhbmQgdGhlIG90aGVyIGZvciBy ZWYgdGVzdHMuIEJvdGggaGF2ZQorICAgICAgICAjIHRoZSBzYW1lIHdvcmtlciBudW1iZXIsIHNv IHRoaXMgcHJldmVudHMgdGhlbSBmcm9tIHVzaW5nIHRoZSBzYW1lIFh2ZmIgaW5zdGFuY2UuCisg ICAgICAgIGRpc3BsYXlfaWQgPSBzZWxmLl93b3JrZXJfbnVtYmVyICogMiArIDEKKyAgICAgICAg aWYgc2VsZi5fcGl4ZWxfdGVzdHM6CisgICAgICAgICAgICBkaXNwbGF5X2lkICs9IDEKICAgICAg ICAgcnVuX3h2ZmIgPSBbIlh2ZmIiLCAiOiVkIiAlIChkaXNwbGF5X2lkKSwgIi1zY3JlZW4iLCAg IjAiLCAiODAweDYwMHgyNCIsICItbm9saXN0ZW4iLCAidGNwIl0KICAgICAgICAgd2l0aCBvcGVu KG9zLmRldm51bGwsICd3JykgYXMgZGV2bnVsbDoKICAgICAgICAgICAgIHNlbGYuX3h2ZmJfcHJv Y2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4ocnVuX3h2ZmIsIHN0ZGVycj1kZXZudWxsKQpAQCAtNjEs NiArNjYsNyBAQCBjbGFzcyBHdGtEcml2ZXIoV2ViS2l0RHJpdmVyKToKICAgICAgICAgICAgICMg RklYTUU6IFRoaXMgc2hvdWxkIHVzZSBFeGVjdXRpdmUua2lsbF9wcm9jZXNzCiAgICAgICAgICAg ICBvcy5raWxsKHNlbGYuX3h2ZmJfcHJvY2Vzcy5waWQsIHNpZ25hbC5TSUdURVJNKQogICAgICAg ICAgICAgc2VsZi5feHZmYl9wcm9jZXNzLndhaXQoKQorICAgICAgICAgICAgc2VsZi5feHZmYl9w cm9jZXNzID0gTm9uZQogCiAKIGNsYXNzIEd0a1BvcnQoV2ViS2l0UG9ydCk6CkBAIC02OCwxMSAr NzQsNiBAQCBjbGFzcyBHdGtQb3J0KFdlYktpdFBvcnQpOgogCiAgICAgZGVmIF9faW5pdF9fKHNl bGYsIGhvc3QsICoqa3dhcmdzKToKICAgICAgICAgV2ViS2l0UG9ydC5fX2luaXRfXyhzZWxmLCBo b3N0LCAqKmt3YXJncykKLQotICAgICAgICAjIEZJWE1FOiBEaXNhYmxlIHJlZiB0ZXN0cyBmb3Ig bm93LCB0aGV5IG1ha2UgdGhlIGJ1aWxkYm90cyB2ZXJ5IGZsYWt5IDooCi0gICAgICAgICMgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNjAxCi0gICAgICAgIHNlbGYu c2V0X29wdGlvbl9kZWZhdWx0KCJub19yZWZfdGVzdHMiLCBUcnVlKQotCiAgICAgICAgIHNlbGYu X3ZlcnNpb24gPSBzZWxmLnBvcnRfbmFtZQogCiAgICAgZGVmIF9wb3J0X2ZsYWdfZm9yX3Njcmlw dHMoc2VsZik6Cg==