72592 2011-11-17 03:21:45 -0800 [GTK] ATK API tests failing because of patch for bug 72390 2011-11-17 03:47:45 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned pnormand oldest_to_newest 504707 0 mario 2011-11-17 03:21:45 -0800 The following errors have been observed in the GTK bots after applying the patches for bug 72390: TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatk... (pid=1726) ** ERROR:../../Source/WebKit/gtk/tests/testatk.c:1628:testWebkitAtkParentForRootObject: assertion failed (atk_object_get_n_accessible_children(axBox) == 1): (0 == 1) The problem here is that the get_n_accessible_children() line shouldn't be placed there but, in any case, after the ref_child() (in the followin line), so it's 100% sure the parent object will report the right number of children (atkobjects are lazyly created). Actually it shouldn't be there at all since it's not actually needed for the functionality that is being tested, so I'd rather remove it. TEST: /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/unittests/testatkroles... (pid=1735) ** ERROR:../../Source/WebKit/gtk/tests/testatkroles.c:106:test_webkit_atk_get_role_document_frame: assertion failed: (fixture->role == ATK_ROLE_DOCUMENT_FRAME) The problem here is that I missed to adapt testatkroles.c to properly find the document frame (which is no longer the root object in the hierarchy), so this will need a patch to reflect the shift in the hierarchy. 504709 1 115554 mario 2011-11-17 03:26:35 -0800 Created attachment 115554 Patch proposal 504713 2 115554 pnormand 2011-11-17 03:39:43 -0800 Comment on attachment 115554 Patch proposal Looks good! 504716 3 mario 2011-11-17 03:47:45 -0800 Committed r100596: <http://trac.webkit.org/changeset/100596> 115554 2011-11-17 03:26:35 -0800 2011-11-17 03:39:43 -0800 Patch proposal 0001-2011-11-17-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3977 mario RnJvbSBlNzQ3ZDI3ZWY5ZWU2NzI2MDIwMTQ3OTNmOGZlZDg4MTczZWVjODA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDE3IE5vdiAyMDExIDEyOjI1OjQzICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0xMS0xNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIEFUSyBBUEkgdGVzdHMgZmFpbGluZyBiZWNhdXNlIG9mIHBhdGNoIGZv ciBidWcgNzIzOTAKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzI1OTIKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICog dGVzdHMvdGVzdGF0ay5jOgogICAgICAgICh0ZXN0V2Via2l0QXRrUGFyZW50Rm9yUm9vdE9iamVj dCk6IFJlbW92ZSB0aGUgb2ZmZW5kaW5nIGxpbmUgaW4KICAgICAgICB0aGUgdW5pdCB0ZXN0LCB3 aGljaCBpcyBub3QgYWN0dWFsbHkgcmVxdWlyZWQgdG8gdGVzdCB0aGUgbmV3CiAgICAgICAgZnVu Y3Rpb25hbGl0eSBhbmQgY2F1c2VzIHByb2JsZW1zIGluIHNvbWUgc2NlbmFyaW9zLCBkdWUgdG8g dGhlCiAgICAgICAgbGF6eSBjcmVhdGlvbiBtZWNoYW5pc20gb2YgQXRrT2JqZWN0cy4KCiAgICAg ICAgKiB0ZXN0cy90ZXN0YXRrcm9sZXMuYzoKICAgICAgICAoZmluaXNoX2xvYWRpbmcpOiBSZWZs ZWN0IHRoYXQgdGhlIGRvY3VtZW50IGZyYW1lIG9iamVjdCBpcyBubwogICAgICAgIGxvbmdlciB0 aGUgcm9vdCBhY2Nlc3NpYmlsaXR5IG9iamVjdCAoYSBzY3JvbGwgcGFuZSBmcm9tIG5vdyBvbiks CiAgICAgICAgYnV0IHRoZSBvbmx5IGNoaWxkIG9mIHRoYXQgb25lLiBUaHVzLCBza2lwIHRoYXQg cm9vdCBvYmplY3QuCi0tLQogU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAg fCAgIDE4ICsrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0 ay5jICAgICAgfCAgICAxIC0KIFNvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGtyb2xlcy5j IHwgICAxMiArKysrKysrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggZTBiOWVhYS4uZDYyNzA2MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTExLTE3ICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBVEsgQVBJIHRl c3RzIGZhaWxpbmcgYmVjYXVzZSBvZiBwYXRjaCBmb3IgYnVnIDcyMzkwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU5MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvdGVzdGF0ay5jOgorICAg ICAgICAodGVzdFdlYmtpdEF0a1BhcmVudEZvclJvb3RPYmplY3QpOiBSZW1vdmUgdGhlIG9mZmVu ZGluZyBsaW5lIGluCisgICAgICAgIHRoZSB1bml0IHRlc3QsIHdoaWNoIGlzIG5vdCBhY3R1YWxs eSByZXF1aXJlZCB0byB0ZXN0IHRoZSBuZXcKKyAgICAgICAgZnVuY3Rpb25hbGl0eSBhbmQgY2F1 c2VzIHByb2JsZW1zIGluIHNvbWUgc2NlbmFyaW9zLCBkdWUgdG8gdGhlCisgICAgICAgIGxhenkg Y3JlYXRpb24gbWVjaGFuaXNtIG9mIEF0a09iamVjdHMuCisKKyAgICAgICAgKiB0ZXN0cy90ZXN0 YXRrcm9sZXMuYzoKKyAgICAgICAgKGZpbmlzaF9sb2FkaW5nKTogUmVmbGVjdCB0aGF0IHRoZSBk b2N1bWVudCBmcmFtZSBvYmplY3QgaXMgbm8KKyAgICAgICAgbG9uZ2VyIHRoZSByb290IGFjY2Vz c2liaWxpdHkgb2JqZWN0IChhIHNjcm9sbCBwYW5lIGZyb20gbm93IG9uKSwKKyAgICAgICAgYnV0 IHRoZSBvbmx5IGNoaWxkIG9mIHRoYXQgb25lLiBUaHVzLCBza2lwIHRoYXQgcm9vdCBvYmplY3Qu CisKIDIwMTEtMTEtMTYgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIENvbnNpZGVyIHBhcmVudCBBdGtPYmplY3QgaW4gd2Via2l0X2Fj Y2Vzc2libGVfZ2V0X3BhcmVudCgpLCBpZiBhbHJlYWR5IHNldApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9ndGsvdGVzdHMvdGVzdGF0ay5jIGIvU291cmNlL1dlYktpdC9ndGsvdGVzdHMvdGVz dGF0ay5jCmluZGV4IDhhODkyODkuLjUwNWE0MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Z3RrL3Rlc3RzL3Rlc3RhdGsuYworKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRr LmMKQEAgLTE2MjUsNyArMTYyNSw2IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJraXRBdGtQYXJlbnRG b3JSb290T2JqZWN0KCkKICAgICBBdGtPYmplY3QqIGF4Qm94ID0gZ3RrX3dpZGdldF9nZXRfYWNj ZXNzaWJsZSAoYm94KTsKICAgICBnX2Fzc2VydChBVEtfSVNfT0JKRUNUKGF4Qm94KSk7CiAKLSAg ICBnX2Fzc2VydF9jbXBpbnQoYXRrX29iamVjdF9nZXRfbl9hY2Nlc3NpYmxlX2NoaWxkcmVuKGF4 Qm94KSwgPT0sIDEpOwogICAgIEF0a09iamVjdCogYXhCb3hDaGlsZCA9IGF0a19vYmplY3RfcmVm X2FjY2Vzc2libGVfY2hpbGQoYXhCb3gsIDApOwogICAgIGdfYXNzZXJ0KGF4Qm94Q2hpbGQpOwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0ay90ZXN0cy90ZXN0YXRrcm9sZXMuYyBiL1Nv dXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGtyb2xlcy5jCmluZGV4IGIwZGM4YjYuLmU2ZjFi MTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGtyb2xlcy5jCisr KyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3RhdGtyb2xlcy5jCkBAIC01OSw5ICs1OSwx OSBAQCBzdGF0aWMgZ2Jvb2xlYW4gZmluaXNoX2xvYWRpbmcoQXRrUm9sZXNGaXh0dXJlKiBmaXh0 dXJlKQogICAgIGlmIChnX21haW5fbG9vcF9pc19ydW5uaW5nKGZpeHR1cmUtPmxvb3ApKQogICAg ICAgICBnX21haW5fbG9vcF9xdWl0KGZpeHR1cmUtPmxvb3ApOwogCi0gICAgZml4dHVyZS0+ZG9j dW1lbnRGcmFtZSA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2libGUoZml4dHVyZS0+d2ViVmlldyk7 CisgICAgLy8gV2l0aCB0aGUgY2hhbmdlIHRvIHN1cHBvcnQgV0syIGFjY2Vzc2liaWxpdHksIHRo ZSByb290IG9iamVjdAorICAgIC8vIGhhcyBjaGFuZ2VkIGFuZCBpdCdzIG5vIGxvbmdlciB0aGUg ZG9jdW1lbnQgZnJhbWUsIGJ1dCBhIHNjcm9sbAorICAgIC8vIHBhbmUgY29udGFpbmluZyB0aGUg ZG9jdW1lbnQgZnJhbWUgYXMgaXQncyBvbmx5IGNoaWxkLiBTZWUgdGhlCisgICAgLy8gYnVnIDcy MzkwIGZvciBtb3JlIGRldGFpbHMgb24gdGhpcyBjaGFuZ2UuCisgICAgLy8gaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMzkwCisgICAgQXRrT2JqZWN0KiByb290T2Jq ZWN0ID0gZ3RrX3dpZGdldF9nZXRfYWNjZXNzaWJsZShmaXh0dXJlLT53ZWJWaWV3KTsKKyAgICBm aXh0dXJlLT5kb2N1bWVudEZyYW1lID0gYXRrX29iamVjdF9yZWZfYWNjZXNzaWJsZV9jaGlsZChy b290T2JqZWN0LCAwKTsKICAgICBnX2Fzc2VydChmaXh0dXJlLT5kb2N1bWVudEZyYW1lKTsKIAor ICAgIC8vIFJlbW92ZSB0aGUgcmVmZXJlbmNlIGFkZGVkIGJ5IHJlZl9hY2Nlc3NpYmxlX2NoaWxk KCkgYW5kCisgICAgLy8gcmV0dXJuLCBzaW5jZSB3ZSBkb24ndCBuZWVkIHRvIGtlZXAgdGhhdCBl eHRyYSByZWYgYXQgYWxsLgorICAgIGdfb2JqZWN0X3VucmVmKGZpeHR1cmUtPmRvY3VtZW50RnJh bWUpOworCiAgICAgcmV0dXJuIEZBTFNFOwogfQogCi0tIAoxLjcuNy4xCgo=