72591 2011-11-17 02:53:29 -0800 Remove document.width / document.height 2012-03-07 10:51:09 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annevk webkit-unassigned abarth arv brianh.smartsheet code.vineet darin dglazkov divya dominicc mitz Ms2ger ojan sam tabatkins webkit.review.bot yonathan oldest_to_newest 504688 0 annevk 2011-11-17 02:53:29 -0800 WebKit is the only vendor who remains to have support for this. 504699 1 annevk 2011-11-17 03:05:21 -0800 abarth says they're on HTMLDocument. 504700 2 abarth 2011-11-17 03:06:38 -0800 [02:54am] annevk: jarek: only Gecko and WebKit supported them [02:54am] annevk: jarek: some Google-demo is still using them it seems, but not much more than that as far as I know [03:00am] abarth: annevk: which demo? [03:01am] annevk: http://studio.html5rocks.com/#Puzzle because of code in http://studio.html5rocks.com/samples/svg-puzzle/jigsaw.js [03:01am] annevk: instead of document.width it should use document.body.clientWidth and same for height 504701 3 115551 abarth 2011-11-17 03:08:50 -0800 Created attachment 115551 work in progress 504748 4 code.vineet 2011-11-17 04:39:05 -0800 May be we need to remove below line from Source/WebCore/bindings/objc/PublicDOMInterfaces.h @property(readonly) int width; @property(readonly) int height; 504770 5 115551 webkit.review.bot 2011-11-17 05:19:01 -0800 Comment on attachment 115551 work in progress Attachment 115551 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10477160 New failing tests: fast/dom/document-width-height-force-layout.html fullscreen/video-specified-size.html 504957 6 abarth 2011-11-17 10:22:23 -0800 If these functions are exposed in the ObjC bindings, then we can't remove the implementation. We could potentially restrict the API to just ObjC though. 505503 7 dominicc 2011-11-17 22:14:00 -0800 (In reply to comment #6) > If these functions are exposed in the ObjC bindings, then we can't remove the implementation. We could potentially restrict the API to just ObjC though. This is what we did for initOverflowEvent in bug 71687. It was public Objective C API; it is now in the Objective C binding only. 505974 8 115847 code.vineet 2011-11-18 12:27:33 -0800 Created attachment 115847 proposed patch (In reply to comment #7) > (In reply to comment #6) > > If these functions are exposed in the ObjC bindings, then we can't remove the implementation. We could potentially restrict the API to just ObjC though. > > This is what we did for initOverflowEvent in bug 71687. It was public Objective C API; it is now in the Objective C binding only. Attaching as per above review comments. Moved height/width attribute under "LANGUAGE_OBJECTIVE_C" Please let me know your comments on this. 506105 9 115847 abarth 2011-11-18 15:10:44 -0800 Comment on attachment 115847 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=115847&action=review > LayoutTests/fast/dom/document-width-height-force-layout.html:-15 > - log("document.width = " + document.width); > - log("document.height = " + document.height); Can you change this test to use document.body.clientWidth and document.body.clientHeight rather than remove it? > LayoutTests/fullscreen/video-specified-size.html:-14 > - waitForEventTestAndEnd(document, 'webkitfullscreenchange', "video.clientWidth==document.width"); Rather than removing this test, you can just change document.width on this line to document.body.clientWidth. 506313 10 115928 code.vineet 2011-11-18 20:00:00 -0800 Created attachment 115928 Updated patch as per review comments Updated patch as per review comments. Using document.body.clientWidth/document.body.clientHeight instead of document.width/document.height. 506316 11 115928 abarth 2011-11-18 20:05:12 -0800 Comment on attachment 115928 Updated patch as per review comments View in context: https://bugs.webkit.org/attachment.cgi?id=115928&action=review > LayoutTests/fast/dom/document-width-height-force-layout.html:15 > - log("document.width = " + document.width); > - log("document.height = " + document.height); > + log("document.width = " + document.body.clientWidth); > + log("document.height = " + document.body.clientHeight); I would have updated the left side of these log functions too. 506317 12 115929 code.vineet 2011-11-18 20:14:49 -0800 Created attachment 115929 updated_patch 506325 13 115929 webkit.review.bot 2011-11-18 22:05:20 -0800 Comment on attachment 115929 updated_patch Clearing flags on attachment: 115929 Committed r100847: <http://trac.webkit.org/changeset/100847> 506326 14 webkit.review.bot 2011-11-18 22:05:25 -0800 All reviewed patches have been landed. Closing bug. 519635 15 yonathan 2011-12-12 16:04:52 -0800 document.width (screen pixels) was actually not equivalent to document.body.clientWidth (CSS pixels). This was actually the quirk I used to calculate zoom level in WebKit [1]. I'm curious to know whether there is any other hack to get the zoom level in WebKit. [1]: http://stackoverflow.com/questions/1713771/how-to-detect-page-zoom-level-in-all-modern-browsers 519645 16 abarth 2011-12-12 16:11:05 -0800 It's unclear whether we want web sites to be able to detect the zoom level. If we do, we can add an API for that rather than having folks write sites that rely on quirks. 519653 17 yonathan 2011-12-12 16:19:34 -0800 It can be quite useful to measure zoom level e.g. to download an image or make a canvas that is at device resolution. I agree that it shouldn't require hacks though. 556358 18 brianh.smartsheet 2012-02-14 09:45:36 -0800 This "fix" will negatively impact our user base, at least those using Safari and Chrome. As Yonathan mentioned, it can be useful to detect zoom, and this change will leave Webkit browsers as the only ones without a method for doing so. It's true that the methods differ between browsers, and it would be preferable to have a standard API for getting this information, but unfortunately there seems to be a philosophical debate among open source browser developers over whether web developers can be trusted to use this information responsibly. Since it's not a security hole of any kind, I'd like to think we should be given the benefit of the doubt and treated as adults. Judging from the comments, this bug seemed to be based on the incorrect assumption that document.width returned the same value as document.body.clientWidth, and was therefore completely extraneous. Now that you've learned otherwise, I hope you will reconsider, and restore this property, at least until you've more carefully considered the issue of exposing device pixels and/or zoom detection. 556409 19 yonathan 2012-02-14 10:57:26 -0800 Brian, you can still use -webkit-text-size-adjust:none to determine zoom level for Webkit. I'm curious whether you know of any trick to get zoom level in Opera; in newer Opera, I'm not aware of any measurement that is in device pixels anymore. btw I put my code at https://github.com/yonran/detect-zoom 572546 20 mitz 2012-03-06 22:41:24 -0800 This change broke a Mac app that uses embedded web content for its UI. 572553 21 abarth 2012-03-06 22:52:44 -0800 Should we add an app-specific quirk? It should be easy to stub in the API using a script a la http://trac.webkit.org/browser/trunk/Source/WebKit/mac/Misc/MailQuirksUserScript.js 572567 22 mitz 2012-03-06 23:10:14 -0800 (In reply to comment #21) > Should we add an app-specific quirk? Doing so would fix this one app of which I happen to know, but not any other apps and websites that may have been broken by this change. I think the best and safest solution is to revert this change. If there is a strong argument against this (reading comments 0 through 19 in this bug, I failed to see what justified the change), then a linked-on-or-before check would be acceptable. 572577 23 abarth 2012-03-06 23:20:43 -0800 Is there any evidence that this change broke any web sites? The comments on this bug thus far seem to all be about using this API as a hack to detect the zoom level. 572581 24 mitz 2012-03-06 23:22:54 -0800 (In reply to comment #23) > Is there any evidence that this change broke any web sites? Not that I know of. 572583 25 mitz 2012-03-06 23:23:18 -0800 Filed bug 80494. 115551 2011-11-17 03:08:50 -0800 2011-11-17 05:19:01 -0800 work in progress bug-72591-20111117030849.patch text/plain 1669 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5jcHAJKHJldmlzaW9uIDEwMDU5MSkK KysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtOTAsMjAgKzkwLDYgQEAgSFRNTERvY3VtZW50Ojp+SFRNTERvY3VtZW50KCkKIHsKIH0KIAot aW50IEhUTUxEb2N1bWVudDo6d2lkdGgoKQotewotICAgIHVwZGF0ZUxheW91dElnbm9yZVBlbmRp bmdTdHlsZXNoZWV0cygpOwotICAgIEZyYW1lVmlldyogZnJhbWVWaWV3ID0gdmlldygpOwotICAg IHJldHVybiBmcmFtZVZpZXcgPyBmcmFtZVZpZXctPmNvbnRlbnRzV2lkdGgoKSA6IDA7Ci19Ci0K LWludCBIVE1MRG9jdW1lbnQ6OmhlaWdodCgpCi17Ci0gICAgdXBkYXRlTGF5b3V0SWdub3JlUGVu ZGluZ1N0eWxlc2hlZXRzKCk7Ci0gICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSB2aWV3KCk7Ci0g ICAgcmV0dXJuIGZyYW1lVmlldyA/IGZyYW1lVmlldy0+Y29udGVudHNIZWlnaHQoKSA6IDA7Ci19 Ci0KIFN0cmluZyBIVE1MRG9jdW1lbnQ6OmRpcigpCiB7CiAgICAgSFRNTEVsZW1lbnQqIGIgPSBi b2R5KCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVudC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmgJKHJldmlzaW9uIDEwMDU5 MSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3VtZW50LmgJKHdvcmtpbmcgY29weSkK QEAgLTQxLDkgKzQxLDYgQEAgcHVibGljOgogICAgIH0KICAgICB2aXJ0dWFsIH5IVE1MRG9jdW1l bnQoKTsKIAotICAgIGludCB3aWR0aCgpOwotICAgIGludCBoZWlnaHQoKTsKLQogICAgIFN0cmlu ZyBkaXIoKTsKICAgICB2b2lkIHNldERpcihjb25zdCBTdHJpbmcmKTsKIApJbmRleDogU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTERvY3VtZW50LmlkbAkocmV2aXNpb24gMTAwNTkxKQorKysgU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MRG9jdW1lbnQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC00NCw4ICs0NCw2 IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgdm9pZCBjYXB0dXJlRXZlbnRzKCk7CiAgICAgICAg IHZvaWQgcmVsZWFzZUV2ZW50cygpOwogCi0gICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25n IHdpZHRoOwotICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgbG9uZyBoZWlnaHQ7CiAgICAgICAg ICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBk aXI7CiAgICAgICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmdd IERPTVN0cmluZyBkZXNpZ25Nb2RlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3Ry aW5nIGNvbXBhdE1vZGU7Cg== 115847 2011-11-18 12:27:33 -0800 2011-11-18 20:00:00 -0800 proposed patch height.diff text/plain 5349 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDgwNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE4ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8dmluZWV0LmNoYXVkaGFyeUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNTkxCisgICAgICAgIFJlbW92 ZSBkb2N1bWVudC53aWR0aCAvIGRvY3VtZW50LmhlaWdodAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgZG9jdW1lbnQud2lkdGgvZG9jdW1l bnQuaGVpZ2h0IGZyb20gSlMgYmluZGluZ3MsCisgICAgICAgIGJ1dCBrZWVwaW5nIHRoZSBzYW1l IGZvciBPYmpDIGJpbmRpbmdzLgorCisgICAgICAgICogaHRtbC9IVE1MRG9jdW1lbnQuaWRsOgor CiAyMDExLTExLTE4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIEFwcGVhcmFuY2Ugb2YgY29tcG91bmQgdHJhbnNmb3JtIGFuaW1hdGlvbnMgdW5kZXIg YXBwcyBsaW5rZWQgb24gU25vd0xlb3BhcmQgaXMgaW5jb3JyZWN0CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEb2N1bWVudC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MRG9jdW1lbnQuaWRsCShyZXZpc2lvbiAxMDA3NDkpCisrKyBTb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxEb2N1bWVudC5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDggKzQ0LDEwIEBA IG1vZHVsZSBodG1sIHsKICAgICAgICAgdm9pZCBjYXB0dXJlRXZlbnRzKCk7CiAgICAgICAgIHZv aWQgcmVsZWFzZUV2ZW50cygpOwogCisjaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykg JiYgTEFOR1VBR0VfT0JKRUNUSVZFX0MKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcg d2lkdGg7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nIGhlaWdodDsKKyNlbmRpZgog ICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgW0NvbnZlcnROdWxsVG9OdWxsU3RyaW5nXSBET01T dHJpbmcgZGlyOwogICAgICAgICAgICAgICAgICBhdHRyaWJ1dGUgW0NvbnZlcnROdWxsVG9OdWxs U3RyaW5nXSBET01TdHJpbmcgZGVzaWduTW9kZTsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRl IERPTVN0cmluZyBjb21wYXRNb2RlOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwODA0KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEt MTEtMTggIFZpbmVldCBDaGF1ZGhhcnkgIDx2aW5lZXQuY2hhdWRoYXJ5QG1vdG9yb2xhLmNvbT4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI1OTEK KyAgICAgICAgUmVtb3ZlIGRvY3VtZW50LndpZHRoIC8gZG9jdW1lbnQuaGVpZ2h0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMgc3VwcG9ydCBmb3Ig ZG9jdW1lbnQud2lkdGggLyBkb2N1bWVudC5oZWlnaHQgaGFzIGJlZW4KKyAgICAgICAgcmVtb3Zl ZCByZW1vdmluZyB0ZXN0cyByZWxhdGVkIHRvIHRoYXQgdG9vLgorCisgICAgICAgICogZmFzdC9k b20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC1leHBlY3RlZC50eHQ6IFJlbW92 ZWQuCisgICAgICAgICogZmFzdC9kb20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91 dC5odG1sOiBSZW1vdmVkLgorICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNp emUtZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tc3Bl Y2lmaWVkLXNpemUuaHRtbDogUmVtb3ZlZC4KKwogMjAxMS0xMS0xOCAgQWRhbSBLbGVpbiAgPGFk YW1rQGNocm9taXVtLm9yZz4KIAogICAgICAgICBMYXlvdXQgVGVzdCBhY2Nlc3NpYmlsaXR5L2xv YWRpbmctaWZyYW1lLXNlbmRzLW5vdGlmaWNhdGlvbi5odG1sIGlzIHNsb3cgb24gV2luIGRiZwpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxh eW91dC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9j dW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEw MDc0OSkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LXdpZHRoLWhlaWdodC1mb3Jj ZS1sYXlvdXQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzAsMCBAQAotVGhp cyB0ZXN0cyB0aGF0IGRvY3VtZW50LndpZHRoIGFuZCBkb2N1bWVudC5oZWlnaHQgY2F1c2UgYSBs YXlvdXQgb24gdXNlLiBUaGUgdGVzdCBoYXMgcGFzc2VkIGlmIHRoZXkgaGF2ZSBwb3NpdGl2ZSB2 YWx1ZXMuCi0KLWRvY3VtZW50LndpZHRoID0gODAwCi1kb2N1bWVudC5oZWlnaHQgPSA2MDAKLQpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxh eW91dC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LXdp ZHRoLWhlaWdodC1mb3JjZS1sYXlvdXQuaHRtbAkocmV2aXNpb24gMTAwNzQ5KQorKysgTGF5b3V0 VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC5odG1sCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDIzICswLDAgQEAKLTxodG1sPgotPGhlYWQ+Ci0gICAgPHNjcmlw dD4KLSAgICAgICAgZnVuY3Rpb24gbG9nKG1zZykKLSAgICAgICAgewotICAgICAgICAgICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVh dGVUZXh0Tm9kZShtc2cgKyAiXG4iKSk7Ci0gICAgICAgIH0KLQotICAgICAgICBmdW5jdGlvbiB0 ZXN0KCkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikKLSAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 Ci0KLSAgICAgICAgICAgIGxvZygiZG9jdW1lbnQud2lkdGggPSAiICsgZG9jdW1lbnQud2lkdGgp OwotICAgICAgICAgICAgbG9nKCJkb2N1bWVudC5oZWlnaHQgPSAiICsgZG9jdW1lbnQuaGVpZ2h0 KTsKLSAgICAgICAgfQotICAgIDwvc2NyaXB0PgotPC9oZWFkPgotPGJvZHkgb25sb2FkPSJ0ZXN0 KCkiPgotICAgIDxwPlRoaXMgdGVzdHMgdGhhdCBkb2N1bWVudC53aWR0aCBhbmQgZG9jdW1lbnQu aGVpZ2h0IGNhdXNlIGEgbGF5b3V0IG9uIHVzZS4gIFRoZSB0ZXN0IGhhcyBwYXNzZWQgaWYgdGhl eSBoYXZlIHBvc2l0aXZlIHZhbHVlcy48L3A+Ci0gICAgPHByZSBpZD0iY29uc29sZSI+PC9wcmU+ Ci08L2JvZHk+Ci08L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLXNw ZWNpZmllZC1zaXplLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mdWxs c2NyZWVuL3ZpZGVvLXNwZWNpZmllZC1zaXplLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMTAwNzQ5 KQorKysgTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1zcGVjaWZpZWQtc2l6ZS1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMCwwIEBACi1FVkVOVCh3ZWJraXRmdWxsc2Ny ZWVuY2hhbmdlKSBURVNUKHZpZGVvLmNsaWVudFdpZHRoPT1kb2N1bWVudC53aWR0aCkgT0sKLUVO RCBPRiBURVNUCi0KSW5kZXg6IExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVk LXNpemUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLXNw ZWNpZmllZC1zaXplLmh0bWwJKHJldmlzaW9uIDEwMDc0OSkKKysrIExheW91dFRlc3RzL2Z1bGxz Y3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNpemUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSwxOCAr MCwwIEBACi08Ym9keT4KLSAgICA8dmlkZW8gaWQ9InZpZGVvIiB3aWR0aD0iMzAwIiBjb250cm9s cz48L3ZpZGVvPgotICAgIDxzY3JpcHQgc3JjPSJmdWxsLXNjcmVlbi10ZXN0LmpzIj48L3Njcmlw dD4KLSAgICA8c2NyaXB0IHNyYz0uLi9tZWRpYS9tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgotICAg IDxzY3JpcHQ+Ci0gICAgICAgIHNldFNyY0J5SWQoInZpZGVvIiwgZmluZE1lZGlhRmlsZSgidmlk ZW8iLCAiLi4vbWVkaWEvY29udGVudC90ZXN0IikpOwotICAgICAgICB2YXIgdmlkZW8gPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgndmlkZW8nKTsKLQotICAgICAgICAvLyBCYWlsIG91dCBlYXJs eSBpZiB0aGUgZnVsbCBzY3JlZW4gQVBJIGlzIG5vdCBlbmFibGVkIG9yIGlzIG1pc3Npbmc6Ci0g ICAgICAgIGlmIChFbGVtZW50LnByb3RvdHlwZS53ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbiA9PSB1 bmRlZmluZWQpIHsKLSAgICAgICAgICAgIGxvZ1Jlc3VsdChmYWxzZSwgIkVsZW1lbnQucHJvdG90 eXBlLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuID09IHVuZGVmaW5lZCIpOwotICAgICAgICAgICAg ZW5kVGVzdCgpOwotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgd2FpdEZvckV2ZW50VGVz dEFuZEVuZChkb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCAidmlkZW8uY2xpZW50 V2lkdGg9PWRvY3VtZW50LndpZHRoIik7Ci0gICAgICAgICAgICBydW5XaXRoS2V5RG93bihmdW5j dGlvbigpe3ZpZGVvLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKCl9KTsKLSAgICAgICAgfQotICAg IDwvc2NyaXB0PgotPC9ib2R5PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 115928 2011-11-18 20:00:00 -0800 2011-11-18 20:14:49 -0800 Updated patch as per review comments width_height.diff text/plain 5824 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDg0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTE4ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8dmluZWV0LmNoYXVkaGFyeUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNTkxCisgICAgICAgIFJlbW92 ZSBkb2N1bWVudC53aWR0aCAvIGRvY3VtZW50LmhlaWdodAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgZG9jdW1lbnQud2lkdGgvZG9jdW1l bnQuaGVpZ2h0IGZyb20gSlMgYmluZGluZ3MsCisgICAgICAgIGJ1dCBrZWVwaW5nIHRoZSBzYW1l IGZvciBPYmpDIGJpbmRpbmdzLiBBbHNvIGl0IHNob3VsZCB1c2UKKyAgICAgICAgZG9jdW1lbnQu Ym9keS5jbGllbnRXaWR0aCBhbmQgZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQgaW5zdGVhZC4K KworICAgICAgICAqIGh0bWwvSFRNTERvY3VtZW50LmlkbDoKKwogMjAxMS0xMS0xOCAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjEwMDgyNi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERv Y3VtZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVu dC5pZGwJKHJldmlzaW9uIDEwMDc0OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3Vt ZW50LmlkbAkod29ya2luZyBjb3B5KQpAQCAtNDQsOCArNDQsMTAgQEAgbW9kdWxlIGh0bWwgewog ICAgICAgICB2b2lkIGNhcHR1cmVFdmVudHMoKTsKICAgICAgICAgdm9pZCByZWxlYXNlRXZlbnRz KCk7CiAKKyNpZiBkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpF Q1RJVkVfQwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgbG9uZyB3aWR0aDsKICAgICAgICAg cmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgaGVpZ2h0OworI2VuZGlmCiAgICAgICAgICAgICAgICAg IGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBkaXI7CiAgICAg ICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmlu ZyBkZXNpZ25Nb2RlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNvbXBh dE1vZGU7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDA4NDMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0xMS0xOCAgVmluZWV0IENo YXVkaGFyeSAgPHZpbmVldC5jaGF1ZGhhcnlAbW90b3JvbGEuY29tPgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU5MQorICAgICAgICBSZW1vdmUg ZG9jdW1lbnQud2lkdGggLyBkb2N1bWVudC5oZWlnaHQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBzdXBwb3J0IGZvciBkb2N1bWVudC53aWR0aCAv IGRvY3VtZW50LmhlaWdodCBoYXMgYmVlbgorICAgICAgICByZW1vdmVkIGl0IHNob3VsZCB1c2Ug ZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCBhbmQgZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQK KyAgICAgICAgcmVzcGVjdGl2ZWx5LgorCisgICAgICAgICogZmFzdC9kb20vZG9jdW1lbnQtd2lk dGgtaGVpZ2h0LWZvcmNlLWxheW91dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20v ZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC5odG1sOgorICAgICAgICBNb2RpZmll ZCB0ZXN0IGNhc2UgdG8gdXNlIGRvY3VtZW50LmJvZHkuY2xpZW50V2lkdGggYW5kIGRvY3VtZW50 LmJvZHkuY2xpZW50SGVpZ2h0LgorICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVk LXNpemUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVk LXNpemUuaHRtbDoKKyAgICAgICAgTW9kaWZpZWQgdGVzdCBjYXNlIHRvIHVzZSBkb2N1bWVudC5i b2R5LmNsaWVudFdpZHRoLgorCiAyMDExLTExLTE4ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEFkZCBhbm90aGVyIGlzZmluaXRlIGFzc2VydGlvbiBmYWlsdXJl IGZvciBmYXN0L2JvcmRlcnMvCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVudC13 aWR0aC1oZWlnaHQtZm9yY2UtbGF5b3V0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVudC13aWR0aC1oZWlnaHQtZm9yY2UtbGF5b3V0LWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMTAwNzQ5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1l bnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTEsNCArMSw0IEBACi1UaGlzIHRlc3RzIHRoYXQgZG9jdW1lbnQud2lkdGggYW5kIGRvY3Vt ZW50LmhlaWdodCBjYXVzZSBhIGxheW91dCBvbiB1c2UuIFRoZSB0ZXN0IGhhcyBwYXNzZWQgaWYg dGhleSBoYXZlIHBvc2l0aXZlIHZhbHVlcy4KK1RoaXMgdGVzdHMgdGhhdCBkb2N1bWVudC5ib2R5 LmNsaWVudFdpZHRoIGFuZCBkb2N1bWVudC5ib2R5LmNsaWVudEhlaWdodCBjYXVzZSBhIGxheW91 dCBvbiB1c2UuIFRoZSB0ZXN0IGhhcyBwYXNzZWQgaWYgdGhleSBoYXZlIHBvc2l0aXZlIHZhbHVl cy4KIAogZG9jdW1lbnQud2lkdGggPSA4MDAKIGRvY3VtZW50LmhlaWdodCA9IDYwMApJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LXdpZHRoLWhl aWdodC1mb3JjZS1sYXlvdXQuaHRtbAkocmV2aXNpb24gMTAwNzQ5KQorKysgTGF5b3V0VGVzdHMv ZmFzdC9kb20vZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xMSwxMyArMTEsMTMgQEAKICAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpCiAgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVt cEFzVGV4dCgpOwogCi0gICAgICAgICAgICBsb2coImRvY3VtZW50LndpZHRoID0gIiArIGRvY3Vt ZW50LndpZHRoKTsKLSAgICAgICAgICAgIGxvZygiZG9jdW1lbnQuaGVpZ2h0ID0gIiArIGRvY3Vt ZW50LmhlaWdodCk7CisgICAgICAgICAgICBsb2coImRvY3VtZW50LndpZHRoID0gIiArIGRvY3Vt ZW50LmJvZHkuY2xpZW50V2lkdGgpOworICAgICAgICAgICAgbG9nKCJkb2N1bWVudC5oZWlnaHQg PSAiICsgZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQpOwogICAgICAgICB9CiAgICAgPC9zY3Jp cHQ+CiA8L2hlYWQ+CiA8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Ci0gICAgPHA+VGhpcyB0ZXN0cyB0 aGF0IGRvY3VtZW50LndpZHRoIGFuZCBkb2N1bWVudC5oZWlnaHQgY2F1c2UgYSBsYXlvdXQgb24g dXNlLiAgVGhlIHRlc3QgaGFzIHBhc3NlZCBpZiB0aGV5IGhhdmUgcG9zaXRpdmUgdmFsdWVzLjwv cD4KKyAgICA8cD5UaGlzIHRlc3RzIHRoYXQgZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCBhbmQg ZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQgY2F1c2UgYSBsYXlvdXQgb24gdXNlLiAgVGhlIHRl c3QgaGFzIHBhc3NlZCBpZiB0aGV5IGhhdmUgcG9zaXRpdmUgdmFsdWVzLjwvcD4KICAgICA8cHJl IGlkPSJjb25zb2xlIj48L3ByZT4KIDwvYm9keT4KIDwvaHRtbD4KSW5kZXg6IExheW91dFRlc3Rz L2Z1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNpemUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNpemUtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAxMDA3NDkpCisrKyBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLXNw ZWNpZmllZC1zaXplLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMgQEAK LUVWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UpIFRFU1QodmlkZW8uY2xpZW50V2lkdGg9PWRv Y3VtZW50LndpZHRoKSBPSworRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNoYW5nZSkgVEVTVCh2aWRl by5jbGllbnRXaWR0aD09ZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCkgT0sKIEVORCBPRiBURVNU CiAKSW5kZXg6IExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNpemUuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mdWxsc2NyZWVuL3ZpZGVvLXNwZWNpZmllZC1z aXplLmh0bWwJKHJldmlzaW9uIDEwMDc0OSkKKysrIExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlk ZW8tc3BlY2lmaWVkLXNpemUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNSwxNCArNSwxMyBAQAog ICAgIDxzY3JpcHQ+CiAgICAgICAgIHNldFNyY0J5SWQoInZpZGVvIiwgZmluZE1lZGlhRmlsZSgi dmlkZW8iLCAiLi4vbWVkaWEvY29udGVudC90ZXN0IikpOwogICAgICAgICB2YXIgdmlkZW8gPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgndmlkZW8nKTsKLQogICAgICAgICAvLyBCYWlsIG91dCBl YXJseSBpZiB0aGUgZnVsbCBzY3JlZW4gQVBJIGlzIG5vdCBlbmFibGVkIG9yIGlzIG1pc3Npbmc6 CiAgICAgICAgIGlmIChFbGVtZW50LnByb3RvdHlwZS53ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbiA9 PSB1bmRlZmluZWQpIHsKICAgICAgICAgICAgIGxvZ1Jlc3VsdChmYWxzZSwgIkVsZW1lbnQucHJv dG90eXBlLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuID09IHVuZGVmaW5lZCIpOwogICAgICAgICAg ICAgZW5kVGVzdCgpOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgd2FpdEZvckV2ZW50 VGVzdEFuZEVuZChkb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCAidmlkZW8uY2xp ZW50V2lkdGg9PWRvY3VtZW50LndpZHRoIik7CisgICAgICAgICAgICB3YWl0Rm9yRXZlbnRUZXN0 QW5kRW5kKGRvY3VtZW50LCAnd2Via2l0ZnVsbHNjcmVlbmNoYW5nZScsICJ2aWRlby5jbGllbnRX aWR0aD09ZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCIpOwogICAgICAgICAgICAgcnVuV2l0aEtl eURvd24oZnVuY3Rpb24oKXt2aWRlby53ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbigpfSk7CiAgICAg ICAgIH0KICAgICA8L3NjcmlwdD4KLTwvYm9keT4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl Cis8L2JvZHk+Cg== 115929 2011-11-18 20:14:49 -0800 2011-11-18 22:05:20 -0800 updated_patch width_height.diff text/plain 5913 code.vineet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDg0MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTE4ICBWaW5lZXQg Q2hhdWRoYXJ5ICA8dmluZWV0LmNoYXVkaGFyeUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNTkxCisgICAgICAgIFJlbW92 ZSBkb2N1bWVudC53aWR0aCAvIGRvY3VtZW50LmhlaWdodAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgZG9jdW1lbnQud2lkdGgvZG9jdW1l bnQuaGVpZ2h0IGZyb20gSlMgYmluZGluZ3MsCisgICAgICAgIGJ1dCBrZWVwaW5nIHRoZSBzYW1l IGZvciBPYmpDIGJpbmRpbmdzLiBBbHNvIGl0IHNob3VsZCB1c2UKKyAgICAgICAgZG9jdW1lbnQu Ym9keS5jbGllbnRXaWR0aCBhbmQgZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQgaW5zdGVhZC4K KworICAgICAgICAqIGh0bWwvSFRNTERvY3VtZW50LmlkbDoKKwogMjAxMS0xMS0xOCAgU2hlcmlm ZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjEwMDgyNi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERv Y3VtZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEb2N1bWVu dC5pZGwJKHJldmlzaW9uIDEwMDc0OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERvY3Vt ZW50LmlkbAkod29ya2luZyBjb3B5KQpAQCAtNDQsOCArNDQsMTAgQEAgbW9kdWxlIGh0bWwgewog ICAgICAgICB2b2lkIGNhcHR1cmVFdmVudHMoKTsKICAgICAgICAgdm9pZCByZWxlYXNlRXZlbnRz KCk7CiAKKyNpZiBkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpF Q1RJVkVfQwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgbG9uZyB3aWR0aDsKICAgICAgICAg cmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgaGVpZ2h0OworI2VuZGlmCiAgICAgICAgICAgICAgICAg IGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyBkaXI7CiAgICAg ICAgICAgICAgICAgIGF0dHJpYnV0ZSBbQ29udmVydE51bGxUb051bGxTdHJpbmddIERPTVN0cmlu ZyBkZXNpZ25Nb2RlOwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNvbXBh dE1vZGU7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDA4NDMpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0xMS0xOCAgVmluZWV0IENo YXVkaGFyeSAgPHZpbmVldC5jaGF1ZGhhcnlAbW90b3JvbGEuY29tPgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU5MQorICAgICAgICBSZW1vdmUg ZG9jdW1lbnQud2lkdGggLyBkb2N1bWVudC5oZWlnaHQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcyBzdXBwb3J0IGZvciBkb2N1bWVudC53aWR0aCAv IGRvY3VtZW50LmhlaWdodCBoYXMgYmVlbgorICAgICAgICByZW1vdmVkIGl0IHNob3VsZCB1c2Ug ZG9jdW1lbnQuYm9keS5jbGllbnRXaWR0aCBhbmQgZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQK KyAgICAgICAgcmVzcGVjdGl2ZWx5LgorCisgICAgICAgICogZmFzdC9kb20vZG9jdW1lbnQtd2lk dGgtaGVpZ2h0LWZvcmNlLWxheW91dC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20v ZG9jdW1lbnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC5odG1sOgorICAgICAgICBNb2RpZmll ZCB0ZXN0IGNhc2UgdG8gdXNlIGRvY3VtZW50LmJvZHkuY2xpZW50V2lkdGggYW5kIGRvY3VtZW50 LmJvZHkuY2xpZW50SGVpZ2h0LgorICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVk LXNpemUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZ1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVk LXNpemUuaHRtbDoKKyAgICAgICAgTW9kaWZpZWQgdGVzdCBjYXNlIHRvIHVzZSBkb2N1bWVudC5i b2R5LmNsaWVudFdpZHRoLgorCiAyMDExLTExLTE4ICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEFkZCBhbm90aGVyIGlzZmluaXRlIGFzc2VydGlvbiBmYWlsdXJl IGZvciBmYXN0L2JvcmRlcnMvCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVudC13 aWR0aC1oZWlnaHQtZm9yY2UtbGF5b3V0LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVudC13aWR0aC1oZWlnaHQtZm9yY2UtbGF5b3V0LWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMTAwNzQ5KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vZG9jdW1l bnQtd2lkdGgtaGVpZ2h0LWZvcmNlLWxheW91dC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkK QEAgLTEsNSArMSw1IEBACi1UaGlzIHRlc3RzIHRoYXQgZG9jdW1lbnQud2lkdGggYW5kIGRvY3Vt ZW50LmhlaWdodCBjYXVzZSBhIGxheW91dCBvbiB1c2UuIFRoZSB0ZXN0IGhhcyBwYXNzZWQgaWYg dGhleSBoYXZlIHBvc2l0aXZlIHZhbHVlcy4KK1RoaXMgdGVzdHMgdGhhdCBkb2N1bWVudC5ib2R5 LmNsaWVudFdpZHRoIGFuZCBkb2N1bWVudC5ib2R5LmNsaWVudEhlaWdodCBjYXVzZSBhIGxheW91 dCBvbiB1c2UuIFRoZSB0ZXN0IGhhcyBwYXNzZWQgaWYgdGhleSBoYXZlIHBvc2l0aXZlIHZhbHVl cy4KIAotZG9jdW1lbnQud2lkdGggPSA4MDAKLWRvY3VtZW50LmhlaWdodCA9IDYwMAorZG9jdW1l bnQuYm9keS5jbGllbnRXaWR0aCA9IDgwMAorZG9jdW1lbnQuYm9keS5jbGllbnRIZWlnaHQgPSA2 MDAKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LXdpZHRoLWhlaWdodC1mb3Jj ZS1sYXlvdXQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb2N1bWVu dC13aWR0aC1oZWlnaHQtZm9yY2UtbGF5b3V0Lmh0bWwJKHJldmlzaW9uIDEwMDc0OSkKKysrIExh eW91dFRlc3RzL2Zhc3QvZG9tL2RvY3VtZW50LXdpZHRoLWhlaWdodC1mb3JjZS1sYXlvdXQuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMTEsMTMgKzExLDEzIEBACiAgICAgICAgICAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKIAotICAgICAgICAgICAgbG9nKCJkb2N1bWVudC53aWR0aCA9 ICIgKyBkb2N1bWVudC53aWR0aCk7Ci0gICAgICAgICAgICBsb2coImRvY3VtZW50LmhlaWdodCA9 ICIgKyBkb2N1bWVudC5oZWlnaHQpOworICAgICAgICAgICAgbG9nKCJkb2N1bWVudC5ib2R5LmNs aWVudFdpZHRoID0gIiArIGRvY3VtZW50LmJvZHkuY2xpZW50V2lkdGgpOworICAgICAgICAgICAg bG9nKCJkb2N1bWVudC5ib2R5LmNsaWVudEhlaWdodCA9ICIgKyBkb2N1bWVudC5ib2R5LmNsaWVu dEhlaWdodCk7CiAgICAgICAgIH0KICAgICA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5IG9ubG9h ZD0idGVzdCgpIj4KLSAgICA8cD5UaGlzIHRlc3RzIHRoYXQgZG9jdW1lbnQud2lkdGggYW5kIGRv Y3VtZW50LmhlaWdodCBjYXVzZSBhIGxheW91dCBvbiB1c2UuICBUaGUgdGVzdCBoYXMgcGFzc2Vk IGlmIHRoZXkgaGF2ZSBwb3NpdGl2ZSB2YWx1ZXMuPC9wPgorICAgIDxwPlRoaXMgdGVzdHMgdGhh dCBkb2N1bWVudC5ib2R5LmNsaWVudFdpZHRoIGFuZCBkb2N1bWVudC5ib2R5LmNsaWVudEhlaWdo dCBjYXVzZSBhIGxheW91dCBvbiB1c2UuICBUaGUgdGVzdCBoYXMgcGFzc2VkIGlmIHRoZXkgaGF2 ZSBwb3NpdGl2ZSB2YWx1ZXMuPC9wPgogICAgIDxwcmUgaWQ9ImNvbnNvbGUiPjwvcHJlPgogPC9i b2R5PgogPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1zcGVjaWZp ZWQtc2l6ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZnVsbHNjcmVl bi92aWRlby1zcGVjaWZpZWQtc2l6ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDEwMDc0OSkKKysr IExheW91dFRlc3RzL2Z1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNpemUtZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMyBAQAotRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNo YW5nZSkgVEVTVCh2aWRlby5jbGllbnRXaWR0aD09ZG9jdW1lbnQud2lkdGgpIE9LCitFVkVOVCh3 ZWJraXRmdWxsc2NyZWVuY2hhbmdlKSBURVNUKHZpZGVvLmNsaWVudFdpZHRoPT1kb2N1bWVudC5i b2R5LmNsaWVudFdpZHRoKSBPSwogRU5EIE9GIFRFU1QKIApJbmRleDogTGF5b3V0VGVzdHMvZnVs bHNjcmVlbi92aWRlby1zcGVjaWZpZWQtc2l6ZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Z1bGxzY3JlZW4vdmlkZW8tc3BlY2lmaWVkLXNpemUuaHRtbAkocmV2aXNpb24gMTAwNzQ5 KQorKysgTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi92aWRlby1zcGVjaWZpZWQtc2l6ZS5odG1sCSh3 b3JraW5nIGNvcHkpCkBAIC01LDE0ICs1LDEzIEBACiAgICAgPHNjcmlwdD4KICAgICAgICAgc2V0 U3JjQnlJZCgidmlkZW8iLCBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICIuLi9tZWRpYS9jb250ZW50 L3Rlc3QiKSk7CiAgICAgICAgIHZhciB2aWRlbyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd2 aWRlbycpOwotCiAgICAgICAgIC8vIEJhaWwgb3V0IGVhcmx5IGlmIHRoZSBmdWxsIHNjcmVlbiBB UEkgaXMgbm90IGVuYWJsZWQgb3IgaXMgbWlzc2luZzoKICAgICAgICAgaWYgKEVsZW1lbnQucHJv dG90eXBlLndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuID09IHVuZGVmaW5lZCkgewogICAgICAgICAg ICAgbG9nUmVzdWx0KGZhbHNlLCAiRWxlbWVudC5wcm90b3R5cGUud2Via2l0UmVxdWVzdEZ1bGxT Y3JlZW4gPT0gdW5kZWZpbmVkIik7CiAgICAgICAgICAgICBlbmRUZXN0KCk7CiAgICAgICAgIH0g ZWxzZSB7Ci0gICAgICAgICAgICB3YWl0Rm9yRXZlbnRUZXN0QW5kRW5kKGRvY3VtZW50LCAnd2Vi a2l0ZnVsbHNjcmVlbmNoYW5nZScsICJ2aWRlby5jbGllbnRXaWR0aD09ZG9jdW1lbnQud2lkdGgi KTsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudFRlc3RBbmRFbmQoZG9jdW1lbnQsICd3ZWJraXRm dWxsc2NyZWVuY2hhbmdlJywgInZpZGVvLmNsaWVudFdpZHRoPT1kb2N1bWVudC5ib2R5LmNsaWVu dFdpZHRoIik7CiAgICAgICAgICAgICBydW5XaXRoS2V5RG93bihmdW5jdGlvbigpe3ZpZGVvLndl YmtpdFJlcXVlc3RGdWxsU2NyZWVuKCl9KTsKICAgICAgICAgfQogICAgIDwvc2NyaXB0PgotPC9i b2R5PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKKzwvYm9keT4K