72582 2011-11-17 00:19:51 -0800 WTF_EXPORT should be clang aware. 2011-11-17 00:34:40 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 67852 1 morrita morrita oldest_to_newest 504623 0 morrita 2011-11-17 00:19:51 -0800 Curretly WTF_EXPORT doesn't care about Clang compiler. Because Clang understands the same "visibility" attribute as gcc, we can let the macro definition to allow it under compilation with Clang. 504624 1 115539 morrita 2011-11-17 00:22:39 -0800 Created attachment 115539 Patch 504629 2 115539 hausmann 2011-11-17 00:29:04 -0800 Comment on attachment 115539 Patch Hm, I think the best way to write this expression is: #elif COMPILER(GCC) || COMPILER(CLANG) #COMPILER(GCC) implies __GNUC__ && !COMPILER(RVCT) and COMPILER(RVCT) is __CC_ARM or __ARMCC__ However I'm somewhat surprised CLANG doesn't identify itself as gcc (for compatibility). 504631 3 morrita 2011-11-17 00:34:19 -0800 > However I'm somewhat surprised CLANG doesn't identify itself as gcc (for compatibility). Whoa, good point. It actually knows __GNUC__. This patch is invalid. 115539 2011-11-17 00:22:39 -0800 2011-11-17 00:34:40 -0800 Patch bug-72582-20111117172237.patch text/plain 1339 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogOTk5MjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU4 OGNkMDljMmIxNTM2ZjM5NGJjNDFkODg4YmY0ZGU1Y2JjYTRiMWQuLjU3ZTc1NjlkNWIyMGIyNjQ0 N2YwYzJlMWE5M2JmZTk2YmU1OWEyMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTExLTE3ICBIYWppbWUgTW9ycml0YSAgPG1vcnJpdGFAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFdURl9FWFBPUlQgc2hvdWxkIGJlIGNsYW5nIGF3YXJlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI1ODIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9FeHBvcnRNYWNy b3MuaDoKKwogMjAxMS0xMS0wOSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAg ICAgICAgIERGRyBieXRlIGFycmF5IHN1cHBvcnQgc29tZXRpbWVzIGNsYW1wcyB2YWx1ZXMgaW5j b3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRXhwb3J0TWFj cm9zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0V4cG9ydE1hY3Jvcy5oCmluZGV4IDNm YWRkMzdlZTkzZWI3NDEyOGQ5NmE5ZGMxMzBmOTJlZTYwYmY5ZjMuLjM0ZmYxMDg1NTc4MDM3NjAx NTQxYWE1NjQ2M2Y3MzRlNjdlZGJlNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvRXhwb3J0TWFjcm9zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9FeHBv cnRNYWNyb3MuaApAQCAtMzUsNyArMzUsNyBAQAogI2lmICFQTEFURk9STShDSFJPTUlVTSkgJiYg T1MoV0lORE9XUykgJiYgIUNPTVBJTEVSKEdDQykKICNkZWZpbmUgV1RGX0VYUE9SVCBfX2RlY2xz cGVjKGRsbGV4cG9ydCkKICNkZWZpbmUgV1RGX0lNUE9SVCBfX2RlY2xzcGVjKGRsbGltcG9ydCkK LSNlbGlmIGRlZmluZWQoX19HTlVDX18pICYmICFkZWZpbmVkKF9fQ0NfQVJNKSAmJiAhZGVmaW5l ZChfX0FSTUNDX18pCisjZWxpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0NDX0FS TSkgJiYgIWRlZmluZWQoX19BUk1DQ19fKSB8fCBDT01QSUxFUihDTEFORykKICNkZWZpbmUgV1RG X0VYUE9SVCBfX2F0dHJpYnV0ZV9fKCh2aXNpYmlsaXR5KCJkZWZhdWx0IikpKQogI2RlZmluZSBX VEZfSU1QT1JUIFdURl9FWFBPUlQKICNlbHNlCg==