72576 2011-11-16 18:34:50 -0800 [chromium] Add some useful text to existing debug dump 2011-11-18 16:15:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh cc-bugs enne jamesr kbr webkit.review.bot oldest_to_newest 504498 0 shawnsingh 2011-11-16 18:34:50 -0800 The --show-composited-layer-tree flag shows a useful dump of the tree as text, but I had to modify it and then revert it for several patches already. Could we just add this information into the debug dump so its always there? Specifically: (1) adding the draw transform for RenderSurfaces, and (2) using "//" as a divider between columns to visualize the matrix more easily. Patch is coming in just a moment. 504501 1 115511 shawnsingh 2011-11-16 18:39:39 -0800 Created attachment 115511 Patch 504924 2 enne 2011-11-17 09:42:30 -0800 That looks really useful. This change looks good to me. 506041 3 115511 kbr 2011-11-18 14:00:54 -0800 Comment on attachment 115511 Patch Does this change affect any layout tests? These are called from CCLayerImpl::layerTreeAsText() but I don't know whether that's related to LayoutTestController's similarly named functionality. 506099 4 shawnsingh 2011-11-18 15:03:50 -0800 (In reply to comment #3) > (From update of attachment 115511 [details]) > Does this change affect any layout tests? These are called from CCLayerImpl::layerTreeAsText() but I don't know whether that's related to LayoutTestController's similarly named functionality. No, this is simply a debug dump local to our compositor code that is visualized with --show-composited-layer-tree command-line flag. Just in case, I also double-checked layout tests before and after this patch, and I don't see any obvious regressions. 506171 5 115511 webkit.review.bot 2011-11-18 16:15:05 -0800 Comment on attachment 115511 Patch Clearing flags on attachment: 115511 Committed r100823: <http://trac.webkit.org/changeset/100823> 506172 6 webkit.review.bot 2011-11-18 16:15:09 -0800 All reviewed patches have been landed. Closing bug. 115511 2011-11-16 18:39:39 -0800 2011-11-18 16:15:04 -0800 Patch bug-72576-20111116183938.patch text/plain 3714 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM1NzEwOTNiNjQwZDNm Y2Q1Zjg1MGQ3ZWRiMjUzNDk1NmVkOTRmNC4uYjE2MDc1YTNlOGZjYzFjOGZkZjQ2ZGUyMWE0MmJj MzI1ZDg2OTQ3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTE2ICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g QWRkIHNvbWUgdXNlZnVsIHRleHQgdG8gZXhpc3RpbmcgZGVidWcgZHVtcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI1NzYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllckltcGwuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q0NMYXllckltcGw6OmR1bXBMYXllclByb3BlcnRpZXMpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1JlbmRlclN1cmZhY2U6OmR1bXBTdXJmYWNlKToKKwog MjAxMS0xMS0xNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMDIxMy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJbXBsLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJJ bXBsLmNwcAppbmRleCA5MDQ4ZmRjODJkMTA1YjNjNjI2MGRlYWIxZDkxMGQxMDgxZWFhNDY2Li45 YzQxZjRlNDNlM2M3ZWM1YWZmYjFmMTZlNWIyNjYxM2FhMDdmNmIzIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVySW1wbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXll ckltcGwuY3BwCkBAIC0xODksOSArMTg5LDkgQEAgdm9pZCBDQ0xheWVySW1wbDo6ZHVtcExheWVy UHJvcGVydGllcyhUZXh0U3RyZWFtJiB0cywgaW50IGluZGVudCkgY29uc3QKIAogICAgIHdyaXRl SW5kZW50KHRzLCBpbmRlbnQpOwogICAgIHRzIDw8ICJkcmF3VHJhbnNmb3JtOiAiOwotICAgIHRz IDw8IG1fZHJhd1RyYW5zZm9ybS5tMTEoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTIo KSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTMoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5z Zm9ybS5tMTQoKSA8PCAiLCAiOwotICAgIHRzIDw8IG1fZHJhd1RyYW5zZm9ybS5tMjEoKSA8PCAi LCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMjIoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5t MjMoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMjQoKSA8PCAiLCAiOwotICAgIHRzIDw8 IG1fZHJhd1RyYW5zZm9ybS5tMzEoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMzIoKSA8 PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMzMoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9y bS5tMzQoKSA8PCAiLCAiOworICAgIHRzIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTEoKSA8PCAiLCAi IDw8IG1fZHJhd1RyYW5zZm9ybS5tMTIoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTMo KSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTQoKSA8PCAiICAvLyAgIjsKKyAgICB0cyA8 PCBtX2RyYXdUcmFuc2Zvcm0ubTIxKCkgPDwgIiwgIiA8PCBtX2RyYXdUcmFuc2Zvcm0ubTIyKCkg PDwgIiwgIiA8PCBtX2RyYXdUcmFuc2Zvcm0ubTIzKCkgPDwgIiwgIiA8PCBtX2RyYXdUcmFuc2Zv cm0ubTI0KCkgPDwgIiAgLy8gICI7CisgICAgdHMgPDwgbV9kcmF3VHJhbnNmb3JtLm0zMSgpIDw8 ICIsICIgPDwgbV9kcmF3VHJhbnNmb3JtLm0zMigpIDw8ICIsICIgPDwgbV9kcmF3VHJhbnNmb3Jt Lm0zMygpIDw8ICIsICIgPDwgbV9kcmF3VHJhbnNmb3JtLm0zNCgpIDw8ICIgIC8vICAiOwogICAg IHRzIDw8IG1fZHJhd1RyYW5zZm9ybS5tNDEoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5t NDIoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tNDMoKSA8PCAiLCAiIDw8IG1fZHJhd1Ry YW5zZm9ybS5tNDQoKSA8PCAiXG4iOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2UuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJTdXJmYWNlLmNw cAppbmRleCA0N2E3NjMxMGJlYmMxODRkODM4ZGFiYTM5YjMzYTA2ZmYyZmJmNWNkLi43Y2I5YTMy NGM5YjBiNWQwZjY2MjU2ZTJjYjMxM2JlOWNiZmYyZjEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2UuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVy U3VyZmFjZS5jcHAKQEAgLTIyOCw2ICsyMjgsMTMgQEAgdm9pZCBDQ1JlbmRlclN1cmZhY2U6OmR1 bXBTdXJmYWNlKFRleHRTdHJlYW0mIHRzLCBpbnQgaW5kZW50KSBjb25zdAogCiAgICAgd3JpdGVJ bmRlbnQodHMsIGluZGVudCsxKTsKICAgICB0cyA8PCAiY29udGVudFJlY3Q6ICgiIDw8IG1fY29u dGVudFJlY3QueCgpIDw8ICIsICIgPDwgbV9jb250ZW50UmVjdC55KCkgPDwgIiwgIiA8PCBtX2Nv bnRlbnRSZWN0LndpZHRoKCkgPDwgIiwgIiA8PCBtX2NvbnRlbnRSZWN0LmhlaWdodCgpIDw8ICJc biI7CisKKyAgICB3cml0ZUluZGVudCh0cywgaW5kZW50KzEpOworICAgIHRzIDw8ICJkcmF3VHJh bnNmb3JtOiAiOworICAgIHRzIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTEoKSA8PCAiLCAiIDw8IG1f ZHJhd1RyYW5zZm9ybS5tMTIoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTMoKSA8PCAi LCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tMTQoKSA8PCAiICAvLyAgIjsKKyAgICB0cyA8PCBtX2Ry YXdUcmFuc2Zvcm0ubTIxKCkgPDwgIiwgIiA8PCBtX2RyYXdUcmFuc2Zvcm0ubTIyKCkgPDwgIiwg IiA8PCBtX2RyYXdUcmFuc2Zvcm0ubTIzKCkgPDwgIiwgIiA8PCBtX2RyYXdUcmFuc2Zvcm0ubTI0 KCkgPDwgIiAgLy8gICI7CisgICAgdHMgPDwgbV9kcmF3VHJhbnNmb3JtLm0zMSgpIDw8ICIsICIg PDwgbV9kcmF3VHJhbnNmb3JtLm0zMigpIDw8ICIsICIgPDwgbV9kcmF3VHJhbnNmb3JtLm0zMygp IDw8ICIsICIgPDwgbV9kcmF3VHJhbnNmb3JtLm0zNCgpIDw8ICIgIC8vICAiOworICAgIHRzIDw8 IG1fZHJhd1RyYW5zZm9ybS5tNDEoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tNDIoKSA8 PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9ybS5tNDMoKSA8PCAiLCAiIDw8IG1fZHJhd1RyYW5zZm9y bS5tNDQoKSA8PCAiXG4iOwogfQogCiBpbnQgQ0NSZW5kZXJTdXJmYWNlOjpvd25pbmdMYXllcklk KCkgY29uc3QK