72573 2011-11-16 18:15:34 -0800 WebKit does not send mouse down/up/click events to ARIA tabs 2011-11-30 17:05:43 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach bdakin oldest_to_newest 504483 0 cfleizach 2011-11-16 18:15:34 -0800 WK needs to send click() when there's no actionElement 505980 1 cfleizach 2011-11-18 12:54:50 -0800 There are some more control type elements that should send the click event too when targeted 505983 2 cfleizach 2011-11-18 12:59:08 -0800 rdar://10444670 505985 3 115851 cfleizach 2011-11-18 12:59:45 -0800 Created attachment 115851 patch 512132 4 115851 bdakin 2011-11-30 14:27:58 -0800 Comment on attachment 115851 patch View in context: https://bugs.webkit.org/attachment.cgi?id=115851&action=review Overall, this seems good, but since I have one issue above and there are no ChangeLogs, I am going to r- for the time being. I will definitely r+ once you address those things though. > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:881 > + case RadioButtonRole: This shouldn't be necessary since this case should fall into the earlier conditional check: if (AccessibilityObject::isARIAInput(ariaRoleAttribute())). Right? > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:882 > + case CheckBoxRole: Same for this one. 512212 5 117291 cfleizach 2011-11-30 16:16:57 -0800 Created attachment 117291 patch 512217 6 117291 darin 2011-11-30 16:25:09 -0800 Comment on attachment 117291 patch View in context: https://bugs.webkit.org/attachment.cgi?id=117291&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:883 > return static_cast<Element*>(m_renderer->node()); This should use the toElement checked cast instead of static_cast. 512255 7 cfleizach 2011-11-30 17:03:42 -0800 http://trac.webkit.org/changeset/101571 512260 8 cfleizach 2011-11-30 17:05:43 -0800 http://trac.webkit.org/changeset/101572 115851 2011-11-18 12:59:45 -0800 2011-11-30 16:16:57 -0800 patch patch.txt text/plain 5405 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMTAwODAxKQorKysgU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtODc0LDkgKzg3NCwxOCBAQAogICAgIGlmIChtX3JlbmRlcmVyLT5pc0JveE1v ZGVsT2JqZWN0KCkgJiYgdG9SZW5kZXJCb3hNb2RlbE9iamVjdChtX3JlbmRlcmVyKS0+aXNNZW51 TGlzdCgpKQogICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG1fcmVuZGVyZXIt Pm5vZGUoKSk7CiAKLSAgICBBY2Nlc3NpYmlsaXR5Um9sZSByb2xlID0gcm9sZVZhbHVlKCk7Ci0g ICAgaWYgKHJvbGUgPT0gQnV0dG9uUm9sZSB8fCByb2xlID09IFBvcFVwQnV0dG9uUm9sZSkKKyAg ICBzd2l0Y2ggKHJvbGVWYWx1ZSgpKSB7CisgICAgY2FzZSBCdXR0b25Sb2xlOgorICAgIGNhc2Ug UG9wVXBCdXR0b25Sb2xlOgorICAgIGNhc2UgVGFiUm9sZToKKyAgICBjYXNlIFJhZGlvQnV0dG9u Um9sZToKKyAgICBjYXNlIENoZWNrQm94Um9sZToKKyAgICBjYXNlIE1lbnVJdGVtUm9sZToKKyAg ICBjYXNlIExpc3RJdGVtUm9sZToKICAgICAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEVsZW1lbnQq PihtX3JlbmRlcmVyLT5ub2RlKCkpOyAKKyAgICBkZWZhdWx0OgorICAgICAgICBicmVhazsKKyAg ICB9CiAgICAgCiAgICAgRWxlbWVudCogZWx0ID0gYW5jaG9yRWxlbWVudCgpOwogICAgIGlmICgh ZWx0KQpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wcmVzcy13b3Jrcy1vbi1jb250 cm9sLXR5cGVzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3Np YmlsaXR5L3ByZXNzLXdvcmtzLW9uLWNvbnRyb2wtdHlwZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wcmVzcy13b3Jrcy1vbi1jb250cm9s LXR5cGVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNyBAQAorZ3JvdXAK K2J1dHRvbgordGFiIGJ1dHRvbgorcmFkaW8KK2NoZWNrYm94CittZW51IGl0ZW0KK21lbnUgaXRl bSBjaGVja2JveAorbWVudSBpdGVtIHJhZGlvCitsaXN0IGl0ZW0KK1RoaXMgdGVzdHMgdGhhdCB3 aGVuIGNlcnRhaW4gY29udHJvbCB0eXBlIGVsZW1lbnRzIGFyZSBwcmVzc2VkLCBhIHZhbGlkIGV2 ZW50IGlzIHNlbnQgdGhhdCByZWZlcmVuY2VzIHRoZSByaWdodCBlbGVtZW50LgorCitPbiBzdWNj ZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBi eSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ2JvZHknKSBpcyB0cnVlCitQQVNTIGV2ZW50U3JjRWxlbWVudCA9PSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYnV0dG9uJykgaXMgdHJ1ZQorUEFTUyBldmVudFNyY0Vs ZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RhYicpIGlzIHRydWUKK1BBU1MgZXZl bnRTcmNFbGVtZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdyYWRpbycpIGlzIHRydWUK K1BBU1MgZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjaGVja2Jv eCcpIGlzIHRydWUKK1BBU1MgZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdtZW51aXRlbScpIGlzIHRydWUKK1BBU1MgZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdtZW51aXRlbWNoZWNrYm94JykgaXMgdHJ1ZQorUEFTUyBldmVudFNy Y0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ21lbnVpdGVtcmFkaW8nKSBpcyB0 cnVlCitQQVNTIGV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbGlz dGl0ZW0nKSBpcyB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9wcmVzcy13b3Jrcy1v bi1jb250cm9sLXR5cGVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9wcmVzcy13b3Jrcy1vbi1jb250cm9sLXR5cGVzLmh0bWwJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNzLXdvcmtzLW9uLWNvbnRyb2wtdHlwZXMuaHRt bAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2OSBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICIt Ly9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9m YXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eSBpZD0iYm9keSI+CisKKzxkaXYgcm9sZT0iZ3JvdXAiIGlkPSJncm91cCIgdGFiaW5kZXg9IjAi Pmdyb3VwPC9kaXY+Cis8ZGl2IHJvbGU9ImJ1dHRvbiIgaWQ9ImJ1dHRvbiIgdGFiaW5kZXg9IjAi PmJ1dHRvbjwvZGl2PgorPGRpdiByb2xlPSJ0YWIiIGlkPSJ0YWIiIHRhYmluZGV4PSIwIj50YWIg YnV0dG9uPC9kaXY+Cis8ZGl2IHJvbGU9InJhZGlvIiBpZD0icmFkaW8iIHRhYmluZGV4PSIwIj5y YWRpbzwvZGl2PgorPGRpdiByb2xlPSJjaGVja2JveCIgaWQ9ImNoZWNrYm94IiB0YWJpbmRleD0i MCI+Y2hlY2tib3g8L2Rpdj4KKzxkaXYgcm9sZT0ibWVudWl0ZW0iIGlkPSJtZW51aXRlbSIgdGFi aW5kZXg9IjAiPm1lbnUgaXRlbTwvZGl2PgorPGRpdiByb2xlPSJtZW51aXRlbWNoZWNrYm94IiBp ZD0ibWVudWl0ZW1jaGVja2JveCIgdGFiaW5kZXg9IjAiPm1lbnUgaXRlbSBjaGVja2JveDwvZGl2 PgorPGRpdiByb2xlPSJtZW51aXRlbXJhZGlvIiBpZD0ibWVudWl0ZW1yYWRpbyIgdGFiaW5kZXg9 IjAiPm1lbnUgaXRlbSByYWRpbzwvZGl2PgorPGRpdiByb2xlPSJsaXN0aXRlbSIgaWQ9Imxpc3Rp dGVtIiB0YWJpbmRleD0iMCI+bGlzdCBpdGVtPC9kaXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+ PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+CisKKyAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiYm9keSIpLm9ubW91c2Vkb3duID0gaGFuZGxlUHJlc3M7CisKKyAg ICB2YXIgcHJlc3NDb3VudCA9IDA7CisgICAgdmFyIGV2ZW50U3JjRWxlbWVudDsKKyAgICBmdW5j dGlvbiBoYW5kbGVQcmVzcyhlKSB7CisgICAgICAgZXZlbnRTcmNFbGVtZW50ID0gZS5zcmNFbGVt ZW50OworCisgICAgICAgLy8gRmlyc3QgcHJlc3Mgd2FzIG9uIHRoZSBncm91cCBlbGVtZW50LiBU aGF0IGlzIG5vdCBhIGNvbnRyb2wgdHlwZSBhbmQgaXQgc2hvdWxkCisgICAgICAgLy8gaGF2ZSBj YXVzZWQgdGhlIGJvZHkgdG8gYmUgdGhlIHRhcmdldCBlbGVtZW50IGluc3RlYWQgb2YgdGhlIGdy b3VwIGVsZW1lbnQuCisgICAgICAgaWYgKHByZXNzQ291bnQgPT0gMCkKKyAgICAgICAgICBzaG91 bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm9k eScpIik7CisgICAgICAgZWxzZSBpZiAocHJlc3NDb3VudCA9PSAxKQorICAgICAgICAgIHNob3Vs ZEJlVHJ1ZSgiZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdidXR0 b24nKSIpOworICAgICAgIGVsc2UgaWYgKHByZXNzQ291bnQgPT0gMikKKyAgICAgICAgICBzaG91 bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGFi JykiKTsKKyAgICAgICBlbHNlIGlmIChwcmVzc0NvdW50ID09IDMpCisgICAgICAgICAgc2hvdWxk QmVUcnVlKCJldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JhZGlv JykiKTsKKyAgICAgICBlbHNlIGlmIChwcmVzc0NvdW50ID09IDQpCisgICAgICAgICAgc2hvdWxk QmVUcnVlKCJldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NoZWNr Ym94JykiKTsKKyAgICAgICBlbHNlIGlmIChwcmVzc0NvdW50ID09IDUpCisgICAgICAgICAgc2hv dWxkQmVUcnVlKCJldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ21l bnVpdGVtJykiKTsKKyAgICAgICBlbHNlIGlmIChwcmVzc0NvdW50ID09IDYpCisgICAgICAgICAg c2hvdWxkQmVUcnVlKCJldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J21lbnVpdGVtY2hlY2tib3gnKSIpOworICAgICAgIGVsc2UgaWYgKHByZXNzQ291bnQgPT0gNykK KyAgICAgICAgICBzaG91bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgnbWVudWl0ZW1yYWRpbycpIik7CisgICAgICAgZWxzZSBpZiAocHJlc3NDb3Vu dCA9PSA4KQorICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiZXZlbnRTcmNFbGVtZW50ID09IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdsaXN0aXRlbScpIik7CisKKyAgICAgICBwcmVzc0NvdW50Kys7 CisgICAgfQorCisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB3aGVuIGNlcnRhaW4g Y29udHJvbCB0eXBlIGVsZW1lbnRzIGFyZSBwcmVzc2VkLCBhIHZhbGlkIGV2ZW50IGlzIHNlbnQg dGhhdCByZWZlcmVuY2VzIHRoZSByaWdodCBlbGVtZW50LiIpOworCisgICAgaWYgKHdpbmRvdy5h Y2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworCisgICAgICAgIHZhciBpdGVtcyA9IG5ldyBBcnJh eSgiZ3JvdXAiLCAiYnV0dG9uIiwgInRhYiIsICJyYWRpbyIsICJjaGVja2JveCIsICJtZW51aXRl bSIsICJtZW51aXRlbWNoZWNrYm94IiwgIm1lbnVpdGVtcmFkaW8iLCAibGlzdGl0ZW0iKTsKKyAg ICAgICAgZm9yICh2YXIgayA9IDA7IGsgPCBpdGVtcy5sZW5ndGg7IGsrKykgeworICAgICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChpdGVtc1trXSkuZm9jdXMoKTsKKyAgICAgICAgICAg YWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQucHJlc3MoKTsKKyAgICAgICAg fQorICAgIH0KKworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo= 117291 2011-11-30 16:16:57 -0800 2011-11-30 16:25:09 -0800 patch patch.txt text/plain 6907 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMTU2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTExLTMwICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0IGRvZXMgbm90 IHNlbmQgbW91c2UgZG93bi91cC9jbGljayBldmVudHMgdG8gQVJJQSB0YWJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGFyZSBhIG51bWJlciBv ZiAiY29udHJvbCIgdHlwZSBlbGVtZW50cyB0aGF0IHNob3VsZCBwZXJmb3JtIGEgY2xpY2sgb24g dGhlIGFjdHVhbCBlbGVtZW50LgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvcHJlc3Mt d29ya3Mtb24tY29udHJvbC10eXBlcy5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdDo6YWN0aW9uRWxlbWVudCk6CisKIDIwMTEtMTEtMzAgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ2Fubm90IHNlbGVjdCBSVEwgdGV4 dCBpbnNpZGUgTFRSIHRleHQgZnJvbSByaWdodCB0byBsZWZ0IGJ5IGEgbW91c2UgZHJhZwpJbmRl eDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAxMDE1NjQpCisrKyBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC04NzQsOSArODc0LDE2IEBACiAgICAgaWYgKG1fcmVuZGVyZXItPmlzQm94TW9kZWxP YmplY3QoKSAmJiB0b1JlbmRlckJveE1vZGVsT2JqZWN0KG1fcmVuZGVyZXIpLT5pc01lbnVMaXN0 KCkpCiAgICAgICAgIHJldHVybiBzdGF0aWNfY2FzdDxFbGVtZW50Kj4obV9yZW5kZXJlci0+bm9k ZSgpKTsKIAotICAgIEFjY2Vzc2liaWxpdHlSb2xlIHJvbGUgPSByb2xlVmFsdWUoKTsKLSAgICBp ZiAocm9sZSA9PSBCdXR0b25Sb2xlIHx8IHJvbGUgPT0gUG9wVXBCdXR0b25Sb2xlKQorICAgIHN3 aXRjaCAocm9sZVZhbHVlKCkpIHsKKyAgICBjYXNlIEJ1dHRvblJvbGU6CisgICAgY2FzZSBQb3BV cEJ1dHRvblJvbGU6CisgICAgY2FzZSBUYWJSb2xlOgorICAgIGNhc2UgTWVudUl0ZW1Sb2xlOgor ICAgIGNhc2UgTGlzdEl0ZW1Sb2xlOgogICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8RWxlbWVu dCo+KG1fcmVuZGVyZXItPm5vZGUoKSk7IAorICAgIGRlZmF1bHQ6CisgICAgICAgIGJyZWFrOwor ICAgIH0KICAgICAKICAgICBFbGVtZW50KiBlbHQgPSBhbmNob3JFbGVtZW50KCk7CiAgICAgaWYg KCFlbHQpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDE1NjQpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMS0zMCAgQ2hyaXMgRmxl aXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdCBkb2VzIG5vdCBz ZW5kIG1vdXNlIGRvd24vdXAvY2xpY2sgZXZlbnRzIHRvIEFSSUEgdGFicworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI1NzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvcHJlc3Mt d29ya3Mtb24tY29udHJvbC10eXBlcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvcHJlc3Mtd29ya3Mtb24tY29udHJvbC10eXBlcy5odG1sOiBBZGRlZC4KKwog MjAxMS0xMS0zMCAgVmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtDaHJvbWl1bV0gQWRkaW5nIGJhc2VsaW5lIHZhcmlhdGlvbnMgZm9yIHBsYXRmb3JtIHNw ZWNpZmljIGNvbG9yIGRpZmZlcmVuY2VzCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L3ByZXNzLXdvcmtzLW9uLWNvbnRyb2wtdHlwZXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvcHJlc3Mtd29ya3Mtb24tY29udHJvbC10eXBlcy1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3By ZXNzLXdvcmtzLW9uLWNvbnRyb2wtdHlwZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDI3IEBACitncm91cAorYnV0dG9uCit0YWIgYnV0dG9uCityYWRpbworY2hlY2tib3gK K21lbnUgaXRlbQorbWVudSBpdGVtIGNoZWNrYm94CittZW51IGl0ZW0gcmFkaW8KK2xpc3QgaXRl bQorVGhpcyB0ZXN0cyB0aGF0IHdoZW4gY2VydGFpbiBjb250cm9sIHR5cGUgZWxlbWVudHMgYXJl IHByZXNzZWQsIGEgdmFsaWQgZXZlbnQgaXMgc2VudCB0aGF0IHJlZmVyZW5jZXMgdGhlIHJpZ2h0 IGVsZW1lbnQuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIGV2ZW50U3Jj RWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm9keScpIGlzIHRydWUKK1BBU1Mg ZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdidXR0b24nKSBpcyB0 cnVlCitQQVNTIGV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGFi JykgaXMgdHJ1ZQorUEFTUyBldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3JhZGlvJykgaXMgdHJ1ZQorUEFTUyBldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ2NoZWNrYm94JykgaXMgdHJ1ZQorUEFTUyBldmVudFNyY0VsZW1lbnQgPT0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ21lbnVpdGVtJykgaXMgdHJ1ZQorUEFTUyBldmVudFNy Y0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ21lbnVpdGVtY2hlY2tib3gnKSBp cyB0cnVlCitQQVNTIGV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn bWVudWl0ZW1yYWRpbycpIGlzIHRydWUKK1BBU1MgZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdsaXN0aXRlbScpIGlzIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3Np YmlsaXR5L3ByZXNzLXdvcmtzLW9uLWNvbnRyb2wtdHlwZXMuaHRtbAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3ByZXNzLXdvcmtzLW9uLWNvbnRyb2wtdHlwZXMuaHRt bAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvcHJlc3Mtd29ya3Mt b24tY29udHJvbC10eXBlcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDY5IEBACis8IURP Q1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFk PgorPHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiByb2xlPSJncm91cCIgaWQ9 Imdyb3VwIiB0YWJpbmRleD0iMCI+Z3JvdXA8L2Rpdj4KKzxkaXYgcm9sZT0iYnV0dG9uIiBpZD0i YnV0dG9uIiB0YWJpbmRleD0iMCI+YnV0dG9uPC9kaXY+Cis8ZGl2IHJvbGU9InRhYiIgaWQ9InRh YiIgdGFiaW5kZXg9IjAiPnRhYiBidXR0b248L2Rpdj4KKzxkaXYgcm9sZT0icmFkaW8iIGlkPSJy YWRpbyIgdGFiaW5kZXg9IjAiPnJhZGlvPC9kaXY+Cis8ZGl2IHJvbGU9ImNoZWNrYm94IiBpZD0i Y2hlY2tib3giIHRhYmluZGV4PSIwIj5jaGVja2JveDwvZGl2PgorPGRpdiByb2xlPSJtZW51aXRl bSIgaWQ9Im1lbnVpdGVtIiB0YWJpbmRleD0iMCI+bWVudSBpdGVtPC9kaXY+Cis8ZGl2IHJvbGU9 Im1lbnVpdGVtY2hlY2tib3giIGlkPSJtZW51aXRlbWNoZWNrYm94IiB0YWJpbmRleD0iMCI+bWVu dSBpdGVtIGNoZWNrYm94PC9kaXY+Cis8ZGl2IHJvbGU9Im1lbnVpdGVtcmFkaW8iIGlkPSJtZW51 aXRlbXJhZGlvIiB0YWJpbmRleD0iMCI+bWVudSBpdGVtIHJhZGlvPC9kaXY+Cis8ZGl2IHJvbGU9 Imxpc3RpdGVtIiBpZD0ibGlzdGl0ZW0iIHRhYmluZGV4PSIwIj5saXN0IGl0ZW08L2Rpdj4KKwor PHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNj cmlwdD4KKworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib2R5Iikub25tb3VzZWRvd24g PSBoYW5kbGVQcmVzczsKKworICAgIHZhciBwcmVzc0NvdW50ID0gMDsKKyAgICB2YXIgZXZlbnRT cmNFbGVtZW50OworICAgIGZ1bmN0aW9uIGhhbmRsZVByZXNzKGUpIHsKKyAgICAgICBldmVudFNy Y0VsZW1lbnQgPSBlLnNyY0VsZW1lbnQ7CisKKyAgICAgICAvLyBGaXJzdCBwcmVzcyB3YXMgb24g dGhlIGdyb3VwIGVsZW1lbnQuIFRoYXQgaXMgbm90IGEgY29udHJvbCB0eXBlIGFuZCBpdCBzaG91 bGQKKyAgICAgICAvLyBoYXZlIGNhdXNlZCB0aGUgYm9keSB0byBiZSB0aGUgdGFyZ2V0IGVsZW1l bnQgaW5zdGVhZCBvZiB0aGUgZ3JvdXAgZWxlbWVudC4KKyAgICAgICBpZiAocHJlc3NDb3VudCA9 PSAwKQorICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdib2R5JykiKTsKKyAgICAgICBlbHNlIGlmIChwcmVzc0NvdW50ID09 IDEpCisgICAgICAgICAgc2hvdWxkQmVUcnVlKCJldmVudFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ2J1dHRvbicpIik7CisgICAgICAgZWxzZSBpZiAocHJlc3NDb3VudCA9 PSAyKQorICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiZXZlbnRTcmNFbGVtZW50ID09IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCd0YWInKSIpOworICAgICAgIGVsc2UgaWYgKHByZXNzQ291bnQgPT0g MykKKyAgICAgICAgICBzaG91bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgncmFkaW8nKSIpOworICAgICAgIGVsc2UgaWYgKHByZXNzQ291bnQgPT0g NCkKKyAgICAgICAgICBzaG91bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgnY2hlY2tib3gnKSIpOworICAgICAgIGVsc2UgaWYgKHByZXNzQ291bnQg PT0gNSkKKyAgICAgICAgICBzaG91bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnbWVudWl0ZW0nKSIpOworICAgICAgIGVsc2UgaWYgKHByZXNzQ291 bnQgPT0gNikKKyAgICAgICAgICBzaG91bGRCZVRydWUoImV2ZW50U3JjRWxlbWVudCA9PSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnbWVudWl0ZW1jaGVja2JveCcpIik7CisgICAgICAgZWxzZSBp ZiAocHJlc3NDb3VudCA9PSA3KQorICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiZXZlbnRTcmNFbGVt ZW50ID09IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdtZW51aXRlbXJhZGlvJykiKTsKKyAgICAg ICBlbHNlIGlmIChwcmVzc0NvdW50ID09IDgpCisgICAgICAgICAgc2hvdWxkQmVUcnVlKCJldmVu dFNyY0VsZW1lbnQgPT0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xpc3RpdGVtJykiKTsKKwor ICAgICAgIHByZXNzQ291bnQrKzsKKyAgICB9CisKKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 cyB0aGF0IHdoZW4gY2VydGFpbiBjb250cm9sIHR5cGUgZWxlbWVudHMgYXJlIHByZXNzZWQsIGEg dmFsaWQgZXZlbnQgaXMgc2VudCB0aGF0IHJlZmVyZW5jZXMgdGhlIHJpZ2h0IGVsZW1lbnQuIik7 CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAgICAgICAg dmFyIGl0ZW1zID0gbmV3IEFycmF5KCJncm91cCIsICJidXR0b24iLCAidGFiIiwgInJhZGlvIiwg ImNoZWNrYm94IiwgIm1lbnVpdGVtIiwgIm1lbnVpdGVtY2hlY2tib3giLCAibWVudWl0ZW1yYWRp byIsICJsaXN0aXRlbSIpOworICAgICAgICBmb3IgKHZhciBrID0gMDsgayA8IGl0ZW1zLmxlbmd0 aDsgaysrKSB7CisgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKGl0ZW1zW2tdKS5m b2N1cygpOworICAgICAgICAgICBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVu dC5wcmVzcygpOworICAgICAgICB9CisgICAgfQorCis8L3NjcmlwdD4KKworPHNjcmlwdCBzcmM9 Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==