72568 2011-11-16 17:33:35 -0800 bool WebChromeClient::shouldInterruptJavaScript casts pointer to bool and always returns true 2011-11-18 11:13:42 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adauria adauria aroben ddkilzer ggaren joepeck webkit.review.bot oldest_to_newest 504449 0 adauria 2011-11-16 17:33:35 -0800 bool WebChromeClient::shouldInterruptJavaScript() uses CallUIDelegate instead of CallUIDelegateReturningBoolean. This causes shouldInterruptJavaScript() to cast a pointer to a bool, thereby always returning true. 505011 1 115629 adauria 2011-11-17 11:28:48 -0800 Created attachment 115629 Patch 505725 2 115629 ddkilzer 2011-11-18 06:08:35 -0800 Comment on attachment 115629 Patch R=me=me 505899 3 ggaren 2011-11-18 10:45:31 -0800 r=me too! 505913 4 115629 webkit.review.bot 2011-11-18 10:58:18 -0800 Comment on attachment 115629 Patch Clearing flags on attachment: 115629 Committed r100792: <http://trac.webkit.org/changeset/100792> 505914 5 webkit.review.bot 2011-11-18 10:58:23 -0800 All reviewed patches have been landed. Closing bug. 505927 6 aroben 2011-11-18 11:13:42 -0800 It should be possible to write a regression test for this using TestWebKitAPI. 115629 2011-11-17 11:28:48 -0800 2011-11-18 10:58:18 -0800 Patch bug-72568-20111117112846.patch text/plain 1655 adauria SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDY0NykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTExLTE2 ICBBbnRvbiBEJ0F1cmlhICA8YWRhdXJpYUBhcHBsZS5jb20+CisKKyAgICAgICAgYm9vbCBXZWJD aHJvbWVDbGllbnQ6OnNob3VsZEludGVycnVwdEphdmFTY3JpcHQgY2FzdHMgcG9pbnRlciB0byBi b29sIGFuZCBhbHdheXMgcmV0dXJucyB0cnVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD03MjU2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYkNocm9tZUNsaWVudDo6c2hvdWxkSW50ZXJydXB0SmF2YVNj cmlwdCBjYWxsZWQgQ2FsbFVJRGVsZWdhdGUsIHdoaWNoIHVzZWQgYW4gaWQKKyAgICAgICAgYXMg dGhlIHJldHVybiB2YWx1ZSwgd2hpY2ggd2FzIHRoZW4gY2FzdCB0byBhIGJvb2wgYW5kIGFsd2F5 cyByZXR1cm5lZCB0cnVlLiBUaGlzCisgICAgICAgIHBhdGNoIHVzZXMgQ2FsbFVJRGVsZWdhdGVS ZXR1cm5pbmdCb29sZWFuIGluc3RlYWQgb2YgQ2FsbFVJRGVsZWdhdGUsIHdpdGggdGhlIGRlZmF1 bHQKKyAgICAgICAgcmV0dXJuIHZhbHVlIG9mIE5PLgorCisgICAgICAgICogV2ViQ29yZVN1cHBv cnQvV2ViQ2hyb21lQ2xpZW50Lm1tOgorICAgICAgICAoV2ViQ2hyb21lQ2xpZW50OjpzaG91bGRJ bnRlcnJ1cHRKYXZhU2NyaXB0KToKKwogMjAxMS0xMS0xNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdC9tYWMgcGFydCBvZiA8cmRhcjovL3Byb2JsZW0v MTAyNjIyNDI+IEFkZCBBUEkgZm9yIHBhZ2luYXRlZCBkaXNwbGF5CkluZGV4OiBTb3VyY2UvV2Vi S2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50Lm1tCShyZXZp c2lvbiAxMDA2NDcpCisrKyBTb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJv bWVDbGllbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTUyNCw3ICs1MjQsNyBAQCBib29sIFdlYkNo cm9tZUNsaWVudDo6cnVuSmF2YVNjcmlwdFByb21wCiAKIGJvb2wgV2ViQ2hyb21lQ2xpZW50Ojpz aG91bGRJbnRlcnJ1cHRKYXZhU2NyaXB0KCkKIHsKLSAgICByZXR1cm4gQ2FsbFVJRGVsZWdhdGUo bV93ZWJWaWV3LCBAc2VsZWN0b3Iod2ViVmlld1Nob3VsZEludGVycnVwdEphdmFTY3JpcHQ6KSk7 CisgICAgcmV0dXJuIENhbGxVSURlbGVnYXRlUmV0dXJuaW5nQm9vbGVhbihOTywgbV93ZWJWaWV3 LCBAc2VsZWN0b3Iod2ViVmlld1Nob3VsZEludGVycnVwdEphdmFTY3JpcHQ6KSk7CiB9CiAKIHZv aWQgV2ViQ2hyb21lQ2xpZW50OjpzZXRTdGF0dXNiYXJUZXh0KGNvbnN0IFN0cmluZyYgc3RhdHVz KQo=