72562 2011-11-16 16:09:06 -0800 [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory 2011-11-16 17:14:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dpranke ojan scherkus tkent tonyg vrk webkit.review.bot oldest_to_newest 504365 0 jamesr 2011-11-16 16:09:06 -0800 [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory 504369 1 115472 jamesr 2011-11-16 16:10:46 -0800 Created attachment 115472 Patch 504371 2 jamesr 2011-11-16 16:12:32 -0800 When moving the compositing/ tests to the main layout test run I left the accelerated video and canvas 2d triggers off by default. I think this is a mistake - we should turn those triggers on for tests within compositing/ so we can verify the compositor interactions and leave them off for the rest of the tree, unless the tests turn themselves turn these features on via explicit triggers. 504423 3 115472 webkit.review.bot 2011-11-16 17:14:21 -0800 Comment on attachment 115472 Patch Clearing flags on attachment: 115472 Committed r100533: <http://trac.webkit.org/changeset/100533> 504424 4 webkit.review.bot 2011-11-16 17:14:28 -0800 All reviewed patches have been landed. Closing bug. 115472 2011-11-16 16:10:46 -0800 2011-11-16 17:14:21 -0800 Patch bug-72562-20111116161044.patch text/plain 4068 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNTE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWUyN2I4OWY3OTc4ZDNiNmEyYmNiNmM3MzU2ZmM5MGM1 MDJhOGU5OC4uZDU3OTVjZDkwZjgxOTZlNGQ0ODBlMDU1ZTZiZmM4Mzc1YmVmNWUyYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTExLTE2ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW2Nocm9taXVtXSBFbmFibGUgdmlkZW8gYW5kIGNhbnZhcyAyZCBjb21wb3NpdGlu ZyB0cmlnZ2VycyBieSBkZWZhdWx0IGZvciBsYXlvdXQgdGVzdHMgaW4gdGhlIGNvbXBvc2l0aW5n IGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzI1NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHA6CisgICAgICAgIChUZXN0 U2hlbGw6OnJ1bkZpbGVUZXN0KToKKwogMjAxMS0xMS0xNiAgVG9ueSBDaGFuZyAgPHRvbnlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtOUldUXSBzcGVjdWxhdGl2ZSBmaXggZm9yIG11bHRpcGxl IHN1YnByb2Nlc3MgdGVzdCBvbiBjeWd3aW4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9UZXN0U2hlbGwuY3BwCmluZGV4IDQ5NGFmNDA5YzllNTI0MDc4ZjE3N2VmYmE1OWY2MTI1N2Jk ZTQyMmEuLmNiMWUyMTliMDc2NmI4YjkwOWU2M2MwZDhkYjAxMmMzMjhmYmQ0OTggMTAwNjQ0Ci0t LSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKKysrIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcApAQCAtMjE4LDYgKzIxOCwx MiBAQCB2b2lkIFRlc3RTaGVsbDo6cnVuRmlsZVRlc3QoY29uc3QgVGVzdFBhcmFtcyYgcGFyYW1z KQogICAgICAgICB8fCB0ZXN0VXJsLmZpbmQoImxvYWRpbmdcXCIpICE9IHN0cmluZzo6bnBvcykK ICAgICAgICAgbV9sYXlvdXRUZXN0Q29udHJvbGxlci0+c2V0U2hvdWxkRHVtcEZyYW1lTG9hZENh bGxiYWNrcyh0cnVlKTsKIAorICAgIGlmICh0ZXN0VXJsLmZpbmQoImNvbXBvc2l0aW5nLyIpICE9 IHN0cmluZzo6bnBvcyB8fCB0ZXN0VXJsLmZpbmQoImNvbXBvc2l0aW5nXFwiKSAhPSBzdHJpbmc6 Om5wb3MpIHsKKyAgICAgICAgbV9wcmVmcy5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yVmlkZW9F bmFibGVkID0gdHJ1ZTsKKyAgICAgICAgbV9wcmVmcy5hY2NlbGVyYXRlZDJkQ2FudmFzRW5hYmxl ZCA9IHRydWU7CisgICAgICAgIG1fcHJlZnMuYXBwbHlUbyhtX3dlYlZpZXcpOworICAgIH0KKwog ICAgIGlmICh0ZXN0VXJsLmZpbmQoIi9kdW1wQXNUZXh0LyIpICE9IHN0cmluZzo6bnBvcwogICAg ICAgICB8fCB0ZXN0VXJsLmZpbmQoIlxcZHVtcEFzVGV4dFxcIikgIT0gc3RyaW5nOjpucG9zKSB7 CiAgICAgICAgIG1fbGF5b3V0VGVzdENvbnRyb2xsZXItPnNldFNob3VsZER1bXBBc1RleHQodHJ1 ZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggOWU1YWI0YzFlYzA5YmZmMzUzOWZkM2I5MjFkZmZkOTc4NzVhZjU0OS4uMGY5 ZWU0OTI3ZmQ3Mzk3OGMyZDI1M2IwZDEzMTJjZjZiNDhiNzczOCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTExLTE2ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW2Nocm9taXVtXSBFbmFibGUgdmlkZW8gYW5kIGNhbnZhcyAyZCBjb21wb3NpdGlu ZyB0cmlnZ2VycyBieSBkZWZhdWx0IGZvciBsYXlvdXQgdGVzdHMgaW4gdGhlIGNvbXBvc2l0aW5n IGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzI1NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDoKKwogMjAxMS0xMS0x NiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERGRyBnbG9iYWwg dmFyaWFibGUgQ1NFIG1pc2hhbmRsZXMgdGhlIGNyb3NzLWdsb2JhbC1vYmplY3QgaW5saW5pbmcg Y29ybmVyIGNhc2UKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dAppbmRleCA2NDg4ZjgxNjNlMTAyZDQ4Y2QyMDk1ZmJhNTgxZmU2OWI5 OTFiODk4Li4yYWUwN2MyYmQ2Y2ZkOTIzYzYwMzY3NzRjYzczOTBhOTdiMjc0YTFhIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0 CkBAIC0yNTQsMTIgKzI1NCwxNiBAQCBXT05URklYIFNLSVAgOiBmYXN0L2NhbnZhcy9jYW52YXMt Z3JhZGllbnQtYWRkU3RvcC1lcnJvci5odG1sID0gRkFJTAogLy8gdGhpcyB0ZXN0IHdpbGwgYWx3 YXlzIGZhaWwuCiBXT05URklYIFNLSVAgTElOVVggV0lOIDogZmFzdC9ldmVudHMvb3B0aW9uLXRh Yi5odG1sID0gRkFJTAogCi0vLyBwcm9iYWJseSBhcmVuJ3QgYXBwbGljYWJsZSB0byB0aGlzIGNv bmZpZwotQlVHV0s3MjQwMiA6IGNvbXBvc2l0aW5nL3ZpZGVvLXBhZ2UtdmlzaWJpbGl0eS5odG1s ID0gRkFJTAotQlVHV0s3MjQwMiA6IGNvbXBvc2l0aW5nL2dlb21ldHJ5L2NsaXBwZWQtdmlkZW8t Y29udHJvbGxlci5odG1sID0gRkFJTAotQlVHV0s3MjQwMiA6IGNvbXBvc2l0aW5nL2dlb21ldHJ5 L3ZpZGVvLWZpeGVkLXNjcm9sbGluZy5odG1sID0gRkFJTAotQlVHV0s3MjQwMiA6IGNvbXBvc2l0 aW5nL2dlb21ldHJ5L3ZpZGVvLW9wYWNpdHktb3ZlcmxheS5odG1sID0gRkFJTAotQlVHV0s3MjQw MiA6IGNvbXBvc2l0aW5nL2xheWVyLWNyZWF0aW9uL3NwYW5PdmVybGFwc0NhbnZhcy5odG1sID0g RkFJTAorLy8gV2lsbCBuZWVkIHJlYmFzZWxpbmVzIGZvciBuZXcgY29tcG9zaXRpbmcgdHJpZ2dl cnMKK0JVR0pBTUVTUiA6IGNvbXBvc2l0aW5nL3ZpZGVvLXBhZ2UtdmlzaWJpbGl0eS5odG1sID0g RkFJTAorQlVHSkFNRVNSIDogY29tcG9zaXRpbmcvZ2VvbWV0cnkvY2xpcHBlZC12aWRlby1jb250 cm9sbGVyLmh0bWwgPSBGQUlMCitCVUdKQU1FU1IgOiBjb21wb3NpdGluZy9nZW9tZXRyeS92aWRl by1maXhlZC1zY3JvbGxpbmcuaHRtbCA9IEZBSUwKK0JVR0pBTUVTUiA6IGNvbXBvc2l0aW5nL2dl b21ldHJ5L3ZpZGVvLW9wYWNpdHktb3ZlcmxheS5odG1sID0gRkFJTAorQlVHSkFNRVNSIDogY29t cG9zaXRpbmcvbGF5ZXItY3JlYXRpb24vc3Bhbk92ZXJsYXBzQ2FudmFzLmh0bWwgPSBGQUlMCitC VUdKQU1FU1IgOiBjb21wb3NpdGluZy9sYXllcnMtaW5zaWRlLW92ZXJmbG93LXNjcm9sbC5odG1s ID0gRkFJTAorQlVHSkFNRVNSIDogY29tcG9zaXRpbmcvb3ZlcmZsb3cvb3ZlcmZsb3ctY29tcG9z aXRpbmctZGVzY2VuZGFudC5odG1sID0gRkFJTAorQlVHSkFNRVNSIDogY29tcG9zaXRpbmcvb3Zl cmZsb3cvc2Nyb2xsLWFuY2VzdG9yLXVwZGF0ZS5odG1sID0gRkFJTAorQlVHSkFNRVNSIDogY29t cG9zaXRpbmcvc2VsZi1wYWludGluZy1sYXllcnMuaHRtbCA9IEZBSUwKIAogLy8gdGV4dCBmYWls dXJlcyBvbiBldmVyeSBwbGF0Zm9ybS4gYXBwZWFycyB0byBiZSBhIHJlYWwgaXNzdWUKIEJVR1dL NzI0MDIgOiBjb21wb3NpdGluZy9nZW9tZXRyeS9saW1pdC1sYXllci1ib3VuZHMtY2xpcHBpbmct YW5jZXN0b3IuaHRtbCA9IFRFWFQK