72556 2011-11-16 15:07:00 -0800 JS wrappers of DOM objects should have no-op constructors 2011-11-16 15:46:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam abarth japhet webkit.review.bot oldest_to_newest 504303 0 sam 2011-11-16 15:07:00 -0800 JS wrappers of DOM objects should have no-op constructors 504315 1 115459 sam 2011-11-16 15:24:49 -0800 Created attachment 115459 Patch 504322 2 115459 ggaren 2011-11-16 15:29:14 -0800 Comment on attachment 115459 Patch r=me 504339 3 sam 2011-11-16 15:46:59 -0800 Committed r100517: <http://trac.webkit.org/changeset/100517> 115459 2011-11-16 15:24:49 -0800 2011-11-16 15:29:14 -0800 Patch bug-72556-20111116152448.patch text/plain 5261 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDUxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMzIEBACisyMDExLTExLTE2ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgSlMgd3JhcHBlcnMgb2YgRE9NIG9iamVj dHMgc2hvdWxkIGhhdmUgbm8tb3AgY29uc3RydWN0b3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgdXNpbmcgYSBSZWZQdHIgdG8gaG9sZCBET00g b2JqZWN0cyBjb250YWluZWQgYnkgSmF2YVNjcmlwdAorICAgICAgICB3cmFwcGVycyBhbmQgaW5z dGVhZCB1c2UgYSByYXcgcG9pbnRlci4gV2Ugd2VyZSBhbHJlYWR5IHJlbGVhc2luZworICAgICAg ICB0aGUgdW5kZXJseWluZyBvYmplY3QgYmVmb3JlIHRoZSBkZXN0cnVjdG9yIHJhbiAodmlhIHRo ZSBmaW5hbGl6ZXIpCisgICAgICAgIHNvIHRoZSBkZWZhdWx0IGJlaGF2aW9yIG9mIGRlc3Ryb3lp bmcgdGhlIFJlZlB0ciBpcyBhbHdheXMgdW5uZWNlc3NhcnkKKyAgICAgICAgYnVzeSB3b3JrLiAK KworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTVmFsdWVDdXN0b20uY3BwOgorICAgICAgICAo V2ViQ29yZTo6SlNDU1NWYWx1ZU93bmVyOjpmaW5hbGl6ZSk6CisgICAgICAgICogYmluZGluZ3Mv anMvSlNOb2RlQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTTm9kZU93bmVyOjpmaW5h bGl6ZSk6CisgICAgICAgIChXZWJDb3JlOjpKU05vZGU6OnZpc2l0Q2hpbGRyZW4pOgorICAgICAg ICBDYWxsIHJlbGVhc2VJbXBsKCkgaW5zdGVhZCBvZiBjbGVhckltcGwoKS4KKworICAgICAgICAq IGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVI ZWFkZXIpOgorICAgICAgICBTdG9wIHN0b3JpbmcgbV9pbXBsIGluIGEgUmVmUHRyIGFuZCBpbnN0 ZWFkIHVzZSBhIHJhdyBwb2ludGVyLiBTd2l0Y2gKKyAgICAgICAgY2xlYXJJbXBsKCkgdG8gcmVs ZWFzZUltcGwoKSwgd2hpY2ggZXhwbGljaXRseSBkZXJlZnMgdGhlIHBvaW50ZXIgYW5kCisgICAg ICAgIGNsZWFyIGl0LgorCisgICAgICAgIChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKyAgICAg ICAgVXNlIGxlYWtQdHIoKSB0byBleHBsaWNpdGx5IGFkb3B0IHRoZSBQYXNzUmVmUHRyIGludG8g dGhlIHJhdyBwb2ludGVyLgorICAgICAgICBDaGFuZ2UgZGVmYXVsdCBmaW5hbGl6ZSB0byBjYWxs IHJlbGVhc2VJbXBsKCkgaW5zdGVhZCBvZiBjbGVhckltcGwoKS4KKwogMjAxMS0xMS0xNiAgTWlj aGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgOCBCaXQg U3RyaW5ncyBpbiBKYXZhU2NyaXB0Q29yZQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNDU1NWYWx1ZUN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNDU1NWYWx1ZUN1c3RvbS5jcHAJKHJldmlzaW9uIDEwMDQ2NCkKKysrIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTVmFsdWVDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02OCw3ICs2OCw3IEBAIHZvaWQgSlNDU1NWYWx1ZU93bmVyOjpmaW5hbGl6ZShKU0M6Okhh bmQKICAgICBET01XcmFwcGVyV29ybGQqIHdvcmxkID0gc3RhdGljX2Nhc3Q8RE9NV3JhcHBlcldv cmxkKj4oY29udGV4dCk7CiAgICAgd29ybGQtPm1fY3NzVmFsdWVSb290cy5yZW1vdmUoanNDU1NW YWx1ZS0+aW1wbCgpKTsKICAgICB1bmNhY2hlV3JhcHBlcih3b3JsZCwganNDU1NWYWx1ZS0+aW1w bCgpLCBqc0NTU1ZhbHVlKTsKLSAgICBqc0NTU1ZhbHVlLT5jbGVhckltcGwoKTsKKyAgICBqc0NT U1ZhbHVlLT5yZWxlYXNlSW1wbCgpOwogfQogCiBKU1ZhbHVlIHRvSlMoRXhlY1N0YXRlKiBleGVj LCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBDU1NWYWx1ZSogdmFsdWUpCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU05vZGVDdXN0b20uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAJKHJldmlzaW9u IDEwMDQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTm9kZUN1c3RvbS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE0MSw3ICsxNDEsNyBAQCB2b2lkIEpTTm9kZU93bmVyOjpmaW5h bGl6ZShKU0M6OkhhbmRsZTxKCiAgICAgSlNOb2RlKiBqc05vZGUgPSBzdGF0aWNfY2FzdDxKU05v ZGUqPihoYW5kbGUuZ2V0KCkuYXNDZWxsKCkpOwogICAgIERPTVdyYXBwZXJXb3JsZCogd29ybGQg PSBzdGF0aWNfY2FzdDxET01XcmFwcGVyV29ybGQqPihjb250ZXh0KTsKICAgICB1bmNhY2hlV3Jh cHBlcih3b3JsZCwganNOb2RlLT5pbXBsKCksIGpzTm9kZSk7Ci0gICAganNOb2RlLT5jbGVhcklt cGwoKTsKKyAgICBqc05vZGUtPnJlbGVhc2VJbXBsKCk7CiB9CiAKIEpTVmFsdWUgSlNOb2RlOjpp bnNlcnRCZWZvcmUoRXhlY1N0YXRlKiBleGVjKQpAQCAtMjAxLDcgKzIwMSw3IEBAIHZvaWQgSlNO b2RlOjp2aXNpdENoaWxkcmVuKEpTQ2VsbCogY2VsbCwKICAgICBBU1NFUlQodGhpc09iamVjdC0+ c3RydWN0dXJlKCktPnR5cGVJbmZvKCkub3ZlcnJpZGVzVmlzaXRDaGlsZHJlbigpKTsKICAgICBC YXNlOjp2aXNpdENoaWxkcmVuKHRoaXNPYmplY3QsIHZpc2l0b3IpOwogCi0gICAgTm9kZSogbm9k ZSA9IHRoaXNPYmplY3QtPm1faW1wbC5nZXQoKTsKKyAgICBOb2RlKiBub2RlID0gdGhpc09iamVj dC0+aW1wbCgpOwogICAgIG5vZGUtPnZpc2l0SlNFdmVudExpc3RlbmVycyh2aXNpdG9yKTsKIAog ICAgIHZpc2l0b3IuYWRkT3BhcXVlUm9vdChyb290KG5vZGUpKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCShyZXZpc2lv biAxMDA0NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0 b3JKUy5wbQkod29ya2luZyBjb3B5KQpAQCAtOTI0LDEwICs5MjQsMTAgQEAgc3ViIEdlbmVyYXRl SGVhZGVyCiAgICAgfQogCiAgICAgaWYgKCEkaGFzUGFyZW50KSB7Ci0gICAgICAgIHB1c2goQGhl YWRlckNvbnRlbnQsICIgICAgJGltcGxUeXBlKiBpbXBsKCkgY29uc3QgeyByZXR1cm4gbV9pbXBs LmdldCgpOyB9XG4iKTsKLSAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICB2b2lkIGNs ZWFySW1wbCgpIHsgbV9pbXBsLmNsZWFyKCk7IH1cblxuIik7CisgICAgICAgIHB1c2goQGhlYWRl ckNvbnRlbnQsICIgICAgJGltcGxUeXBlKiBpbXBsKCkgY29uc3QgeyByZXR1cm4gbV9pbXBsOyB9 XG4iKTsKKyAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICB2b2lkIHJlbGVhc2VJbXBs KCkgeyBtX2ltcGwtPmRlcmVmKCk7IG1faW1wbCA9IDA7IH1cblxuIik7CiAgICAgICAgIHB1c2go QGhlYWRlckNvbnRlbnQsICJwcml2YXRlOlxuIik7Ci0gICAgICAgIHB1c2goQGhlYWRlckNvbnRl bnQsICIgICAgUmVmUHRyPCRpbXBsVHlwZT4gbV9pbXBsO1xuIik7CisgICAgICAgIHB1c2goQGhl YWRlckNvbnRlbnQsICIgICAgJGltcGxUeXBlKiBtX2ltcGw7XG4iKTsKICAgICB9IGVsc2lmICgk ZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJHZW5lcmF0ZU5hdGl2ZUNvbnZlcnRlciJ9 KSB7CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAgJGltcGxDbGFzc05hbWUqIGlt cGwoKSBjb25zdFxuIik7CiAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIgICAge1xuIik7 CkBAIC0xNTQ1LDcgKzE1NDUsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgOiAkcGFyZW50Q2xhc3NOYW1lKHN0cnVjdHVy ZSwgZ2xvYmFsT2JqZWN0LCBpbXBsKVxuIik7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAg ICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICA6ICRwYXJlbnRDbGFzc05hbWUoc3RydWN0dXJlLCBn bG9iYWxPYmplY3QpXG4iKTsKLSAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICwg bV9pbXBsKGltcGwpXG4iKTsKKyAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICwg bV9pbXBsKGltcGwubGVha1JlZigpKVxuIik7CiAgICAgICAgIH0KICAgICAgICAgcHVzaChAaW1w bENvbnRlbnQsICJ7XG4iKTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ9XG5cbiIpOwpA QCAtMjIxMyw3ICsyMjEzLDcgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAg cHVzaChAaW1wbENvbnRlbnQsICIgICAgSlMke2ltcGxDbGFzc05hbWV9KiBqcyR7aW1wbENsYXNz TmFtZX0gPSBzdGF0aWNfY2FzdDxKUyR7aW1wbENsYXNzTmFtZX0qPihoYW5kbGUuZ2V0KCkuYXND ZWxsKCkpO1xuIik7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgIERPTVdyYXBwZXJX b3JsZCogd29ybGQgPSBzdGF0aWNfY2FzdDxET01XcmFwcGVyV29ybGQqPihjb250ZXh0KTtcbiIp OwogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICB1bmNhY2hlV3JhcHBlcih3b3JsZCwg anMke2ltcGxDbGFzc05hbWV9LT5pbXBsKCksIGpzJHtpbXBsQ2xhc3NOYW1lfSk7XG4iKTsKLSAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAganMke2ltcGxDbGFzc05hbWV9LT5jbGVhcklt cGwoKTtcbiIpOworICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICBqcyR7aW1wbENsYXNz TmFtZX0tPnJlbGVhc2VJbXBsKCk7XG4iKTsKICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ9 XG5cbiIpOwogICAgIH0KIAo=