7255 2006-02-14 12:14:14 -0800 label attribute in option elements is ignored 2006-02-14 14:38:38 -0800 1 1 1 Unclassified WebKit Forms 412 Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 sullivan sullivan oldest_to_newest 32497 0 sullivan 2006-02-14 12:14:14 -0800 The OPTION element has a "label" attribute which, when present, is supposed to be used in the user interface rather than the text contents of the element. This is described on <http://www.w3.org/TR/REC-html40/interact/forms.html>: This attribute allows authors to specify a shorter label for an option than the content of the OPTION element. When specified, user agents should use the value of this attribute rather than the content of the OPTION element as the option label. WebKit ignores this attribute, though a getter and setter are supplied in the Objective-C DOM API at least. IE supports this attribute, though Firefox ignores it. Here's an example. This should show a pop-up menu with menu items titled "1" and "2", but instead it shows a pop-up menu with long menu item titles: <select> <option value="1" label="1">the label for this element is "1"</option> <option value="2" label="2">the label for this element is "2"</option> </select> 32500 1 6487 sullivan 2006-02-14 12:28:37 -0800 Created attachment 6487 test cases that include empty label 32502 2 6488 sullivan 2006-02-14 12:31:11 -0800 Created attachment 6488 patch to support label attribute for OPTION elements 32504 3 6488 sullivan 2006-02-14 12:37:50 -0800 Comment on attachment 6488 patch to support label attribute for OPTION elements Oops, I didn't mean to mark it review-+. Also, I haven't attached the layout tests yet, so I'll set this to review- until I have the tests ready. 32512 4 6489 sullivan 2006-02-14 13:26:54 -0800 Created attachment 6489 layout tests for patch 32513 5 6488 sullivan 2006-02-14 13:27:29 -0800 Comment on attachment 6488 patch to support label attribute for OPTION elements Now that I've attached the new layout tests, this is ready for review. 32524 6 hyatt 2006-02-14 14:07:08 -0800 HTML also will let you write: <option label>Foo</option> Should make sure we match WinIE in that situation too. 32525 7 hyatt 2006-02-14 14:07:33 -0800 Also, what about list boxes? Need to see if label is used for <select size="10"> for example. 32526 8 hyatt 2006-02-14 14:07:47 -0800 Also need to test optgroups. 32528 9 sullivan 2006-02-14 14:18:19 -0800 In response to comment 6: the behavior for this case is the same on MacIE as in WebKit; I'll add a layout test. In response to comment 7: list boxes don't use the label but should; I'll write a bug In response to comment 8: optgroups already deal with the label (used as hierarchical menu item title) 32531 10 sullivan 2006-02-14 14:38:38 -0800 I was wrong about list boxes in my previous comment; they do work correctly now with label attributes. (I was using the wrong Safari when I tested that case.) I'm adding another layout test for this. 6487 2006-02-14 12:28:37 -0800 2006-02-14 13:26:54 -0800 test cases that include empty label option_label_test.html text/html 282 sullivan PHNlbGVjdD4NPG9wdGlvbiBsYWJlbD0iMSI+dGhlIGxhYmVsIGZvciB0aGlzIGVsZW1lbnQgaXMg IjEiPC9vcHRpb24+DTxvcHRpb24+dGhpcyBpdGVtIGhhcyBubyBsYWJlbDwvb3B0aW9uPg08b3B0 aW9uIGxhYmVsPSIiPmVtcHR5IGxhYmVsIHNob3VsZCBkaXNwbGF5IGVtcHR5IHN0cmluZyB0byBt YXRjaCBJRTwvb3B0aW9uPg08b3B0aW9uIGxhYmVsPSIgIj53aGl0ZSBzcGFjZSBsYWJlbCBzaG91 bGQgZGlzcGxheSBlbXB0eSBzdHJpbmcgdG8gbWF0Y2ggSUU8L29wdGlvbj4NPC9zZWxlY3Q+ 6488 2006-02-14 12:31:11 -0800 2006-02-14 13:33:25 -0800 patch to support label attribute for OPTION elements 7255-patch.txt text/plain 953 sullivan SW5kZXg6IHJlbmRlcmluZy9yZW5kZXJfZm9ybS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5n L3JlbmRlcl9mb3JtLmNwcAkocmV2aXNpb24gMTI3OTEpCisrKyByZW5kZXJpbmcvcmVuZGVyX2Zv cm0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MTYsNyArNzE2LDEyIEBACiAgICAgICAgICAgICB9 CiAgICAgICAgICAgICBlbHNlIGlmIChsaXN0SXRlbXNbbGlzdEluZGV4XS0+aGFzVGFnTmFtZShv cHRpb25UYWcpKSB7CiAgICAgICAgICAgICAgICAgSFRNTE9wdGlvbkVsZW1lbnRJbXBsICpvcHRp b25FbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTE9wdGlvbkVsZW1lbnRJbXBsKj4obGlzdEl0ZW1z W2xpc3RJbmRleF0pOwotICAgICAgICAgICAgICAgIFFTdHJpbmcgaXRlbVRleHQgPSBvcHRpb25F bGVtZW50LT50ZXh0KCkucXN0cmluZygpOworICAgICAgICAgICAgICAgIFFTdHJpbmcgaXRlbVRl eHQ7CisgICAgICAgICAgICAgICAgaWYgKG9wdGlvbkVsZW1lbnQtPmhhc0F0dHJpYnV0ZShsYWJl bEF0dHIpKQorICAgICAgICAgICAgICAgICAgICBpdGVtVGV4dCA9IG9wdGlvbkVsZW1lbnQtPmdl dEF0dHJpYnV0ZShsYWJlbEF0dHIpLnFzdHJpbmcoKTsKKyAgICAgICAgICAgICAgICBlbHNlCisg ICAgICAgICAgICAgICAgICAgIGl0ZW1UZXh0ID0gb3B0aW9uRWxlbWVudC0+dGV4dCgpLnFzdHJp bmcoKTsKKyAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICBpdGVtVGV4dC5yZXBsYWNl KFFDaGFyKCdcXCcpLCBiYWNrc2xhc2hBc0N1cnJlbmN5U3ltYm9sKCkpOwogCiAgICAgICAgICAg ICAgICAgLy8gSW4gV2luSUUsIGxlYWRpbmcgYW5kIHRyYWlsaW5nIHdoaXRlc3BhY2UgaXMgaWdu b3JlZCBpbiBvcHRpb25zLiBXZSBtYXRjaCB0aGlzIGJlaGF2aW9yLgo= 6489 2006-02-14 13:26:54 -0800 2006-02-14 13:26:54 -0800 layout tests for patch 7255-layout-tests.txt text/plain 1121 sullivan SW5kZXg6IGRvbS9odG1sL2xldmVsMi9odG1sL0hUTUxPcHRpb25FbGVtZW50X2xhYmVsMDEuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBkb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MT3B0aW9uRWxlbWVudF9s YWJlbDAxLmh0bWwJKHJldmlzaW9uIDApCisrKyBkb20vaHRtbC9sZXZlbDIvaHRtbC9IVE1MT3B0 aW9uRWxlbWVudF9sYWJlbDAxLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKKzxzZWxl Y3Q+DTxvcHRpb24gbGFiZWw9IjEiPnRoZSBsYWJlbCBmb3IgdGhpcyBlbGVtZW50IGlzICIxIjwv b3B0aW9uPg08L3NlbGVjdD4KSW5kZXg6IGRvbS9odG1sL2xldmVsMi9odG1sL0hUTUxPcHRpb25F bGVtZW50X2xhYmVsMDIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkb20vaHRtbC9sZXZlbDIvaHRtbC9I VE1MT3B0aW9uRWxlbWVudF9sYWJlbDAyLmh0bWwJKHJldmlzaW9uIDApCisrKyBkb20vaHRtbC9s ZXZlbDIvaHRtbC9IVE1MT3B0aW9uRWxlbWVudF9sYWJlbDAyLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEgQEAKKzxzZWxlY3Q+DTxvcHRpb24gbGFiZWw9IiI+ZW1wdHkgbGFiZWwgc2hvdWxk IGRpc3BsYXkgZW1wdHkgc3RyaW5nIHRvIG1hdGNoIElFPC9vcHRpb24+DTwvc2VsZWN0PgpJbmRl eDogZG9tL2h0bWwvbGV2ZWwyL2h0bWwvSFRNTE9wdGlvbkVsZW1lbnRfbGFiZWwwMy5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGRvbS9odG1sL2xldmVsMi9odG1sL0hUTUxPcHRpb25FbGVtZW50X2xhYmVs MDMuaHRtbAkocmV2aXNpb24gMCkKKysrIGRvbS9odG1sL2xldmVsMi9odG1sL0hUTUxPcHRpb25F bGVtZW50X2xhYmVsMDMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorPHNlbGVjdD4N PG9wdGlvbiBsYWJlbD0iICI+d2hpdGUgc3BhY2UgbGFiZWwgc2hvdWxkIGRpc3BsYXkgZW1wdHkg c3RyaW5nIHRvIG1hdGNoIElFPC9vcHRpb24+DTwvc2VsZWN0Pgo=