72544 2011-11-16 13:59:50 -0800 DropShadowFilterOperation violates platform isolation 2011-11-16 21:26:06 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino cmarrin macpherson sam simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 504227 0 dino 2011-11-16 13:59:50 -0800 The DropShadowFilterOperation references ShadowData. It shouldn't. 504228 1 webkit-bug-importer 2011-11-16 14:00:17 -0800 <rdar://problem/10457784> 504293 2 115456 dino 2011-11-16 14:55:48 -0800 Created attachment 115456 Patch 504294 3 dino 2011-11-16 14:56:46 -0800 Oops - and I'll remove the #include too. 504448 4 115456 simon.fraser 2011-11-16 17:33:31 -0800 Comment on attachment 115456 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115456&action=review > Source/WebCore/platform/graphics/filters/FilterOperation.h:271 > class DropShadowFilterOperation : public FilterOperation { Isn't there a ShadowData include that could be removed now? 504539 5 dino 2011-11-16 21:26:06 -0800 http://trac.webkit.org/changeset/100560 115456 2011-11-16 14:55:48 -0800 2011-11-16 17:33:30 -0800 Patch shadow-fix.patch text/plain 5337 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4Y2QxNmJiLi43Y2I2MzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTEtMTEtMTYgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAg IERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRpb24gdmlvbGF0ZXMgcGxhdGZvcm0gaXNvbGF0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU0NAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgU2hhZG93 RGF0YSBwcm9wZXJ0aWVzIGludG8gdGhlIERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRpb24KKyAgICAg ICAgdG8gYXZvaWQgZGVwZW5kaW5nIG9uIHNvbWV0aGluZyBvdXRzaWRlIHBsYXRmb3JtLgorCisg ICAgICAgICogY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OnZhbHVlRm9yRmlsdGVyKToKKyAg ICAgICAgKiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NT dHlsZVNlbGVjdG9yOjpjcmVhdGVGaWx0ZXJPcGVyYXRpb25zKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6 RHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkRy b3BTaGFkb3dGaWx0ZXJPcGVyYXRpb246OngpOgorICAgICAgICAoV2ViQ29yZTo6RHJvcFNoYWRv d0ZpbHRlck9wZXJhdGlvbjo6eSk6CisgICAgICAgIChXZWJDb3JlOjpEcm9wU2hhZG93RmlsdGVy T3BlcmF0aW9uOjpzdGREZXZpYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6RHJvcFNoYWRvd0Zp bHRlck9wZXJhdGlvbjo6Y29sb3IpOgorICAgICAgICAoV2ViQ29yZTo6RHJvcFNoYWRvd0ZpbHRl ck9wZXJhdGlvbjo6b3BlcmF0b3I9PSk6CisgICAgICAgIChXZWJDb3JlOjpEcm9wU2hhZG93Rmls dGVyT3BlcmF0aW9uOjpEcm9wU2hhZG93RmlsdGVyT3BlcmF0aW9uKToKKwogMjAxMS0xMS0xNiAg Sm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFBhZ2UvbGF5ZXIgZmxh c2hlcyBhZnRlciBHUFUtYWNjZWxlcmF0ZWQgQ1NTIHRyYW5zaXRpb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAKaW5kZXggYWNiN2Y5 Zi4uOWRhNGUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5 bGVEZWNsYXJhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5 bGVEZWNsYXJhdGlvbi5jcHAKQEAgLTczNSw3ICs3MzUsOCBAQCBQYXNzUmVmUHRyPENTU1ZhbHVl PiBDU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb246OnZhbHVlRm9yRmlsdGVyKFJlbmRlclN0eWxl KiBzdAogICAgICAgICAgICAgRHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbiogZHJvcFNoYWRvd09w ZXJhdGlvbiA9IHN0YXRpY19jYXN0PERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRpb24qPihmaWx0ZXJP cGVyYXRpb24pOwogICAgICAgICAgICAgZmlsdGVyVmFsdWUgPSBXZWJLaXRDU1NGaWx0ZXJWYWx1 ZTo6Y3JlYXRlKFdlYktpdENTU0ZpbHRlclZhbHVlOjpEcm9wU2hhZG93RmlsdGVyT3BlcmF0aW9u KTsKICAgICAgICAgICAgIC8vIFdlIHdhbnQgb3VyIGNvbXB1dGVkIHN0eWxlIHRvIGxvb2sgbGlr ZSB0aGF0IG9mIGEgdGV4dCBzaGFkb3cgKGhhcyBuZWl0aGVyIHNwcmVhZCBub3IgaW5zZXQgc3R5 bGUpLgotICAgICAgICAgICAgZmlsdGVyVmFsdWUtPmFwcGVuZCh2YWx1ZUZvclNoYWRvdyhkcm9w U2hhZG93T3BlcmF0aW9uLT5zaGFkb3coKSwgQ1NTUHJvcGVydHlUZXh0U2hhZG93LCBzdHlsZSkp OworICAgICAgICAgICAgU2hhZG93RGF0YSBzaGFkb3dEYXRhID0gU2hhZG93RGF0YShkcm9wU2hh ZG93T3BlcmF0aW9uLT54KCksIGRyb3BTaGFkb3dPcGVyYXRpb24tPnkoKSwgZHJvcFNoYWRvd09w ZXJhdGlvbi0+c3RkRGV2aWF0aW9uKCksIDAsIE5vcm1hbCwgZmFsc2UsIGRyb3BTaGFkb3dPcGVy YXRpb24tPmNvbG9yKCkpOworICAgICAgICAgICAgZmlsdGVyVmFsdWUtPmFwcGVuZCh2YWx1ZUZv clNoYWRvdygmc2hhZG93RGF0YSwgQ1NTUHJvcGVydHlUZXh0U2hhZG93LCBzdHlsZSkpOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICNpZiBFTkFCTEUoQ1NTX1NIQURFUlMpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKaW5kZXggNzUyN2Q3My4uMTZiNWRmMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcApAQCAtNTY0OSw5ICs1NjQ5 LDggQEAgYm9vbCBDU1NTdHlsZVNlbGVjdG9yOjpjcmVhdGVGaWx0ZXJPcGVyYXRpb25zKENTU1Zh bHVlKiBpblZhbHVlLCBSZW5kZXJTdHlsZSogc3QKICAgICAgICAgICAgIENvbG9yIGNvbG9yOwog ICAgICAgICAgICAgaWYgKGl0ZW0tPmNvbG9yKQogICAgICAgICAgICAgICAgIGNvbG9yID0gZ2V0 Q29sb3JGcm9tUHJpbWl0aXZlVmFsdWUoaXRlbS0+Y29sb3IuZ2V0KCkpOwotICAgICAgICAgICAg T3duUHRyPFNoYWRvd0RhdGE+IHNoYWRvd0RhdGEgPSBhZG9wdFB0cihuZXcgU2hhZG93RGF0YSh4 LCB5LCBibHVyLCAwLCBOb3JtYWwsIGZhbHNlLCBjb2xvci5pc1ZhbGlkKCkgPyBjb2xvciA6IENv bG9yOjp0cmFuc3BhcmVudCkpOwogICAgICAgICAgICAgCi0gICAgICAgICAgICBvcGVyYXRpb25z Lm9wZXJhdGlvbnMoKS5hcHBlbmQoRHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbjo6Y3JlYXRlKHNo YWRvd0RhdGEucmVsZWFzZSgpLCBvcGVyYXRpb25UeXBlKSk7CisgICAgICAgICAgICBvcGVyYXRp b25zLm9wZXJhdGlvbnMoKS5hcHBlbmQoRHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbjo6Y3JlYXRl KHgsIHksIGJsdXIsIGNvbG9yLmlzVmFsaWQoKSA/IGNvbG9yIDogQ29sb3I6OnRyYW5zcGFyZW50 LCBvcGVyYXRpb25UeXBlKSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAgICAg ICBjYXNlIFdlYktpdENTU0ZpbHRlclZhbHVlOjpVbmtub3duRmlsdGVyT3BlcmF0aW9uOgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJP cGVyYXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRmls dGVyT3BlcmF0aW9uLmgKaW5kZXggYWYyNDFmOS4uNGNlODQ1OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9GaWx0ZXJPcGVyYXRpb24uaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZpbHRlck9wZXJhdGlv bi5oCkBAIC0yNzAsMTIgKzI3MCwxNSBAQCBwcml2YXRlOgogCiBjbGFzcyBEcm9wU2hhZG93Rmls dGVyT3BlcmF0aW9uIDogcHVibGljIEZpbHRlck9wZXJhdGlvbiB7CiBwdWJsaWM6Ci0gICAgc3Rh dGljIFBhc3NSZWZQdHI8RHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbj4gY3JlYXRlKFBhc3NPd25Q dHI8U2hhZG93RGF0YT4gc2hhZG93LCBPcGVyYXRpb25UeXBlIHR5cGUpCisgICAgc3RhdGljIFBh c3NSZWZQdHI8RHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbj4gY3JlYXRlKGludCB4LCBpbnQgeSwg aW50IHN0ZERldmlhdGlvbiwgQ29sb3IgY29sb3IsIE9wZXJhdGlvblR5cGUgdHlwZSkKICAgICB7 Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgRHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbihz aGFkb3csIHR5cGUpKTsKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBEcm9wU2hhZG93Rmls dGVyT3BlcmF0aW9uKHgsIHksIHN0ZERldmlhdGlvbiwgY29sb3IsIHR5cGUpKTsKICAgICB9CiAK LSAgICBjb25zdCBTaGFkb3dEYXRhKiBzaGFkb3coKSBjb25zdCB7IHJldHVybiBtX3NoYWRvdy5n ZXQoKTsgfQorICAgIGludCB4KCkgY29uc3QgeyByZXR1cm4gbV94OyB9CisgICAgaW50IHkoKSBj b25zdCB7IHJldHVybiBtX3k7IH0KKyAgICBpbnQgc3RkRGV2aWF0aW9uKCkgY29uc3QgeyByZXR1 cm4gbV9zdGREZXZpYXRpb247IH0KKyAgICBDb2xvciBjb2xvcigpIGNvbnN0IHsgcmV0dXJuIG1f Y29sb3I7IH0KIAogcHJpdmF0ZToKIApAQCAtMjg0LDE2ICsyODcsMjIgQEAgcHJpdmF0ZToKICAg ICAgICAgaWYgKCFpc1NhbWVUeXBlKG8pKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg ICAgICBjb25zdCBEcm9wU2hhZG93RmlsdGVyT3BlcmF0aW9uKiBvdGhlciA9IHN0YXRpY19jYXN0 PGNvbnN0IERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRpb24qPigmbyk7Ci0gICAgICAgIHJldHVybiAq bV9zaGFkb3cgPT0gKihvdGhlci0+bV9zaGFkb3cpOworICAgICAgICByZXR1cm4gbV94ID09IG90 aGVyLT5tX3ggJiYgbV95ID09IG90aGVyLT5tX3kgJiYgbV9zdGREZXZpYXRpb24gPT0gb3RoZXIt Pm1fc3RkRGV2aWF0aW9uICYmIG1fY29sb3IgPT0gb3RoZXItPm1fY29sb3I7CiAgICAgfQogCi0g ICAgRHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbihQYXNzT3duUHRyPFNoYWRvd0RhdGE+IHNoYWRv dywgT3BlcmF0aW9uVHlwZSB0eXBlKQorICAgIERyb3BTaGFkb3dGaWx0ZXJPcGVyYXRpb24oaW50 IHgsIGludCB5LCBpbnQgc3RkRGV2aWF0aW9uLCBDb2xvciBjb2xvciwgT3BlcmF0aW9uVHlwZSB0 eXBlKQogICAgICAgICA6IEZpbHRlck9wZXJhdGlvbih0eXBlKQotICAgICAgICAsIG1fc2hhZG93 KHNoYWRvdykKKyAgICAgICAgLCBtX3goeCkKKyAgICAgICAgLCBtX3koeSkKKyAgICAgICAgLCBt X3N0ZERldmlhdGlvbihzdGREZXZpYXRpb24pCisgICAgICAgICwgbV9jb2xvcihjb2xvcikKICAg ICB7CiAgICAgfQogCi0gICAgT3duUHRyPFNoYWRvd0RhdGE+IG1fc2hhZG93OworICAgIGludCBt X3g7CisgICAgaW50IG1feTsKKyAgICBpbnQgbV9zdGREZXZpYXRpb247CisgICAgQ29sb3IgbV9j b2xvcjsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK