<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>72543</bug_id>
          
          <creation_ts>2011-11-16 13:52:07 -0800</creation_ts>
          <short_desc>[Skia / Chromium] Use new name for pixel config field of GrTextureDesc</short_desc>
          <delta_ts>2011-11-23 00:26:36 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brian Salomon">bsalomon</reporter>
          <assigned_to name="Brian Salomon">bsalomon</assigned_to>
          <cc>senorblanco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>504220</commentid>
    <comment_count>0</comment_count>
    <who name="Brian Salomon">bsalomon</who>
    <bug_when>2011-11-16 13:52:07 -0800</bug_when>
    <thetext>Use new name for pixel config field of GrTextureDesc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>504222</commentid>
    <comment_count>1</comment_count>
      <attachid>115444</attachid>
    <who name="Brian Salomon">bsalomon</who>
    <bug_when>2011-11-16 13:54:35 -0800</bug_when>
    <thetext>Created attachment 115444
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>504225</commentid>
    <comment_count>2</comment_count>
    <who name="Brian Salomon">bsalomon</who>
    <bug_when>2011-11-16 13:57:00 -0800</bug_when>
    <thetext>I renamed this field from fFormat to fConfig in Skia to be more consistent with the rest of the code. Currently both names are in an anonymous union so that WebKit doesn&apos;t break. I&apos;ll remove the union once WK is using the new name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507697</commentid>
    <comment_count>3</comment_count>
    <who name="Brian Salomon">bsalomon</who>
    <bug_when>2011-11-22 10:59:06 -0800</bug_when>
    <thetext>Stephen, could you take a look at this trivial patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507698</commentid>
    <comment_count>4</comment_count>
      <attachid>115444</attachid>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2011-11-22 11:00:32 -0800</bug_when>
    <thetext>Comment on attachment 115444
Patch

Looks fine.  r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507978</commentid>
    <comment_count>5</comment_count>
      <attachid>115444</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-23 00:26:32 -0800</bug_when>
    <thetext>Comment on attachment 115444
Patch

Clearing flags on attachment: 115444

Committed r101046: &lt;http://trac.webkit.org/changeset/101046&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507979</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-23 00:26:36 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>115444</attachid>
            <date>2011-11-16 13:54:35 -0800</date>
            <delta_ts>2011-11-23 00:26:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-72543-20111116165434.patch</filename>
            <type>text/plain</type>
            <size>1356</size>
            <attacher name="Brian Salomon">bsalomon</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDQ5OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE2ICBCcmlhbiBT
YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBVc2UgbmV3IG5hbWUgZm9y
IHBpeGVsIGNvbmZpZyBmaWVsZCBvZiBHclRleHR1cmVEZXNjCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjU0MworCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RlZCBieSBldmVyeSBjYW52YXMyZCBsYXlv
dXQgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJT
a2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2VsZXJhdGVkQ2FudmFzKToKKwog
MjAxMS0xMS0xNiAgQWxleGFuZHJlIEVsaWFzICA8YWVsaWFzQGdvb2dsZS5jb20+CiAKICAgICAg
ICAgW2Nocm9taXVtXSBBZGQgbnVsbCBwb2ludGVyIGNoZWNrIGluIHNldERldmljZVNjYWxlRmFj
dG9yCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVm
ZmVyU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp
Y3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCShyZXZpc2lvbiAxMDA0OTgpCisrKyBTb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAJKHdvcmtp
bmcgY29weSkKQEAgLTc5LDcgKzc5LDcgQEAgc3RhdGljIFNrQ2FudmFzKiBjcmVhdGVBY2NlbGVy
YXRlZENhbnZhcwogICAgIGRlc2MuZkFBTGV2ZWwgPSBrTm9uZV9HckFBTGV2ZWw7CiAgICAgZGVz
Yy5mV2lkdGggPSBzaXplLndpZHRoKCk7CiAgICAgZGVzYy5mSGVpZ2h0ID0gc2l6ZS5oZWlnaHQo
KTsKLSAgICBkZXNjLmZGb3JtYXQgPSBrUkdCQV84ODg4X0dyUGl4ZWxDb25maWc7CisgICAgZGVz
Yy5mQ29uZmlnID0ga1JHQkFfODg4OF9HclBpeGVsQ29uZmlnOwogICAgIFNrQXV0b1RVbnJlZjxH
clRleHR1cmU+IHRleHR1cmUoZ3ItPmNyZWF0ZVVuY2FjaGVkVGV4dHVyZShkZXNjLCAwLCAwKSk7
CiAgICAgaWYgKCF0ZXh0dXJlLmdldCgpKQogICAgICAgICByZXR1cm4gMDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>