72517 2011-11-16 09:58:34 -0800 [NRWT] refactor drivers to require pixel_tests param 2011-11-16 13:04:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tony tony abarth dpranke ojan webkit.review.bot oldest_to_newest 503996 0 tony 2011-11-16 09:58:34 -0800 refactor drivers to require pixel_tests param 503997 1 115400 tony 2011-11-16 09:59:13 -0800 Created attachment 115400 Patch 504164 2 115400 webkit.review.bot 2011-11-16 13:04:06 -0800 Comment on attachment 115400 Patch Clearing flags on attachment: 115400 Committed r100494: <http://trac.webkit.org/changeset/100494> 504165 3 webkit.review.bot 2011-11-16 13:04:11 -0800 All reviewed patches have been landed. Closing bug. 115400 2011-11-16 09:59:13 -0800 2011-11-16 13:04:06 -0800 Patch bug-72517-20111116095931.patch text/plain 4851 tony U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNDYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWMwZWU0YjY5ZWMwOGFkYzQ2NWY4NzYwNWVmOWY5ODZi OWY5ODg5YS4uNzE0ZDhhMDk2ODUzZjJjMDlkMzA2YTUxNWYyMjkxMTE1YTlmMjQwZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDExLTExLTE2ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW05SV1RdIHJlZmFjdG9yIGRyaXZlcnMgdG8gcmVxdWlyZSBwaXhlbF90ZXN0cyBwYXJhbQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI1MTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyB0ZXN0cywg anVzdCBhIHJlZmFjdG9yaW5nLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX3VuaXR0ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0X3VuaXR0ZXN0LnB5OgorCiAyMDExLTExLTE2 ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAg ICBbUXRdIFByb3NwZWN0aXZlIGZpeCBmb3IgYnJva2VuIHBsdWdpbiB0ZXN0cwpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5k ZXggMWM3ODY1M2I2ZTI4ODRlMTA5MDkwOWI5OWY4OGFiOTlhMGZmYjFkZC4uMDc0NzI2YzhjZmM4 MDVhNTQ2MmZjZDNkNWYzMDNiZDU4YzM0MjY4ZCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CkBAIC0zOTksNyArMzk5LDcg QEAgY2xhc3MgQ2hyb21pdW1Qb3J0KFBvcnQpOgogCiAjIEZJWE1FOiBUaGlzIHNob3VsZCBpbmhl cml0IGZyb20gV2ViS2l0RHJpdmVyIG5vdyB0aGF0IENocm9taXVtIGhhcyBhIER1bXBSZW5kZXJU cmVlIHByb2Nlc3MgbGlrZSB0aGUgcmVzdCBvZiBXZWJLaXQuCiBjbGFzcyBDaHJvbWl1bURyaXZl cihEcml2ZXIpOgotICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0LCB3b3JrZXJfbnVtYmVyLCBw aXhlbF90ZXN0cz1UcnVlKToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgcG9ydCwgd29ya2VyX251 bWJlciwgcGl4ZWxfdGVzdHMpOgogICAgICAgICBEcml2ZXIuX19pbml0X18oc2VsZiwgcG9ydCwg d29ya2VyX251bWJlciwgcGl4ZWxfdGVzdHMpCiAgICAgICAgIHNlbGYuX3Byb2MgPSBOb25lCiAg ICAgICAgIHNlbGYuX2ltYWdlX3BhdGggPSBOb25lCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3VuaXR0ZXN0LnB5IGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV91bml0dGVzdC5weQpp bmRleCAwN2IwM2QzMzYxMzZiZTQwY2M5YmMxM2E5ZTUxNTZjY2FmYjI0NjEyLi4wZjJlMjFjNTRl YWNkZmI1NDU3Mjc4ZGFlZjQ2MGFkYWZmM2RkODlhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3VuaXR0ZXN0LnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fdW5pdHRlc3Qu cHkKQEAgLTUwLDggKzUwLDcgQEAgZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydCBpbXBv cnQgcG9ydF90ZXN0Y2FzZQogY2xhc3MgQ2hyb21pdW1Ecml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RD YXNlKToKICAgICBkZWYgc2V0VXAoc2VsZik6CiAgICAgICAgIG1vY2tfcG9ydCA9IE1vY2soKQot ICAgICAgICBtb2NrX3BvcnQuZ2V0X29wdGlvbiA9IGxhbWJkYSBvcHRpb25fbmFtZTogJycKLSAg ICAgICAgc2VsZi5kcml2ZXIgPSBjaHJvbWl1bS5DaHJvbWl1bURyaXZlcihtb2NrX3BvcnQsIHdv cmtlcl9udW1iZXI9MCkKKyAgICAgICAgc2VsZi5kcml2ZXIgPSBjaHJvbWl1bS5DaHJvbWl1bURy aXZlcihtb2NrX3BvcnQsIHdvcmtlcl9udW1iZXI9MCwgcGl4ZWxfdGVzdHM9VHJ1ZSkKIAogICAg IGRlZiB0ZXN0X3Rlc3Rfc2hlbGxfY29tbWFuZChzZWxmKToKICAgICAgICAgZXhwZWN0ZWRfY29t bWFuZCA9ICJ0ZXN0Lmh0bWwgMiBjaGVja3N1bVxuIgpAQCAtMTIzLDcgKzEyMiw3IEBAIGNsYXNz IENocm9taXVtRHJpdmVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICAgICAgY2xhc3Mg TW9ja0RyaXZlcihjaHJvbWl1bS5DaHJvbWl1bURyaXZlcik6CiAgICAgICAgICAgICBkZWYgX19p bml0X18oc2VsZik6Ci0gICAgICAgICAgICAgICAgY2hyb21pdW0uQ2hyb21pdW1Ecml2ZXIuX19p bml0X18oc2VsZiwgbW9ja19wb3J0LCB3b3JrZXJfbnVtYmVyPTApCisgICAgICAgICAgICAgICAg Y2hyb21pdW0uQ2hyb21pdW1Ecml2ZXIuX19pbml0X18oc2VsZiwgbW9ja19wb3J0LCB3b3JrZXJf bnVtYmVyPTAsIHBpeGVsX3Rlc3RzPUZhbHNlKQogCiAgICAgICAgICAgICBkZWYgY21kX2xpbmUo c2VsZik6CiAgICAgICAgICAgICAgICAgcmV0dXJuICdweXRob24nCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CmluZGV4IDgxZDNkOTQ3 ZDgzOGU4MTNkMTU5NTY3NGJiZWJlODI0MTIzMjliMmUuLjMyMzY5ZDZjOGNlZTQ5ZGYzYWMyNzA0 ZjQ4YzZiYjJjNzExZDIyZDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5CkBAIC00NDAsNyArNDQwLDcgQEAgY2xhc3MgV2ViS2l0 UG9ydChQb3J0KToKIGNsYXNzIFdlYktpdERyaXZlcihEcml2ZXIpOgogICAgICIiIldlYktpdCBp bXBsZW1lbnRhdGlvbiBvZiB0aGUgRHVtcFJlbmRlclRyZWUvV2ViS2l0VGVzdFJ1bm5lciBpbnRl cmZhY2UuIiIiCiAKLSAgICBkZWYgX19pbml0X18oc2VsZiwgcG9ydCwgd29ya2VyX251bWJlciwg cGl4ZWxfdGVzdHM9RmFsc2UpOgorICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0LCB3b3JrZXJf bnVtYmVyLCBwaXhlbF90ZXN0cyk6CiAgICAgICAgIERyaXZlci5fX2luaXRfXyhzZWxmLCBwb3J0 LCB3b3JrZXJfbnVtYmVyLCBwaXhlbF90ZXN0cykKICAgICAgICAgc2VsZi5fZHJpdmVyX3RlbXBk aXIgPSBwb3J0Ll9maWxlc3lzdGVtLm1rZHRlbXAocHJlZml4PSclcy0nICUgc2VsZi5fcG9ydC5k cml2ZXJfbmFtZSgpKQogICAgICAgICAjIFdlYktpdFRlc3RSdW5uZXIgY2FuIHJlcG9ydCBiYWNr IHN1YnByb2Nlc3MgY3Jhc2hlcyBieSBwcmludGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQppbmRl eCBmYWRkNzRjNGQ2ZTljMTQzYjZlOWQ3OTcxZWE0MTQ0MGFkZTIwNjA4Li45ZTM3OGNlMGVhMWEw N2Q1ODc2Mjk1MjRjMTkxNTQ5NGQwNTA5YWI4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQpAQCAt MjU1LDcgKzI1NSw3IEBAIGNsYXNzIE1vY2tTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiBjbGFzcyBX ZWJLaXREcml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgdGVzdF9yZWFkX2Js b2NrKHNlbGYpOgogICAgICAgICBwb3J0ID0gVGVzdFdlYktpdFBvcnQoKQotICAgICAgICBkcml2 ZXIgPSBXZWJLaXREcml2ZXIocG9ydCwgMCkKKyAgICAgICAgZHJpdmVyID0gV2ViS2l0RHJpdmVy KHBvcnQsIDAsIHBpeGVsX3Rlc3RzPUZhbHNlKQogICAgICAgICBkcml2ZXIuX3NlcnZlcl9wcm9j ZXNzID0gTW9ja1NlcnZlclByb2Nlc3MoWwogICAgICAgICAgICAgJ0FjdHVhbEhhc2g6IGZvb2Jh cicsCiAgICAgICAgICAgICAnQ29udGVudC1UeXBlOiBteV90eXBlJywKQEAgLTI2OSw3ICsyNjks NyBAQCBjbGFzcyBXZWJLaXREcml2ZXJUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKIAogICAgIGRl ZiB0ZXN0X3JlYWRfYmluYXJ5X2Jsb2NrKHNlbGYpOgogICAgICAgICBwb3J0ID0gVGVzdFdlYktp dFBvcnQoKQotICAgICAgICBkcml2ZXIgPSBXZWJLaXREcml2ZXIocG9ydCwgMCkKKyAgICAgICAg ZHJpdmVyID0gV2ViS2l0RHJpdmVyKHBvcnQsIDAsIHBpeGVsX3Rlc3RzPVRydWUpCiAgICAgICAg IGRyaXZlci5fc2VydmVyX3Byb2Nlc3MgPSBNb2NrU2VydmVyUHJvY2VzcyhbCiAgICAgICAgICAg ICAnQWN0dWFsSGFzaDogYWN0dWFsJywKICAgICAgICAgICAgICdFeHBlY3RlZEhhc2g6IGV4cGVj dGVkJywK