72516 2011-11-16 09:50:03 -0800 [CMake] Make CODE_GENERATOR_PREPROCESSOR more useable 2011-11-17 13:47:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga webkit.review.bot oldest_to_newest 503992 0 paroga 2011-11-16 09:50:03 -0800 [CMake] Make CODE_GENERATOR_PREPROCESSOR more useable 503993 1 115398 paroga 2011-11-16 09:53:04 -0800 Created attachment 115398 Patch 505054 2 115398 bfulgham 2011-11-17 11:54:04 -0800 Comment on attachment 115398 Patch Using only the executable name implies that the development tools path is in the current environment. This is probably a safe assumption for anything driven by Visual Studio, but will CMake know where to find everything? 505060 3 paroga 2011-11-17 11:55:52 -0800 (In reply to comment #2) > (From update of attachment 115398 [details]) > Using only the executable name implies that the development tools path is in the current environment. This is probably a safe assumption for anything driven by Visual Studio, but will CMake know where to find everything? You need a VS environment anyway (at the moment) when building from command line, so it's there safe too. 505068 4 115398 bfulgham 2011-11-17 12:04:41 -0800 Comment on attachment 115398 Patch This change looks good to me! 505167 5 115398 webkit.review.bot 2011-11-17 13:47:37 -0800 Comment on attachment 115398 Patch Clearing flags on attachment: 115398 Committed r100665: <http://trac.webkit.org/changeset/100665> 505168 6 webkit.review.bot 2011-11-17 13:47:41 -0800 All reviewed patches have been landed. Closing bug. 115398 2011-11-16 09:53:04 -0800 2011-11-17 13:47:37 -0800 Patch bug-72516-20111116185302.patch text/plain 1583 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDI3YTVlODI4ZTE4NDU3Y2I5M2E0MTI1MTE5ZjM2MjJiY2VhYzc5YTkuLmVlYWEwMmJiOGYxNjIx MzBiYjA1NmI2NTNmNWMwMGNiOTc2NWQxN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC02LDcgKzYsOSBAQCBJRiAoV1RGX09TX1VOSVgpCiBFTkRJRiAoV1RGX09TX1VOSVgpCiAKIElG IChNU1ZDKQotICAgIFNFVChDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNTT1IgIiR7Q01BS0VfQ1hY X0NPTVBJTEVSfSAvbm9sb2dvIC9FUCIpCisgICAgIyBGSVhNRTogU29tZSBjb2RlZ2VuZXJhdG9y cyBkb24ndCBzdXBwb3J0IHBhdGhzIHdpdGggc3BhY2VzLiBTbyB1c2UgdGhlIGV4ZWN1dGFibGUg bmFtZSBvbmx5LgorICAgIEdFVF9GSUxFTkFNRV9DT01QT05FTlQoQ09ERV9HRU5FUkFUT1JfUFJF UFJPQ0VTU09SX0VYRUNVVEFCTEUgJHtDTUFLRV9DWFhfQ09NUElMRVJ9IE5BTUUpCisgICAgU0VU KENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUiAiJHtDT0RFX0dFTkVSQVRPUl9QUkVQUk9DRVNT T1JfRVhFQ1VUQUJMRX0gL25vbG9nbyAvRVAiKQogRUxTRSAoKQogICAgIFNFVChDT0RFX0dFTkVS QVRPUl9QUkVQUk9DRVNTT1IgIiR7Q01BS0VfQ1hYX0NPTVBJTEVSfSAtRSAtUCAteCBjKysiKQog RU5ESUYgKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1M2ZiNmU5 Nzc4NTM3NDhiNjczYTQyZWI4M2I3YTdkYjI3ZjEzYzhkLi5hMWU3YjdkODdhYjI1NjI3OGRlMWM1 YWUzZTYxNmYzY2YyNzhiNmNlIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMTYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dh QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NNYWtlXSBNYWtlIENPREVfR0VORVJBVE9SX1BSRVBS T0NFU1NPUiBtb3JlIHVzZWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcyNTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgT24gd2luZG93cyBzb21lIGNvZGUgZ2VuZXJhdG9ycyBmYWlsLCBpZiB0aGUg cGF0aCB0byB0aGUgcHJlcHJvY2Vzc29yIGNvbnRhaW5zIHNwYWNlcy4KKyAgICAgICAgVXNlIG9u bHkgdGhlIGV4ZWN1dGFibGUgbmFtZSB0byBhdm9pZCB0aGlzIGlzc3VlIGZvciBub3cuCisKKyAg ICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZToKKwogMjAxMS0xMS0xNSAg U2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0 XSBDZW50cmFsaXplIGhpZGVfc3ltYm9scyBhbmQgZW5zdXJlIGFsbCBsaWJzIGFyZSBidWlsdCB3 aXRoIHN5bWJvbCB2aXNpYmlsaXR5ICYgYnN5bWJvbGljX2Z1bmN0aW9ucwo=