72515 2011-11-16 09:34:56 -0800 check-webkit-style should recognize functions even if they have OVERRIDE after them. Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-11-16 13:51:37 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin abarth ojan webkit.review.bot oldest_to_newest 503972 0 levin 2011-11-16 09:34:56 -0800 https://bugs.webkit.org/show_bug.cgi?id=52162#c37 503994 1 115399 levin 2011-11-16 09:55:42 -0800 Created attachment 115399 Patch 504218 2 115399 webkit.review.bot 2011-11-16 13:51:31 -0800 Comment on attachment 115399 Patch Clearing flags on attachment: 115399 Committed r100499: <http://trac.webkit.org/changeset/100499> 504219 3 webkit.review.bot 2011-11-16 13:51:37 -0800 All reviewed patches have been landed. Closing bug. 115399 2011-11-16 09:55:42 -0800 2011-11-16 13:51:31 -0800 Patch bug-72515-20111116095541.patch text/plain 3320 levin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMzc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTljOTc0MmNlMjc4ZmQwNDU3ZDJmYjJkMDYxNGU0NjFk MzFjMDI1Yi4uYTM2MjE1NTQ2MmY0YjdmZDU1ZmFlZGI0ZGE5MDVjNDhlOTQzZmU0ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDExLTExLTE2ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVtLm9yZz4KKworICAg ICAgICBjaGVjay13ZWJraXQtc3R5bGUgc2hvdWxkIHJlY29nbml6ZSBmdW5jdGlvbnMgZXZlbiBp ZiB0aGV5IGhhdmUgT1ZFUlJJREUgYWZ0ZXIgdGhlbS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNTE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weToKKwogMjAxMS0xMS0xNSAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEZpeCBhIHdlYmtpdHB5IHRlc3QgY2F1c2VkIGJ5IHJlbmFtaW5nIHRoZSBh Y2NlbGVyYXRlLXZpZGVvIGZsYWcgaW4gcjEwMDM1NS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMWM3MDI0NDNmNDczOWNiMGNkMTY5MTEyOTM1 OTY2MmUxYTZkNGQ1NC4uNzEzOTMyN2U5OGM5NWI0NjUyM2JkMzAyOWRhNWQ2MTBlN2I2OGMxNCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTIx NDMsMTIgKzIxNDMsMTIgQEAgZGVmIGNoZWNrX2JyYWNlcyhjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGVycm9yKToKICAgICAgICAgIyAnKScsIG9yICcpIGNvbnN0JyBhbmQgZG9lc24ndCBiZWdp biB3aXRoICdpZnxmb3J8d2hpbGV8c3dpdGNofGVsc2UnLgogICAgICAgICAjIFdlIGFsc28gYWxs b3cgJyMnIGZvciAjZW5kaWYgYW5kICc9JyBmb3IgYXJyYXkgaW5pdGlhbGl6YXRpb24uCiAgICAg ICAgIHByZXZpb3VzX2xpbmUgPSBnZXRfcHJldmlvdXNfbm9uX2JsYW5rX2xpbmUoY2xlYW5fbGlu ZXMsIGxpbmVfbnVtYmVyKVswXQotICAgICAgICBpZiAoKG5vdCBzZWFyY2gocidbOzp9eyk9XVxz KiR8XClccypjb25zdFxzKiQnLCBwcmV2aW91c19saW5lKQorICAgICAgICBpZiAoKG5vdCBzZWFy Y2gocidbOzp9eyk9XVxzKiR8XClccyooKGNvbnN0fE9WRVJSSURFKVxzKikqXHMqJCcsIHByZXZp b3VzX2xpbmUpCiAgICAgICAgICAgICAgb3Igc2VhcmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hp bGV8c3dpdGNofGVsc2UpXGInLCBwcmV2aW91c19saW5lKSkKICAgICAgICAgICAgIGFuZCBwcmV2 aW91c19saW5lLmZpbmQoJyMnKSA8IDApOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIs ICd3aGl0ZXNwYWNlL2JyYWNlcycsIDQsCiAgICAgICAgICAgICAgICAgICAnVGhpcyB7IHNob3Vs ZCBiZSBhdCB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBsaW5lJykKLSAgICBlbGlmIChzZWFyY2go cidcKVxzKihjb25zdFxzKik/e1xzKiQnLCBsaW5lKQorICAgIGVsaWYgKHNlYXJjaChyJ1wpXHMq KCgoY29uc3R8T1ZFUlJJREUpXHMqKSpccyopP3tccyokJywgbGluZSkKICAgICAgICAgICBhbmQg bGluZS5jb3VudCgnKCcpID09IGxpbmUuY291bnQoJyknKQogICAgICAgICAgIGFuZCBub3Qgc2Vh cmNoKHInXGIoaWZ8Zm9yfGZvcmVhY2h8d2hpbGV8c3dpdGNoKVxiJywgbGluZSkKICAgICAgICAg ICBhbmQgbm90IG1hdGNoKHInXHMrW0EtWl9dW0EtWl8wLTldK1xiJywgbGluZSkpOgpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3Qu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eQppbmRleCBiODI5Njk2ODlkZGM4OGVhMjljY2Y1NmJmNGQ1NWYzMjZhZDYzZTNlLi5hZTkwOWNi MTRiZDNmZjdlNGU1MmQxNjJhOGRmMDUxNjEwZTdiOWM0IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMTUzMCwx MSArMTUzMCwyMiBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAg ICAgICAgICAnaW50IGZvbygpIGNvbnN0IHsnLAogICAgICAgICAgICAgJ1BsYWNlIGJyYWNlIG9u IGl0cyBvd24gbGluZSBmb3IgZnVuY3Rpb24gZGVmaW5pdGlvbnMuICBbd2hpdGVzcGFjZS9icmFj ZXNdIFs0XScpCiAgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAg ICAgICdpbnQgZm9vKCkgY29uc3QgT1ZFUlJJREUgeycsCisgICAgICAgICAgICAnUGxhY2UgYnJh Y2Ugb24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlvbiBkZWZpbml0aW9ucy4gIFt3aGl0ZXNwYWNl L2JyYWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAorICAg ICAgICAgICAgJ2ludCBmb28oKSBPVkVSUklERSB7JywKKyAgICAgICAgICAgICdQbGFjZSBicmFj ZSBvbiBpdHMgb3duIGxpbmUgZm9yIGZ1bmN0aW9uIGRlZmluaXRpb25zLiAgW3doaXRlc3BhY2Uv YnJhY2VzXSBbNF0nKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCiAgICAg ICAgICAgICAnaW50IGZvbygpIGNvbnN0XG4nCiAgICAgICAgICAgICAne1xuJwogICAgICAgICAg ICAgJ31cbicsCiAgICAgICAgICAgICAnJykKICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGlu ZV9saW50KAorICAgICAgICAgICAgJ2ludCBmb28oKSBPVkVSUklERVxuJworICAgICAgICAgICAg J3tcbicKKyAgICAgICAgICAgICd9XG4nLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYu YXNzZXJ0X211bHRpX2xpbmVfbGludCgKICAgICAgICAgICAgICdpZiAoY29uZGl0aW9uXG4nCiAg ICAgICAgICAgICAnICAgICYmIGNvbmRpdGlvbjJcbicKICAgICAgICAgICAgICcgICAgJiYgY29u ZGl0aW9uMykge1xuJwo=