72500 2011-11-16 06:38:43 -0800 [GTK] Use a URI instead of local path to create download destination in WebKit2 2011-11-16 23:59:22 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned pnormand oldest_to_newest 503821 0 cgarcia 2011-11-16 06:38:43 -0800 We should expect a URI instead of a local path for the destination. 503824 1 115371 cgarcia 2011-11-16 06:41:56 -0800 Created attachment 115371 Patch 503828 2 115371 pnormand 2011-11-16 06:47:14 -0800 Comment on attachment 115371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review Looks good! Maybe consider the following nit :) > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69 > + downloadFailed(downloadDestinationError(response, _("Cannot determine destination URI"))); What about mentioning the value of the suggestedFilename? 503933 3 115371 mrobinson 2011-11-16 08:51:20 -0800 Comment on attachment 115371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115371&action=review >> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:69 > > What about mentioning the value of the suggestedFilename? I think this is a good idea! _ seems to accept standard printf format parameters. 504613 4 cgarcia 2011-11-16 23:59:22 -0800 Committed r100569: <http://trac.webkit.org/changeset/100569> 115371 2011-11-16 06:41:56 -0800 2011-11-16 08:51:20 -0800 Patch wk2-download-destination-uri.diff text/plain 2049 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5YjQ3YTgwLi4xZDFmYmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTEtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFVzZSBhIFVSSSBpbnN0ZWFkIG9mIGxvY2FsIHBhdGggdG8gY3Jl YXRlIGRvd25sb2FkIGRlc3RpbmF0aW9uIGluIFdlYktpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0Rvd25sb2Fkcy9zb3VwL0Rv d25sb2FkU291cC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkQ2xpZW50OjpkaWRSZWNl aXZlUmVzcG9uc2UpOiBVc2UKKyAgICAgICAgZ19maWxlX25ld19mb3JfdXJpKCkgaW5zdGFkIG9m IGdfZmlsZV9uZXdfZm9yX3BhdGgoKS4gQWxzbyB1c2UKKyAgICAgICAgYWRvcHRHUmVmIHRvIGZp eCBhIG1lbW9yeSBsZWFrLgorCiAyMDExLTExLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgd2Via2l0X3dlYl92aWV3X2xv YWRfcmVxdWVzdCgpIHRvIFdlYktpdDIgR1RLKyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3NvdXAvRG93bmxvYWRTb3VwLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvRG93bmxvYWRzL3NvdXAvRG93bmxvYWRTb3VwLmNwcAppbmRleCAy MzkzMjJmLi4yZjY3MDBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Rv d25sb2Fkcy9zb3VwL0Rvd25sb2FkU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9Eb3dubG9hZHMvc291cC9Eb3dubG9hZFNvdXAuY3BwCkBAIC02NCwxMyArNjQsMTMgQEAg cHVibGljOgogICAgICAgICB9CiAKICAgICAgICAgYm9vbCBvdmVyd3JpdGU7Ci0gICAgICAgIFN0 cmluZyBmaWxlbmFtZSA9IG1fZG93bmxvYWQtPmRlY2lkZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3Rl ZEZpbGVuYW1lKHN1Z2dlc3RlZEZpbGVuYW1lLnV0ZjgoKS5kYXRhKCksIG92ZXJ3cml0ZSk7Ci0g ICAgICAgIGlmIChmaWxlbmFtZS5pc0VtcHR5KCkpIHsKLSAgICAgICAgICAgIGRvd25sb2FkRmFp bGVkKGRvd25sb2FkRGVzdGluYXRpb25FcnJvcihyZXNwb25zZSwgXygiQ2Fubm90IGRldGVybWlu ZSBkZXN0aW5hdGlvbiBmaWxlbmFtZSIpKSk7CisgICAgICAgIFN0cmluZyBkZXN0aW5hdGlvblVS SSA9IG1fZG93bmxvYWQtPmRlY2lkZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lKHN1 Z2dlc3RlZEZpbGVuYW1lLnV0ZjgoKS5kYXRhKCksIG92ZXJ3cml0ZSk7CisgICAgICAgIGlmIChk ZXN0aW5hdGlvblVSSS5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgIGRvd25sb2FkRmFpbGVkKGRv d25sb2FkRGVzdGluYXRpb25FcnJvcihyZXNwb25zZSwgXygiQ2Fubm90IGRldGVybWluZSBkZXN0 aW5hdGlvbiBVUkkiKSkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAg ICAgR1JlZlB0cjxHRmlsZT4gZmlsZShnX2ZpbGVfbmV3X2Zvcl9wYXRoKGZpbGVuYW1lLnV0Zjgo KS5kYXRhKCkpKTsKKyAgICAgICAgR1JlZlB0cjxHRmlsZT4gZmlsZSA9IGFkb3B0R1JlZihnX2Zp bGVfbmV3X2Zvcl91cmkoZGVzdGluYXRpb25VUkkudXRmOCgpLmRhdGEoKSkpOwogICAgICAgICBH T3duUHRyPEdFcnJvcj4gZXJyb3I7CiAgICAgICAgIG1fb3V0cHV0U3RyZWFtID0gYWRvcHRHUmVm KGdfZmlsZV9yZXBsYWNlKGZpbGUuZ2V0KCksIDAsIFRSVUUsIEdfRklMRV9DUkVBVEVfTk9ORSwg MCwgJmVycm9yLm91dFB0cigpKSk7CiAgICAgICAgIGlmICghbV9vdXRwdXRTdHJlYW0pIHsK