72498 2011-11-16 06:28:06 -0800 NRWT not running webkit_gpu_tests properly for Leopard (Mac OS 10.5) 2012-02-29 12:36:49 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 epoger dpranke abarth dpranke jamesr ojan tony webkit.review.bot oldest_to_newest 503812 0 epoger 2011-11-16 06:28:06 -0800 Split off of https://bugs.webkit.org/show_bug.cgi?id=72275 ('check-webkit-style broken by r99773: "Could not determine the port"') ... As of this point, webkit_gpu_tests was green for Leopard: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29/builds/1197 webkit r100350 chromium r110212 [from webkit_gpu_tests stdio] Found: 254 tests The next run had a failure while parsing expectations: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29/builds/1198 webkit r100373 chromium r110235 That continued to be the case until this run: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29/builds/1202 webkit r100398 chromium r110256 At this point, it was able to parse the expectations but was now trying to run 27185 tests instead of 254. (NRWT is apparently interpreting the chromium-gpu-cg-mac platform as a CPU platform, not a GPU platform) [from webkit_gpu_tests stdio] Found: 27185 tests As of webkit r100439 , I can confirm that it is still trying to run 27185 tests. Based on the evidence above, I believe this is the result of a webkit change within the range r100350:r100398 . 503825 1 epoger 2011-11-16 06:44:45 -0800 I think these changes are the most likely suspects. CCing the authors: http://trac.webkit.org/changeset/100350 http://trac.webkit.org/changeset/100352 http://trac.webkit.org/changeset/100355 http://trac.webkit.org/changeset/100356 http://trac.webkit.org/changeset/100360 http://trac.webkit.org/changeset/100368 http://trac.webkit.org/changeset/100374 503987 2 tony 2011-11-16 09:46:37 -0800 It looks like this is due to r100355. Now that we moved the tests into the regular layout test run, on chromium-gpu-cg-mac-leopard, paths is empty, so test_files.find() returns all tests. It seems like we just want to remove the webkit_gpu_tests step from the Leopard bots. James or Dirk, can you confirm that this is the desired behavior? 504006 3 dpranke 2011-11-16 10:06:29 -0800 (In reply to comment #2) > It looks like this is due to r100355. > > Now that we moved the tests into the regular layout test run, on chromium-gpu-cg-mac-leopard, paths is empty, so test_files.find() returns all tests. > > It seems like we just want to remove the webkit_gpu_tests step from the Leopard bots. > > James or Dirk, can you confirm that this is the desired behavior? Ah, whoops, I forgot about that default behavior, and had assumed that there would still be some tests to run, but I didn't think it through. Obviously, we don't want to run all 27k tests on Leopard ;). Yeah, we can either remove the webkit_gpu_tests step from Leopard, or give them some dummy list of paths to run just to be a no-op (e.g., one test or a small directory or something) until we can remove webkit_gpu_tests everywhere. 504027 4 epoger 2011-11-16 10:28:39 -0800 (In reply to comment #3) > (In reply to comment #2) > > It looks like this is due to r100355. > > > > Now that we moved the tests into the regular layout test run, on chromium-gpu-cg-mac-leopard, paths is empty, so test_files.find() returns all tests. > > > > It seems like we just want to remove the webkit_gpu_tests step from the Leopard bots. > > > > James or Dirk, can you confirm that this is the desired behavior? > > Ah, whoops, I forgot about that default behavior, and had assumed that there would still be some tests to run, but I didn't think it through. Obviously, we don't want to run all 27k tests on Leopard ;). > > Yeah, we can either remove the webkit_gpu_tests step from Leopard, or give them some dummy list of paths to run just to be a no-op (e.g., one test or a small directory or something) until we can remove webkit_gpu_tests everywhere. How is it that Leopard and SnowLeopard are being treated differently? Shouldn't they both be treated essentially the same? 504098 5 dpranke 2011-11-16 11:37:55 -0800 (In reply to comment #4) > How is it that Leopard and SnowLeopard are being treated differently? Shouldn't they both be treated essentially the same? IIRC, we don't support accelerated video compositing on Leopard, but we do on SL. 504123 6 dpranke 2011-11-16 12:17:43 -0800 Okay, per conversation w/ jamesr just now, it looks like it might make the most sense to just stop running webkit_gpu_tests on Leopard CG. 504130 7 dpranke 2011-11-16 12:24:18 -0800 http://codereview.chromium.org/8575012/ I think this'll require a master restart, though. In the meantime, it's not great that we're running 27k tests, so I'll upload a hack to run *something*. 504141 8 115423 dpranke 2011-11-16 12:32:29 -0800 Created attachment 115423 Patch 504144 9 115423 jamesr 2011-11-16 12:33:22 -0800 Comment on attachment 115423 Patch R=me 504148 10 jamesr 2011-11-16 12:35:01 -0800 Sorry about that, the intent was to run zero tests on 10.5 webkit_gpu_tests. We don't ship accelerated compositing on that platform and afaik never intend to, so there aren't any tests that are useful to run on that platform in the gpu configuration. 504151 11 dpranke 2011-11-16 12:42:55 -0800 Committed r100491: <http://trac.webkit.org/changeset/100491> 504276 12 115423 webkit.review.bot 2011-11-16 14:44:32 -0800 Comment on attachment 115423 Patch Clearing flags on attachment: 115423 Committed r100509: <http://trac.webkit.org/changeset/100509> 504278 13 webkit.review.bot 2011-11-16 14:44:37 -0800 All reviewed patches have been landed. Closing bug. 504296 14 dpranke 2011-11-16 14:57:48 -0800 This was closed incorrectly (and landed twice) because I forgot to clear the CQ+ flag; I mean to leave it open until the buildbot picks up the other change and I can revert the hack to chromium_gpu.py. 567830 15 dpranke 2012-02-29 12:36:49 -0800 Ok, the CG bots are gone. We're still running fast/canvas and canvas/philip on the Leopard bot (now a Skia bot), and although they are not accelerated, the tests are passing. Given that I'm trying to remove the webkit_gpu_tests step completely, I'm going to ignore this for now and close this bug. 115423 2011-11-16 12:32:29 -0800 2011-11-16 14:44:32 -0800 Patch bug-72498-20111116123228.patch text/plain 1690 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODdhODdmZmQzYjk3NTVhZjM0Y2E2NWQ3ZjY4MjhkMGUw MGQ5NzQxMi4uZmUyN2MxNDU0NTMyYmI3Y2I4MTU2ZTE4YjY1YWNjYmFmZDlhOWM1YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTExLTE2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJ1biBhIGR1bW15IHRlc3QgaW4gdGhlIGdwdSBjb25maWd1cmF0aW9ucyBpZiB0aGVy ZSdzIG5vdGhpbmcgdG8gZG8uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MjQ5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9n cHUucHk6CisKIDIwMTEtMTEtMTYgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIHRvIHN1cHBvcnQgYWNjZXNzaWJp bGl0eS1yZWxhdGVkIERSVCBBUElzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CmluZGV4IDhlM2U5OWJhZDYyMjFm MzBhNWY3M2M3ZTUwMzg1ZDFkMTQ2YTU1ODQuLjgzNGMyMDNiMzgzZTdhOGM5Y2I3Yjk4OGU0MmZh NDY4NTg0ZjhlMmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5CkBAIC05Miw2ICs5MiwxNCBAQCBkZWYgX3Rl c3RzKHBvcnQsIHBhdGhzKToKICAgICAgICAgICAgICMgaW4gcnVubmluZyB0aGUgdGVzdHMgdGhl cmUuCiAgICAgICAgICAgICBwYXRocyArPSBbJ2Zhc3QvY2FudmFzJywgJ2NhbnZhcy9waGlsaXAn XQogCisgICAgICAgIGlmIG5vdCBwYXRoczoKKyAgICAgICAgICAgICMgRklYTUU6IFRoaXMgaXMg YSBoYWNrIHVudGlsIHdlIGNhbiB0dXJuIG9mIHRoZSB3ZWJraXRfZ3B1CisgICAgICAgICAgICAj IHRlc3RzIG9uIHRoZSBib3RzLiBJZiBwYXRocyBpcyBlbXB0eSwgdGVzdF9maWxlcy5maW5kKCkK KyAgICAgICAgICAgICMgZmluZHMgKmV2ZXJ5dGhpbmcqLiBIb3dldmVyLCB3ZSBoYXZlIHRvIHJl dHVybiBzb21ldGhpbmcsCisgICAgICAgICAgICAjIG9yIE5SV1QgdGhpbmtzIHRoZXJlJ3Mgc29t ZXRoaW5nIHdyb25nLiBTbywgd2UgcmV0dXJuIGEgc2luZ2xlCisgICAgICAgICAgICAjIGR1bW15 IHRlc3QuIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI0OTgu CisgICAgICAgICAgICBwYXRocyA9IFsnZmFzdC9odG1sL2FydGljbGUtZWxlbWVudC5odG1sJ10K KwogICAgIHJldHVybiBzZXQoW3BvcnQucmVsYXRpdmVfdGVzdF9maWxlbmFtZShmKSBmb3IgZiBp biB0ZXN0X2ZpbGVzLmZpbmQocG9ydCwgcGF0aHMpXSkKIAogCg==