72497 2011-11-16 06:25:53 -0800 GraphicsContextStateSaver's restore() called redundantly in CanvasRenderingContext2D 2011-11-16 11:17:05 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 0 pdr webkit-unassigned darin kling webkit.review.bot zimmermann oldest_to_newest 503810 0 115368 pdr 2011-11-16 06:25:53 -0800 Created attachment 115368 Small patch to remove an extra restore() call. In https://bugs.webkit.org/show_bug.cgi?id=61528, it was pointed out (by Andreas Kling) that GraphicsContextStateSaver.restore() is called twice in CanvasRenderingContext2D::drawTextInternal. 503818 1 115369 pdr 2011-11-16 06:32:06 -0800 Created attachment 115369 Small patch to remove an extra restore() call. Still had the old bugid. Updated 61528->72497 503919 2 115369 kling 2011-11-16 08:38:02 -0800 Comment on attachment 115369 Small patch to remove an extra restore() call. View in context: https://bugs.webkit.org/attachment.cgi?id=115369&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Actually, cq will choke on this line, you need to remove it. :) 503922 3 115386 pdr 2011-11-16 08:41:20 -0800 Created attachment 115386 Small patch to remove an extra restore() call. Removed line about no new tests. 503926 4 115387 pdr 2011-11-16 08:47:20 -0800 Created attachment 115387 Small patch to remove an extra restore() call. Manual edit to patch file fail. Lets try this again.. 504077 5 115387 webkit.review.bot 2011-11-16 11:17:00 -0800 Comment on attachment 115387 Small patch to remove an extra restore() call. Clearing flags on attachment: 115387 Committed r100475: <http://trac.webkit.org/changeset/100475> 504078 6 webkit.review.bot 2011-11-16 11:17:05 -0800 All reviewed patches have been landed. Closing bug. 115368 2011-11-16 06:25:53 -0800 2011-11-16 06:32:06 -0800 Small patch to remove an extra restore() call. 61528.restore.patch text/plain 1370 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDI5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE1ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGV4dHJhIEdyYXBoaWNz Q29udGV4dFN0YXRlU2F2ZXIgcmVzdG9yZSgpIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTc5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAg ICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd1RleHRJbnRlcm5hbCk6CisKIDIw MTEtMTEtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBIb3N0V2luZG93IGludmFsaWRhdGlvbiBmdW5jdGlvbnMgc2hvdWxkIHVzZSByb290IHZpZXcg Y29vcmRpbmF0ZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl cmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkocmV2aXNpb24gMTAwMjg2KQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjIwNSw3ICsyMjA1LDYgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQ6OmRyYXdUZXh0SQogICAgICAgICAvLyBXZSBkcmF3IHdoZW4gZm9udFdpZHRoIGlzIDAg c28gY29tcG9zaXRpbmcgb3BlcmF0aW9ucyAoZWcsIGEgImNvcHkiIG9wKSBzdGlsbCB3b3JrLgog ICAgICAgICBjLT5zY2FsZShGbG9hdFNpemUoKGZvbnRXaWR0aCA+IDAgPyAod2lkdGggLyBmb250 V2lkdGgpIDogMCksIDEpKTsKICAgICAgICAgYy0+ZHJhd0JpZGlUZXh0KGZvbnQsIHRleHRSdW4s IEZsb2F0UG9pbnQoMCwgMCkpOwotICAgICAgICBzdGF0ZVNhdmVyLnJlc3RvcmUoKTsKICAgICB9 IGVsc2UKICAgICAgICAgYy0+ZHJhd0JpZGlUZXh0KGZvbnQsIHRleHRSdW4sIGxvY2F0aW9uKTsK IAo= 115369 2011-11-16 06:32:06 -0800 2011-11-16 08:41:20 -0800 Small patch to remove an extra restore() call. 72497.restore.2.patch text/plain 1370 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDI5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE1ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGV4dHJhIEdyYXBoaWNz Q29udGV4dFN0YXRlU2F2ZXIgcmVzdG9yZSgpIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAg ICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd1RleHRJbnRlcm5hbCk6CisKIDIw MTEtMTEtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAg ICBIb3N0V2luZG93IGludmFsaWRhdGlvbiBmdW5jdGlvbnMgc2hvdWxkIHVzZSByb290IHZpZXcg Y29vcmRpbmF0ZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRl cmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkocmV2aXNpb24gMTAwMjg2KQorKysgU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjIwNSw3ICsyMjA1LDYgQEAgdm9pZCBDYW52YXNSZW5kZXJpbmdDb250 ZXh0MkQ6OmRyYXdUZXh0SQogICAgICAgICAvLyBXZSBkcmF3IHdoZW4gZm9udFdpZHRoIGlzIDAg c28gY29tcG9zaXRpbmcgb3BlcmF0aW9ucyAoZWcsIGEgImNvcHkiIG9wKSBzdGlsbCB3b3JrLgog ICAgICAgICBjLT5zY2FsZShGbG9hdFNpemUoKGZvbnRXaWR0aCA+IDAgPyAod2lkdGggLyBmb250 V2lkdGgpIDogMCksIDEpKTsKICAgICAgICAgYy0+ZHJhd0JpZGlUZXh0KGZvbnQsIHRleHRSdW4s IEZsb2F0UG9pbnQoMCwgMCkpOwotICAgICAgICBzdGF0ZVNhdmVyLnJlc3RvcmUoKTsKICAgICB9 IGVsc2UKICAgICAgICAgYy0+ZHJhd0JpZGlUZXh0KGZvbnQsIHRleHRSdW4sIGxvY2F0aW9uKTsK IAo= 115386 2011-11-16 08:41:20 -0800 2011-11-16 08:47:20 -0800 Small patch to remove an extra restore() call. 72497.restore.3.patch text/plain 1337 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDI5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE1ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGV4dHJhIEdyYXBoaWNz Q29udGV4dFN0YXRlU2F2ZXIgcmVzdG9yZSgpIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29u dGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6 ZHJhd1RleHRJbnRlcm5hbCk6CisKIDIwMTEtMTEtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBIb3N0V2luZG93IGludmFsaWRhdGlvbiBmdW5jdGlv bnMgc2hvdWxkIHVzZSByb290IHZpZXcgY29vcmRpbmF0ZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAko cmV2aXNpb24gMTAwMjg2KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVu ZGVyaW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIwNSw3ICsyMjA1LDYgQEAg dm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdUZXh0SQogICAgICAgICAvLyBXZSBk cmF3IHdoZW4gZm9udFdpZHRoIGlzIDAgc28gY29tcG9zaXRpbmcgb3BlcmF0aW9ucyAoZWcsIGEg ImNvcHkiIG9wKSBzdGlsbCB3b3JrLgogICAgICAgICBjLT5zY2FsZShGbG9hdFNpemUoKGZvbnRX aWR0aCA+IDAgPyAod2lkdGggLyBmb250V2lkdGgpIDogMCksIDEpKTsKICAgICAgICAgYy0+ZHJh d0JpZGlUZXh0KGZvbnQsIHRleHRSdW4sIEZsb2F0UG9pbnQoMCwgMCkpOwotICAgICAgICBzdGF0 ZVNhdmVyLnJlc3RvcmUoKTsKICAgICB9IGVsc2UKICAgICAgICAgYy0+ZHJhd0JpZGlUZXh0KGZv bnQsIHRleHRSdW4sIGxvY2F0aW9uKTsKIAo= 115387 2011-11-16 08:47:20 -0800 2011-11-16 11:17:00 -0800 Small patch to remove an extra restore() call. 72497.restore.3.patch text/plain 1337 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDI5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTE1ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGV4dHJhIEdyYXBoaWNz Q29udGV4dFN0YXRlU2F2ZXIgcmVzdG9yZSgpIGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29u dGV4dDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6 ZHJhd1RleHRJbnRlcm5hbCk6CisKIDIwMTEtMTEtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBIb3N0V2luZG93IGludmFsaWRhdGlvbiBmdW5jdGlv bnMgc2hvdWxkIHVzZSByb290IHZpZXcgY29vcmRpbmF0ZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAko cmV2aXNpb24gMTAwMjg2KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVu ZGVyaW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIwNSw3ICsyMjA1LDYgQEAg dm9pZCBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdUZXh0SQogICAgICAgICAvLyBXZSBk cmF3IHdoZW4gZm9udFdpZHRoIGlzIDAgc28gY29tcG9zaXRpbmcgb3BlcmF0aW9ucyAoZWcsIGEg ImNvcHkiIG9wKSBzdGlsbCB3b3JrLgogICAgICAgICBjLT5zY2FsZShGbG9hdFNpemUoKGZvbnRX aWR0aCA+IDAgPyAod2lkdGggLyBmb250V2lkdGgpIDogMCksIDEpKTsKICAgICAgICAgYy0+ZHJh d0JpZGlUZXh0KGZvbnQsIHRleHRSdW4sIEZsb2F0UG9pbnQoMCwgMCkpOwotICAgICAgICBzdGF0 ZVNhdmVyLnJlc3RvcmUoKTsKICAgICB9IGVsc2UKICAgICAgICAgYy0+ZHJhd0JpZGlUZXh0KGZv bnQsIHRleHRSdW4sIGxvY2F0aW9uKTsKIAo=