72488 2011-11-16 04:35:48 -0800 Remove unnecessary if check from RenderListBox::paintItemForeground 2011-11-16 07:05:17 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 xqb748 webkit-unassigned darin tkent webkit.review.bot oldest_to_newest 503760 0 xqb748 2011-11-16 04:35:48 -0800 There is a if check which checks for visibility before drawing text. if (itemStyle->visibility() != HIDDEN) paintInfo.context->drawBidiText(itemFont, textRun, r.location()); I think this if check is unnecessary, since there is already an early return available for the visibility and the itemStyle is not modified in between. The early return is as follows:- if (itemStyle->visibility() == HIDDEN) return; 503765 1 115359 xqb748 2011-11-16 04:40:58 -0800 Created attachment 115359 Proposed Patch Proposed Patch. 503806 2 115359 kling 2011-11-16 06:19:15 -0800 Comment on attachment 115359 Proposed Patch r=me 503842 3 115359 webkit.review.bot 2011-11-16 07:05:13 -0800 Comment on attachment 115359 Proposed Patch Clearing flags on attachment: 115359 Committed r100447: <http://trac.webkit.org/changeset/100447> 503843 4 webkit.review.bot 2011-11-16 07:05:17 -0800 All reviewed patches have been landed. Closing bug. 115359 2011-11-16 04:40:58 -0800 2011-11-16 07:05:13 -0800 Proposed Patch 72488.txt text/plain 1292 xqb748 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDQzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTE2ICBBbnRhcnlh bWkgUGFuZGlhICA8YW50YXJ5YW1pLnBhbmRpYUBtb3Rvcm9sYS5jb20+CisKKyAgICAgICAgUmVt b3ZlIHVubmVjZXNzYXJ5IGlmIGNoZWNrIGZyb20gUmVuZGVyTGlzdEJveDo6cGFpbnRJdGVtRm9y ZWdyb3VuZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcyNDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyTGlzdEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJM aXN0Qm94OjpwYWludEl0ZW1Gb3JlZ3JvdW5kKToKKwogMjAxMS0xMS0xNiAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjEwMDI2Ni4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM aXN0Qm94LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGlzdEJveC5jcHAJKHJldmlzaW9uIDEwMDQyOSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMaXN0Qm94LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIwLDggKzQyMCw3IEBAIHZv aWQgUmVuZGVyTGlzdEJveDo6cGFpbnRJdGVtRm9yZWdyb3VuZCgKICAgICB9CiAKICAgICAvLyBE cmF3IHRoZSBpdGVtIHRleHQKLSAgICBpZiAoaXRlbVN0eWxlLT52aXNpYmlsaXR5KCkgIT0gSElE REVOKQotICAgICAgICBwYWludEluZm8uY29udGV4dC0+ZHJhd0JpZGlUZXh0KGl0ZW1Gb250LCB0 ZXh0UnVuLCByLmxvY2F0aW9uKCkpOworICAgIHBhaW50SW5mby5jb250ZXh0LT5kcmF3QmlkaVRl eHQoaXRlbUZvbnQsIHRleHRSdW4sIHIubG9jYXRpb24oKSk7CiB9CiAKIHZvaWQgUmVuZGVyTGlz dEJveDo6cGFpbnRJdGVtQmFja2dyb3VuZChQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgTGF5 b3V0UG9pbnQmIHBhaW50T2Zmc2V0LCBpbnQgbGlzdEluZGV4KQo=