72476 2011-11-15 23:45:27 -0800 Specialize HashTraits for RefPtr to use PassRefPtr as "pass type" to reduce reference count churn 2011-12-24 14:49:42 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72474 1 darin darin webkit.review.bot oldest_to_newest 503643 0 darin 2011-11-15 23:45:27 -0800 Once the HashMap feature to use a "pass type" is complete, we can start using PassRefPtr for the "pass type" for hash maps where the value is a RefPtr. This should cut down on reference count churn a bit when adding items and taking items out of the map. 515498 1 117954 darin 2011-12-05 16:46:53 -0800 Created attachment 117954 Patch 527029 2 117954 webkit.review.bot 2011-12-24 14:49:38 -0800 Comment on attachment 117954 Patch Clearing flags on attachment: 117954 Committed r103665: <http://trac.webkit.org/changeset/103665> 527030 3 webkit.review.bot 2011-12-24 14:49:42 -0800 All reviewed patches have been landed. Closing bug. 117954 2011-12-05 16:46:53 -0800 2011-12-24 14:49:38 -0800 Patch bug-72476-20111205164713.patch text/plain 2364 darin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAyMDcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDExLTEyLTA1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBT cGVjaWFsaXplIEhhc2hUcmFpdHMgZm9yIFJlZlB0ciB0byB1c2UgUGFzc1JlZlB0ciBhcyAicGFz cyB0eXBlIiB0byByZWR1Y2UgcmVmZXJlbmNlIGNvdW50IGNodXJuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MjQ3NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0hhc2hUcmFpdHMuaDogRGVmaW5l ZCBQYXNzSW5UeXBlIGFuZCBzdG9yZSBmdW5jdGlvbiBpbiBIYXNoVHJhaXRzPFJlZlB0cj4uCisK IDIwMTEtMTItMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIENv bnZlcnQgSlNDbGFzc1JlZiB0byB1c2UgSGFzaE1hcDxPd25QdHI+CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd3RmL0hhc2hUcmFpdHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd3RmL0hhc2hUcmFpdHMuaAkocmV2aXNpb24gMTAyMDU0KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9IYXNoVHJhaXRzLmgJKHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcw LDggQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHN0YXRpYyBQYXNzT3V0VHlwZSBwYXNzT3V0 KGNvbnN0IFQmIHZhbHVlKSB7IHJldHVybiB2YWx1ZTsgfQogCiAgICAgICAgIC8vIFR5cGUgZm9y IHJldHVybiB2YWx1ZSBvZiBmdW5jdGlvbnMgdGhhdCBkbyBub3QgdHJhbnNmZXIgb3duZXJzaGlw LCBzdWNoIGFzIGdldC4KLSAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBjaGFuZ2UgdGhpcyB0 eXBlIHRvIGNvbnN0IFQmIGZvciBiZXR0ZXIgcGVyZm9ybWFuY2UuCisgICAgICAgIC8vIEZJWE1F OiBXZSBjb3VsZCBjaGFuZ2UgdGhpcyB0eXBlIHRvIGNvbnN0IFQmIGZvciBiZXR0ZXIgcGVyZm9y bWFuY2UgaWYgd2UgZmlndXJlZCBvdXQKKyAgICAgICAgLy8gYSB3YXkgdG8gaGFuZGxlIHRoZSBy ZXR1cm4gdmFsdWUgZnJvbSBlbXB0eVZhbHVlLCB3aGljaCBpcyBhIHRlbXBvcmFyeS4KICAgICAg ICAgdHlwZWRlZiBUIFBlZWtUeXBlOwogICAgICAgICBzdGF0aWMgUGVla1R5cGUgcGVlayhjb25z dCBUJiB2YWx1ZSkgeyByZXR1cm4gdmFsdWU7IH0KICAgICB9OwpAQCAtMTI0LDEwICsxMjUsMTIg QEAgbmFtZXNwYWNlIFdURiB7CiAgICAgfTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFA+IHN0 cnVjdCBIYXNoVHJhaXRzPFJlZlB0cjxQPiA+IDogU2ltcGxlQ2xhc3NIYXNoVHJhaXRzPFJlZlB0 cjxQPiA+IHsKLSAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBjaGFuZ2UgUGFzc0luVHlwZSB0 byBQYXNzUmVmUHRyIGZvciBiZXR0ZXIgcGVyZm9ybWFuY2UuCisgICAgICAgIHR5cGVkZWYgUGFz c1JlZlB0cjxQPiBQYXNzSW5UeXBlOworICAgICAgICBzdGF0aWMgdm9pZCBzdG9yZShQYXNzUmVm UHRyPFA+IHZhbHVlLCBSZWZQdHI8UD4mIHN0b3JhZ2UpIHsgc3RvcmFnZSA9IHZhbHVlOyB9CisK ICAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBjaGFuZ2UgUGFzc091dFR5cGUgdG8gUGFzc1Jl ZlB0ciBmb3IgYmV0dGVyIHBlcmZvcm1hbmNlLgotICAgICAgICAvLyBGSVhNRTogV2UgY291bGQg Y29uc2lkZXIgY2hhbmdpbmcgUGVla1R5cGUgdG8gYSByYXcgcG9pbnRlciBzbyBjYWxsZXJzIGRv bid0IG5lZWQgdG8KLSAgICAgICAgLy8gY2FsbCBnZXQ7IGRvaW5nIHNvIHdpbGwgcmVxdWlyZSB1 cGRhdGluZyBtYW55IGNhbGwgc2l0ZXMuCisgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY29u c2lkZXIgY2hhbmdpbmcgUGVla1R5cGUgdG8gYSByYXcgcG9pbnRlciBmb3IgYmV0dGVyIHBlcmZv cm1hbmNlLAorICAgICAgICAvLyBidXQgdGhlbiBjYWxsZXJzIHdvbid0IG5lZWQgdG8gY2FsbCBn ZXQ7IGRvaW5nIHNvIHdpbGwgcmVxdWlyZSB1cGRhdGluZyBtYW55IGNhbGwgc2l0ZXMuCiAgICAg fTsKIAogICAgIHRlbXBsYXRlPD4gc3RydWN0IEhhc2hUcmFpdHM8U3RyaW5nPiA6IFNpbXBsZUNs YXNzSGFzaFRyYWl0czxTdHJpbmc+IHsgfTsK