72469 2011-11-15 23:28:55 -0800 [WebKit2][gtk] Fix assert while running TestWebKitSettings 2011-11-17 00:53:26 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nayankk nayankk cgarcia mrobinson webkit.review.bot oldest_to_newest 503627 0 nayankk 2011-11-15 23:28:55 -0800 By default, value of minimum-font-size property is 0. But TestWebKitSetting checks for value 5. 503656 1 115336 nayankk 2011-11-15 23:56:31 -0800 Created attachment 115336 Correct the test 503657 2 webkit.review.bot 2011-11-15 23:59:38 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 504636 3 115336 webkit.review.bot 2011-11-17 00:53:22 -0800 Comment on attachment 115336 Correct the test Clearing flags on attachment: 115336 Committed r100578: <http://trac.webkit.org/changeset/100578> 504637 4 webkit.review.bot 2011-11-17 00:53:26 -0800 All reviewed patches have been landed. Closing bug. 115336 2011-11-15 23:56:31 -0800 2011-11-17 00:53:22 -0800 Correct the test bug-72469-20111116132626.patch text/plain 1733 nayankk U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwNDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzI5NmE5OGFkZmFmNjRm N2U4ZWE0NTEzOGI2NDJlNGMwNWJkMGEwYy4uN2VjNWNkMzk3ZjI0ZjMyMDhmM2JjNDM5YTFiNjc5 YTQ0ZjYyNDA3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTE1ICBOYXlh biBLdW1hciBLICA8bmF5YW5ra0Btb3Rvcm9sYS5jb20+CisKKyAgICAgICAgW1dlYktpdDJdW2d0 a10gRml4IGFzc2VydCB3aGlsZSBydW5uaW5nIFRlc3RXZWJLaXRTZXR0aW5ncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI0NjkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHA6CisgICAgICAgICh0ZXN0V2ViS2l0U2V0dGlu Z3MpOiBDb3JyZWN0IHRoZSB0ZXN0LgorCiAyMDExLTExLTE1ICBBbmR5IEVzdGVzICA8YWVzdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBDb25zb2xpZGF0ZSB0aGUgbG9naWMgdGhhdCBjcmVhdGVz IHJ1biBsb29wIG9ic2VydmVycyBmb3IgZmx1c2hpbmcgbGF5ZXIgdHJlZSBjaGFuZ2VzIHRvIENv cmVBbmltYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0U2V0dGluZ3MuY3BwCmluZGV4IDQ2YzZmZmZlNzIwNjVh ZjA1NWE5ODA2YzgxMmZkODdiYjA1NmQ4MzYuLjU0OGQ1ODFkMWM1NTZlOTdiZTdkOGFjOWYyZWIy MmYzNDVkNWY4MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L3Rlc3RzL1Rlc3RXZWJLaXRTZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFdlYktpdFNldHRpbmdzLmNwcApAQCAtMTQ3LDggKzE0Nyw4 IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJLaXRTZXR0aW5ncyhUZXN0KiwgZ2NvbnN0cG9pbnRlcikK ICAgICB3ZWJraXRfc2V0dGluZ3Nfc2V0X2RlZmF1bHRfbW9ub3NwYWNlX2ZvbnRfc2l6ZShzZXR0 aW5ncywgMTIpOwogICAgIGdfYXNzZXJ0X2NtcHVpbnQod2Via2l0X3NldHRpbmdzX2dldF9kZWZh dWx0X21vbm9zcGFjZV9mb250X3NpemUoc2V0dGluZ3MpLCA9PSwgMTIpOwogCi0gICAgLy8gRGVm YXVsdCBtaW5pbXVtIGZvbnQgc2l6ZSBpcyA1LgotICAgIGdfYXNzZXJ0X2NtcHVpbnQod2Via2l0 X3NldHRpbmdzX2dldF9taW5pbXVtX2ZvbnRfc2l6ZShzZXR0aW5ncyksID09LCA1KTsKKyAgICAv LyBEZWZhdWx0IG1pbmltdW0gZm9udCBzaXplIGlzIDAuCisgICAgZ19hc3NlcnRfY21wdWludCh3 ZWJraXRfc2V0dGluZ3NfZ2V0X21pbmltdW1fZm9udF9zaXplKHNldHRpbmdzKSwgPT0sIDApOwog ICAgIHdlYmtpdF9zZXR0aW5nc19zZXRfbWluaW11bV9mb250X3NpemUoc2V0dGluZ3MsIDcpOwog ICAgIGdfYXNzZXJ0X2NtcHVpbnQod2Via2l0X3NldHRpbmdzX2dldF9taW5pbXVtX2ZvbnRfc2l6 ZShzZXR0aW5ncyksID09LCA3KTsKIAo=