72464 2011-11-15 22:44:31 -0800 [chromium] Add null pointer check in setDeviceScaleFactor 2011-11-16 13:13:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 aelias webkit-unassigned aelias aroben fsamuel jamesr webkit.review.bot oldest_to_newest 503604 0 aelias 2011-11-15 22:44:31 -0800 [chromium] Add null pointer check in setDeviceScaleFActor 503605 1 115325 aelias 2011-11-15 22:45:50 -0800 Created attachment 115325 Patch 503998 2 fsamuel 2011-11-16 09:59:41 -0800 That looks fine to me. Please ask fishd or jamesr to r+ it. 504172 3 115325 webkit.review.bot 2011-11-16 13:11:39 -0800 Comment on attachment 115325 Patch Clearing flags on attachment: 115325 Committed r100496: <http://trac.webkit.org/changeset/100496> 504174 4 webkit.review.bot 2011-11-16 13:11:43 -0800 All reviewed patches have been landed. Closing bug. 504178 5 115325 aroben 2011-11-16 13:13:41 -0800 Comment on attachment 115325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115325&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (Tiny fix.) I don't understand this. Sure, the fix is small in terms of the number of characters changed. But presumably you are fixing a crash, which is not a "tiny" issue. Is it possible to test this? 115325 2011-11-15 22:45:50 -0800 2011-11-16 13:13:41 -0800 Patch bug-72464-20111115224549.patch text/plain 1305 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWM1NzEwOTNiNjQwZDNm Y2Q1Zjg1MGQ3ZWRiMjUzNDk1NmVkOTRmNC4uODUwNzA0ZDJkMzkyNTQ2Yjc4ZThiZmJiMmExMmVh ZWIyNTVlY2U2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTExLTE1ICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEFk ZCBudWxsIHBvaW50ZXIgY2hlY2sgaW4gc2V0RGV2aWNlU2NhbGVGYWN0b3IKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyNDY0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoVGlueSBm aXguKQorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6 OnNldERldmljZVNjYWxlRmFjdG9yKToKKwogMjAxMS0xMS0xNSAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjEwMDIxMy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCmluZGV4IDg2OTU1OTFkYjJlMWE5YzA1MmVmZWFi ZjU4ZTVjZDg1YzNiZTdjNTIuLmNlNzNlYjBiY2I4ZTI2OGMzNmE4ZDJhNmRmZjFmNjY5YTBjYjFh NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9QYWdlLmNwcApAQCAtNjU2LDcgKzY1Niw4IEBAIHZvaWQgUGFnZTo6c2V0 RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQgc2NhbGVGYWN0b3IpCiAgICAgc2V0TmVlZHNSZWNhbGNT dHlsZUluQWxsRnJhbWVzKCk7CiAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0g ICAgbV9tYWluRnJhbWUtPmRldmljZU9yUGFnZVNjYWxlRmFjdG9yQ2hhbmdlZCgpOworICAgIGlm IChtYWluRnJhbWUoKSkKKyAgICAgICAgbWFpbkZyYW1lKCktPmRldmljZU9yUGFnZVNjYWxlRmFj dG9yQ2hhbmdlZCgpOwogI2VuZGlmCiAKICAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1haW5GcmFt ZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkK