72453 2011-11-15 19:35:09 -0800 DRT's uiElementAttributeValueCallback function is leaky 2011-11-15 22:51:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben darin cfleizach darin oldest_to_newest 503519 0 aroben 2011-11-15 19:35:09 -0800 Check it out: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/AccessibilityUIElement.cpp?rev=99741#L377 We're leaking the attribute string. The Leaks bot concurs. 503603 1 115324 darin 2011-11-15 22:43:06 -0800 Created attachment 115324 Patch 503608 2 darin 2011-11-15 22:46:54 -0800 Committed r100409: <http://trac.webkit.org/changeset/100409> 115324 2011-11-15 22:43:06 -0800 2011-11-15 22:51:57 -0800 Patch bug-72453-20111115224305.patch text/plain 1898 darin SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEwMDQwNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTExLTE1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKwor ICAgICAgICBEUlQncyB1aUVsZW1lbnRBdHRyaWJ1dGVWYWx1ZUNhbGxiYWNrIGZ1bmN0aW9uIGlz IGxlYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03 MjQ1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5jcHA6CisgICAgICAgICh1aUVs ZW1lbnRBdHRyaWJ1dGVWYWx1ZUNhbGxiYWNrKTogVXNlIEpTUmV0YWluUHRyIGFuZCBkb24ndCBs ZWFrLgorCiAyMDExLTExLTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIEltcGxlbWVudCBlZGl0LWRpc3RhbmNlIGJhc2VkIHJldmlld2VyIHJlY29nbml0aW9u IGFsZ29yaXRobQpJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxl bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudC5jcHAJKHJldmlzaW9uIDk5OTg1KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUv QWNjZXNzaWJpbGl0eVVJRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3NiwxMSArMzc2 LDExIEBAIHN0YXRpYyBKU1ZhbHVlUmVmIHN0cmluZ0F0dHJpYnV0ZVZhbHVlQ2EKIAogc3RhdGlj IEpTVmFsdWVSZWYgdWlFbGVtZW50QXR0cmlidXRlVmFsdWVDYWxsYmFjayhKU0NvbnRleHRSZWYg Y29udGV4dCwgSlNPYmplY3RSZWYgZnVuY3Rpb24sIEpTT2JqZWN0UmVmIHRoaXNPYmplY3QsIHNp emVfdCBhcmd1bWVudENvdW50LCBjb25zdCBKU1ZhbHVlUmVmIGFyZ3VtZW50c1tdLCBKU1ZhbHVl UmVmKiBleGNlcHRpb24pCiB7Ci0gICAgSlNTdHJpbmdSZWYgYXR0cmlidXRlID0gMDsKKyAgICBK U1JldGFpblB0cjxKU1N0cmluZ1JlZj4gYXR0cmlidXRlOwogICAgIGlmIChhcmd1bWVudENvdW50 ID09IDEpCi0gICAgICAgIGF0dHJpYnV0ZSA9IEpTVmFsdWVUb1N0cmluZ0NvcHkoY29udGV4dCwg YXJndW1lbnRzWzBdLCBleGNlcHRpb24pOworICAgICAgICBhdHRyaWJ1dGUuYWRvcHQoSlNWYWx1 ZVRvU3RyaW5nQ29weShjb250ZXh0LCBhcmd1bWVudHNbMF0sIGV4Y2VwdGlvbikpOwogICAgIAot ICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjptYWtlSlNBY2Nlc3NpYmlsaXR5VUlF bGVtZW50KGNvbnRleHQsIHRvQVhFbGVtZW50KHRoaXNPYmplY3QpLT51aUVsZW1lbnRBdHRyaWJ1 dGVWYWx1ZShhdHRyaWJ1dGUpKTsKKyAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6 bWFrZUpTQWNjZXNzaWJpbGl0eVVJRWxlbWVudChjb250ZXh0LCB0b0FYRWxlbWVudCh0aGlzT2Jq ZWN0KS0+dWlFbGVtZW50QXR0cmlidXRlVmFsdWUoYXR0cmlidXRlLmdldCgpKSk7CiB9CiAKIHN0 YXRpYyBKU1ZhbHVlUmVmIG51bWJlckF0dHJpYnV0ZVZhbHVlQ2FsbGJhY2soSlNDb250ZXh0UmVm IGNvbnRleHQsIEpTT2JqZWN0UmVmIGZ1bmN0aW9uLCBKU09iamVjdFJlZiB0aGlzT2JqZWN0LCBz aXplX3QgYXJndW1lbnRDb3VudCwgY29uc3QgSlNWYWx1ZVJlZiBhcmd1bWVudHNbXSwgSlNWYWx1 ZVJlZiogZXhjZXB0aW9uKQo=