72451 2011-11-15 19:11:12 -0800 Web Inspector: Share Highlight Code for Drawing Outlined Quad 2011-11-15 19:54:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 503511 0 joepeck 2011-11-15 19:11:12 -0800 The drawRectHighlight had the same draw outline quad code as the drawNodeHighlight path. This shares the code. 503512 1 115298 joepeck 2011-11-15 19:13:17 -0800 Created attachment 115298 [PATCH] Share Code 503530 2 115298 webkit.review.bot 2011-11-15 19:54:27 -0800 Comment on attachment 115298 [PATCH] Share Code Clearing flags on attachment: 115298 Committed r100395: <http://trac.webkit.org/changeset/100395> 503531 3 webkit.review.bot 2011-11-15 19:54:32 -0800 All reviewed patches have been landed. Closing bug. 115298 2011-11-15 19:13:17 -0800 2011-11-15 19:54:27 -0800 [PATCH] Share Code share.patch text/plain 1871 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MTY1MDhhLi5hYWY1MGU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTEtMTEtMTUgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaGFyZSBIaWdobGlnaHQgQ29kZSBmb3IgRHJhd2luZyBP dXRsaW5lZCBRdWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MjQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHA6CisKIDIwMTEtMTEtMTQgIEFs ZXhhbmRyZSBFbGlhcyAgPGFlbGlhc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0g Rml4IHNjYWxlRGVsdGEgem9vbS1vdXQgdmlzaWJpbGl0eSByZWN0IGJ1ZwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0RPTU5vZGVIaWdobGlnaHRlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hsaWdodGVyLmNwcAppbmRleCA5MzAzNWJiLi4y ODU3YzhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hs aWdodGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvRE9NTm9kZUhpZ2hsaWdo dGVyLmNwcApAQCAtNDYyLDI2ICs0NjIsOCBAQCB2b2lkIGRyYXdSZWN0SGlnaGxpZ2h0KEdyYXBo aWNzQ29udGV4dCYgY29udGV4dCwgRG9jdW1lbnQqIGRvY3VtZW50LCBIaWdobGlnaHREYQogICAg IEZsb2F0UmVjdCBvdmVybGF5UmVjdCA9IHZpZXctPnZpc2libGVDb250ZW50UmVjdCgpOwogICAg IGNvbnRleHQudHJhbnNsYXRlKC1vdmVybGF5UmVjdC54KCksIC1vdmVybGF5UmVjdC55KCkpOwog Ci0gICAgc3RhdGljIGNvbnN0IGludCBvdXRsaW5lVGhpY2tuZXNzID0gMjsKLQotICAgIFBhdGgg cXVhZFBhdGggPSBxdWFkVG9QYXRoKEZsb2F0UmVjdCgqKGhpZ2hsaWdodERhdGEtPnJlY3QpKSk7 Ci0KLSAgICAvLyBDbGlwIG91dCB0aGUgcXVhZCwgdGhlbiBkcmF3IHdpdGggYSAycHggc3Ryb2tl IHRvIGdldCBhIHBpeGVsCi0gICAgLy8gb2Ygb3V0bGluZSAoYmVjYXVzZSBpbmZsYXRpbmcgYSBx dWFkIGlzIGhhcmQpCi0gICAgewotICAgICAgICBjb250ZXh0LnNhdmUoKTsKLSAgICAgICAgY29u dGV4dC5jbGlwT3V0KHF1YWRQYXRoKTsKLQotICAgICAgICBjb250ZXh0LnNldFN0cm9rZVRoaWNr bmVzcyhvdXRsaW5lVGhpY2tuZXNzKTsKLSAgICAgICAgY29udGV4dC5zZXRTdHJva2VDb2xvciho aWdobGlnaHREYXRhLT5jb250ZW50T3V0bGluZSwgQ29sb3JTcGFjZURldmljZVJHQik7Ci0gICAg ICAgIGNvbnRleHQuc3Ryb2tlUGF0aChxdWFkUGF0aCk7Ci0KLSAgICAgICAgY29udGV4dC5yZXN0 b3JlKCk7Ci0gICAgfQotCi0gICAgLy8gTm93IGRvIHRoZSBmaWxsCi0gICAgY29udGV4dC5zZXRG aWxsQ29sb3IoaGlnaGxpZ2h0RGF0YS0+Y29udGVudCwgQ29sb3JTcGFjZURldmljZVJHQik7Ci0g ICAgY29udGV4dC5maWxsUGF0aChxdWFkUGF0aCk7CisgICAgRmxvYXRSZWN0IGhpZ2hsaWdodFJl Y3QoKihoaWdobGlnaHREYXRhLT5yZWN0KSk7CisgICAgZHJhd091dGxpbmVkUXVhZChjb250ZXh0 LCBoaWdobGlnaHRSZWN0LCBoaWdobGlnaHREYXRhLT5jb250ZW50LCBoaWdobGlnaHREYXRhLT5j b250ZW50T3V0bGluZSk7CiB9CiAKIH0gLy8gYW5vbnltb3VzIG5hbWVzcGFjZQo=