72436 2011-11-15 16:14:47 -0800 Layout Test http/tests/multipart/invalid-image-data.html is crashing 2011-11-16 14:11:14 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pkasting japhet abarth japhet webkit.review.bot oldest_to_newest 503400 0 pkasting 2011-11-15 16:14:47 -0800 The following layout test is failing an assertion on the Win dbg 2 canary (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmultipart%2Finvalid-image-data.html ): http/tests/multipart/invalid-image-data.html ASSERTION FAILED: size == 0 || size >= m_encodedSize (this is in CachedResource::setEncodedSize()) The most obvious change in the blame list is http://trac.webkit.org/changeset/100311/ . 504079 1 115413 japhet 2011-11-16 11:18:21 -0800 Created attachment 115413 patch 504081 2 115413 abarth 2011-11-16 11:20:36 -0800 Comment on attachment 115413 patch I'm not sure sendDataToResource is the perfect name, but I understand why you chose it. 504237 3 115413 webkit.review.bot 2011-11-16 14:11:10 -0800 Comment on attachment 115413 patch Clearing flags on attachment: 115413 Committed r100503: <http://trac.webkit.org/changeset/100503> 504238 4 webkit.review.bot 2011-11-16 14:11:14 -0800 All reviewed patches have been landed. Closing bug. 115413 2011-11-16 11:18:21 -0800 2011-11-16 14:11:10 -0800 patch multi.txt text/plain 4194 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDQ3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDExLTExLTE2ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRml4IGluY29ycmVjdCBtdWx0 aXBhcnQgaGFuZGxpbmcgaW4gcjEwMDMxMS4KKyAgICAgICAgU3VicmVzb3VyY2VMb2FkZXI6OmRp ZFJlY2VpdmVEYXRhKCkgaXMgZ2V0dGluZyBjYWxsZWQKKyAgICAgICAgdHdpY2UsIHdoaWNoIGhh cyB1bmludGVuZGVkIHNpZGUgZWZmZWN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcyNDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgaHR0cC90ZXN0cy9tdWx0aXBhcnQvaW52YWxpZC1pbWFnZS1kYXRh Lmh0bWwgc2hvdWxkIHN0b3AKKyAgICAgICAgYXNzZXJ0aW5nIGFmdGVyIHRoaXMuCisKKyAgICAg ICAgKiBsb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3Vi cmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNwb25zZSk6CisgICAgICAgIChXZWJDb3JlOjpT dWJyZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6U3Vi cmVzb3VyY2VMb2FkZXI6OnNlbmREYXRhVG9SZXNvdXJjZSk6CisgICAgICAgICogbG9hZGVyL1N1 YnJlc291cmNlTG9hZGVyLmg6CisKIDIwMTEtMTEtMTYgIEFudGFyeWFtaSBQYW5kaWEgIDxhbnRh cnlhbWkucGFuZGlhQG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBbR3RrXSBkaXNwbGF5Om5vbmUg aGFzIG5vIGVmZmVjdCBvbiA8b3B0aW9uPiBlbGVtZW50LgpJbmRleDogU291cmNlL1dlYkNvcmUv bG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAxMDA0NjEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNzksNyArMTc5LDcgQEAKICAgICAgICAgLy8gU2luY2UgYSBzdWJyZXNvdXJjZSBsb2FkZXIg ZG9lcyBub3QgbG9hZCBtdWx0aXBhcnQgc2VjdGlvbnMgcHJvZ3Jlc3NpdmVseSwKICAgICAgICAg Ly8gZGVsaXZlciB0aGUgcHJldmlvdXNseSByZWNlaXZlZCBkYXRhIHRvIHRoZSBsb2FkZXIgYWxs IGF0IG9uY2Ugbm93LgogICAgICAgICAvLyBUaGVuIGNsZWFyIHRoZSBkYXRhIHRvIG1ha2Ugd2F5 IGZvciB0aGUgbmV4dCBtdWx0aXBhcnQgc2VjdGlvbi4KLSAgICAgICAgZGlkUmVjZWl2ZURhdGEo YnVmZmVyLT5kYXRhKCksIGJ1ZmZlci0+c2l6ZSgpLCAtMSwgdHJ1ZSk7CisgICAgICAgIHNlbmRE YXRhVG9SZXNvdXJjZShidWZmZXItPmRhdGEoKSwgYnVmZmVyLT5zaXplKCkpOwogICAgICAgICBj bGVhclJlc291cmNlRGF0YSgpOwogICAgICAgICAKICAgICAgICAgLy8gQWZ0ZXIgdGhlIGZpcnN0 IG11bHRpcGFydCBzZWN0aW9uIGlzIGNvbXBsZXRlLCBzaWduYWwgdG8gZGVsZWdhdGVzIHRoYXQg dGhpcyBsb2FkIGlzICJmaW5pc2hlZCIgCkBAIC0yMDQsNiArMjA0LDEyIEBACiAgICAgICAgIHJl dHVybjsKICAgICB9CiAKKyAgICBpZiAoIW1fbG9hZGluZ011bHRpcGFydENvbnRlbnQpCisgICAg ICAgIHNlbmREYXRhVG9SZXNvdXJjZShkYXRhLCBsZW5ndGgpOworfQorCit2b2lkIFN1YnJlc291 cmNlTG9hZGVyOjpzZW5kRGF0YVRvUmVzb3VyY2UoY29uc3QgY2hhciogZGF0YSwgaW50IGxlbmd0 aCkKK3sKICAgICAvLyBUaGVyZSBhcmUgdHdvIGNhc2VzIHdoZXJlIHdlIG1pZ2h0IG5lZWQgdG8g Y3JlYXRlIG91ciBvd24gU2hhcmVkQnVmZmVyIGluc3RlYWQgb2YgY29weWluZyB0aGUgb25lIGlu IFJlc291cmNlTG9hZGVyLgogICAgIC8vICgxKSBNdWx0aXBhcnQgY29udGVudDogVGhlIGxvYWRl ciBkZWxpdmVycyB0aGUgZGF0YSBpbiBhIG11bHRpcGFydCBzZWN0aW9uIGFsbCBhdCBvbmNlLCB0 aGVuIHNlbmRzIGVvZi4KICAgICAvLyAgICAgVGhlIHJlc291cmNlIGRhdGEgd2lsbCBjaGFuZ2Ug YXMgdGhlIG5leHQgcGFydCBpcyBsb2FkZWQsIHNvIHdlIG5lZWQgdG8gbWFrZSBhIGNvcHkuCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuaAkocmV2aXNpb24g MTAwNDYxKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmgJKHdv cmtpbmcgY29weSkKQEAgLTY4LDYgKzY4LDggQEAKICNlbmRpZgogICAgIHZpcnR1YWwgdm9pZCBy ZWxlYXNlUmVzb3VyY2VzKCk7CiAKKyAgICB2b2lkIHNlbmREYXRhVG9SZXNvdXJjZShjb25zdCBj aGFyKiwgaW50KTsKKwogICAgIGVudW0gU3VicmVzb3VyY2VMb2FkZXJTdGF0ZSB7CiAgICAgICAg IFVuaW5pdGlhbGl6ZWQsCiAgICAgICAgIEluaXRpYWxpemVkLApJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkocmV2aXNp b24gMTAwNDYxKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xMjQ3LDggKzEyNDcsNyBAQAogQlVHQ1IxMDM2 MSBXSU4gOiBodHRwL3Rlc3RzL21pc2Mvc2luZ2xlLWNoYXJhY3Rlci1waS1zdHlsZXNoZWV0Lnho dG1sID0gRkFJTAogCiAvLyBXaW5kb3dzIGlzIG1pc3NpbmcgdGhlIGdyZWVuIGJveC4gU3RhcnRl ZCB0byBwYXNzIGluIHJvbGwgdG8gV2ViS2l0IHI1MDMxMwotQlVHQ1I4NzI5IFdJTiBSRUxFQVNF IDogaHR0cC90ZXN0cy9tdWx0aXBhcnQvaW52YWxpZC1pbWFnZS1kYXRhLmh0bWwgPSBJTUFHRStU RVhUCi1CVUdXSzcyNDM2IFdJTiBERUJVRyA6IGh0dHAvdGVzdHMvbXVsdGlwYXJ0L2ludmFsaWQt aW1hZ2UtZGF0YS5odG1sID0gQ1JBU0gKK0JVR0NSODcyOSBXSU4gOiBodHRwL3Rlc3RzL211bHRp cGFydC9pbnZhbGlkLWltYWdlLWRhdGEuaHRtbCA9IElNQUdFK1RFWFQKIAogLy8gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K IC8vIE1BQyBQT1JUIFRFU1RTCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDA0NzIpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMS0x NiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBD UkFTSCBleHBlY3RhdGlvbiBmb3IKKyAgICAgICAgaHR0cC90ZXN0cy9tdWx0aXBhcnQvaW52YWxp ZC1pbWFnZS1kYXRhLmh0bWwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03MjQzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAy MDExLTExLTE2ICBTZXJnZXkgR2xhenVub3YgIDxzZXJnLmdsYXp1bm92QGdtYWlsLmNvbT4KIAog ICAgICAgICBTY3JpcHRDb250cm9sbGVyOjpleGVjdXRlSWZKYXZhU2NyaXB0VVJMIGdldHMgY29u ZnVzZWQgYnkgc3luY2hyb25vdXMgZnJhbWUgbG9hZHMK