72416 2011-11-15 14:10:55 -0800 Leaks seen in MemoryPressureHandlerMac.mm on Leaks bot 2011-11-17 14:49:46 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FLion%20Intel%20Leaks%2Fr100308%20%28129%29%2F InRadar P2 Normal --- 1 aroben msaboff darin msaboff webkit-bug-importer oldest_to_newest 503251 0 aroben 2011-11-15 14:10:55 -0800 http://build.webkit.org/LeaksViewer/?url=%2Fresults%2FLion%20Intel%20Leaks%2Fr100308%20%28129%29%2F shows that _cache_event_source and _timer_event_source in MemoryPressureHandlerMac.mm are being leaked. It looks like MemoryPressureHandler::uninstall is canceling but not releasing _cache_event_source. It looks like MemoryPressureHandler::holdOff will overwrite _timer_event_source without canceling or releasing it. (Perhaps uninstall should be doing this?) 503253 1 webkit-bug-importer 2011-11-15 14:11:09 -0800 <rdar://problem/10450686> 505180 2 115670 msaboff 2011-11-17 13:58:48 -0800 Created attachment 115670 Proposed Patch 505181 3 115670 ggaren 2011-11-17 14:00:46 -0800 Comment on attachment 115670 Proposed Patch r=me 505246 4 msaboff 2011-11-17 14:49:46 -0800 Committed r100681: <http://trac.webkit.org/changeset/100681> 115670 2011-11-17 13:58:48 -0800 2011-11-17 14:00:45 -0800 Proposed Patch 72416.patch text/plain 2840 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMDY2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDExLTExLTE3ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIExlYWtzIHNlZW4gaW4gTWVt b3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1tIG9uIExlYWtzIGJvdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzI0MTYKKworICAgICAgICBBZGRlZCBjb2Rl IHRvIHJlbGVhc2UgX2NhY2hlX2V2ZW50X3NvdXJjZSBhbmQgX3RpbWVyX2V2ZW50X3NvdXJjZQor ICAgICAgICBhZnRlciB0aGV5IGFyZSBjYW5jZWxlZCBvciB3aGVuIGNsZWFuaW5nIHVwLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgZml4aW5nIGxlYWtzIGNhdWdodCBieSBsZWFrcyBib3QuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9NZW1vcnlQcmVzc3VyZUhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5UHJl c3N1cmVIYW5kbGVyOjp+TWVtb3J5UHJlc3N1cmVIYW5kbGVyKToKKyAgICAgICAgKiBwbGF0Zm9y bS9tYWMvTWVtb3J5UHJlc3N1cmVIYW5kbGVyTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVt b3J5UHJlc3N1cmVIYW5kbGVyOjp1bmluc3RhbGwpOgorICAgICAgICAoV2ViQ29yZTo6TWVtb3J5 UHJlc3N1cmVIYW5kbGVyOjpob2xkT2ZmKToKKwogMjAxMS0xMS0xNyAgTWFyayBSb3dlICA8bXJv d2VAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzcyNjQ2PiBEaXNh YmxlIGRlcHJlY2F0aW9uIHdhcm5pbmdzIGFyb3VuZCBjb2RlIHdoZXJlIHdlIGNhbm5vdCBlYXNp bHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01lbW9yeVByZXNzdXJlSGFuZGxlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTWVtb3J5UHJlc3N1cmVI YW5kbGVyLmNwcAkocmV2aXNpb24gMTAwNjMyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v TWVtb3J5UHJlc3N1cmVIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsMTEg QEAgTWVtb3J5UHJlc3N1cmVIYW5kbGVyOjpNZW1vcnlQcmVzc3VyZUhhbgogewogfQogCitNZW1v cnlQcmVzc3VyZUhhbmRsZXI6On5NZW1vcnlQcmVzc3VyZUhhbmRsZXIoKQoreworICAgIHVuaW5z dGFsbCgpOworfQorCiAjaWYgIVBMQVRGT1JNKE1BQykgfHwgZGVmaW5lZChCVUlMRElOR19PTl9M RU9QQVJEKSB8fCBkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKIHZvaWQgTWVtb3J5 UHJlc3N1cmVIYW5kbGVyOjppbnN0YWxsKCkgeyB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9NZW1vcnlQcmVzc3VyZUhhbmRsZXJNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNzdXJlSGFuZGxlck1hYy5tbQkocmV2 aXNpb24gMTAwNjMyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL01lbW9yeVByZXNz dXJlSGFuZGxlck1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNzYsNyArNzYsMTUgQEAgdm9pZCBN ZW1vcnlQcmVzc3VyZUhhbmRsZXI6OnVuaW5zdGFsbCgpCiAgICAgICAgIHJldHVybjsKIAogICAg IGRpc3BhdGNoX3NvdXJjZV9jYW5jZWwoX2NhY2hlX2V2ZW50X3NvdXJjZSk7CisgICAgZGlzcGF0 Y2hfcmVsZWFzZShfY2FjaGVfZXZlbnRfc291cmNlKTsKICAgICBfY2FjaGVfZXZlbnRfc291cmNl ID0gMDsKKworICAgIGlmIChfdGltZXJfZXZlbnRfc291cmNlKSB7CisgICAgICAgIGRpc3BhdGNo X3NvdXJjZV9jYW5jZWwoX3RpbWVyX2V2ZW50X3NvdXJjZSk7CisgICAgICAgIGRpc3BhdGNoX3Jl bGVhc2UoX3RpbWVyX2V2ZW50X3NvdXJjZSk7CisgICAgICAgIF90aW1lcl9ldmVudF9zb3VyY2Ug PSAwOworICAgIH0KKwogICAgIG1faW5zdGFsbGVkID0gZmFsc2U7CiAgICAgCiAgICAgbm90aWZ5 X2NhbmNlbChfbm90aWZ5VG9rZW4pOwpAQCAtOTMsNiArMTAxLDcgQEAgdm9pZCBNZW1vcnlQcmVz c3VyZUhhbmRsZXI6OmhvbGRPZmYodW5zaQogICAgICAgICAgICAgZGlzcGF0Y2hfc291cmNlX3Nl dF90aW1lcihfdGltZXJfZXZlbnRfc291cmNlLCBkaXNwYXRjaF90aW1lKERJU1BBVENIX1RJTUVf Tk9XLCBzZWNvbmRzICogTlNFQ19QRVJfU0VDKSwgRElTUEFUQ0hfVElNRV9GT1JFVkVSLCAxICog c19zZWNvbmRzQmV0d2Vlbk1lbW9yeUNsZWFudXApOwogICAgICAgICAgICAgZGlzcGF0Y2hfc291 cmNlX3NldF9ldmVudF9oYW5kbGVyKF90aW1lcl9ldmVudF9zb3VyY2UsIF57CiAgICAgICAgICAg ICAgICAgZGlzcGF0Y2hfc291cmNlX2NhbmNlbChfdGltZXJfZXZlbnRfc291cmNlKTsKKyAgICAg ICAgICAgICAgICBkaXNwYXRjaF9yZWxlYXNlKF90aW1lcl9ldmVudF9zb3VyY2UpOwogICAgICAg ICAgICAgICAgIF90aW1lcl9ldmVudF9zb3VyY2UgPSAwOwogICAgICAgICAgICAgICAgIG1lbW9y eVByZXNzdXJlSGFuZGxlcigpLmluc3RhbGwoKTsKICAgICAgICAgICAgIH0pOwo=