72399 2011-11-15 11:01:01 -0800 media/track/track-cues-seeking.html is flaky 2011-11-15 11:49:30 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 72215 1 annacc annacc eric.carlson webkit.review.bot oldest_to_newest 503060 0 annacc 2011-11-15 11:01:01 -0800 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-cues-seeking.html 503064 1 115204 annacc 2011-11-15 11:04:39 -0800 Created attachment 115204 make sure both the video and the track are ready to be tested 503074 2 115204 eric.carlson 2011-11-15 11:13:37 -0800 Comment on attachment 115204 make sure both the video and the track are ready to be tested View in context: https://bugs.webkit.org/attachment.cgi?id=115204&action=review > LayoutTests/media/track/track-cues-seeking.html:22 > + function startTest() "startTest" probably isn't the right name for this function because it only starts the test 50% of the time. Maybe "checkState", or "attemptTests", or "requiredEventReceived", or ? 503087 3 annacc 2011-11-15 11:19:29 -0800 (In reply to comment #2) > (From update of attachment 115204 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115204&action=review > > > LayoutTests/media/track/track-cues-seeking.html:22 > > + function startTest() > > "startTest" probably isn't the right name for this function because it only starts the test 50% of the time. Maybe "checkState", or "attemptTests", or "requiredEventReceived", or ? Good call. I like "attemptTests" I'll go with that one. Thanks Eric! 503088 4 115208 annacc 2011-11-15 11:21:58 -0800 Created attachment 115208 Patch for landing 503110 5 115208 webkit.review.bot 2011-11-15 11:49:26 -0800 Comment on attachment 115208 Patch for landing Clearing flags on attachment: 115208 Committed r100303: <http://trac.webkit.org/changeset/100303> 503111 6 webkit.review.bot 2011-11-15 11:49:30 -0800 All reviewed patches have been landed. Closing bug. 115204 2011-11-15 11:04:39 -0800 2011-11-15 11:21:55 -0800 make sure both the video and the track are ready to be tested bug-72399-20111115110438.patch text/plain 2517 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2Y1N2U1NmYyMDI1N2QwNjU1YjQw ZGIzMzA5ZWIxY2QzMzhkOWE2ZS4uMDQzODFkMzhlMDJiYjRkNDZkNGQ3MjE1ZDI2YmFmYmRjMzJh YmIyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTE1ICBBbm5hIENhdmVuZGVyICA8 YW5uYWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1cmUgYm90aCB0aGUgdmlkZW8g YW5kIHRoZSB0cmFjayBhcmUgcmVhZHkgdG8gYmUgdGVzdGVkIGJlZm9yZSB0ZXN0aW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIzOTkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3RyYWNr L3RyYWNrLWN1ZXMtc2Vla2luZy5odG1sOgorCiAyMDExLTExLTE1ICBUb255IENoYW5nICA8dG9u eUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgZW5hYmxlIG5ldyBmbGV4Ym94IHRlc3RzIGV2ZXJ5 d2hlcmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZXMtc2Vl a2luZy5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3Vlcy1zZWVraW5nLmh0 bWwKaW5kZXggMzRlN2M4ODQzMzNhZWRmMjFiZGE2Njg5MWU2ZDVmODcxNzM4NDE5Yi4uZDgxN2Nh ZTU2NWI1MGMyM2FjYzg5MWFmOWViMGQ4ZmI3MWI5NDNhYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvbWVkaWEvdHJhY2svdHJhY2stY3Vlcy1zZWVraW5nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv bWVkaWEvdHJhY2svdHJhY2stY3Vlcy1zZWVraW5nLmh0bWwKQEAgLTksMTIgKzksMjYgQEAKICAg ICA8Ym9keT4KICAgICAgICAgPHA+VGVzdHMgVGV4dFRyYWNrJ3MgYWN0aXZlQ3VlcyBhcmUgaW5k ZXhlZCBhbmQgdXBkYXRlZCBkdXJpbmcgdmlkZW8gcGxheWJhY2suPC9wPgogICAgICAgICA8dmlk ZW8gY29udHJvbHM+Ci0gICAgICAgICAgICA8dHJhY2sgaWQ9InRlc3RUcmFjayIgc3JjPSJjYXB0 aW9ucy13ZWJ2dHQvY3Vlcy1vdmVybGFwcGluZy52dHQiIGtpbmQ9InN1YnRpdGxlcyI+CisgICAg ICAgICAgICA8dHJhY2sgaWQ9InRlc3RUcmFjayIgc3JjPSJjYXB0aW9ucy13ZWJ2dHQvY3Vlcy1v dmVybGFwcGluZy52dHQiIGtpbmQ9InN1YnRpdGxlcyIgb25sb2FkPSJsb2FkZWQoKSI+CiAgICAg ICAgIDwvdmlkZW8+CiAgICAgICAgIDxzY3JpcHQ+ICAgICAgICAgICAgCiAgICAgICAgICAgICAK ICAgICAgICAgdmFyIHNlZWtlZENvdW50ID0gMDsKICAgICAgICAgdmFyIHRlc3RUcmFjazsKKyAg ICAgICAgCisgICAgICAgIHZhciB0cmFja0xvYWRlZCA9IGZhbHNlOworICAgICAgICB2YXIgdmlk ZW9DYW5QbGF5VGhyb3VnaCA9IGZhbHNlOworCisgICAgICAgIGZ1bmN0aW9uIHN0YXJ0VGVzdCgp IAorICAgICAgICB7CisgICAgICAgICAgICBpZiAoIXRyYWNrTG9hZGVkIHx8ICF2aWRlb0NhblBs YXlUaHJvdWdoKQorICAgICAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICAgICAgdGVzdFRy YWNrID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RUcmFjayIpOworICAgICAgICAgICAg dGVzdEV4cGVjdGVkKCJ0ZXN0VHJhY2sudHJhY2suY3Vlcy5sZW5ndGgiLCAzKTsKKyAgICAgICAg ICAgIHJ1bigidmlkZW8uY3VycmVudFRpbWUgPSAwLjUiKTsKKyAgICAgICAgICAgIGNvbnNvbGVX cml0ZSgiIik7CisgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiBzZWVrZWQoKQogICAgICAg ICB7CkBAIC0zOCwxMiArNTIsMTYgQEAKICAgICAgICAgd2FpdEZvckV2ZW50KCdjYW5wbGF5dGhy b3VnaCcsCiAgICAgICAgICAgICBmdW5jdGlvbiAoKSAKICAgICAgICAgICAgIHsKLSAgICAgICAg ICAgICAgICB0ZXN0VHJhY2sgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdFRyYWNrIik7 Ci0gICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ0ZXN0VHJhY2sudHJhY2suY3Vlcy5sZW5n dGgiLCAzKTsKLSAgICAgICAgICAgICAgICBydW4oInZpZGVvLmN1cnJlbnRUaW1lID0gMC41Iik7 Ci0gICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICAgICAgICAgICAgICB2aWRl b0NhblBsYXlUaHJvdWdoID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBzdGFydFRlc3QoKTsKICAg ICAgICAgICAgIH0KICAgICAgICAgKTsKKyAgICAgICAgCisgICAgICAgIGZ1bmN0aW9uIGxvYWRl ZCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHRyYWNrTG9hZGVkID0gdHJ1ZTsKKyAgICAgICAg ICAgIHN0YXJ0VGVzdCgpOworICAgICAgICB9CiAKICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgp OwogICAgICAgICB2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICIuLi9jb250ZW50 L3Rlc3QiKTsK 115208 2011-11-15 11:21:58 -0800 2011-11-15 11:49:26 -0800 Patch for landing bug-72399-20111115112157.patch text/plain 2524 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjkyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2Y1N2U1NmYyMDI1N2QwNjU1YjQw ZGIzMzA5ZWIxY2QzMzhkOWE2ZS4uZDlmY2QzZGY2ZjQxZTE4OTMyMDM3YWQwNDlkOGZiNDNjN2Nm MTE1NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTExLTE1ICBBbm5hIENhdmVuZGVyICA8 YW5uYWNjQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWtlIHN1cmUgYm90aCB0aGUgdmlkZW8g YW5kIHRoZSB0cmFjayBhcmUgcmVhZHkgdG8gYmUgdGVzdGVkIGJlZm9yZSB0ZXN0aW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIzOTkKKworICAg ICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgKiBtZWRpYS90cmFjay90 cmFjay1jdWVzLXNlZWtpbmcuaHRtbDoKKwogMjAxMS0xMS0xNSAgVG9ueSBDaGFuZyAgPHRvbnlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIGVuYWJsZSBuZXcgZmxleGJveCB0ZXN0cyBldmVyeXdo ZXJlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWVzLXNlZWtp bmcuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWN1ZXMtc2Vla2luZy5odG1s CmluZGV4IDM0ZTdjODg0MzMzYWVkZjIxYmRhNjY4OTFlNmQ1Zjg3MTczODQxOWIuLmUyNzhlZmY4 MGYzMDUzYmRlMWRlMTcyNWU1NzhiNzNmMmI4MzUxYTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL3RyYWNrL3RyYWNrLWN1ZXMtc2Vla2luZy5odG1sCisrKyBiL0xheW91dFRlc3RzL21l ZGlhL3RyYWNrL3RyYWNrLWN1ZXMtc2Vla2luZy5odG1sCkBAIC05LDEyICs5LDI2IEBACiAgICAg PGJvZHk+CiAgICAgICAgIDxwPlRlc3RzIFRleHRUcmFjaydzIGFjdGl2ZUN1ZXMgYXJlIGluZGV4 ZWQgYW5kIHVwZGF0ZWQgZHVyaW5nIHZpZGVvIHBsYXliYWNrLjwvcD4KICAgICAgICAgPHZpZGVv IGNvbnRyb2xzPgotICAgICAgICAgICAgPHRyYWNrIGlkPSJ0ZXN0VHJhY2siIHNyYz0iY2FwdGlv bnMtd2VidnR0L2N1ZXMtb3ZlcmxhcHBpbmcudnR0IiBraW5kPSJzdWJ0aXRsZXMiPgorICAgICAg ICAgICAgPHRyYWNrIGlkPSJ0ZXN0VHJhY2siIHNyYz0iY2FwdGlvbnMtd2VidnR0L2N1ZXMtb3Zl cmxhcHBpbmcudnR0IiBraW5kPSJzdWJ0aXRsZXMiIG9ubG9hZD0ibG9hZGVkKCkiPgogICAgICAg ICA8L3ZpZGVvPgogICAgICAgICA8c2NyaXB0PiAgICAgICAgICAgIAogICAgICAgICAgICAgCiAg ICAgICAgIHZhciBzZWVrZWRDb3VudCA9IDA7CiAgICAgICAgIHZhciB0ZXN0VHJhY2s7CisgICAg ICAgIAorICAgICAgICB2YXIgdHJhY2tMb2FkZWQgPSBmYWxzZTsKKyAgICAgICAgdmFyIHZpZGVv Q2FuUGxheVRocm91Z2ggPSBmYWxzZTsKKworICAgICAgICBmdW5jdGlvbiBhdHRlbXB0VGVzdHMo KSAKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKCF0cmFja0xvYWRlZCB8fCAhdmlkZW9DYW5Q bGF5VGhyb3VnaCkKKyAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgIHRlc3RU cmFjayA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0VHJhY2siKTsKKyAgICAgICAgICAg IHRlc3RFeHBlY3RlZCgidGVzdFRyYWNrLnRyYWNrLmN1ZXMubGVuZ3RoIiwgMyk7CisgICAgICAg ICAgICBydW4oInZpZGVvLmN1cnJlbnRUaW1lID0gMC41Iik7CisgICAgICAgICAgICBjb25zb2xl V3JpdGUoIiIpOworICAgICAgICB9CiAKICAgICAgICAgZnVuY3Rpb24gc2Vla2VkKCkKICAgICAg ICAgewpAQCAtMzgsMTIgKzUyLDE2IEBACiAgICAgICAgIHdhaXRGb3JFdmVudCgnY2FucGxheXRo cm91Z2gnLAogICAgICAgICAgICAgZnVuY3Rpb24gKCkgCiAgICAgICAgICAgICB7Ci0gICAgICAg ICAgICAgICAgdGVzdFRyYWNrID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RUcmFjayIp OwotICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidGVzdFRyYWNrLnRyYWNrLmN1ZXMubGVu Z3RoIiwgMyk7Ci0gICAgICAgICAgICAgICAgcnVuKCJ2aWRlby5jdXJyZW50VGltZSA9IDAuNSIp OwotICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisgICAgICAgICAgICAgICAgdmlk ZW9DYW5QbGF5VGhyb3VnaCA9IHRydWU7CisgICAgICAgICAgICAgICAgYXR0ZW1wdFRlc3RzKCk7 CiAgICAgICAgICAgICB9CiAgICAgICAgICk7CisgICAgICAgIAorICAgICAgICBmdW5jdGlvbiBs b2FkZWQoKQorICAgICAgICB7CisgICAgICAgICAgICB0cmFja0xvYWRlZCA9IHRydWU7CisgICAg ICAgICAgICBhdHRlbXB0VGVzdHMoKTsKKyAgICAgICAgfQogCiAgICAgICAgIGZpbmRNZWRpYUVs ZW1lbnQoKTsKICAgICAgICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiLi4v Y29udGVudC90ZXN0Iik7Cg==