72394 2011-11-15 10:04:15 -0800 [GTK] Use GQuark's in the ATK wrapper to get and set arbitrary data 2011-11-16 00:16:56 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned mrobinson oldest_to_newest 503001 0 mario 2011-11-15 10:04:15 -0800 As we will probably need to use this in the near future for WK2, it will be nice to polish current code to use GQuarks and not to replicate literal strings everywhere, when setting and getting arbitrary data. 503006 1 115189 mario 2011-11-15 10:08:09 -0800 Created attachment 115189 Patch proposal 503668 2 mario 2011-11-16 00:16:56 -0800 Committed r100419: <http://trac.webkit.org/changeset/100419> 115189 2011-11-15 10:08:09 -0800 2011-11-15 11:43:35 -0800 Patch proposal 0001-2011-11-15-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 5049 mario RnJvbSAzZmQxNTg0NDI0ZTQ5Nzk0ZGU1MzZhYWNmOGUyNGU3ZTU5ODZiMTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUdWUsIDE1IE5vdiAyMDExIDE5OjA3OjA2ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMS0xMS0xNSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIFVzZSBHUXVhcmsncyBpbiB0aGUgQVRLIHdyYXBwZXIgdG8gZ2V0IGFu ZCBzZXQgYXJiaXRyYXJ5IGRhdGEKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzIzOTQKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgog ICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5LCBubyBuZXcgdGVzdHMgbmVlZGVkLgoKICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoK ICAgICAgICAod2Via2l0X2FjY2Vzc2libGVfY2xhc3NfaW5pdCk6IEluaXRpYWxpemUgR1F1YXJr cy4KICAgICAgICAoZ2V0R2FpbFRleHRVdGlsRm9yQXRrKTogVXNlIGdhaWxUZXh0VXRpbFF1YXJr LgogICAgICAgIChnZXRQYW5nb0xheW91dEZvckF0ayk6IFJlbW92ZSB1bnVzZWQgY2FsbCB0bwog ICAgICAgIGdfb2JqZWN0X3NldF9kYXRhX2Z1bGwsIHNpbmNlIHRoYXQgZGF0YSBpcyBubyB1c2Vk IGFueXdoZXJlLgogICAgICAgICh3ZWJraXRBY2Nlc3NpYmxlSHlwZXJsaW5rSW1wbEdldEh5cGVy bGluayk6IFVzZSBoeXBlcmxpbmtPYmplY3RRdWFyay4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwog Li4uL2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAgICAgICAgICAgfCAgIDE1 ICsrKysrKysrKystLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCA1IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1OGMzZTJjLi45NWY2MDJjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMTEtMTUgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hl ekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFVzZSBHUXVhcmsncyBpbiB0aGUgQVRLIHdy YXBwZXIgdG8gZ2V0IGFuZCBzZXQgYXJiaXRyYXJ5IGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcyMzk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IGZ1bmN0aW9uYWxpdHksIG5vIG5ldyB0 ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5 T2JqZWN0V3JhcHBlckF0ay5jcHA6CisgICAgICAgICh3ZWJraXRfYWNjZXNzaWJsZV9jbGFzc19p bml0KTogSW5pdGlhbGl6ZSBHUXVhcmtzLgorICAgICAgICAoZ2V0R2FpbFRleHRVdGlsRm9yQXRr KTogVXNlIGdhaWxUZXh0VXRpbFF1YXJrLgorICAgICAgICAoZ2V0UGFuZ29MYXlvdXRGb3JBdGsp OiBSZW1vdmUgdW51c2VkIGNhbGwgdG8KKyAgICAgICAgZ19vYmplY3Rfc2V0X2RhdGFfZnVsbCwg c2luY2UgdGhhdCBkYXRhIGlzIG5vIHVzZWQgYW55d2hlcmUuCisgICAgICAgICh3ZWJraXRBY2Nl c3NpYmxlSHlwZXJsaW5rSW1wbEdldEh5cGVybGluayk6IFVzZSBoeXBlcmxpbmtPYmplY3RRdWFy ay4KKwogMjAxMS0xMS0xNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW1Y4XSBGaXggaW5jb3JyZWN0IGhhbmRsaW5nIG9mIEphdmFTY3JpcHQgcHJvcGVydGll cyBpbiBET01TdHJpbmdNYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcAppbmRl eCA0ZmJjOWU5Li5mZjQwZGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3Bw CkBAIC03Niw2ICs3Niw5IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCitzdGF0aWMg R1F1YXJrIGdhaWxUZXh0VXRpbFF1YXJrID0gMDsKK3N0YXRpYyBHUXVhcmsgaHlwZXJsaW5rT2Jq ZWN0UXVhcmsgPSAwOworCiBzdGF0aWMgQWNjZXNzaWJpbGl0eU9iamVjdCogZmFsbGJhY2tPYmpl Y3QoKQogewogICAgIC8vIEZJWE1FOiBBbiBBWE9iamVjdENhY2hlIHdpdGggYSBEb2N1bWVudCBp cyBtZWFuaW5nbGVzcy4KQEAgLTgzMCw2ICs4MzMsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfYWNj ZXNzaWJsZV9jbGFzc19pbml0KEF0a09iamVjdENsYXNzKiBrbGFzcykKICAgICBrbGFzcy0+Z2V0 X2luZGV4X2luX3BhcmVudCA9IHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9pbmRleF9pbl9wYXJlbnQ7 CiAgICAga2xhc3MtPmdldF9hdHRyaWJ1dGVzID0gd2Via2l0X2FjY2Vzc2libGVfZ2V0X2F0dHJp YnV0ZXM7CiAgICAga2xhc3MtPnJlZl9yZWxhdGlvbl9zZXQgPSB3ZWJraXRfYWNjZXNzaWJsZV9y ZWZfcmVsYXRpb25fc2V0OworCisgICAgZ2FpbFRleHRVdGlsUXVhcmsgPSBnX3F1YXJrX2Zyb21f c3RhdGljX3N0cmluZygid2Via2l0LWFjY2Vzc2libGUtZ2FpbC10ZXh0LXV0aWwiKTsKKyAgICBo eXBlcmxpbmtPYmplY3RRdWFyayA9IGdfcXVhcmtfZnJvbV9zdGF0aWNfc3RyaW5nKCJ3ZWJraXQt YWNjZXNzaWJsZS1oeXBlcmxpbmstb2JqZWN0Iik7CiB9CiAKIEdUeXBlCkBAIC0xMjc1LDEzICsx MjgxLDEzIEBAIHN0YXRpYyBnY2hhciogd2Via2l0X2FjY2Vzc2libGVfdGV4dF9nZXRfdGV4dChB dGtUZXh0KiB0ZXh0LCBnaW50IHN0YXJ0T2Zmc2V0LCBnCiAKIHN0YXRpYyBHYWlsVGV4dFV0aWwq IGdldEdhaWxUZXh0VXRpbEZvckF0ayhBdGtUZXh0KiB0ZXh0T2JqZWN0KQogewotICAgIGdwb2lu dGVyIGRhdGEgPSBnX29iamVjdF9nZXRfZGF0YShHX09CSkVDVCh0ZXh0T2JqZWN0KSwgIndlYmtp dC1hY2Nlc3NpYmxlLWdhaWwtdGV4dC11dGlsIik7CisgICAgZ3BvaW50ZXIgZGF0YSA9IGdfb2Jq ZWN0X2dldF9xZGF0YShHX09CSkVDVCh0ZXh0T2JqZWN0KSwgZ2FpbFRleHRVdGlsUXVhcmspOwog ICAgIGlmIChkYXRhKQogICAgICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8R2FpbFRleHRVdGlsKj4o ZGF0YSk7CiAKICAgICBHYWlsVGV4dFV0aWwqIGdhaWxUZXh0VXRpbCA9IGdhaWxfdGV4dF91dGls X25ldygpOwogICAgIGdhaWxfdGV4dF91dGlsX3RleHRfc2V0dXAoZ2FpbFRleHRVdGlsLCB3ZWJr aXRfYWNjZXNzaWJsZV90ZXh0X2dldF90ZXh0KHRleHRPYmplY3QsIDAsIC0xKSk7Ci0gICAgZ19v YmplY3Rfc2V0X2RhdGFfZnVsbChHX09CSkVDVCh0ZXh0T2JqZWN0KSwgIndlYmtpdC1hY2Nlc3Np YmxlLWdhaWwtdGV4dC11dGlsIiwgZ2FpbFRleHRVdGlsLCBnX29iamVjdF91bnJlZik7CisgICAg Z19vYmplY3Rfc2V0X3FkYXRhX2Z1bGwoR19PQkpFQ1QodGV4dE9iamVjdCksIGdhaWxUZXh0VXRp bFF1YXJrLCBnYWlsVGV4dFV0aWwsIGdfb2JqZWN0X3VucmVmKTsKICAgICByZXR1cm4gZ2FpbFRl eHRVdGlsOwogfQogCkBAIC0xMzAyLDcgKzEzMDgsNiBAQCBzdGF0aWMgUGFuZ29MYXlvdXQqIGdl dFBhbmdvTGF5b3V0Rm9yQXRrKEF0a1RleHQqIHRleHRPYmplY3QpCiAKICAgICAvLyBDcmVhdGUg YSBzdHJpbmcgd2l0aCB0aGUgbGF5b3V0IGFzIGl0IGFwcGVhcnMgb24gdGhlIHNjcmVlbgogICAg IFBhbmdvTGF5b3V0KiBsYXlvdXQgPSBndGtfd2lkZ2V0X2NyZWF0ZV9wYW5nb19sYXlvdXQoc3Rh dGljX2Nhc3Q8R3RrV2lkZ2V0Kj4od2ViVmlldyksIHRleHRGb3JPYmplY3QoY29yZU9iamVjdCkp OwotICAgIGdfb2JqZWN0X3NldF9kYXRhX2Z1bGwoR19PQkpFQ1QodGV4dE9iamVjdCksICJ3ZWJr aXQtYWNjZXNzaWJsZS1wYW5nby1sYXlvdXQiLCBsYXlvdXQsIGdfb2JqZWN0X3VucmVmKTsKICAg ICByZXR1cm4gbGF5b3V0OwogfQogCkBAIC0yMzYwLDEwICsyMzY1LDEwIEBAIHN0YXRpYyB2b2lk IGF0a0h5cGVydGV4dEludGVyZmFjZUluaXQoQXRrSHlwZXJ0ZXh0SWZhY2UqIGlmYWNlKQogCiBz dGF0aWMgQXRrSHlwZXJsaW5rKiB3ZWJraXRBY2Nlc3NpYmxlSHlwZXJsaW5rSW1wbEdldEh5cGVy bGluayhBdGtIeXBlcmxpbmtJbXBsKiBoeXBlcmxpbmspCiB7Ci0gICAgQXRrSHlwZXJsaW5rKiBo eXBlcmxpbmtPYmplY3QgPSBBVEtfSFlQRVJMSU5LKGdfb2JqZWN0X2dldF9kYXRhKEdfT0JKRUNU KGh5cGVybGluayksICJoeXBlcmxpbmstb2JqZWN0IikpOworICAgIEF0a0h5cGVybGluayogaHlw ZXJsaW5rT2JqZWN0ID0gQVRLX0hZUEVSTElOSyhnX29iamVjdF9nZXRfcWRhdGEoR19PQkpFQ1Qo aHlwZXJsaW5rKSwgaHlwZXJsaW5rT2JqZWN0UXVhcmspKTsKICAgICBpZiAoIWh5cGVybGlua09i amVjdCkgewogICAgICAgICBoeXBlcmxpbmtPYmplY3QgPSBBVEtfSFlQRVJMSU5LKHdlYmtpdEFj Y2Vzc2libGVIeXBlcmxpbmtOZXcoaHlwZXJsaW5rKSk7Ci0gICAgICAgIGdfb2JqZWN0X3NldF9k YXRhKEdfT0JKRUNUKGh5cGVybGluayksICJoeXBlcmxpbmstb2JqZWN0IiwgaHlwZXJsaW5rT2Jq ZWN0KTsKKyAgICAgICAgZ19vYmplY3Rfc2V0X3FkYXRhKEdfT0JKRUNUKGh5cGVybGluayksIGh5 cGVybGlua09iamVjdFF1YXJrLCBoeXBlcmxpbmtPYmplY3QpOwogICAgIH0KICAgICByZXR1cm4g aHlwZXJsaW5rT2JqZWN0OwogfQotLSAKMS43LjcuMQoK