<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>72389</bug_id>
          
          <creation_ts>2011-11-15 08:33:51 -0800</creation_ts>
          <short_desc>[Qt][WK2][Mac] MiniBrowser cannot create socketpair.</short_desc>
          <delta_ts>2011-11-16 06:56:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zeno Albisser">zeno</reporter>
          <assigned_to name="Zeno Albisser">zeno</assigned_to>
          <cc>webkit.review.bot</cc>
    
    <cc>zoltan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>502929</commentid>
    <comment_count>0</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-11-15 08:33:51 -0800</bug_when>
    <thetext>Creation of socket failed with errno: 43

This is due to using AF_UNIX and SOCK_SEQPACKET in socketpair.
This is fine for Linux, but seems not to be implemented on mac.
We should simply go back to using SOCK_DGRAM for mac.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>502962</commentid>
    <comment_count>1</comment_count>
      <attachid>115178</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-11-15 09:24:25 -0800</bug_when>
    <thetext>Created attachment 115178
patch for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503735</commentid>
    <comment_count>2</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-11-16 02:40:05 -0800</bug_when>
    <thetext>we should consider replacing our IPC mechanisms with the webkit2 ones from the mac port.
i will see if this is doable, and come up with a patch for that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503787</commentid>
    <comment_count>3</comment_count>
      <attachid>115178</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-11-16 05:48:12 -0800</bug_when>
    <thetext>Comment on attachment 115178
patch for review.

lets have this as an intermediate fix for the mac platform.
Nevertheless I will be glad to look into a longterm solution of course. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503835</commentid>
    <comment_count>4</comment_count>
      <attachid>115178</attachid>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-11-16 06:56:22 -0800</bug_when>
    <thetext>Comment on attachment 115178
patch for review.

Clearing flags on attachment: 115178

Committed r100445: &lt;http://trac.webkit.org/changeset/100445&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>503837</commentid>
    <comment_count>5</comment_count>
    <who name="Zeno Albisser">zeno</who>
    <bug_when>2011-11-16 06:56:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>115178</attachid>
            <date>2011-11-15 09:24:25 -0800</date>
            <delta_ts>2011-11-16 06:56:22 -0800</delta_ts>
            <desc>patch for review.</desc>
            <filename>72389_20111115-182156.patch</filename>
            <type>text/plain</type>
            <size>1126</size>
            <attacher name="Zeno Albisser">zeno</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCA0NTFjNmZiLi4wNjM0NWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg
QEAKKzIwMTEtMTEtMTUgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg
ICAgW1F0XVtXSzJdW01hY10gTWluaUJyb3dzZXIgY2Fubm90IGNyZWF0ZSBzb2NrZXRwYWlyLgor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzIzODkKKwor
ICAgICAgICBVc2UgU09DS19ER1JBTSBvbiBtYWMgaW5zdGVhZCBvZiBTT0NLX1NFUVBBQ0tFVC4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv
Y2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNzTGF1bmNoZXJRdC5jcHA6CisKIDIwMTEtMTEtMTQgIENh
aW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJvc3NhLm9y
Zz4KIAogICAgICAgICBbUXRdIFJlbW92ZSByZWZlcmVuY2UgdG8gUVdlYk5hdmlnYXRpb25Db250
cm9sbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQv
UHJvY2Vzc0xhdW5jaGVyUXQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVy
L3F0L1Byb2Nlc3NMYXVuY2hlclF0LmNwcAppbmRleCA5ZmMxYWYxLi5iYTNiMzY1IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvcXQvUHJvY2Vzc0xhdW5jaGVy
UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9xdC9Qcm9jZXNz
TGF1bmNoZXJRdC5jcHAKQEAgLTU1LDcgKzU1LDcgQEAKICNpbmNsdWRlIDxzaWduYWwuaD4KICNl
bmRpZgogCi0jaWZkZWYgU09DS19TRVFQQUNLRVQKKyNpZiBkZWZpbmVkKFNPQ0tfU0VRUEFDS0VU
KSAmJiAhZGVmaW5lZChRX09TX01BQ1gpCiAjZGVmaW5lIFNPQ0tFVF9UWVBFIFNPQ0tfU0VRUEFD
S0VUCiAjZWxzZQogI2RlZmluZSBTT0NLRVRfVFlQRSBTT0NLX0RHUkFNCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>