72387 2011-11-15 07:55:43 -0800 Remove useless const modifier from KURL::init 2011-11-15 11:17:01 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71921 1 ddkilzer ddkilzer darin koivisto webkit.review.bot oldest_to_newest 502903 0 ddkilzer 2011-11-15 07:55:43 -0800 Follow-up to Bug 71921 Comment #17. 502911 1 115168 ddkilzer 2011-11-15 08:06:36 -0800 Created attachment 115168 Patch v1 502935 2 115168 kling 2011-11-15 08:45:02 -0800 Comment on attachment 115168 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=115168&action=review > Source/WebCore/platform/KURL.cpp:489 > - const char* bufferStart = bufferPos; > + char* bufferStart = bufferPos; Why is this const useless but the ones further down (baseString, baseStringStart, pathStart, baseStringEnd, relStringStart, relStringPos) aren't? 502938 3 ddkilzer 2011-11-15 08:52:40 -0800 (In reply to comment #2) > (From update of attachment 115168 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=115168&action=review > > > Source/WebCore/platform/KURL.cpp:489 > > - const char* bufferStart = bufferPos; > > + char* bufferStart = bufferPos; > > Why is this const useless but the ones further down (baseString, baseStringStart, pathStart, baseStringEnd, relStringStart, relStringPos) aren't? Per Darin's statement in Bug 71921 Comment #17, they would be useless as well. This patch was only to remove the useless 'const' modifier I added for Bug 71921, but I can remove the rest if that's what the consensus is. 503009 4 darin 2011-11-15 10:14:32 -0800 We use const char* all the time, and I did not mean to imply that was useless. I am not saying that the const keyword is useless, just that making actual local variables const is not something we do in most WebKit code. Not the characters that a local variable points to, the local variable itself. 503010 5 115168 darin 2011-11-15 10:15:49 -0800 Comment on attachment 115168 Patch v1 Given that this is a pointer into a buffer of non-const characters, I think it's fine for it to be char*, even though I did not mean to claim this was useless at all! 503083 6 115168 webkit.review.bot 2011-11-15 11:16:57 -0800 Comment on attachment 115168 Patch v1 Clearing flags on attachment: 115168 Committed r100298: <http://trac.webkit.org/changeset/100298> 503084 7 webkit.review.bot 2011-11-15 11:17:01 -0800 All reviewed patches have been landed. Closing bug. 115168 2011-11-15 08:06:36 -0800 2011-11-15 11:16:57 -0800 Patch v1 bug-72387-20111115080635.patch text/plain 1332 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdhZjZiZmUwNjFmYjQ1 N2Q5NTcwZGM3ODgyNmNlMzUxNDY0YTUxNC4uMTM3MmU5MmI1N2JlMDBhNGQxOWExZDc2MmIxYmEx MjM4ZDlmMTIwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTE1ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVzZWxlc3Mg Y29uc3QgbW9kaWZpZXIgZnJvbSBLVVJMOjppbml0CisgICAgICAgIDxodHRwOi8vd2Via2l0Lm9y Zy9iLzcyMzg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLVVJMOjppbml0KTog UmVtb3ZlIHVzZWxlc3MgY29uc3QuCisKIDIwMTEtMTEtMTQgIFRvbnkgQ2hhbmcgIDx0b255QGNo cm9taXVtLm9yZz4KIAogICAgICAgICByZW1vdmUgLXdhcC1tYXJxdWVlIGNzcyBwcm9wZXJ5IHZh bHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCmluZGV4IGFkOGY4ZDhlNmJmNjRkZTVlMGY5YWVl MDJjZGI1MDBhYzg1YzYwMzQuLmU3NTJiYjhhNDZiNTBhYWU0YjhjYTg1MDZmZjc0ODA5MmE2N2Q3 ZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tVUkwuY3BwCkBAIC00ODYsNyArNDg2LDcgQEAgdm9pZCBL VVJMOjppbml0KGNvbnN0IEtVUkwmIGJhc2UsIGNvbnN0IFN0cmluZyYgcmVsYXRpdmUsIGNvbnN0 IFRleHRFbmNvZGluZyYgZW4KICAgICAgICAgICAgICAgICBwYXJzZUJ1ZmZlci5yZXNpemUoYnVm ZmVyU2l6ZSk7CiAKICAgICAgICAgICAgICAgICBjaGFyKiBidWZmZXJQb3MgPSBwYXJzZUJ1ZmZl ci5kYXRhKCk7Ci0gICAgICAgICAgICAgICAgY29uc3QgY2hhciogYnVmZmVyU3RhcnQgPSBidWZm ZXJQb3M7CisgICAgICAgICAgICAgICAgY2hhciogYnVmZmVyU3RhcnQgPSBidWZmZXJQb3M7CiAK ICAgICAgICAgICAgICAgICAvLyBmaXJzdCBjb3B5IGV2ZXJ5dGhpbmcgYmVmb3JlIHRoZSBwYXRo IGZyb20gdGhlIGJhc2UKICAgICAgICAgICAgICAgICB1bnNpZ25lZCBiYXNlTGVuZ3RoID0gYmFz ZS5tX3N0cmluZy5sZW5ndGgoKTsK