72381 2011-11-15 05:56:56 -0800 media-blocked-by-willsendrequest.html is flaky 2011-11-15 08:15:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonyg eric.carlson darin oldest_to_newest 502847 0 tonyg 2011-11-15 05:56:56 -0800 The media/media-blocked-by-willsendrequest.html test has been flaky across all chromium platforms for as far back as we have history. My guess is that the flakiness isn't limited to chromium, though. When the test fails, we are missing the following two lines of output: EVENT(loadstart) EVENT(error) From the symptoms, my best guess is that the test is trying to run before the video's loadstart. Eric, assigning to you just because you are the test author and I don't want to leave this ownerless. Please feel free re-title if this is chromium specific and/or bounce back to me for any reason. Chromium flakiness dashboard results: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=media%2Fmedia-blocked-by-willsendrequest.html 502868 1 115154 tonyg 2011-11-15 06:43:15 -0800 Created attachment 115154 Patch 502870 2 tonyg 2011-11-15 06:43:53 -0800 Committed r100275: <http://trac.webkit.org/changeset/100275> 502894 3 eric.carlson 2011-11-15 07:20:12 -0800 (In reply to comment #0) > The media/media-blocked-by-willsendrequest.html test has been flaky across all chromium platforms for as far back as we have history. My guess is that the flakiness isn't limited to chromium, though. When the test fails, we are missing the following two lines of output: > EVENT(loadstart) > EVENT(error) > > From the symptoms, my best guess is that the test is trying to run before the video's loadstart. > I think your guess is correct. I believe that the test passes on other platforms but fails on chromium because the chromium media engine takes longer to start up so the widow's 'load' event is fired while the media events are in the queue waiting to be dispatched. > Eric, assigning to you just because you are the test author and I don't want to leave this ownerless. > I will change the test to not finish until all required events have been handled. 502901 4 115165 eric.carlson 2011-11-15 07:45:48 -0800 Created attachment 115165 Proposed patch 502904 5 115165 tonyg 2011-11-15 07:56:52 -0800 Comment on attachment 115165 Proposed patch Thanks! Any chance I could talk you into reverting r100275 along with this patch? 502914 6 eric.carlson 2011-11-15 08:15:25 -0800 (In reply to comment #5) > (From update of attachment 115165 [details]) > Thanks! Any chance I could talk you into reverting r100275 along with this patch? Good point, will do. 502915 7 eric.carlson 2011-11-15 08:15:34 -0800 http://trac.webkit.org/changeset/100282 115154 2011-11-15 06:43:15 -0800 2011-11-15 06:43:15 -0800 Patch bug-72381-20111115144313.patch text/plain 1282 tonyg U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwMjc0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjNlNDUwNWI2Yjk3MzdhOTMxMzAy ZWEzMDI5MGZmODllNzRjNTc1Ni4uYjJkZDFkZDQ3Yzg2ZmJjYmE1Njk0NGJmZDgyNzk1ZThhMmQ4 MjI4NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDExLTExLTE1ICBUb255IEdlbnRpbGNvcmUg IDx0b255Z0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgbWVkaWEtYmxvY2tlZC1ieS13aWxsc2Vu ZHJlcXVlc3QuaHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzIzODEKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dDogTWFyayB0ZXN0IGFzIGZsYWt5LgorCiAyMDExLTExLTE1ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgZm9udCBwcm9w ZXJ0eSBkb2VzIG5vdCBzaG93IHVwIGFzICJzaG9ydGhhbmQiIGluIGluc3BlY3RvcgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0Cmlu ZGV4IDE2NzUyZjBkZDhjYjVmM2VkNGI0YzU2YzdkMTk0NTU2YTc2NmI3MWQuLmY3ZWRhZTVhMDRi MTIyMjA4Njg1NjJlNGQ4MzQ2MGFiNzQ0YTMwMTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKQEAgLTM4NzUsMyArMzg3NSw1 IEBAIEJVR1dLNzIzNjkgOiBtZWRpYS90cmFjay90cmFjay13ZWJ2dHQtdGMwMDMtbmV3bGluZXMu aHRtbCA9IFRFWFQgUEFTUwogQlVHV0s1OTc3MSBXSU4gOiBodHRwL3Rlc3RzL2luc3BlY3Rvci9y ZXNvdXJjZS10cmVlL3Jlc291cmNlLXRyZWUtZnJhbWUtYWRkLmh0bWwgPSBUSU1FT1VUIFBBU1MK IAogQlVHV0s3MjM3NiBXSU4gOiBmYXN0L2Zvcm1zL2ZpbGUvaW5wdXQtZmlsZS1sYWJlbC5odG1s ID0gVEVYVCBQQVNTCisKK0JVR1dLNzIzODEgOiBtZWRpYS9tZWRpYS1ibG9ja2VkLWJ5LXdpbGxz ZW5kcmVxdWVzdC5odG1sID0gVEVYVCBQQVNTCg== 115165 2011-11-15 07:45:48 -0800 2011-11-15 07:56:52 -0800 Proposed patch patch_1.txt text/plain 2711 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwMDI3OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDExLTExLTE1ICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIG1lZGlhLWJsb2NrZWQtYnktd2lsbHNl bmRyZXF1ZXN0Lmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTcyMzgxCisKKyAgICAgICAgRG9uJ3QgYXNzdW1lIHRoZSBtZWRpYSBl dmVudHMgd2lsbCBiZSBkaXNwYXRjaGVkIGJlZm9yZSB0aGUgd2luZG93ICdsb2FkJyBldmVudC4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlh L21lZGlhLWJsb2NrZWQtYnktd2lsbHNlbmRyZXF1ZXN0Lmh0bWw6CisKIDIwMTEtMTEtMTUgIFBo aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIG1hcmtlZApJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtYmxvY2tlZC1ieS13aWxs c2VuZHJlcXVlc3QuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1i bG9ja2VkLWJ5LXdpbGxzZW5kcmVxdWVzdC5odG1sCShyZXZpc2lvbiAxMDAyNzcpCisrKyBMYXlv dXRUZXN0cy9tZWRpYS9tZWRpYS1ibG9ja2VkLWJ5LXdpbGxzZW5kcmVxdWVzdC5odG1sCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMCwyNiArMTAsNDEgQEAKICAgICBhbmQgZG9lcyBub3QgYmxvY2sgdGhl IGRvY3VtZW50J3MgJ2xvYWQnIGV2ZW50LjwvcD4KIAogICAgIDxzY3JpcHQ+CisgICAgICAgIHZh ciBldmVudHMgPSBbXTsKKwogICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KSB7CiAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAgICAg ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRXaWxsU2VuZFJlcXVlc3RSZXR1cm5zTnVs bCh0cnVlKTsKICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICBjb25zb2xlV3JpdGUoIlRoaXMg dGVzdCBjYW4gb25seSBiZSBydW4gaW4gRHVtcFJlbmRlclRyZWUhPGJyPjxicj4iKTsKKyAgICAg ICAgICAgIGNvbnNvbGVXcml0ZSgiPGI+PGVtPlRoaXMgdGVzdCBjYW4gb25seSBiZSBydW4gaW4g RHVtcFJlbmRlclRyZWUhPC9lbT48L2I+PGJyPjxicj4iKTsKIAotICAgICAgICBmdW5jdGlvbiBs b2FkZWQoKSAKKyAgICAgICAgZnVuY3Rpb24gZmluaXNoKCkgCiAgICAgICAgIHsKKyAgICAgICAg ICAgIGNvbnNvbGVXcml0ZSgiRVZFTlQobG9hZHN0YXJ0KSIpOworICAgICAgICAgICAgY29uc29s ZVdyaXRlKCJFVkVOVChlcnJvcikiKTsKICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8u ZXJyb3IiLCBudWxsLCAiIT0iKTsKICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uZXJy b3IuY29kZSIsIE1lZGlhRXJyb3IuTUVESUFfRVJSX1NSQ19OT1RfU1VQUE9SVEVEKTsKICAgICAg ICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8ubmV0d29ya1N0YXRlIiwgSFRNTE1lZGlhRWxlbWVu dC5ORVRXT1JLX05PX1NPVVJDRSk7CiAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOwogICAg ICAgICAgICAgZW5kVGVzdCgpOwogICAgICAgICB9OwotICAgICAgICAKLSAgICAgICAgd2luZG93 Lm9ubG9hZCA9IGxvYWRlZDsKKworICAgICAgICBmdW5jdGlvbiBoYW5kbGVFdmVudChldnQpCisg ICAgICAgIHsKKyAgICAgICAgICAgIC8vIFdhaXQgdW50aWwgYWxsIHRocmVlIGV2ZW50cyB3ZSBs aXN0ZW4gZm9yIGhhdmUgYmVlbiByZWNlaXZlZCBiZWZvcmUgdGVzdGluZy4KKyAgICAgICAgICAg IC8vIE1lZGlhIGV2ZW50cyBhcmUgZGlzcGF0Y2hlZCBhc3luY2hyb25vdXNseSBzbyB3ZSBjYW4n dCBhc3N1bWUgdGhleSB3aWxsIGZpcmUKKyAgICAgICAgICAgIC8vIGJlZm9yZSB3aW5kb3cub25s b2FkLgorICAgICAgICAgICAgaWYgKGV2ZW50cy5pbmRleE9mKGV2dC50eXBlKSA9PSAtMSkKKyAg ICAgICAgICAgICAgICBldmVudHMucHVzaChldnQudHlwZSk7CisgICAgICAgICAgICBpZiAoZXZl bnRzLmxlbmd0aCA9PSAzKQorICAgICAgICAgICAgICAgIGZpbmlzaCgpOworICAgICAgICB9CiAK ICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOwotICAgICAgICB3YWl0Rm9yRXZlbnQoImxvYWRz dGFydCIpOwotICAgICAgICB3YWl0Rm9yRXZlbnQoImVycm9yIik7CisKKyAgICAgICAgd2luZG93 LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBoYW5kbGVFdmVudCk7CisgICAgICAgIHZpZGVvLmFk ZEV2ZW50TGlzdGVuZXIoJ2xvYWRzdGFydCcsIGhhbmRsZUV2ZW50KTsKKyAgICAgICAgdmlkZW8u YWRkRXZlbnRMaXN0ZW5lcignZXJyb3InLCBoYW5kbGVFdmVudCk7CiAKICAgICAgICAgdGVzdEV4 cGVjdGVkKCJ2aWRlby5uZXR3b3JrU3RhdGUiLCBIVE1MTWVkaWFFbGVtZW50Lk5FVFdPUktfRU1Q VFkpOwogICAgICAgICBjb25zb2xlV3JpdGUoIiIpOwo=