7235 2006-02-13 11:30:48 -0800 Pure CSS Tooltips method renders wrong and creates artifacts 2006-12-16 12:21:26 -0800 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED http://www.cybersaps.org/2004/01/Pure-css-tooltips.html HasReduction P2 Normal --- 1 jerome webkit-unassigned michaelm mitz oldest_to_newest 32318 0 jerome 2006-02-13 11:30:48 -0800 Using the 'Pure CSS Tooltips' method described in the url given in report (http://www.cybersaps.org/2004/01/Pure-css-tooltips.html) ends up with funky draw problems in Safari (and WebKit nightly.) This will render fine in Firefox. Hope to see this fixed, being an excellent no-javascript-fancy-tooltip method. I pulled a more noticeable example from an app at my work that renders really bad: http://www.macsaresexy.com/files/pure_css_tooltips.html 32319 1 6461 jerome 2006-02-13 11:32:15 -0800 Created attachment 6461 uploaded version of css render bug example wanted to upload a version of the linked file so don't have to rely on my link 32322 2 ap 2006-02-13 11:54:02 -0800 This looks quite similar to bug 7204. 32325 3 jerome 2006-02-13 12:05:05 -0800 (In reply to comment #2) > This looks quite similar to bug 7204. > sounds like it could be, 7204 references javascript and DOM usage of producing content where this one is pure CSS, html is already there but the use of CSS in doing some tricks like :hover, display: none etc. with elements inside an <a> tag seem to get rendered funny. but could be similar in how it's rendered/handled internally. just wanted to clarify that this one isn't javascript & DOM related I don't think. 32353 4 6469 mitz 2006-02-13 15:08:03 -0800 Created attachment 6469 Reduced testcase 32354 5 mitz 2006-02-13 15:10:04 -0800 This is a repaint issue 32483 6 mitz 2006-02-14 11:09:01 -0800 This is the case of a positioned layer that has an enclosing relpositioned inline which is handled in updateLayerPosition, but not in getAbsoluteRepaintRect* and absolutePosition, hence the incorrect repaint. 32517 7 6491 mitz 2006-02-14 14:00:21 -0800 Created attachment 6491 First cut at a fix This fixes the bug by implementing the logic from RenderLayer::updateLayerPosition in RenderBox::absolutePosition and RenderBox::computeAbsoluteRepaintRect. It's probably a bad idea to repeat that code twice, so I'll welcome suggestions on that (including naming). 32530 8 6491 hyatt 2006-02-14 14:37:51 -0800 Comment on attachment 6491 First cut at a fix Unfortunate code duplication, but eventually I wanted to rework absolutePosition to use layers anyway. 32721 9 6506 mitz 2006-02-15 09:40:15 -0800 Created attachment 6506 Patch including manual test and changelog entry Left in the duplicate code for now. 33144 10 6506 hyatt 2006-02-17 12:59:17 -0800 Comment on attachment 6506 Patch including manual test and changelog entry r=me 41722 11 mitz 2006-12-16 12:21:26 -0800 *** Bug 3875 has been marked as a duplicate of this bug. *** 6461 2006-02-13 11:32:15 -0800 2006-02-13 11:32:15 -0800 uploaded version of css render bug example pure_css_tooltips.html text/html 3178 jerome PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIK CSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4KCjxo dG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iIGxh bmc9ImVuIj4KPGhlYWQ+Cgk8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9 InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCIvPgoKCTx0aXRsZT51bnRpdGxlZDwvdGl0bGU+Cgk8 c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoJI2luZm8gewoJCWhlaWdodDogOGVtOwoJCWRpc3BsYXk6 IGlubGluZTsKCQlmb250LWZhbWlseTogc2VyaWY7Cgl9CgkjaW5mbzpob3ZlciB7CgkJYmFja2dy b3VuZC1jb2xvcjogI2ZmZjsKCX0KCglhI3BvcHVwOnZpc2l0ZWQgewoJCWNvbG9yOiAjMDAwOwoJ CXRleHQtZGVjb3JhdGlvbjogbm9uZTsKCX0KCWEjcG9wdXAgewoJCWNvbG9yOiAjMDAwOwoJCXRl eHQtZGVjb3JhdGlvbjogbm9uZTsKCQlwb3NpdGlvbjogcmVsYXRpdmU7CgkJZm9udC13ZWlnaHQ6 IGJvbGQ7Cgl9CglhI3BvcHVwIHNwYW4gewoJCWRpc3BsYXk6IG5vbmU7Cgl9CglhI3BvcHVwOmhv dmVyIHsKCQljb2xvcjogIzAwMDsKCQljdXJzb3I6IGRlZmF1bHQ7Cgl9CglhI3BvcHVwOmhvdmVy ICNwb3Bib3ggewoJCWRpc3BsYXk6IGJsb2NrOwoJCXBvc2l0aW9uOiBhYnNvbHV0ZTsKCQl0b3A6 IC0uMWVtOwoJCWxlZnQ6IC4xNWVtOwoJCXdpZHRoOiAxNWVtOwoJCWJhY2tncm91bmQtY29sb3I6 ICNmZmY7CgkJY29sb3I6ICMwMDA7CgkJYm9yZGVyOiAycHggc29saWQgIzAwMDA2NjsgCgkJdGV4 dC1hbGlnbjogbGVmdDsKCQlmb250LXNpemU6IC44ZW07CgkJcGFkZGluZzogMS42ZW0gLjNlbSAu M2VtIC4zZW07CgkJYm9yZGVyOiAycHggb3V0c2V0IGJsYWNrOyAKCX0KCWEjcG9wdXA6aG92ZXIg I3BvcHRvcCB7ZGlzcGxheTogYmxvY2s7CgkJcG9zaXRpb246IGFic29sdXRlOwoJCXRvcDogMDsK CQlsZWZ0OiAwOwoJCXdpZHRoOiAxNS4zZW07CgkJX3dpZHRoOiA5OSU7ICAvKiBJRSBvbmx5IGhh Y2sgKi8KCQloZWlnaHQ6IDEuMmVtOwoJCWNvbG9yOiAjMDBjOwoJCWJhY2tncm91bmQtY29sb3I6 ICMwMDAwNjY7IAoJCWNvbG9yOiAjZmZmOwoJCXRleHQtYWxpZ246IGxlZnQ7CQoJCXBhZGRpbmc6 IC4xZW0gLjFlbSAuMWVtIC4yZW07CgkJX3BhZGRpbmc6IDAgLjZlbSAwIC4yZW07IC8qIElFIG9u bHkgaGFjayAqLwoJfQoJYSNwb3B1cDpob3ZlciAjaWNvbiB7CgkJZGlzcGxheTogYmxvY2s7CgkJ ZmxvYXQ6IGxlZnQ7CgkJd2lkdGg6IC44ZW07CgkJYmFja2dyb3VuZC1jb2xvcjogdHJhbnNwYXJl bnQ7CgkJdGV4dC1hbGlnbjogY2VudGVyOwoJCWZvbnQtc2l6ZTogMmVtOwoJCWZvbnQtd2VpZ2h0 OiBib2xkOwoJCW92ZXJmbG93OiBoaWRkZW47CgkJYm9yZGVyOiBtZWRpdW0gaW5zZXQgbmF2eTsK CQlwYWRkaW5nOiAwIC4wNWVtIDAgLjA1ZW07CgkJbWFyZ2luOiAuMWVtIC4zZW0gMCAuMWVtOwoJ fQoKCWEjcG9wdXAgI2ljb25fYnV0dG9uIHsKCQlkaXNwbGF5OiBpbmxpbmU7CgkJcG9zaXRpb246 IGFic29sdXRlOwoJCWJhY2tncm91bmQtY29sb3I6ICMwMDAwNjY7IAoJCWNvbG9yOiAjZmZmOwoJ CWZvbnQtd2VpZ2h0OiBib2xkOwoJCWZvbnQtc2l6ZTogLjhlbTsKCQl0b3A6IC0uMWVtOwoJCWxl ZnQ6IC4xNWVtOwoJCWhlaWdodDogMS4xZW07CQoJCWJvcmRlcjogMnB4IG91dHNldCBibGFjazsg CgkJcGFkZGluZzogLjFlbSAuMWVtIC4xZW0gLjJlbTsKCQlfcGFkZGluZzogMCAuMWVtIDAgLjJl bTsgLyogSUUgb25seSBoYWNrICovCgl9CglhI3BvcHVwOmFjdGl2ZSwgYSNwb3B1cDpmb2N1cyB7 CgkgIC8qIHJlZHVjZSB0aGUgbGluayBzaXplIHRvIHplcm8gd2hlbiB0aGUgbGluayBpcyBpbiB0 aGUgCgkgIGFjdGl2ZS9mb2N1cyBzdGF0ZS4KCSAgVGhpcyBsaXRlcmFsbHkgcmVtb3ZlcyB0aGUg ZG90dGVkIGJvcmRlciB3aGljaCBpcyBPTkxZIGFwcGxpZWQKCSAgdG8gdGhlIGxpbmsgaXRzZWxm IGFuZCBub3QgYW55IGNvbnRhaW5pbmcgZWxlbWVudHMgV0hFTiBUSE9TRQoJICBFTEVNRU5UUyBI QVZFIEEgUE9TSVRJT04gQUJTT0xVVEUhICovCgkgIHdpZHRoOjA7IGhlaWdodDowOwoJICBvdXRs aW5lOjA7IC8qIGZvciBicm93c2VycyB0aGF0IHVuZGVyc3RhbmQgKi8KCSAgfQoJPC9zdHlsZT4K PC9oZWFkPgoKPGJvZHk+Cgo8ZGl2PjxsYWJlbCBmb3I9ImRhdGVfc2hvcnQiID5EYXRlOiA8L2xh YmVsPjxiciAvPjxpbnB1dCB0eXBlPSJ0ZXh0IiBuYW1lPSJkYXRldGltZVtkYXRlX3Nob3J0XSIg dmFsdWU9IjIwMDYtMDUtMjYiIGlkPSJkYXRlX3Nob3J0IiAgLz48ZGl2IGlkPSJpbmZvIj48YSBp ZD0icG9wdXAiIGhyZWY9IiMiIHN0eWxlPSJ6LWluZGV4OjIwMDsiPjxkaXYgaWQ9Imljb25fYnV0 dG9uIj4/PC9kaXY+IDxzcGFuIGlkPSJwb3Bib3giIHN0eWxlPSJ6LWluZGV4OjE5OTsiPjxzcGFu IGlkPSJwb3B0b3AiPj8mbmJzcDsmbmJzcDtIZWxwIFdpdGg6IDxlbT5EYXRlczwvZW0+PC9zcGFu PjxkaXYgaWQ9Imljb24iPj88L2Rpdj4gVGhpcyBmaWVsZCBhY2NlcHRzIGRhdGVzIGluIHBsYWlu IEVuZ2xpc2ggZm9ybWF0IHdoaWNoIGFyZSB0aGVuIHBhcnNlZCBpbnRvIGEgc2VydmljZWFibGUg ZGF0ZS4gVGhpcyBtZWFucyB0aGF0IG9uZSBtYXkgZW50ZXIgZGF0ZXMgaW4gYSBmb3JtYXRzIHN1 Y2ggYXMgIjA2LzA5LzcyIiwgIjE5NjkgMDMgMTUiLCAiTW9uZGF5LCBNYXJjaCAzcmQsIDE5Njki LCBvciBpbiByZWZlcmVudGlhbCBmb3JtcyBsaWtlIHRoZXNlOjxicj4KCTxicj4iKzEgZGF5IiBv ciAidG9tb3Jyb3ciCgk8YnI+Ii0xIGRheSIgb3IgInllc3RlcmRheSIKCTxicj4iKzEgd2VlayAy IGRheXMgNCBob3VycyIKCTxicj4ibmV4dCB0aHVyc2RheSIsICJsYXN0IHdlZWsiLCAibmV4dCBt b250aCIsICJuZXh0IHllYXIiLCBvciAibm93IgoJPGJyPjxicj5JbiBlYWNoIGNhc2UsIHRoZSBk YXRlIGlzIGNhbGN1bGF0ZWQgcmVsYXRpdmUgdGhlIGN1cnJlbnQgZGF0ZSAoZGF0ZSBhbmQgdGlt ZSB2YWx1ZXMgYXJlIHBhcnNlZCBieSB0aGUgInN0cnRvdGltZSIgZnVuY3Rpb24gb2YgUEhQKS4K CTwvc3Bhbj48L2E+PC9kaXY+IDwvZGl2PgoKPC9ib2R5Pgo8L2h0bWw+Cg== 6469 2006-02-13 15:08:03 -0800 2006-02-13 15:08:03 -0800 Reduced testcase 7235 reduction.html text/html 599 mitz PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIK CSJodHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4KCjxo dG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iIGxh bmc9ImVuIj4KPGhlYWQ+Cgk8dGl0bGU+PC90aXRsZT4KCTxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+ CgkjcCB7CgkJcG9zaXRpb246IHJlbGF0aXZlOwoJfQoJI3QgewoJCWRpc3BsYXk6IG5vbmU7CgkJ cG9zaXRpb246IGFic29sdXRlOwoJCXRvcDogLTFlbTsKCQlsZWZ0OiAxZW07CgkJd2lkdGg6IDEw ZW07CgkJaGVpZ2h0OiAxMGVtOwoJCWJhY2tncm91bmQ6IHNpbHZlcjsKCQlib3JkZXI6IHNvbGlk IDFweCByZWQ7Cgl9Cgk8L3N0eWxlPgo8L2hlYWQ+Cjxib2R5Pgo8cD4KPGJ1dHRvbiBvbmNsaWNr PSJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndCcpLnN0eWxlLmRpc3BsYXk9J2Jsb2NrJyI+VGVz dDwvYnV0dG9uPgo8L3A+CkxvcmVtIGlwc3VtCjxzcGFuIGlkPSJwIj4KPGRpdiBpZD0idCI+Cgk8 L2Rpdj48L3NwYW4+CjwvYm9keT4KPC9odG1sPgo= 6491 2006-02-14 14:00:21 -0800 2006-02-15 09:40:15 -0800 First cut at a fix 7235_r0.patch text/plain 4005 mitz SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL3JlbmRlcl9ib3guY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcmVuZGVyaW5nL3JlbmRlcl9ib3guY3BwCShyZXZpc2lvbiAxMjc5MSkKKysrIFdlYkNv cmUvcmVuZGVyaW5nL3JlbmRlcl9ib3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NjUsNiArNjY1 LDM2IEBAIGJvb2wgUmVuZGVyQm94OjphYnNvbHV0ZVBvc2l0aW9uKGludCAmeFAKICAgICAgICAg ZiA9IHRydWU7CiAgICAgUmVuZGVyT2JqZWN0ICpvID0gY29udGFpbmVyKCk7CiAgICAgaWYgKG8g JiYgby0+YWJzb2x1dGVQb3NpdGlvbih4UG9zLCB5UG9zLCBmKSkgeworICAgICAgICBpZiAoc3R5 bGUoKS0+cG9zaXRpb24oKSA9PSBBQlNPTFVURSAmJiBvLT5pc1JlbFBvc2l0aW9uZWQoKSAmJiBv LT5pc0lubGluZUZsb3coKSkgeworICAgICAgICAgICAgLy8gV2hlbiB3ZSBoYXZlIGFuIGVuY2xv c2luZyByZWxwb3NpdGlvbmVkIGlubGluZSwgd2UgbmVlZCB0byBhZGQgaW4gdGhlIG9mZnNldCBv ZiB0aGUgZmlyc3QgbGluZQorICAgICAgICAgICAgLy8gYm94IGZyb20gdGhlIHJlc3Qgb2YgdGhl IGNvbnRlbnQsIGJ1dCBvbmx5IGluIHRoZSBjYXNlcyB3aGVyZSB3ZSBrbm93IHdlJ3JlIHBvc2l0 aW9uZWQKKyAgICAgICAgICAgIC8vIHJlbGF0aXZlIHRvIHRoZSBpbmxpbmUgaXRzZWxmLgorICAg ICAgICAgICAgUmVuZGVyRmxvdyogZmxvdyA9IHN0YXRpY19jYXN0PFJlbmRlckZsb3cqPihvKTsK KyAgICAgICAgICAgIGludCBzeCA9IDA7CisgICAgICAgICAgICBpbnQgc3kgPSAwOworICAgICAg ICAgICAgaWYgKGZsb3ctPmZpcnN0TGluZUJveCgpKSB7CisgICAgICAgICAgICAgICAgc3ggPSBm bG93LT5maXJzdExpbmVCb3goKS0+eFBvcygpOworICAgICAgICAgICAgICAgIHN5ID0gZmxvdy0+ Zmlyc3RMaW5lQm94KCktPnlQb3MoKTsKKyAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICAgICAgc3ggPSBmbG93LT5zdGF0aWNYKCk7CisgICAgICAgICAgICAgICAgc3kgPSBmbG93LT5z dGF0aWNZKCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGJvb2wg aXNJbmxpbmVUeXBlID0gc3R5bGUoKS0+aXNPcmlnaW5hbERpc3BsYXlJbmxpbmVUeXBlKCk7Cisg ICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICghaGFzU3RhdGljWCgpKQorICAgICAgICAgICAg ICAgIHhQb3MgKz0gc3g7CisgICAgICAgICAgICAvLyBUaGlzIGlzIG5vdCB0ZXJyaWJseSBpbnR1 aXRpdmUsIGJ1dCB3ZSBoYXZlIHRvIG1hdGNoIG90aGVyIGJyb3dzZXJzLiAgRGVzcGl0ZSBiZWlu ZyBhIGJsb2NrIGRpc3BsYXkgdHlwZSBpbnNpZGUKKyAgICAgICAgICAgIC8vIGFuIGlubGluZSwg d2Ugc3RpbGwga2VlcCBvdXIgeCBsb2NrZWQgdG8gdGhlIGxlZnQgb2YgdGhlIHJlbGF0aXZlIHBv c2l0aW9uZWQgaW5saW5lLiAgQXJndWFibHkgdGhlIGNvcnJlY3QKKyAgICAgICAgICAgIC8vIGJl aGF2aW9yIHdvdWxkIGJlIHRvIGdvIGZsdXNoIGxlZnQgdG8gdGhlIGJsb2NrIHRoYXQgY29udGFp bnMgdGhlIGlubGluZSwgYnV0IHRoYXQgaXNuJ3Qgd2hhdCBvdGhlciBicm93c2VycworICAgICAg ICAgICAgLy8gZG8uCisgICAgICAgICAgICBpZiAoaGFzU3RhdGljWCgpICYmICFpc0lubGluZVR5 cGUpCisgICAgICAgICAgICAgICAgLy8gQXZvaWQgYWRkaW5nIGluIHRoZSBsZWZ0IGJvcmRlci9w YWRkaW5nIG9mIHRoZSBjb250YWluaW5nIGJsb2NrIHR3aWNlLiAgU3VidHJhY3QgaXQgb3V0Lgor ICAgICAgICAgICAgICAgIHhQb3MgKz0gc3ggLSAoY29udGFpbmluZ0Jsb2NrKCktPmJvcmRlckxl ZnQoKSArIGNvbnRhaW5pbmdCbG9jaygpLT5wYWRkaW5nTGVmdCgpKTsKKyAgICAgICAgICAgIAor ICAgICAgICAgICAgaWYgKCFoYXNTdGF0aWNZKCkpCisgICAgICAgICAgICAgICAgeVBvcyArPSBz eTsKKyAgICAgICAgfQogICAgICAgICBpZiAoby0+aGFzT3ZlcmZsb3dDbGlwKCkpCiAgICAgICAg ICAgICBvLT5sYXllcigpLT5zdWJ0cmFjdFNjcm9sbE9mZnNldCh4UG9zLCB5UG9zKTsgCiAgICAg ICAgICAgICAKQEAgLTc3Niw2ICs4MDYsMzYgQEAgdm9pZCBSZW5kZXJCb3g6OmNvbXB1dGVBYnNv bHV0ZVJlcGFpbnRSZQogCiAgICAgUmVuZGVyT2JqZWN0KiBvID0gY29udGFpbmVyKCk7CiAgICAg aWYgKG8pIHsKKyAgICAgICAgaWYgKHN0eWxlKCktPnBvc2l0aW9uKCkgPT0gQUJTT0xVVEUgJiYg by0+aXNSZWxQb3NpdGlvbmVkKCkgJiYgby0+aXNJbmxpbmVGbG93KCkpIHsKKyAgICAgICAgICAg IC8vIFdoZW4gd2UgaGF2ZSBhbiBlbmNsb3NpbmcgcmVscG9zaXRpb25lZCBpbmxpbmUsIHdlIG5l ZWQgdG8gYWRkIGluIHRoZSBvZmZzZXQgb2YgdGhlIGZpcnN0IGxpbmUKKyAgICAgICAgICAgIC8v IGJveCBmcm9tIHRoZSByZXN0IG9mIHRoZSBjb250ZW50LCBidXQgb25seSBpbiB0aGUgY2FzZXMg d2hlcmUgd2Uga25vdyB3ZSdyZSBwb3NpdGlvbmVkCisgICAgICAgICAgICAvLyByZWxhdGl2ZSB0 byB0aGUgaW5saW5lIGl0c2VsZi4KKyAgICAgICAgICAgIFJlbmRlckZsb3cqIGZsb3cgPSBzdGF0 aWNfY2FzdDxSZW5kZXJGbG93Kj4obyk7CisgICAgICAgICAgICBpbnQgc3ggPSAwOworICAgICAg ICAgICAgaW50IHN5ID0gMDsKKyAgICAgICAgICAgIGlmIChmbG93LT5maXJzdExpbmVCb3goKSkg eworICAgICAgICAgICAgICAgIHN4ID0gZmxvdy0+Zmlyc3RMaW5lQm94KCktPnhQb3MoKTsKKyAg ICAgICAgICAgICAgICBzeSA9IGZsb3ctPmZpcnN0TGluZUJveCgpLT55UG9zKCk7CisgICAgICAg ICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIHN4ID0gZmxvdy0+c3RhdGljWCgpOworICAg ICAgICAgICAgICAgIHN5ID0gZmxvdy0+c3RhdGljWSgpOworICAgICAgICAgICAgfQorICAgICAg ICAgICAgCisgICAgICAgICAgICBib29sIGlzSW5saW5lVHlwZSA9IHN0eWxlKCktPmlzT3JpZ2lu YWxEaXNwbGF5SW5saW5lVHlwZSgpOworICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoIWhh c1N0YXRpY1goKSkKKyAgICAgICAgICAgICAgICB4ICs9IHN4OworICAgICAgICAgICAgLy8gVGhp cyBpcyBub3QgdGVycmlibHkgaW50dWl0aXZlLCBidXQgd2UgaGF2ZSB0byBtYXRjaCBvdGhlciBi cm93c2Vycy4gIERlc3BpdGUgYmVpbmcgYSBibG9jayBkaXNwbGF5IHR5cGUgaW5zaWRlCisgICAg ICAgICAgICAvLyBhbiBpbmxpbmUsIHdlIHN0aWxsIGtlZXAgb3VyIHggbG9ja2VkIHRvIHRoZSBs ZWZ0IG9mIHRoZSByZWxhdGl2ZSBwb3NpdGlvbmVkIGlubGluZS4gIEFyZ3VhYmx5IHRoZSBjb3Jy ZWN0CisgICAgICAgICAgICAvLyBiZWhhdmlvciB3b3VsZCBiZSB0byBnbyBmbHVzaCBsZWZ0IHRv IHRoZSBibG9jayB0aGF0IGNvbnRhaW5zIHRoZSBpbmxpbmUsIGJ1dCB0aGF0IGlzbid0IHdoYXQg b3RoZXIgYnJvd3NlcnMKKyAgICAgICAgICAgIC8vIGRvLgorICAgICAgICAgICAgaWYgKGhhc1N0 YXRpY1goKSAmJiAhaXNJbmxpbmVUeXBlKQorICAgICAgICAgICAgICAgIC8vIEF2b2lkIGFkZGlu ZyBpbiB0aGUgbGVmdCBib3JkZXIvcGFkZGluZyBvZiB0aGUgY29udGFpbmluZyBibG9jayB0d2lj ZS4gIFN1YnRyYWN0IGl0IG91dC4KKyAgICAgICAgICAgICAgICB4ICs9IHN4IC0gKGNvbnRhaW5p bmdCbG9jaygpLT5ib3JkZXJMZWZ0KCkgKyBjb250YWluaW5nQmxvY2soKS0+cGFkZGluZ0xlZnQo KSk7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICghaGFzU3RhdGljWSgpKQorICAgICAg ICAgICAgICAgIHkgKz0gc3k7CisgICAgICAgIH0KICAgICAgICAgLy8gPGJvZHk+IG1heSBub3Qg aGF2ZSBvdmVyZmxvdywgc2luY2UgaXQgbWlnaHQgYmUgYXBwbHlpbmcgaXRzIG92ZXJmbG93IHZh bHVlIHRvIHRoZQogICAgICAgICAvLyBzY3JvbGxiYXJzLgogICAgICAgICBpZiAoby0+aGFzT3Zl cmZsb3dDbGlwKCkpIHsK 6506 2006-02-15 09:40:15 -0800 2006-02-17 12:59:17 -0800 Patch including manual test and changelog entry 7235_r1.patch text/plain 6418 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxMjgyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDYtMDItIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD03MjM1CisgICAgICAgICAgUHVyZSBDU1MgVG9vbHRpcHMgbWV0aG9kIHJlbmRlcnMgd3Jv bmcgYW5kIGNyZWF0ZXMgYXJ0aWZhY3RzCisKKyAgICAgICAgKiBtYW51YWwtdGVzdHMvYnVnemls bGEtNzIzNS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiByZW5kZXJpbmcvcmVuZGVyX2JveC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmFic29sdXRlUG9zaXRpb24pOiBDb3BpZWQg aW4gaGVyZSB0aGUgbG9naWMgZm9yIHBvc2l0aW9uaW5nCisgICAgICAgIHJlbGF0aXZlIHRvIGEg cmVscG9zaXRpb25lZCBpbmxpbmUgZnJvbSBSZW5kZXJMYXllcjo6dXBkYXRlTGF5ZXJQb3NpdGlv bi4KKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZUFic29sdXRlUmVwYWludFJl Y3QpOiBEaXR0by4KKwogMjAwNi0wMi0xNSAgT2xpdmVyIEh1bnQgIDxvamgxNkBzdHVkZW50LmNh bnRlcmJ1cnkuYWMubno+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgZXNlaWRlbC4gIExhbmRlZCBi eSBlc2VpZGVsLgpJbmRleDogV2ViQ29yZS9tYW51YWwtdGVzdHMvYnVnemlsbGEtNzIzNS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTcyMzUuaHRtbAko cmV2aXNpb24gMCkKKysrIFdlYkNvcmUvbWFudWFsLXRlc3RzL2J1Z3ppbGxhLTcyMzUuaHRtbAko cmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MiBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9X M0MvL0RURCBIVE1MIDQuMDEvL0VOIgorICAgICAgICAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRt bDQvc3RyaWN0LmR0ZCI+Cis8aHRtbCBsYW5nPSJlbiI+Cis8aGVhZD4KKwk8c3R5bGUgdHlwZT0i dGV4dC9jc3MiPgorCSNwIHsKKwkJcG9zaXRpb246IHJlbGF0aXZlOworCQlsZWZ0OiAtMTAwcHg7 CisJCW1hcmdpbi1sZWZ0OiAxMDBweDsKKwl9CisJI3QgeworCQlkaXNwbGF5OiBub25lOworCQlw b3NpdGlvbjogYWJzb2x1dGU7CisJCXdpZHRoOiAxMDBweDsKKwkJaGVpZ2h0OiAxMDBweDsKKwkJ YmFja2dyb3VuZDogZ3JlZW47CisJfQorCTwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPjxi PkJVRyBJRDo8L2I+IDxhIGhyZWY9Imh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzIzNSI+QnVnemlsbGEgYnVnIDcyMzU8L2E+IFB1cmUgQ1NTIFRvb2x0aXBz IG1ldGhvZCByZW5kZXJzIHdyb25nIGFuZCBjcmVhdGVzIGFydGlmYWN0czwvcD4KKworPHAgaWQ9 InRlc3QiIHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnNreWJsdWU7IHBhZGRpbmc6M3B4OyI+PGI+ U1RFUFMgVE8gVEVTVDo8L2I+IAorUmVzaXplIHRoZSB3aW5kb3cgaWYgbmVjZXNzYXJ5IHNvIHRo YXQgdGhlIHJlZCBzcXVhcmUgYmVsb3cgaXMgdmlzaWJsZSwgdGhlbiBjbGljayB0aGUgVGVzdCBi dXR0b24uCis8L3A+CisKKzxwIGlkPSJzdWNjZXNzIiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpw YWxlZ3JlZW47IHBhZGRpbmc6M3B4OyI+PGI+VEVTVCBQQVNTOjwvYj4gCitUaGUgc3F1YXJlIHNo b3VsZCBjaGFuZ2UgdG8gc29saWQgZ3JlZW4uCis8L3A+CisKKzxwIGlkPSJmYWlsdXJlIiBzdHls ZT0iYmFja2dyb3VuZC1jb2xvcjojRkYzMzAwOyBwYWRkaW5nOjNweDsiPjxiPlRFU1QgRkFJTDo8 L2I+ICAKK1RoZSBzcXVhcmUgd2lsbCByZW1haW4gcmVkIGFuZCB3aWxsIG9ubHkgY2hhbmdlIHRv IGdyZWVuIHdoZW4gdGhlIHdpbmRvdyBpcyByZXNpemVkLCBzY3JvbGxlZCBvciBvdGhlcndpc2Ug cmVwYWludGVkLgorPC9wPgorCis8cD4KKzxidXR0b24gb25jbGljaz0iZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3QnKS5zdHlsZS5kaXNwbGF5PSdibG9jayciPlRlc3Q8L2J1dHRvbj4KKzwvcD4K KzxzcGFuIGlkPSJwIj4mbmJzcDs8ZGl2IGlkPSJ0Ij48L2Rpdj48L3NwYW4+Cis8ZGl2IHN0eWxl PSJ3aWR0aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IGJhY2tncm91bmQ6IHJlZDsiPjwvZGl2Pgor Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9yZW5kZXJfYm94LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAkocmV2aXNp b24gMTI4MTkpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjY1LDYgKzY2NSwzNiBAQCBib29sIFJlbmRlckJveDo6YWJzb2x1dGVQb3NpdGlv bihpbnQgJnhQCiAgICAgICAgIGYgPSB0cnVlOwogICAgIFJlbmRlck9iamVjdCAqbyA9IGNvbnRh aW5lcigpOwogICAgIGlmIChvICYmIG8tPmFic29sdXRlUG9zaXRpb24oeFBvcywgeVBvcywgZikp IHsKKyAgICAgICAgaWYgKHN0eWxlKCktPnBvc2l0aW9uKCkgPT0gQUJTT0xVVEUgJiYgby0+aXNS ZWxQb3NpdGlvbmVkKCkgJiYgby0+aXNJbmxpbmVGbG93KCkpIHsKKyAgICAgICAgICAgIC8vIFdo ZW4gd2UgaGF2ZSBhbiBlbmNsb3NpbmcgcmVscG9zaXRpb25lZCBpbmxpbmUsIHdlIG5lZWQgdG8g YWRkIGluIHRoZSBvZmZzZXQgb2YgdGhlIGZpcnN0IGxpbmUKKyAgICAgICAgICAgIC8vIGJveCBm cm9tIHRoZSByZXN0IG9mIHRoZSBjb250ZW50LCBidXQgb25seSBpbiB0aGUgY2FzZXMgd2hlcmUg d2Uga25vdyB3ZSdyZSBwb3NpdGlvbmVkCisgICAgICAgICAgICAvLyByZWxhdGl2ZSB0byB0aGUg aW5saW5lIGl0c2VsZi4KKyAgICAgICAgICAgIFJlbmRlckZsb3cqIGZsb3cgPSBzdGF0aWNfY2Fz dDxSZW5kZXJGbG93Kj4obyk7CisgICAgICAgICAgICBpbnQgc3ggPSAwOworICAgICAgICAgICAg aW50IHN5ID0gMDsKKyAgICAgICAgICAgIGlmIChmbG93LT5maXJzdExpbmVCb3goKSkgeworICAg ICAgICAgICAgICAgIHN4ID0gZmxvdy0+Zmlyc3RMaW5lQm94KCktPnhQb3MoKTsKKyAgICAgICAg ICAgICAgICBzeSA9IGZsb3ctPmZpcnN0TGluZUJveCgpLT55UG9zKCk7CisgICAgICAgICAgICB9 IGVsc2UgeworICAgICAgICAgICAgICAgIHN4ID0gZmxvdy0+c3RhdGljWCgpOworICAgICAgICAg ICAgICAgIHN5ID0gZmxvdy0+c3RhdGljWSgpOworICAgICAgICAgICAgfQorICAgICAgICAgICAg CisgICAgICAgICAgICBib29sIGlzSW5saW5lVHlwZSA9IHN0eWxlKCktPmlzT3JpZ2luYWxEaXNw bGF5SW5saW5lVHlwZSgpOworICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoIWhhc1N0YXRp Y1goKSkKKyAgICAgICAgICAgICAgICB4UG9zICs9IHN4OworICAgICAgICAgICAgLy8gVGhpcyBp cyBub3QgdGVycmlibHkgaW50dWl0aXZlLCBidXQgd2UgaGF2ZSB0byBtYXRjaCBvdGhlciBicm93 c2Vycy4gIERlc3BpdGUgYmVpbmcgYSBibG9jayBkaXNwbGF5IHR5cGUgaW5zaWRlCisgICAgICAg ICAgICAvLyBhbiBpbmxpbmUsIHdlIHN0aWxsIGtlZXAgb3VyIHggbG9ja2VkIHRvIHRoZSBsZWZ0 IG9mIHRoZSByZWxhdGl2ZSBwb3NpdGlvbmVkIGlubGluZS4gIEFyZ3VhYmx5IHRoZSBjb3JyZWN0 CisgICAgICAgICAgICAvLyBiZWhhdmlvciB3b3VsZCBiZSB0byBnbyBmbHVzaCBsZWZ0IHRvIHRo ZSBibG9jayB0aGF0IGNvbnRhaW5zIHRoZSBpbmxpbmUsIGJ1dCB0aGF0IGlzbid0IHdoYXQgb3Ro ZXIgYnJvd3NlcnMKKyAgICAgICAgICAgIC8vIGRvLgorICAgICAgICAgICAgaWYgKGhhc1N0YXRp Y1goKSAmJiAhaXNJbmxpbmVUeXBlKQorICAgICAgICAgICAgICAgIC8vIEF2b2lkIGFkZGluZyBp biB0aGUgbGVmdCBib3JkZXIvcGFkZGluZyBvZiB0aGUgY29udGFpbmluZyBibG9jayB0d2ljZS4g IFN1YnRyYWN0IGl0IG91dC4KKyAgICAgICAgICAgICAgICB4UG9zICs9IHN4IC0gKGNvbnRhaW5p bmdCbG9jaygpLT5ib3JkZXJMZWZ0KCkgKyBjb250YWluaW5nQmxvY2soKS0+cGFkZGluZ0xlZnQo KSk7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmICghaGFzU3RhdGljWSgpKQorICAgICAg ICAgICAgICAgIHlQb3MgKz0gc3k7CisgICAgICAgIH0KICAgICAgICAgaWYgKG8tPmhhc092ZXJm bG93Q2xpcCgpKQogICAgICAgICAgICAgby0+bGF5ZXIoKS0+c3VidHJhY3RTY3JvbGxPZmZzZXQo eFBvcywgeVBvcyk7IAogICAgICAgICAgICAgCkBAIC03NzYsNiArODA2LDM2IEBAIHZvaWQgUmVu ZGVyQm94Ojpjb21wdXRlQWJzb2x1dGVSZXBhaW50UmUKIAogICAgIFJlbmRlck9iamVjdCogbyA9 IGNvbnRhaW5lcigpOwogICAgIGlmIChvKSB7CisgICAgICAgIGlmIChzdHlsZSgpLT5wb3NpdGlv bigpID09IEFCU09MVVRFICYmIG8tPmlzUmVsUG9zaXRpb25lZCgpICYmIG8tPmlzSW5saW5lRmxv dygpKSB7CisgICAgICAgICAgICAvLyBXaGVuIHdlIGhhdmUgYW4gZW5jbG9zaW5nIHJlbHBvc2l0 aW9uZWQgaW5saW5lLCB3ZSBuZWVkIHRvIGFkZCBpbiB0aGUgb2Zmc2V0IG9mIHRoZSBmaXJzdCBs aW5lCisgICAgICAgICAgICAvLyBib3ggZnJvbSB0aGUgcmVzdCBvZiB0aGUgY29udGVudCwgYnV0 IG9ubHkgaW4gdGhlIGNhc2VzIHdoZXJlIHdlIGtub3cgd2UncmUgcG9zaXRpb25lZAorICAgICAg ICAgICAgLy8gcmVsYXRpdmUgdG8gdGhlIGlubGluZSBpdHNlbGYuCisgICAgICAgICAgICBSZW5k ZXJGbG93KiBmbG93ID0gc3RhdGljX2Nhc3Q8UmVuZGVyRmxvdyo+KG8pOworICAgICAgICAgICAg aW50IHN4ID0gMDsKKyAgICAgICAgICAgIGludCBzeSA9IDA7CisgICAgICAgICAgICBpZiAoZmxv dy0+Zmlyc3RMaW5lQm94KCkpIHsKKyAgICAgICAgICAgICAgICBzeCA9IGZsb3ctPmZpcnN0TGlu ZUJveCgpLT54UG9zKCk7CisgICAgICAgICAgICAgICAgc3kgPSBmbG93LT5maXJzdExpbmVCb3go KS0+eVBvcygpOworICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBzeCA9IGZs b3ctPnN0YXRpY1goKTsKKyAgICAgICAgICAgICAgICBzeSA9IGZsb3ctPnN0YXRpY1koKTsKKyAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIAorICAgICAgICAgICAgYm9vbCBpc0lubGluZVR5cGUg PSBzdHlsZSgpLT5pc09yaWdpbmFsRGlzcGxheUlubGluZVR5cGUoKTsKKyAgICAgICAgICAgIAor ICAgICAgICAgICAgaWYgKCFoYXNTdGF0aWNYKCkpCisgICAgICAgICAgICAgICAgeCArPSBzeDsK KyAgICAgICAgICAgIC8vIFRoaXMgaXMgbm90IHRlcnJpYmx5IGludHVpdGl2ZSwgYnV0IHdlIGhh dmUgdG8gbWF0Y2ggb3RoZXIgYnJvd3NlcnMuICBEZXNwaXRlIGJlaW5nIGEgYmxvY2sgZGlzcGxh eSB0eXBlIGluc2lkZQorICAgICAgICAgICAgLy8gYW4gaW5saW5lLCB3ZSBzdGlsbCBrZWVwIG91 ciB4IGxvY2tlZCB0byB0aGUgbGVmdCBvZiB0aGUgcmVsYXRpdmUgcG9zaXRpb25lZCBpbmxpbmUu ICBBcmd1YWJseSB0aGUgY29ycmVjdAorICAgICAgICAgICAgLy8gYmVoYXZpb3Igd291bGQgYmUg dG8gZ28gZmx1c2ggbGVmdCB0byB0aGUgYmxvY2sgdGhhdCBjb250YWlucyB0aGUgaW5saW5lLCBi dXQgdGhhdCBpc24ndCB3aGF0IG90aGVyIGJyb3dzZXJzCisgICAgICAgICAgICAvLyBkby4KKyAg ICAgICAgICAgIGlmIChoYXNTdGF0aWNYKCkgJiYgIWlzSW5saW5lVHlwZSkKKyAgICAgICAgICAg ICAgICAvLyBBdm9pZCBhZGRpbmcgaW4gdGhlIGxlZnQgYm9yZGVyL3BhZGRpbmcgb2YgdGhlIGNv bnRhaW5pbmcgYmxvY2sgdHdpY2UuICBTdWJ0cmFjdCBpdCBvdXQuCisgICAgICAgICAgICAgICAg eCArPSBzeCAtIChjb250YWluaW5nQmxvY2soKS0+Ym9yZGVyTGVmdCgpICsgY29udGFpbmluZ0Js b2NrKCktPnBhZGRpbmdMZWZ0KCkpOworICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoIWhh c1N0YXRpY1koKSkKKyAgICAgICAgICAgICAgICB5ICs9IHN5OworICAgICAgICB9CiAgICAgICAg IC8vIDxib2R5PiBtYXkgbm90IGhhdmUgb3ZlcmZsb3csIHNpbmNlIGl0IG1pZ2h0IGJlIGFwcGx5 aW5nIGl0cyBvdmVyZmxvdyB2YWx1ZSB0byB0aGUKICAgICAgICAgLy8gc2Nyb2xsYmFycy4KICAg ICAgICAgaWYgKG8tPmhhc092ZXJmbG93Q2xpcCgpKSB7Cg==